From nobody Fri Nov 1 07:30:28 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1708095890; cv=none; d=zohomail.com; s=zohoarc; b=ZDD/9e8k7ScGRPamqAJEOoQF0lRfZm5ww0hxbLjr8QvAUo/b86QtFnVP/jBK4nbJPy6hw0ontPxN/kn345pRAKnWDuSbokMYGGWlYtc33ySEwbbaNSSfxC0OL/bhItI1bvv2LUJrdgz5S1R0tpYBpZ8ob/R4Z0G3yiCu3WuaHdw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1708095890; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=AcD0U+NtI6do8HeUKTPFxaSrHm3iqkS5BjxbWz7E5WU=; b=AeXZuAQ+3yNjgfAuWDeKb+9Eo3TRn+ZU5v8jcJDB6ZTmZgSEclBBL0L18+cRcXNYhWP7x6U6v/D2vuicSlThnSmAuGsBW8hTFOAX0JIvASvUL0aVOoCb3blLAJxbOGfqN8wb2Prm/LPvXb4a5+x3aZGJFU6Js1AjahQhm1XLdcg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1708095890361195.86104344590865; Fri, 16 Feb 2024 07:04:50 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1razg6-0005xi-8i; Fri, 16 Feb 2024 09:59:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1razg1-0005tb-Em for qemu-devel@nongnu.org; Fri, 16 Feb 2024 09:58:57 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1razfy-00083g-I4 for qemu-devel@nongnu.org; Fri, 16 Feb 2024 09:58:57 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-59-OO--CMkFOmiK87W3UamSdQ-1; Fri, 16 Feb 2024 09:58:50 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 366F783722D; Fri, 16 Feb 2024 14:58:50 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.55]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 145061C060B1; Fri, 16 Feb 2024 14:58:50 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 32CAE21E5A47; Fri, 16 Feb 2024 15:58:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708095533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AcD0U+NtI6do8HeUKTPFxaSrHm3iqkS5BjxbWz7E5WU=; b=Hr4J0ZjMprfdZQqsFmGqwqzMaF3gVsJDhspkhDO8N5yL0OfBSptvUloCCzQGjTHxgmFCNQ J3HvFg5phu/30X7wFBFVeLXYUH1VrQKeXWFf7Fkly6e57LkpkKI+yz3Hhe4zgBzpO/MKtl xXk7KxE2cQ13sU7pLp3XdJcYnvt2GdE= X-MC-Unique: OO--CMkFOmiK87W3UamSdQ-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: michael.roth@amd.com, jsnow@redhat.com, eblake@redhat.com, peter.maydell@linaro.org Subject: [PATCH 12/16] qapi: Call QAPIDoc.check() always Date: Fri, 16 Feb 2024 15:58:36 +0100 Message-ID: <20240216145841.2099240-13-armbru@redhat.com> In-Reply-To: <20240216145841.2099240-1-armbru@redhat.com> References: <20240216145841.2099240-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.364, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1708095891907100001 Content-Type: text/plain; charset="utf-8" We currently call QAPIDoc.check() only for definition documentation. Calling it for free-form documentation as well is simpler. No change, because it doesn't actually do anything there. Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrang=C3=A9 --- scripts/qapi/schema.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/scripts/qapi/schema.py b/scripts/qapi/schema.py index 6a836950a9..8ba5665bc6 100644 --- a/scripts/qapi/schema.py +++ b/scripts/qapi/schema.py @@ -95,10 +95,6 @@ def connect_doc(self, doc=3DNone): for f in self.features: doc.connect_feature(f) =20 - def check_doc(self): - if self.doc: - self.doc.check() - def _set_module(self, schema, info): assert self._checked fname =3D info.fname if info else QAPISchemaModule.BUILTIN_MODULE_= NAME @@ -1223,9 +1219,10 @@ def check(self): for ent in self._entity_list: ent.check(self) ent.connect_doc() - ent.check_doc() for ent in self._entity_list: ent.set_module(self) + for doc in self.docs: + doc.check() =20 def visit(self, visitor): visitor.visit_begin(self) --=20 2.43.0