From nobody Tue Nov 26 12:44:47 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1707853700552167.28313750709322; Tue, 13 Feb 2024 11:48:20 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZyg4-0006o4-Po; Tue, 13 Feb 2024 14:42:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZyg1-0006FR-Mu for qemu-devel@nongnu.org; Tue, 13 Feb 2024 14:42:46 -0500 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZyfu-0006OK-9A for qemu-devel@nongnu.org; Tue, 13 Feb 2024 14:42:45 -0500 Received: from [2a00:23c4:8bb2:1300:c500:f104:bc51:e670] (helo=localhost.localdomain) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rZyf1-0008m4-2L; Tue, 13 Feb 2024 19:41:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To:Cc: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=TXYSIPnBdGCc0Di0xXyXoy0f7ULVQNWNqIqFCCGNsSw=; b=UOoTDSJANt5OBXja4QOXxXN/ot VaA6O1Cf+0QZ5RsUh3gTgRJrRebROsmvp6okH9rA/QJ1sh3qBoB975YqkQBP7d4RGBXT1fkzwh3fo tmU2iqJYAieLhTZWECSBTWjZPhNJnDnKc12Ns1opj8TIQra8HTvxHFIIioPo4iGH3BPhtd4dczT4m 4eotXN1zOS2hELAkmae0nhqRIOKjZN7vXFwP4Dzmhri08dkPfxzub3rrtGAarwV63DcOsQrv9x1aV 18dxEDrp3SjCHy3h4IVJLYypbbswibHAIpwuRvnoM/fJS/B3kHxLDkaL1AUpFpqkZ1wIUzTlyJwIT lKNB2z7PHFiQ4/Qf980uebpcwk+JdG41RkWRU5BDxdoNLrs6F4bCer8kLcmWvElVJw64A8y5J9GdF V4yAXwWJvbcLyqnpChDMM7FcyOHvAXmIc48e4EscJljiYlps1B2Or+HKATzrha+JPBWd2JmAyprOQ ZTtjjgiid+vJD30nHbsusUGx4tnHnjzCKXrIxo36U0tkTiaPlul8rGVEqla74fU8pcqwuc+NIYzYR FklTb3lDH30HzxNCbUQYmkQOHQNG2k/F1jrYtcddw4FhjSbEiGk6YvhB9nMnOD34U/dr27A9Au/7m nwZSKneV45NIZYdThTAzgM77VqdpDlZ2pGSW9FuDQ=; From: Mark Cave-Ayland To: peter.maydell@linaro.org, qemu-devel@nongnu.org Date: Tue, 13 Feb 2024 19:39:48 +0000 Message-Id: <20240213194052.1162753-25-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240213194052.1162753-1-mark.cave-ayland@ilande.co.uk> References: <20240213194052.1162753-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a00:23c4:8bb2:1300:c500:f104:bc51:e670 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [PULL 24/88] esp.c: remove TC adjustment in esp_do_dma() from device path X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1707853702320100001 Content-Type: text/plain; charset="utf-8" Now that the TC is updated for each PDMA access (rather than once the FIFO = is full) there is no need to adjust the TC at start of each DMA transfer if the FIFO is not empty. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Tested-by: Thomas Huth Message-Id: <20240112125420.514425-25-mark.cave-ayland@ilande.co.uk> Signed-off-by: Mark Cave-Ayland --- hw/scsi/esp.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c index 1f9902aec0..ec82097a01 100644 --- a/hw/scsi/esp.c +++ b/hw/scsi/esp.c @@ -754,11 +754,6 @@ static void esp_do_dma(ESPState *s) esp_lower_drq(s); } } else { - /* Adjust TC for any leftover data in the FIFO */ - if (!fifo8_is_empty(&s->fifo)) { - esp_set_tc(s, esp_get_tc(s) - fifo8_num_used(&s->fifo)); - } - /* Copy device data to FIFO */ len =3D MIN(len, fifo8_num_free(&s->fifo)); fifo8_push_all(&s->fifo, s->async_buf, len); --=20 2.39.2