From nobody Mon Sep 16 19:10:55 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1707729404; cv=none; d=zohomail.com; s=zohoarc; b=IP9HN1t0bRlxPeikAXsefAlps1UaOaQ7DH/oJ5Dc17s7RpsMK5L36nOqKy6RIYquPyks7dYwtYjWEMhoup+y+XOL5HVaYzEHeE7aVkjHeRyy7qjfQe+nLF5ZVNlUGBJ0qz9dyFHQuME019HnNQJm0C/eUi/pqrnGcQ4dF0AhFXw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1707729404; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=mYQQQUNM62sBNigJeQVa2uJWpqF1rDNVMBcazRZqQ3E=; b=AgxkeLL2BicOKcbW9K4j7loBYI3Vp+kBWCKPwZXrWwSrNj/0clPgUzDQi/MrYBu88ccOJBV/mkk7oK77G1+GZigvde+d6WO+MJGoMomrxN4Z3Gc8hsmJmYTEXrZKHHfwCGzuKbXdRF1wW3xZOUytIqAaq9rtfoLE9hPz8kXEyn4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 170772940493596.64212989316172; Mon, 12 Feb 2024 01:16:44 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZSOk-0006Kp-Il; Mon, 12 Feb 2024 04:14:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZSOj-0006K9-1h for qemu-devel@nongnu.org; Mon, 12 Feb 2024 04:14:45 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZSOf-0003cH-P4 for qemu-devel@nongnu.org; Mon, 12 Feb 2024 04:14:44 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-639-VXNMTWQwNqKLAeY-snEn3Q-1; Mon, 12 Feb 2024 04:14:39 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 156F6185A789; Mon, 12 Feb 2024 09:14:39 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.55]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E54F9245445; Mon, 12 Feb 2024 09:14:38 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 8543421E657E; Mon, 12 Feb 2024 10:14:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707729280; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mYQQQUNM62sBNigJeQVa2uJWpqF1rDNVMBcazRZqQ3E=; b=OKPJyNOBucryZ+IWiT3JFSIOdxlveZSBuoLIyuzcia/a7qzdvRinIfkvCP8hWtmvEH4oju LQeaPsqZsuBVl7fq/W/fIgcGUK2yqXao47l3gxHF9FVqmmg2U6GOqYXurDdWnManSY4yb4 vWMOS++5FauKXJZOtRk3x0K7aZaliOI= X-MC-Unique: VXNMTWQwNqKLAeY-snEn3Q-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= Subject: [PULL 05/18] sphinx/qapidoc: Drop code to generate doc for simple union tag Date: Mon, 12 Feb 2024 10:14:23 +0100 Message-ID: <20240212091436.688598-6-armbru@redhat.com> In-Reply-To: <20240212091436.688598-1-armbru@redhat.com> References: <20240212091436.688598-1-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.677, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1707729406826100007 QAPISchemaGenRSTVisitor._nodes_for_members() has a special case to auto-generate documentation for a union tag member of implicit (enum) type that lacks documentation. This was useful for simple unions, where the tag member's type was implicitly. The only implicit enum type left today is 'QType'. Not worth a special case. Drop. No change to generated documentation. Signed-off-by: Markus Armbruster Message-ID: <20240205074709.3613229-6-armbru@redhat.com> Reviewed-by: Daniel P. Berrang=C3=A9 --- docs/sphinx/qapidoc.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/docs/sphinx/qapidoc.py b/docs/sphinx/qapidoc.py index 658c288f8f..05b809af27 100644 --- a/docs/sphinx/qapidoc.py +++ b/docs/sphinx/qapidoc.py @@ -168,12 +168,6 @@ def _nodes_for_members(self, doc, what, base=3DNone, v= ariants=3DNone): # TODO drop fallbacks when undocumented members are outlawed if section.text: defn =3D section.text - elif (variants and variants.tag_member =3D=3D section.member - and not section.member.type.doc_type()): - values =3D section.member.type.member_names() - defn =3D [nodes.Text('One of ')] - defn.extend(intersperse([nodes.literal('', v) for v in val= ues], - nodes.Text(', '))) else: defn =3D [nodes.Text('Not documented')] =20 --=20 2.43.0