From nobody Sun Sep 8 01:22:51 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=vrull.eu ARC-Seal: i=1; a=rsa-sha256; t=1707460963; cv=none; d=zohomail.com; s=zohoarc; b=JnFYzSHHRzfALb/jCTprAyC7axZpLSKgkXN8ki5eYyaID5e5cVmxykfEbdekLCHnR9TLI53u8ZfGneuiC8wsODUwx5fQPhNFcMOEJbahsIJsCTSBsQArIHCsgmIeF1zPZa1V/j7JrDQ9RipIosX6KoekD3pusy5JmdyybEeqisA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1707460963; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lyx14WO2VlxFkhc1a5xMd2hg19LxPHSwC4OsD7s+Vd8=; b=dCC1tEa80d+ey0LFlM0wa998gavQ5ZNHk6NCA8SeHVl6YAHjo+dI3C+JcgD5cDupA+RHi7+A+FIb/vJdHHKO2HR5eYCBOUCd/fm6YHY40+FTrjv46vfrwBTZ45Feg2e2KsGh4jGs43o+EPUG5szUrhGY2+0jSOYf2PgZ8aIvOtU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1707460963210740.650644346627; Thu, 8 Feb 2024 22:42:43 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rYKZy-0005xk-Cu; Fri, 09 Feb 2024 01:41:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYKZs-0005rK-1f for qemu-devel@nongnu.org; Fri, 09 Feb 2024 01:41:36 -0500 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rYKZl-0002O2-HQ for qemu-devel@nongnu.org; Fri, 09 Feb 2024 01:41:35 -0500 Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-a34c5ca2537so70429566b.0 for ; Thu, 08 Feb 2024 22:41:27 -0800 (PST) Received: from beast.fritz.box (62-178-148-172.cable.dynamic.surfer.at. [62.178.148.172]) by smtp.gmail.com with ESMTPSA id vk9-20020a170907cbc900b00a36c499c935sm450575ejc.43.2024.02.08.22.41.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 22:41:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; t=1707460886; x=1708065686; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lyx14WO2VlxFkhc1a5xMd2hg19LxPHSwC4OsD7s+Vd8=; b=NzMhSE9msZDHbxldU396Xmv+bK9o1SE7Vn+UNkf3Yf5SNpz3lC9w2uZ1aBz1HMBks9 1chXiYk/hvCe3WqnaYD36tJN6cSohU6QprG+9oAFrYJ5FncQDQidS/QAtyu5dp2m/pB/ rQ5StWyv7s9M/JciJoUONTb9N6p8ewcSn5VmspKjwVnYJvLgJJr6k72oJLm5Q0ztmtsJ CYuf+N5yuXynPZTaPY07D9vwRXMMnD5lsJ95e0RRS0fvu7/g9vJlW78j0jLd4FNbYPeO 6kriThiYQxvIJ+cvQkR5ySkBR9kigxJfGync32j9nScYQzTVAdDYPC/Aq0yOTQS7Pekk nBbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707460886; x=1708065686; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lyx14WO2VlxFkhc1a5xMd2hg19LxPHSwC4OsD7s+Vd8=; b=aXAYay6c3lPYWHIwvF5kLS0xZ3VENSKLsmbDK8hmgnqziYmXkoL1dBksl1nRTS7DFv oMSjVNDtOqm5VgAcaDURVqYXNeNjw6lOrmflhN0xtkL4THTDES+PuhXCol2T+Gv+rB2O xiahhxYtr2OLL3fepvqkS4/riC0nWnvA/ga+Jkn7dQHcbs5Bk1aaxM79Md80QCBe7nae 1rPI9v91dtHB34SHD+nNTa5iQbbTUyY3LjxxOrvGC6HBsudlzB8A2WXisJ6IxP2mncrO imHiLluy+9h4TnHM57/mXtrT+SyM4sdhBD7MndQvY4v4A1vzDQPTY/uUPYlVsQHGKg7h Um/w== X-Forwarded-Encrypted: i=1; AJvYcCVjF4Zf7QflGKlIvW8EaQ6pv7YJv/uqKQiVPOd/bQP1Ia7Z+VWiL+LGH2xSPQwPJdkUx/HL0e0+zyfqX8kigfyOc58oJoE= X-Gm-Message-State: AOJu0YxDGi6t6t2yP7n+vJaKgv3UCKXYPCkwAlTI2Jg9KrLGO5RYxIGI 87Ju/pCh3Vw/1A4lHvf1rDyY5UTnGwF6ZEI4wjV7bPME70cEzqzytfXeiRyH7Cg= X-Google-Smtp-Source: AGHT+IHTlnTiRjjIG5iGqID+1N5AGA7ugO/4dpu/2pphdV/WOEERYZ6slSefSrUbEV5/MAug6BYlpg== X-Received: by 2002:a17:906:56ce:b0:a36:f811:1050 with SMTP id an14-20020a17090656ce00b00a36f8111050mr377077ejc.45.1707460886618; Thu, 08 Feb 2024 22:41:26 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXUwEhrfC72X16CSzyz1KVZWQwv3mhhZWfeaVUmJg50H2aBK/VDI9pn+dFr0LGOGT3cOpaCNZuHyekGu0T0UW2lm2mERLxF223s0oDQRoFxhANu5dU7P58RoPZeS37DbK2w5MyHVMJR211UcO2O+CuVCP1JSJIm+r247uK+CcTqZXbnNDEh5CWZ4YUyEVC8MXjb6am+xOCbt9ZHQuxXHZaT1OEIfDiMAjvPk5FWoCC4p38hApCB+rdhWhSOlIJz+rHcdkJKaqgvF0v5Zx/8xvwSd9Bxhx0wKYxujukXrWpl3PSicWpW5Tzg8VePm28nigea1GaqLR29JnM1owD/PHHfX9tW6gPOr9h8RONASqeIjmWPcJ2+29tl8rHO6ajB5iK01KEg/Vc3rjnt From: =?UTF-8?q?Christoph=20M=C3=BCllner?= To: qemu-riscv@nongnu.org, qemu-devel@nongnu.org, Alistair Francis , Bin Meng , Philipp Tomsich , Palmer Dabbelt , Richard Henderson , Daniel Henrique Barboza , Andrew Jones Cc: =?UTF-8?q?Christoph=20M=C3=BCllner?= , Weiwei Li , Liu Zhiwei Subject: [RFC PATCH v2 1/4] RISC-V: Add support for Ssdtso Date: Fri, 9 Feb 2024 07:41:14 +0100 Message-ID: <20240209064117.2746701-2-christoph.muellner@vrull.eu> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240209064117.2746701-1-christoph.muellner@vrull.eu> References: <20240209064117.2746701-1-christoph.muellner@vrull.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::630; envelope-from=christoph.muellner@vrull.eu; helo=mail-ej1-x630.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @vrull.eu) X-ZM-MESSAGEID: 1707460964147100003 The Ssdtso extension introduces a DTSO field to the {m,s,h}envcfg register to enable TSO at run-time. Building on top of Ztso support, this patch treats Ssdtso just like Ztso (always execute in TSO mode), which should be fine from a correctness perspective. Similar like Ztso, this is expected to have little overhead on host machines that operate in TSO mode (e.g. x86). However, executing the TSO fences on guests without TSO, will have a negative performance impact, regardless if TSO is enabled in the guest or not (e.g. running a RV guest with Ssdtso and disabled DTSO bit on an aarch64 host). Signed-off-by: Christoph M=C3=BCllner --- target/riscv/cpu.c | 8 ++++++-- target/riscv/cpu_bits.h | 3 +++ target/riscv/cpu_cfg.h | 1 + target/riscv/csr.c | 14 +++++++++++--- target/riscv/translate.c | 2 +- 5 files changed, 22 insertions(+), 6 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index b679ecd8c7..ee90c09600 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -174,6 +174,7 @@ const RISCVIsaExtData isa_edata_arr[] =3D { ISA_EXT_DATA_ENTRY(smstateen, PRIV_VERSION_1_12_0, ext_smstateen), ISA_EXT_DATA_ENTRY(ssaia, PRIV_VERSION_1_12_0, ext_ssaia), ISA_EXT_DATA_ENTRY(sscofpmf, PRIV_VERSION_1_12_0, ext_sscofpmf), + ISA_EXT_DATA_ENTRY(ssdtso, PRIV_VERSION_1_12_0, ext_ssdtso), ISA_EXT_DATA_ENTRY(sstc, PRIV_VERSION_1_12_0, ext_sstc), ISA_EXT_DATA_ENTRY(svadu, PRIV_VERSION_1_12_0, ext_svadu), ISA_EXT_DATA_ENTRY(svinval, PRIV_VERSION_1_12_0, ext_svinval), @@ -950,9 +951,11 @@ static void riscv_cpu_reset_hold(Object *obj) env->two_stage_lookup =3D false; =20 env->menvcfg =3D (cpu->cfg.ext_svpbmt ? MENVCFG_PBMTE : 0) | - (cpu->cfg.ext_svadu ? MENVCFG_ADUE : 0); + (cpu->cfg.ext_svadu ? MENVCFG_ADUE : 0) | + (cpu->cfg.ext_ztso && cpu->cfg.ext_ssdtso ? MENVCFG_DTS= O : 0); env->henvcfg =3D (cpu->cfg.ext_svpbmt ? HENVCFG_PBMTE : 0) | - (cpu->cfg.ext_svadu ? HENVCFG_ADUE : 0); + (cpu->cfg.ext_svadu ? HENVCFG_ADUE : 0) | + (cpu->cfg.ext_ztso && cpu->cfg.ext_ssdtso ? HENVCFG_DTS= O : 0); =20 /* Initialized default priorities of local interrupts. */ for (i =3D 0; i < ARRAY_SIZE(env->miprio); i++) { @@ -1460,6 +1463,7 @@ const RISCVCPUMultiExtConfig riscv_cpu_extensions[] = =3D { MULTI_EXT_CFG_BOOL("zve32f", ext_zve32f, false), MULTI_EXT_CFG_BOOL("zve64f", ext_zve64f, false), MULTI_EXT_CFG_BOOL("zve64d", ext_zve64d, false), + MULTI_EXT_CFG_BOOL("ssdtso", ext_ssdtso, false), MULTI_EXT_CFG_BOOL("sstc", ext_sstc, true), =20 MULTI_EXT_CFG_BOOL("smepmp", ext_smepmp, false), diff --git a/target/riscv/cpu_bits.h b/target/riscv/cpu_bits.h index fc2068ee4d..e11191977d 100644 --- a/target/riscv/cpu_bits.h +++ b/target/riscv/cpu_bits.h @@ -744,6 +744,7 @@ typedef enum RISCVException { #define MENVCFG_CBIE (3UL << 4) #define MENVCFG_CBCFE BIT(6) #define MENVCFG_CBZE BIT(7) +#define MENVCFG_DTSO BIT(8) #define MENVCFG_ADUE (1ULL << 61) #define MENVCFG_PBMTE (1ULL << 62) #define MENVCFG_STCE (1ULL << 63) @@ -757,11 +758,13 @@ typedef enum RISCVException { #define SENVCFG_CBIE MENVCFG_CBIE #define SENVCFG_CBCFE MENVCFG_CBCFE #define SENVCFG_CBZE MENVCFG_CBZE +#define SENVCFG_DTSO MENVCFG_DTSO =20 #define HENVCFG_FIOM MENVCFG_FIOM #define HENVCFG_CBIE MENVCFG_CBIE #define HENVCFG_CBCFE MENVCFG_CBCFE #define HENVCFG_CBZE MENVCFG_CBZE +#define HENVCFG_DTSO MENVCFG_DTSO #define HENVCFG_ADUE MENVCFG_ADUE #define HENVCFG_PBMTE MENVCFG_PBMTE #define HENVCFG_STCE MENVCFG_STCE diff --git a/target/riscv/cpu_cfg.h b/target/riscv/cpu_cfg.h index afba8ed0b2..606ae5a120 100644 --- a/target/riscv/cpu_cfg.h +++ b/target/riscv/cpu_cfg.h @@ -73,6 +73,7 @@ struct RISCVCPUConfig { bool ext_zihpm; bool ext_ztso; bool ext_smstateen; + bool ext_ssdtso; bool ext_sstc; bool ext_svadu; bool ext_svinval; diff --git a/target/riscv/csr.c b/target/riscv/csr.c index d4e8ac13b9..c06b674994 100644 --- a/target/riscv/csr.c +++ b/target/riscv/csr.c @@ -2058,7 +2058,9 @@ static RISCVException write_menvcfg(CPURISCVState *en= v, int csrno, target_ulong val) { const RISCVCPUConfig *cfg =3D riscv_cpu_cfg(env); - uint64_t mask =3D MENVCFG_FIOM | MENVCFG_CBIE | MENVCFG_CBCFE | MENVCF= G_CBZE; + uint64_t mask =3D MENVCFG_FIOM | MENVCFG_CBIE | MENVCFG_CBCFE | + MENVCFG_CBZE | + (cfg->ext_ssdtso && !cfg->ext_ztso ? MENVCFG_DTSO : 0); =20 if (riscv_cpu_mxl(env) =3D=3D MXL_RV64) { mask |=3D (cfg->ext_svpbmt ? MENVCFG_PBMTE : 0) | @@ -2108,7 +2110,10 @@ static RISCVException read_senvcfg(CPURISCVState *en= v, int csrno, static RISCVException write_senvcfg(CPURISCVState *env, int csrno, target_ulong val) { - uint64_t mask =3D SENVCFG_FIOM | SENVCFG_CBIE | SENVCFG_CBCFE | SENVCF= G_CBZE; + const RISCVCPUConfig *cfg =3D riscv_cpu_cfg(env); + uint64_t mask =3D SENVCFG_FIOM | SENVCFG_CBIE | SENVCFG_CBCFE | + SENVCFG_CBZE | + (cfg->ext_ssdtso && !cfg->ext_ztso ? SENVCFG_DTSO : 0); RISCVException ret; =20 ret =3D smstateen_acc_ok(env, 0, SMSTATEEN0_HSENVCFG); @@ -2143,7 +2148,10 @@ static RISCVException read_henvcfg(CPURISCVState *en= v, int csrno, static RISCVException write_henvcfg(CPURISCVState *env, int csrno, target_ulong val) { - uint64_t mask =3D HENVCFG_FIOM | HENVCFG_CBIE | HENVCFG_CBCFE | HENVCF= G_CBZE; + const RISCVCPUConfig *cfg =3D riscv_cpu_cfg(env); + uint64_t mask =3D HENVCFG_FIOM | HENVCFG_CBIE | HENVCFG_CBCFE | + HENVCFG_CBZE | + (cfg->ext_ssdtso && !cfg->ext_ztso ? HENVCFG_DTSO : 0); RISCVException ret; =20 ret =3D smstateen_acc_ok(env, 0, SMSTATEEN0_HSENVCFG); diff --git a/target/riscv/translate.c b/target/riscv/translate.c index ea5d52b2ef..f0d4db0b64 100644 --- a/target/riscv/translate.c +++ b/target/riscv/translate.c @@ -1198,7 +1198,7 @@ static void riscv_tr_init_disas_context(DisasContextB= ase *dcbase, CPUState *cs) ctx->cs =3D cs; ctx->pm_mask_enabled =3D FIELD_EX32(tb_flags, TB_FLAGS, PM_MASK_ENABLE= D); ctx->pm_base_enabled =3D FIELD_EX32(tb_flags, TB_FLAGS, PM_BASE_ENABLE= D); - ctx->ztso =3D cpu->cfg.ext_ztso; + ctx->ztso =3D cpu->cfg.ext_ztso || cpu->cfg.ext_ssdtso; ctx->itrigger =3D FIELD_EX32(tb_flags, TB_FLAGS, ITRIGGER); ctx->zero =3D tcg_constant_tl(0); ctx->virt_inst_excp =3D false; --=20 2.43.0 From nobody Sun Sep 8 01:22:51 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=vrull.eu ARC-Seal: i=1; a=rsa-sha256; t=1707460964; cv=none; d=zohomail.com; s=zohoarc; b=M1W+z8p3vbet8taQhdB7cTEmZqsB7K2p48an65EQLoYVmHDAdPYn6ljywC6nf3CQV3as8RIdErwNV9CJkcRU8kzMyUzphuwHByF/5QvWUywIUMqUsBHByKuHSWkac0l+w7qhWeVfZMOJ//Ahh/xkjlL1btTmPDhQbVj9SPliC9Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1707460964; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=EUtumchVWAjnFsnLqrfLNxKYwp3IzTxvepBmSvQHMis=; b=g1eNiE7FkAZnFAOV9k+M0Y/uOG8EwJKokgtmEztsJ55zcssd0t1j7piJEYqLMUsqebNENnzuZJoJNUwasgtZajMSJ9q763wbyDZibVzX7K+HC2pdkVeihUoi9id3uHTVSskF7XZZimfJ5Dubs8wdreTUt1SRoN91BuxpI7IepMU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 170746096415099.99806670626185; Thu, 8 Feb 2024 22:42:44 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rYKZy-0005x1-8Z; Fri, 09 Feb 2024 01:41:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYKZn-0005kn-Gn for qemu-devel@nongnu.org; Fri, 09 Feb 2024 01:41:32 -0500 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rYKZl-0002OE-HY for qemu-devel@nongnu.org; Fri, 09 Feb 2024 01:41:31 -0500 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-558f523c072so918301a12.2 for ; Thu, 08 Feb 2024 22:41:29 -0800 (PST) Received: from beast.fritz.box (62-178-148-172.cable.dynamic.surfer.at. [62.178.148.172]) by smtp.gmail.com with ESMTPSA id vk9-20020a170907cbc900b00a36c499c935sm450575ejc.43.2024.02.08.22.41.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 22:41:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; t=1707460888; x=1708065688; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EUtumchVWAjnFsnLqrfLNxKYwp3IzTxvepBmSvQHMis=; b=USnNRk/B5IDja+g17J+m/dD/Xk7l7RxMTxxANfYgv69tquNdeLLa1tSesk3dRJkD3A KbY5BeaRYI+wXV9haQVmNI4bqhwOJ75jztvdvQnDBv7Q91DWigz+NugdGMzkgSvTws6p TlVjmw1CgQVizz+EPPRKci4hwjbvkiQJFtH4BhIOPTZ35kDHuZKc23UCCNI2sn3680It PaBkLF3tYq66LtwQsjIL8QHejva6H74NCYtbX9bV6LAjhWPE1cFSp4gneZiA7KQUfv7A Oi2zgKUWH9axdyMi7QY3+Dijla2ItL4Ctm0prtovtG4ZDc2F/uFQzohWrIBVuvLkWyoS IQMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707460888; x=1708065688; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EUtumchVWAjnFsnLqrfLNxKYwp3IzTxvepBmSvQHMis=; b=nHwBjo2rpaVcK62/ay4OnuFTzBHp3I0nI9vgtByY+Rj45fW3mABLvpmJwoIrUuNBzk FpzglVeqcYPT5cf/1nDGuuLcAblBrBWefazHPSj4sprerdUf1dgq1hWEBF1l+XFnpTt2 e+h18imT5HcEPbAXf01yc8n6r1BnSP/H97T8s2EdsSvgzhMFbWi7RAtT4j0vF6x6fs75 t8/yDw5k93kt5CTFMaiz+R9m7ubNN7VSUBoGOZyHLsS0mQkF6ojJfFSyJSXjkepkzc+w 9/uAdJ5FPz5OVtq052GLLXFtnXz0nuPtmnf3/uC0K7CcsHeJAqcH7X4jsy9BDzzSS6jy EuEA== X-Gm-Message-State: AOJu0YyKthsEuRYfN7wIkrpo2JVbuo9Jy32hcM+WS3cnMiZGV9onElCa DrHuQdI38RjsyeXkQx4aPitQjgXdGbu+cYFq4cleJEFK80NoHbzIQN8zXlRfVSk= X-Google-Smtp-Source: AGHT+IGsK3WqE/n5HdtWollG/0f1PKEWUQcdsSUUHRmuIs1eIfzrw80IAhDLp9C+l4mUaBLJRqeiSQ== X-Received: by 2002:a17:906:b2c9:b0:a37:76df:be40 with SMTP id cf9-20020a170906b2c900b00a3776dfbe40mr469668ejb.36.1707460887941; Thu, 08 Feb 2024 22:41:27 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWmMnpgfP7SL9AMOeYk/4RPOp12RZO/c3RGu+ogxsjxT/R3WKCdoR2U6r0eKrwFHykbSSVctB0wHpjiQsbytjigZrYZ3ifQwbGm/9K6bl33U8UTUSM/lKaoLPbJVCNPmBnQrqHCpDpPBwkPM7LR0e6Xa593sWHnoscIDAc1MlEU82JfzACVm9SPJ+s6ISMCyjSuIa3kQ/Rb7Oo7UyudanXpaXYWhjh6gmKzVrHW6yyzMljVtHc6C/a8LdrHQ5aa3WK0dNF8/FMUB6B1AJruAFcJWUvC1SUSyCy2WblzBKoQF1Af5Vi0RJYFD+/ttLFdfGzjQfQMjmjQc7HZ5JIsHJxRn1pZQDHqNZrujw== From: =?UTF-8?q?Christoph=20M=C3=BCllner?= To: qemu-riscv@nongnu.org, qemu-devel@nongnu.org, Alistair Francis , Bin Meng , Philipp Tomsich , Palmer Dabbelt , Richard Henderson , Daniel Henrique Barboza , Andrew Jones Cc: =?UTF-8?q?Christoph=20M=C3=BCllner?= , Laurent Vivier Subject: [RFC PATCH v2 2/4] linux-user/riscv: Add Ssdtso extension to hwprobe Date: Fri, 9 Feb 2024 07:41:15 +0100 Message-ID: <20240209064117.2746701-3-christoph.muellner@vrull.eu> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240209064117.2746701-1-christoph.muellner@vrull.eu> References: <20240209064117.2746701-1-christoph.muellner@vrull.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::533; envelope-from=christoph.muellner@vrull.eu; helo=mail-ed1-x533.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @vrull.eu) X-ZM-MESSAGEID: 1707460966266100013 This patch exposes Ssdtso via hwprobe in QEMU's user space emulator. Signed-off-by: Christoph M=C3=BCllner --- linux-user/syscall.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 24fa11d946..bf0d66b8a8 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -8829,6 +8829,7 @@ static int do_getdents64(abi_long dirfd, abi_long arg= 2, abi_long count) #define RISCV_HWPROBE_EXT_ZTSO (1ULL << 33) #define RISCV_HWPROBE_EXT_ZACAS (1ULL << 34) #define RISCV_HWPROBE_EXT_ZICOND (1ULL << 35) +#define RISCV_HWPROBE_EXT_SSDTSO (1ULL << 36) =20 #define RISCV_HWPROBE_KEY_CPUPERF_0 5 #define RISCV_HWPROBE_MISALIGNED_UNKNOWN (0 << 0) @@ -8947,6 +8948,8 @@ static void risc_hwprobe_fill_pairs(CPURISCVState *en= v, RISCV_HWPROBE_EXT_ZACAS : 0; value |=3D cfg->ext_zicond ? RISCV_HWPROBE_EXT_ZICOND : 0; + value |=3D cfg->ext_ssdtso ? + RISCV_HWPROBE_EXT_SSDTSO : 0; __put_user(value, &pair->value); break; case RISCV_HWPROBE_KEY_CPUPERF_0: --=20 2.43.0 From nobody Sun Sep 8 01:22:51 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=vrull.eu ARC-Seal: i=1; a=rsa-sha256; t=1707460978; cv=none; d=zohomail.com; s=zohoarc; b=QWHhDTywLcQyb16QI7hRBQ0IDaboz/hMfvsyiV7uXJw8hbmaweyV1/TmqIBIkDpAL6nxtVMcKXKWQklY+NMJo+SvMV//ftolsVMs8f82DGxYoaRBeQ2qNSLy3B5c26BScHiCZ8ySOwdVVi7a+VukCDoMnZhRUHfAQnflVr7Joas= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1707460978; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ytTPrgvmcSAVYKXxwo9D3fPgoAujr29L9BQ2PXjBjJU=; b=DB+Sl1vozVPV/Efp/QbRQ//KXCuwFAZWdxK/7/ZhUBDsdESilnBPO+e5GbeBT0vuzxTfAJzTF966LRFvau+CxVOAJe05V4QtdJ0H86X32Xbayv5UE9nG8tg/qOcgMfidE91f4c0TYTdjODqQUrWeMuon/DaXxNWtJ+rTjrq9GzE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1707460978806491.8955714604267; Thu, 8 Feb 2024 22:42:58 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rYKZs-0005tp-K0; Fri, 09 Feb 2024 01:41:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYKZo-0005mq-PA for qemu-devel@nongnu.org; Fri, 09 Feb 2024 01:41:34 -0500 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rYKZm-0002Oc-Nf for qemu-devel@nongnu.org; Fri, 09 Feb 2024 01:41:32 -0500 Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-a3916c1f9b0so73545566b.1 for ; Thu, 08 Feb 2024 22:41:30 -0800 (PST) Received: from beast.fritz.box (62-178-148-172.cable.dynamic.surfer.at. [62.178.148.172]) by smtp.gmail.com with ESMTPSA id vk9-20020a170907cbc900b00a36c499c935sm450575ejc.43.2024.02.08.22.41.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 22:41:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; t=1707460889; x=1708065689; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ytTPrgvmcSAVYKXxwo9D3fPgoAujr29L9BQ2PXjBjJU=; b=GUwlIrfMJLi+m0QhrP+rDM9csRnx8WhKzdvziezTCKCl4/Hyzfg0oJHXxvsLPa6UkC vw+2g7YcD9C9XE2W5RliUMejAb5qA4cabirr2q1i87/P9t0VCiFdo2YMcWHUGpBe4/oD 4WbQFiUKMqjI6Urq6VaTBQ/mn7QXz178lismOKkYi9l8/1c51AHOdzC5z16sW+VR1eF+ gbxMtxadjIGI5BI1Kt03UFRQKJbNcN6cDeCNyeJ3vQ0aKSfW9Iatyp97h5N/PBR8DIM0 r3A7Ie+83zib4EhQk0CwDkxyVEOrm0n5HIr0u15Cmr64mJ9rw4EvffXAe5+wCTwfM3+1 MKMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707460889; x=1708065689; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ytTPrgvmcSAVYKXxwo9D3fPgoAujr29L9BQ2PXjBjJU=; b=bvdAQ96STLoZ6JYCyW3n34KQFX1I8vORF0FASpqM4uBRyIQeEeZaF6+zWbDqsZoScD wtjQtxJv1iWBygACXf9FYuv+ZehLujxR3EMwOhXyTDJpWCGlNFISDTI+8fq/D1vG7gm8 J2LtrW0OG2p2etvTGyVSQLI/WAqnwb+M2bCBMSK4OgRSyPM5xf15AYucrnScJG8ZCaOc iRkIMfsBUhvtM3dkk4LWodY6qSIOVrC3PbAi5JT8Rrl7Cu2FvFEBI3fTg/enuODpVpBU i/r00c3GBI2g7ibpREr76R7z8yl5Hl23lJZcEl1oybc98NSdWsv2X+YFmAhVT+hermNg dAWg== X-Gm-Message-State: AOJu0Yzj295KE9T4WOjccZcG6k3GiyxAmWtmSLOm18QY8hb3RkLup0ec 3ZYL6aMlFp62A74Y7B3knPmuOjJg5sHJhEExJKXm+/U9n5NMrncdiCOKK3HOMIM= X-Google-Smtp-Source: AGHT+IFVg4lO8zkHhRZCGeDc2MDr2YQcPD8It/U0CsIDnPbxPJxfIBzw6pOBCu/rKHCc+ukuID9cwQ== X-Received: by 2002:a17:906:3b5a:b0:a3b:721a:9162 with SMTP id h26-20020a1709063b5a00b00a3b721a9162mr409548ejf.66.1707460889359; Thu, 08 Feb 2024 22:41:29 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWR+BGDglxI4JrKwy7PM9PtB7wk/zlH9clO2KU+SaMEc5HYGP6818LRYYzni3w9RdJNoXM91X8rVEr5nFYgjOIIoZB0f99OlA4LQ3LGVCpO6eqW7bv9lj+ElVSDNGrEE1uJcq9QvOJhO2C43pMYwn7oP3VU/SCF0Gs45ZvTINicfDhEItIi1K6p7xy0HLGlWL/JsInD6RN5f17TlbR2Oom/RpL1VjEQRnwWD1gr5KxC14yPlp+TYobLea7Lz4QsCNP2Alo0GyMQgr6g8qhycZvbs7o4AxOUBVem2ahTmphQf7Y6VI/0kK4lIo/2R2ytHRhv3iz9bpVHsWxJLi2CoA8jgZxakVm4JK1KHg== From: =?UTF-8?q?Christoph=20M=C3=BCllner?= To: qemu-riscv@nongnu.org, qemu-devel@nongnu.org, Alistair Francis , Bin Meng , Philipp Tomsich , Palmer Dabbelt , Richard Henderson , Daniel Henrique Barboza , Andrew Jones Cc: =?UTF-8?q?Christoph=20M=C3=BCllner?= , Laurent Vivier Subject: [RFC PATCH v2 3/4] linux-user/prctl: Add dynamic memory consistency model prctl API Date: Fri, 9 Feb 2024 07:41:16 +0100 Message-ID: <20240209064117.2746701-4-christoph.muellner@vrull.eu> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240209064117.2746701-1-christoph.muellner@vrull.eu> References: <20240209064117.2746701-1-christoph.muellner@vrull.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::635; envelope-from=christoph.muellner@vrull.eu; helo=mail-ej1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @vrull.eu) X-ZM-MESSAGEID: 1707460980186100001 This patch implements the prctl calls to set and get the current memory consistency model. This patch does not implement any real functionality but just defines the relevant hooks, where target code take over. Signed-off-by: Christoph M=C3=BCllner --- linux-user/syscall.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index bf0d66b8a8..cf0845a074 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -6309,6 +6309,12 @@ abi_long do_arch_prctl(CPUX86State *env, int code, a= bi_ulong addr) # define PR_SME_VL_LEN_MASK 0xffff # define PR_SME_VL_INHERIT (1 << 17) #endif +#ifndef PR_SET_MEMORY_CONSISTENCY_MODEL +# define PR_SET_MEMORY_CONSISTENCY_MODEL 71 +# define PR_GET_MEMORY_CONSISTENCY_MODEL 72 +# define PR_MEMORY_CONSISTENCY_MODEL_RISCV_WMO 1 +# define PR_MEMORY_CONSISTENCY_MODEL_RISCV_TSO 2 +#endif =20 #include "target_prctl.h" =20 @@ -6355,6 +6361,12 @@ static abi_long do_prctl_inval1(CPUArchState *env, a= bi_long arg2) #ifndef do_prctl_sme_set_vl #define do_prctl_sme_set_vl do_prctl_inval1 #endif +#ifndef do_prctl_set_memory_consistency_model +#define do_prctl_set_memory_consistency_model do_prctl_inval1 +#endif +#ifndef do_prctl_get_memory_consistency_model +#define do_prctl_get_memory_consistency_model do_prctl_inval0 +#endif =20 static abi_long do_prctl(CPUArchState *env, abi_long option, abi_long arg2, abi_long arg3, abi_long arg4, abi_long arg5) @@ -6481,6 +6493,11 @@ static abi_long do_prctl(CPUArchState *env, abi_long= option, abi_long arg2, /* Disable to prevent the target disabling stuff we need. */ return -TARGET_EINVAL; =20 + case PR_SET_MEMORY_CONSISTENCY_MODEL: + return do_prctl_set_memory_consistency_model(env, arg2); + case PR_GET_MEMORY_CONSISTENCY_MODEL: + return do_prctl_get_memory_consistency_model(env); + default: qemu_log_mask(LOG_UNIMP, "Unsupported prctl: " TARGET_ABI_FMT_ld "= \n", option); --=20 2.43.0 From nobody Sun Sep 8 01:22:51 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=vrull.eu ARC-Seal: i=1; a=rsa-sha256; t=1707460962; cv=none; d=zohomail.com; s=zohoarc; b=PxZMRw8R1XfHI+Ay2w727M+fdC5g42Sc98lekUvdsQlkb6Bl/6oFvMFBRz71TXHW4/FTCMtUotAYKuExCnxsMXEpv0qxiuD3YLQ91YkYMQTrxA2wQXiMqSlpmqsZrldWThm8VAHZPP3lmn3+No/o3UGYyrpVf9PkXGIaFkld0Po= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1707460962; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/nJiaJKCuzUzPChMbWkGwMdFArNUhgZ5ZSPilG6i32Y=; b=aruYgUprZVR/nYkeaLJ3dzWQxr2ZYtZo79ua0znErISQsYb52pltHfyPt2wwAX8sIv6z7Drx32CA1oNcBdXQHaHKSDBIkO0eK3OaXNyeTl9ep+3qPCw2O+tcessWg4D2mttbjZHSc3S9ToPLici2yDRnvf/exv2LMYj0T8aHx0w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1707460962204437.30263847754225; Thu, 8 Feb 2024 22:42:42 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rYKa0-0005yf-6w; Fri, 09 Feb 2024 01:41:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYKZq-0005oG-SD for qemu-devel@nongnu.org; Fri, 09 Feb 2024 01:41:34 -0500 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rYKZo-0002P0-5u for qemu-devel@nongnu.org; Fri, 09 Feb 2024 01:41:33 -0500 Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-a2f79e79f0cso81094466b.2 for ; Thu, 08 Feb 2024 22:41:31 -0800 (PST) Received: from beast.fritz.box (62-178-148-172.cable.dynamic.surfer.at. [62.178.148.172]) by smtp.gmail.com with ESMTPSA id vk9-20020a170907cbc900b00a36c499c935sm450575ejc.43.2024.02.08.22.41.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 22:41:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; t=1707460890; x=1708065690; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/nJiaJKCuzUzPChMbWkGwMdFArNUhgZ5ZSPilG6i32Y=; b=L18zqnmRJprRX6etLHTSu+b+1+a0S8nO8BxVQqlYTurrpwXJlR/JYn+Bb1sbINWqva /0/bWN5sXbKN14iH6+uhB839YbfDTbmReS+XlnWKBJwTNI+HmF8pL9+QNr/S2/tdFKjc IZQug9fgYr5ZHFknCNoGsSm5ltBHxEDmOEuEwnx7R7wZ5v8R9O61cp6PeuwQc7EdVWhN UA+5qGj7K0GffMIgKs0rrzejEhukyNb7rqBRgLWXaJen3xiBI2PvuP8wcSY5WF38tX1C WWwBpMFo7ChQLzmLKxPDwHHKD2Zz2d7gM71mYy66XT4lUE9XenCDb2rFooQzwncVZ7qK i9QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707460890; x=1708065690; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/nJiaJKCuzUzPChMbWkGwMdFArNUhgZ5ZSPilG6i32Y=; b=FRw31ZwMXXBewbJtSTwFjuU5HT+F2giCiM3HSEoji0io0P7/KwPYrY2DRejks/FhSV 2Q7Kf5MvlX4nJ67DHhHk0l8BrECzet1vXdR8pulhHYyCe9D5yIoMb6HsY3LWFWJI85qd bsP+boD+t6S5f2il6gt7vjKd4pjCdvTxhc/u3yZmhBOW70nScc6SDnhWyqmdTAariyKt ySRPU6pIwH+31Ara4uRO0tHQ4Mtz5AYv/NC3r6kS+A7mtosfjhPS58svWn8BR49sBbA/ 2lAxuMurRNnV32YQ6QjLZyIYKpBbQQ3v3/7WvVCuBRpPD764Ae9aRIgzdkVccqepfG3V xtMA== X-Forwarded-Encrypted: i=1; AJvYcCV2kA4XXMC6lIdWG8UbrTTgwLBeON6w5/976spgXt6CJFGcCR5r0yxHCflfAJjdVIqoA0RzYo1pDDFtEC7AWT6g6Turud8= X-Gm-Message-State: AOJu0YxtkPLMFQQ/PoS82Vwm+3L2jQt8cmQ9W999tNjNLY4fxsqpmbpI +9dMmIO+7iECBiWKFp3LObqcdrBn3h+VGbs4bk3n3Emt2EewAHUPR/C90ZaMaow= X-Google-Smtp-Source: AGHT+IFB6zbDt8USaW4Fygr3gycFlYc5raNVU0XxxE2AGBqm/iK0fLZo6dSrSq4P4mhQz/mhYpHKWQ== X-Received: by 2002:a17:906:407:b0:a38:421c:876c with SMTP id d7-20020a170906040700b00a38421c876cmr449361eja.19.1707460890727; Thu, 08 Feb 2024 22:41:30 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWXFfFzEpbv5Ch2UC92cQCDa2zHx/3tdtlK6A8FVdI7yPzKl8rdHrd2Bnw/HKp1ikdfErtTDOJQ5MucBZCrzk3ww5GSdWtIrd9K5U1Rks0RQ3TSvicTEqocH/EOoPe11ABThfFQ5ZIEVL8n1tH6HcOtAdxUst7fiq36nqH59Pbx5ayy0Huq1sLUqj7qhCHUxiP187tt20JBWunGQBRWlEQOb44YLHuEneXdLu4GKVj4/Oulnxpj3wISzkdbGRpZv+QMYDq8e0yMavreAaD+S2VkawSCXgi+FBHwXkf2Rf+e8MqVGrTdwHttK9nY90l02N8MVSsLvhYStc2XTTSoQmGMJEMU1Ne+aYJPOHhCPi4jnK29EFHXRLXDmIMVo9RpMF2/MyiV1jF33DJoj+iS5BgjwN+KkWbmTugJoRdhug== From: =?UTF-8?q?Christoph=20M=C3=BCllner?= To: qemu-riscv@nongnu.org, qemu-devel@nongnu.org, Alistair Francis , Bin Meng , Philipp Tomsich , Palmer Dabbelt , Richard Henderson , Daniel Henrique Barboza , Andrew Jones Cc: =?UTF-8?q?Christoph=20M=C3=BCllner?= , Laurent Vivier , Weiwei Li , Liu Zhiwei Subject: [RFC PATCH v2 4/4] linux-user/riscv: Implement dynamic memory consistency model support Date: Fri, 9 Feb 2024 07:41:17 +0100 Message-ID: <20240209064117.2746701-5-christoph.muellner@vrull.eu> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240209064117.2746701-1-christoph.muellner@vrull.eu> References: <20240209064117.2746701-1-christoph.muellner@vrull.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::632; envelope-from=christoph.muellner@vrull.eu; helo=mail-ej1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @vrull.eu) X-ZM-MESSAGEID: 1707460964156100004 This patch implements the dynamic memory consistency model prctl calls for RISC-V. The implementation introduces a single boolean variable to keep the DTSO state. Signed-off-by: Christoph M=C3=BCllner --- linux-user/riscv/target_prctl.h | 76 ++++++++++++++++++++++++++++++++- target/riscv/cpu.c | 5 +++ target/riscv/cpu.h | 1 + 3 files changed, 81 insertions(+), 1 deletion(-) diff --git a/linux-user/riscv/target_prctl.h b/linux-user/riscv/target_prct= l.h index eb53b31ad5..e54321d872 100644 --- a/linux-user/riscv/target_prctl.h +++ b/linux-user/riscv/target_prctl.h @@ -1 +1,75 @@ -/* No special prctl support required. */ +/* + * RISC-V specific prctl functions for linux-user + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ +#ifndef RISCV_TARGET_PRCTL_H +#define RISCV_TARGET_PRCTL_H + +static inline void riscv_dtso_set_enable(CPURISCVState *env, bool enable) +{ + env->dtso_ena =3D enable; +} + +static inline bool riscv_dtso_is_enabled(CPURISCVState *env) +{ + return env->dtso_ena; +} + +static abi_long do_prctl_set_memory_consistency_model(CPUArchState *cpu_en= v, + abi_long arg2) +{ + RISCVCPU *cpu =3D env_archcpu(cpu_env); + bool dtso_ena_old =3D riscv_dtso_is_enabled(cpu_env); + bool dtso_ena_new; + bool has_dtso =3D cpu->cfg.ext_ssdtso; + + switch (arg2) { + case PR_MEMORY_CONSISTENCY_MODEL_RISCV_WMO: + dtso_ena_new =3D false; + break; + case PR_MEMORY_CONSISTENCY_MODEL_RISCV_TSO: + dtso_ena_new =3D true; + break; + default: + return -TARGET_EINVAL; + } + + /* No change requested. */ + if (dtso_ena_old =3D=3D dtso_ena_new) + return 0; + + /* Enabling TSO only works if DTSO is available. */ + if (dtso_ena_new && !has_dtso) + return -TARGET_EINVAL; + + /* Switchin TSO->WMO is not allowed. */ + if (!dtso_ena_new) + return -TARGET_EINVAL; + + riscv_dtso_set_enable(cpu_env, dtso_ena_new); + + /* + * No need to reschedule other threads, because the emulation + * of DTSO is fine (from a memory model view) if they are out + * of sync until they will eventually reschedule. + */ + + return 0; +} + +#define do_prctl_set_memory_consistency_model \ + do_prctl_set_memory_consistency_model + +static abi_long do_prctl_get_memory_consistency_model(CPUArchState *cpu_en= v) +{ + if (riscv_dtso_is_enabled(cpu_env)) + return PR_MEMORY_CONSISTENCY_MODEL_RISCV_TSO; + + return PR_MEMORY_CONSISTENCY_MODEL_RISCV_WMO; +} + +#define do_prctl_get_memory_consistency_model \ + do_prctl_get_memory_consistency_model + +#endif /* RISCV_TARGET_PRCTL_H */ diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index ee90c09600..2e2aac73dc 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -922,6 +922,11 @@ static void riscv_cpu_reset_hold(Object *obj) if (mcc->parent_phases.hold) { mcc->parent_phases.hold(obj); } +#ifdef CONFIG_USER_ONLY + /* Default is true if Ztso is enabled, false otherwise. */ + env->dtso_ena =3D cpu->cfg.ext_ztso; +#endif + #ifndef CONFIG_USER_ONLY env->misa_mxl =3D mcc->misa_mxl_max; env->priv =3D PRV_M; diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index f52dce78ba..69420b2ae3 100644 --- a/target/riscv/cpu.h +++ b/target/riscv/cpu.h @@ -200,6 +200,7 @@ struct CPUArchState { =20 #ifdef CONFIG_USER_ONLY uint32_t elf_flags; + bool dtso_ena; /* Dynamic TSO enable */ #endif =20 #ifndef CONFIG_USER_ONLY --=20 2.43.0