From nobody Tue Nov 26 15:42:25 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1706887446; cv=none; d=zohomail.com; s=zohoarc; b=SH4JE7uIo94z+PjAY4eNtv78qQgO0hk/uhbdKNiS+KkX69qQX5CIJ3Gxyag79dTIGJ3BtCdH9E5+HAa9+AxrjaaLwjkwSysC4fid8LBLZG/fq20jhdj1sqhI38lySnDK2ZGc9kP91wFy03zDBToYztub7C9wP1xxVaLwHG1CcKo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1706887446; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GoIunxXhtFCkVShty0mhpMMgPwob/3WXAOiWsujH6mU=; b=nAKV+nBqikQ4S5fDtRAR9MhY6RJ9sPTAhF7NT/S7dvlV8w5I4n7tYDXJB/XpoSC2swl5Y4gLB4H4vAC95BXztkzZSCcwdL/10AYaZGL5grQfCQSSd8lBP0lZb46uKrPb6kQZHGa1xE8GYiCUeFxCeSrint6OjG4TdqpBEwPASII= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1706887446330249.41042161983523; Fri, 2 Feb 2024 07:24:06 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rVvMu-0008Lz-Qq; Fri, 02 Feb 2024 10:22:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVvMq-0008Ks-VM for qemu-devel@nongnu.org; Fri, 02 Feb 2024 10:22:13 -0500 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rVvMo-0004UM-7M for qemu-devel@nongnu.org; Fri, 02 Feb 2024 10:22:12 -0500 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-1d746856d85so17099565ad.0 for ; Fri, 02 Feb 2024 07:22:09 -0800 (PST) Received: from grind.. ([177.94.15.159]) by smtp.gmail.com with ESMTPSA id j3-20020a170902f24300b001d714a1530bsm1734381plc.176.2024.02.02.07.22.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 07:22:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1706887327; x=1707492127; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GoIunxXhtFCkVShty0mhpMMgPwob/3WXAOiWsujH6mU=; b=irXiDKYvo+Un/lHZ1sAhXtwLTC1ORSxdDfOMjIfFYKC5oeqmkMoxcgpmagNKWOp1sP eKStE3MyX03CFmUmV1LCcdyxNt1cWyTck//os4qaBZTeUIKdeVc2V+lTwxvC4Xbvnbfb 7gU2tHd8q38+m4tSHpkdEO3G6OTSApprf3WAkWInIPm54drKbBhxluaZgW29S3eES+pZ p3C5/7M8PJ06RoKYbdNjKshCTc4JGKpgqXeG5DC/b5sPXoe1SqK40rEDKy/EM+1LOaKu H8j9+ULO054oefQe1FVTe5Rdgc3DEkXKg3qhYsHPkQEkcivcKhzFY2aI9NBd9ia31nlT rNZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706887327; x=1707492127; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GoIunxXhtFCkVShty0mhpMMgPwob/3WXAOiWsujH6mU=; b=BMPsERzmB6X744hfz2/gECF+fcnc1aWEGyeTMFQYcwmGvObUwm9fTWOhU+4oOJyMCR 53IHjVoz83l6fkZ/wHwMw0pqwHK1WtGRxm+O+93mtePnf0d2vGuFRcXnTnTG8L4O4Klz RBTBI7mYwfqg0oWMyTOrxtobtXVyGLocfXFLgba95+Yr1ECH2XjfT9af3VuvqAl0eEcC D61uOlj+SMduQut1PuyDEOxYczNPg/ECzyxD703qYIT8qpL4M75TFwG4cAAkMC0NEn1W C2nVPjZKItILt1n0Qt/o3TjVRBj3MCVGf0Fc2n0LqgVwHvjAZqwfjSFISKMjPaRAWcII 7OLQ== X-Gm-Message-State: AOJu0Yx7rLetb2nrQ6GHvwZeKhgsdKM5eogCnu+YIjaLlPGy9o/NLyE2 O6PRofchdyuSwpWovWrvoMt8+K5rLqDgY/2Je9ICDGbCYp8hMK9SBZkBVX4YjzOqmlz7L1ALx1Q z X-Google-Smtp-Source: AGHT+IEB9lQ74SMLh8kDBCsAc4ObcfHaCzVdR/O5FXFxZDiss+YnA28ie1uRuhD3PXdDWb+VCPfEuA== X-Received: by 2002:a17:902:c643:b0:1d8:ef06:12b6 with SMTP id s3-20020a170902c64300b001d8ef0612b6mr1905325pls.39.1706887327219; Fri, 02 Feb 2024 07:22:07 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWOVAJXFKEqGRsAsSjosurg/S3aud6n/tqVyY6Yp1smkhXVdn8vwI8zKJEJSF2yjorWQLfG81u0LyKdaD1513ucfCj1OOuEn+pZSQqMd6kDEreoqlibh9q5wdPBssv15tRN7pNlhVqsvJkZjlUZ5Euq5FAClrRvdGTzdOy9s3hyItsOaKbd8qT08TbBi3z/u9tKAOq2dCoZG5OPY1H45VxxBJiR6lrmhphzs3tS/gIVNPw1foaPvrggp1tIb40ONDk37Px15vXlEgCSEvQ98NwcrB3qiCiTCg== From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com, bmeng@tinylab.org, liwei1518@gmail.com, zhiwei_liu@linux.alibaba.com, palmer@rivosinc.com, ajones@ventanamicro.com, Daniel Henrique Barboza Subject: [PATCH v3 2/6] target/riscv: add riscv,isa to named features Date: Fri, 2 Feb 2024 12:21:50 -0300 Message-ID: <20240202152154.773253-3-dbarboza@ventanamicro.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240202152154.773253-1-dbarboza@ventanamicro.com> References: <20240202152154.773253-1-dbarboza@ventanamicro.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::634; envelope-from=dbarboza@ventanamicro.com; helo=mail-pl1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ventanamicro.com) X-ZM-MESSAGEID: 1706887447777100007 Content-Type: text/plain; charset="utf-8" Further discussions after the introduction of rva22 support in QEMU revealed that what we've been calling 'named features' are actually regular extensions, with their respective riscv,isa DTs. This is clarified in [1]. [2] is a bug tracker asking for the profile spec to be less cryptic about it. As far as QEMU goes we understand extensions as something that the user can enable/disable in the command line. This isn't the case for named features, so we'll have to reach a middle ground. We'll keep our existing nomenclature 'named features' to refer to any extension that the user can't control in the command line. We'll also do the following: - 'svade' and 'zic64b' flags are renamed to 'ext_svade' and 'ext_zic64b'. 'ext_svade' and 'ext_zic64b' now have riscv,isa strings and priv_spec versions; - skip name feature check in cpu_bump_multi_ext_priv_ver(). Now that named features have a riscv,isa and an entry in isa_edata_arr[] we don't need to gate the call to cpu_cfg_ext_get_min_version() anymore. [1] https://github.com/riscv/riscv-profiles/issues/121 [2] https://github.com/riscv/riscv-profiles/issues/142 Signed-off-by: Daniel Henrique Barboza Reviewed-by: Andrew Jones Reviewed-by: Alistair Francis --- target/riscv/cpu.c | 17 +++++++++++++---- target/riscv/cpu_cfg.h | 6 ++++-- target/riscv/tcg/tcg-cpu.c | 16 ++++++---------- 3 files changed, 23 insertions(+), 16 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 88e8cc8681..28d3cfa8ce 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -97,6 +97,7 @@ bool riscv_cpu_option_set(const char *optname) * instead. */ const RISCVIsaExtData isa_edata_arr[] =3D { + ISA_EXT_DATA_ENTRY(zic64b, PRIV_VERSION_1_12_0, ext_zic64b), ISA_EXT_DATA_ENTRY(zicbom, PRIV_VERSION_1_12_0, ext_zicbom), ISA_EXT_DATA_ENTRY(zicbop, PRIV_VERSION_1_12_0, ext_zicbop), ISA_EXT_DATA_ENTRY(zicboz, PRIV_VERSION_1_12_0, ext_zicboz), @@ -171,6 +172,7 @@ const RISCVIsaExtData isa_edata_arr[] =3D { ISA_EXT_DATA_ENTRY(ssaia, PRIV_VERSION_1_12_0, ext_ssaia), ISA_EXT_DATA_ENTRY(sscofpmf, PRIV_VERSION_1_12_0, ext_sscofpmf), ISA_EXT_DATA_ENTRY(sstc, PRIV_VERSION_1_12_0, ext_sstc), + ISA_EXT_DATA_ENTRY(svade, PRIV_VERSION_1_11_0, ext_svade), ISA_EXT_DATA_ENTRY(svadu, PRIV_VERSION_1_12_0, ext_svadu), ISA_EXT_DATA_ENTRY(svinval, PRIV_VERSION_1_12_0, ext_svinval), ISA_EXT_DATA_ENTRY(svnapot, PRIV_VERSION_1_12_0, ext_svnapot), @@ -1510,9 +1512,16 @@ const RISCVCPUMultiExtConfig riscv_cpu_experimental_= exts[] =3D { DEFINE_PROP_END_OF_LIST(), }; =20 +/* + * 'Named features' is the name we give to extensions that we + * don't want to expose to users. They are either immutable + * (always enabled/disable) or they'll vary depending on + * the resulting CPU state. They have riscv,isa strings + * and priv_ver like regular extensions. + */ const RISCVCPUMultiExtConfig riscv_cpu_named_features[] =3D { - MULTI_EXT_CFG_BOOL("svade", svade, true), - MULTI_EXT_CFG_BOOL("zic64b", zic64b, true), + MULTI_EXT_CFG_BOOL("svade", ext_svade, true), + MULTI_EXT_CFG_BOOL("zic64b", ext_zic64b, true), =20 DEFINE_PROP_END_OF_LIST(), }; @@ -2130,7 +2139,7 @@ static RISCVCPUProfile RVA22U64 =3D { CPU_CFG_OFFSET(ext_zicbop), CPU_CFG_OFFSET(ext_zicboz), =20 /* mandatory named features for this profile */ - CPU_CFG_OFFSET(zic64b), + CPU_CFG_OFFSET(ext_zic64b), =20 RISCV_PROFILE_EXT_LIST_END } @@ -2161,7 +2170,7 @@ static RISCVCPUProfile RVA22S64 =3D { CPU_CFG_OFFSET(ext_svinval), =20 /* rva22s64 named features */ - CPU_CFG_OFFSET(svade), + CPU_CFG_OFFSET(ext_svade), =20 RISCV_PROFILE_EXT_LIST_END } diff --git a/target/riscv/cpu_cfg.h b/target/riscv/cpu_cfg.h index e241922f89..698f926ab1 100644 --- a/target/riscv/cpu_cfg.h +++ b/target/riscv/cpu_cfg.h @@ -117,13 +117,15 @@ struct RISCVCPUConfig { bool ext_smepmp; bool rvv_ta_all_1s; bool rvv_ma_all_1s; - bool svade; - bool zic64b; =20 uint32_t mvendorid; uint64_t marchid; uint64_t mimpid; =20 + /* Named features */ + bool ext_svade; + bool ext_zic64b; + /* Vendor-specific custom extensions */ bool ext_xtheadba; bool ext_xtheadbb; diff --git a/target/riscv/tcg/tcg-cpu.c b/target/riscv/tcg/tcg-cpu.c index 88f92d1c7d..90861cc065 100644 --- a/target/riscv/tcg/tcg-cpu.c +++ b/target/riscv/tcg/tcg-cpu.c @@ -197,12 +197,12 @@ static bool cpu_cfg_offset_is_named_feat(uint32_t ext= _offset) static void riscv_cpu_enable_named_feat(RISCVCPU *cpu, uint32_t feat_offse= t) { switch (feat_offset) { - case CPU_CFG_OFFSET(zic64b): + case CPU_CFG_OFFSET(ext_zic64b): cpu->cfg.cbom_blocksize =3D 64; cpu->cfg.cbop_blocksize =3D 64; cpu->cfg.cboz_blocksize =3D 64; break; - case CPU_CFG_OFFSET(svade): + case CPU_CFG_OFFSET(ext_svade): cpu->cfg.ext_svadu =3D false; break; default: @@ -219,10 +219,6 @@ static void cpu_bump_multi_ext_priv_ver(CPURISCVState = *env, return; } =20 - if (cpu_cfg_offset_is_named_feat(ext_offset)) { - return; - } - ext_priv_ver =3D cpu_cfg_ext_get_min_version(ext_offset); =20 if (env->priv_ver < ext_priv_ver) { @@ -349,11 +345,11 @@ static void riscv_cpu_disable_priv_spec_isa_exts(RISC= VCPU *cpu) =20 static void riscv_cpu_update_named_features(RISCVCPU *cpu) { - cpu->cfg.zic64b =3D cpu->cfg.cbom_blocksize =3D=3D 64 && - cpu->cfg.cbop_blocksize =3D=3D 64 && - cpu->cfg.cboz_blocksize =3D=3D 64; + cpu->cfg.ext_zic64b =3D cpu->cfg.cbom_blocksize =3D=3D 64 && + cpu->cfg.cbop_blocksize =3D=3D 64 && + cpu->cfg.cboz_blocksize =3D=3D 64; =20 - cpu->cfg.svade =3D !cpu->cfg.ext_svadu; + cpu->cfg.ext_svade =3D !cpu->cfg.ext_svadu; } =20 static void riscv_cpu_validate_g(RISCVCPU *cpu) --=20 2.43.0