From nobody Tue Nov 26 16:18:06 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1706651570; cv=none; d=zohomail.com; s=zohoarc; b=HQ8IO8IutN5F2n/YpGlbWJ9needx8Gga15HbKGnIHvTfkBeNhJH9028qCELFdK3Wo92C/dLRBw/9Fmu/tnA+9zwiURb0UN8UM5PsJsC22BtXtQoHT4PZLv5C8rFG2rfH6Cdony7P+I4vyVKZTuy2K6fCdT46ATQN+Ghd0z+JHt0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1706651570; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=sY5gJ4RqzuSGN30tSkomCOHdnKgc43QiUnfx499MYH4=; b=Mb4/Lv65lfHuLPZ4WeMVh9JKy4SGa2+eE3gqTfcb42XOShYEKtvSePrV/WAIDWwl6qQkQPKgkcjlnnN2TAdWlIB/x4SR/H94EQIQxKXC+4AU+Em0gvoF180eCj7tHSs+SMynKNgGlqzr0tLoTDYTYj/BLiKmSYJbKZ2CfwO5cv4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 170665157015323.84237657442395; Tue, 30 Jan 2024 13:52:50 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rUw1w-0002fk-7d; Tue, 30 Jan 2024 16:52:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUw1o-0002W4-1l for qemu-devel@nongnu.org; Tue, 30 Jan 2024 16:52:24 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUw1m-0005rv-I5 for qemu-devel@nongnu.org; Tue, 30 Jan 2024 16:52:23 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-209-xoBaqtMtOeyhV5iK2V20kg-1; Tue, 30 Jan 2024 16:52:16 -0500 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F076688CDCB; Tue, 30 Jan 2024 21:51:46 +0000 (UTC) Received: from localhost (unknown [10.39.192.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5CCA2492BE5; Tue, 30 Jan 2024 21:51:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706651541; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sY5gJ4RqzuSGN30tSkomCOHdnKgc43QiUnfx499MYH4=; b=iF0PG0so/efmDZu20wX7bzDMXlFJ5oUoY+6gigorTpO08p7Wi00ifIw0geyoU0/OmAVHaD 3KKPMlGOKvQt708R+o3s+Cu8NvGUK6rPYsOX4pqR7czy5K6LSeS76F69Iebvi0IFZXH0P3 8l7qwZCqzJPhZ2gqsRGvZg5DrpXO2pc= X-MC-Unique: xoBaqtMtOeyhV5iK2V20kg-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: John Snow , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Eduardo Habkost , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aarushi Mehta , Fam Zheng , Kevin Wolf , Stefan Hajnoczi , qemu-block@nongnu.org, Julia Suvorova , Stefano Garzarella , Alistair Francis , Peter Maydell , Hanna Reitz , Manos Pitsidianakis Subject: [PULL 4/5] hw/core/qdev.c: add qdev_get_human_name() Date: Tue, 30 Jan 2024 16:51:33 -0500 Message-ID: <20240130215134.346557-5-stefanha@redhat.com> In-Reply-To: <20240130215134.346557-1-stefanha@redhat.com> References: <20240130215134.346557-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.292, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1706651571763100001 Content-Type: text/plain; charset="utf-8" From: Manos Pitsidianakis Add a simple method to return some kind of human readable identifier for use in error messages. Reviewed-by: Stefan Hajnoczi Signed-off-by: Manos Pitsidianakis Message-id: 8b566bfced98ae44be1fcc1f8e7215f0c3393aa1.1706598705.git.manos.p= itsidianakis@linaro.org Signed-off-by: Stefan Hajnoczi --- include/hw/qdev-core.h | 14 ++++++++++++++ hw/core/qdev.c | 8 ++++++++ 2 files changed, 22 insertions(+) diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index 151d968238..66338f479f 100644 --- a/include/hw/qdev-core.h +++ b/include/hw/qdev-core.h @@ -993,6 +993,20 @@ const char *qdev_fw_name(DeviceState *dev); void qdev_assert_realized_properly(void); Object *qdev_get_machine(void); =20 +/** + * qdev_get_human_name() - Return a human-readable name for a device + * @dev: The device. Must be a valid and non-NULL pointer. + * + * .. note:: + * This function is intended for user friendly error messages. + * + * Returns: A newly allocated string containing the device id if not null, + * else the object canonical path. + * + * Use g_free() to free it. + */ +char *qdev_get_human_name(DeviceState *dev); + /* FIXME: make this a link<> */ bool qdev_set_parent_bus(DeviceState *dev, BusState *bus, Error **errp); =20 diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 43d863b0c5..c68d0f7c51 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -879,6 +879,14 @@ Object *qdev_get_machine(void) return dev; } =20 +char *qdev_get_human_name(DeviceState *dev) +{ + g_assert(dev !=3D NULL); + + return dev->id ? + g_strdup(dev->id) : object_get_canonical_path(OBJECT(dev)); +} + static MachineInitPhase machine_phase; =20 bool phase_check(MachineInitPhase phase) --=20 2.43.0