From nobody Tue Nov 26 16:21:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1706651597; cv=none; d=zohomail.com; s=zohoarc; b=NXSA57HiKxNpyasmMGJIHW5jydGddgN3Ov8G+e+BsjQs1KXwbRyw+Sjl6gwJygzfU0PVxt0bqtqJKaQSLl+U5i4z7dHowoS2YnkVVxi27mzGiTQHBdRmJiO7ttVwppRylC9orDbrX5wKTwrV1Dz+Oa9649wj8UUOsB1r5jawmq4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1706651597; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5+W7J5ZBmy22p3AjnZeYt4XmdqsSkYcD3NIhzrkj5M8=; b=jNgCYJgckXY7eUT4gBBXJ0Er4tA2ur/G1qGTPhTu4QIEanXy0Cha5GaVtlcqu/WN0KL0v4k9XPd/Bzr5y/zTj/iDtTOIbMnjH5OQrRAol9k5A/ccBjI05oe/ZFgD+Sp1Z3PhdCHAQ/2RDLck6CoX3N4u6Ko5VqiKMf6OsZ5+4zc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1706651597187420.00208539526716; Tue, 30 Jan 2024 13:53:17 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rUw1H-0002CB-39; Tue, 30 Jan 2024 16:51:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUw1C-00026d-5l for qemu-devel@nongnu.org; Tue, 30 Jan 2024 16:51:46 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUw1A-0005mj-2S for qemu-devel@nongnu.org; Tue, 30 Jan 2024 16:51:45 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-655-KLHiQFW2MEGllSxLfbOtRA-1; Tue, 30 Jan 2024 16:51:39 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 48C0010135F2; Tue, 30 Jan 2024 21:51:39 +0000 (UTC) Received: from localhost (unknown [10.39.192.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9406C2166B33; Tue, 30 Jan 2024 21:51:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706651503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5+W7J5ZBmy22p3AjnZeYt4XmdqsSkYcD3NIhzrkj5M8=; b=AlF5qiIYcJ8VgepnFMyh1D4BmVowdiW+0M4ezMTB6QXDEjXHKzV1hmUpG5wQYpmRQDNPe7 wGN7ZgMm8zoioBC7cMqXIE9QhaN6YmVhNUISWbMgb8FDGd5ffgwcE95rIVFESRQz3cj4GD 4lDr/pWAE/86waji32Bju9jGR257QBo= X-MC-Unique: KLHiQFW2MEGllSxLfbOtRA-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: John Snow , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Eduardo Habkost , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aarushi Mehta , Fam Zheng , Kevin Wolf , Stefan Hajnoczi , qemu-block@nongnu.org, Julia Suvorova , Stefano Garzarella , Alistair Francis , Peter Maydell , Hanna Reitz , Fiona Ebner Subject: [PULL 1/5] block/io_uring: improve error message when init fails Date: Tue, 30 Jan 2024 16:51:30 -0500 Message-ID: <20240130215134.346557-2-stefanha@redhat.com> In-Reply-To: <20240130215134.346557-1-stefanha@redhat.com> References: <20240130215134.346557-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.292, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1706651597830100003 Content-Type: text/plain; charset="utf-8" From: Fiona Ebner The man page for io_uring_queue_init states: > io_uring_queue_init(3) returns 0 on success and -errno on failure. and the man page for io_uring_setup (which is one of the functions where the return value of io_uring_queue_init() can come from) states: > On error, a negative error code is returned. The caller should not > rely on errno variable. Tested using 'sysctl kernel.io_uring_disabled=3D2'. Output before this change: > failed to init linux io_uring ring Output after this change: > failed to init linux io_uring ring: Operation not permitted Signed-off-by: Fiona Ebner Signed-off-by: Stefan Hajnoczi Message-ID: <20240123135044.204985-1-f.ebner@proxmox.com> --- block/io_uring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/io_uring.c b/block/io_uring.c index d77ae55745..d11b2051ab 100644 --- a/block/io_uring.c +++ b/block/io_uring.c @@ -432,7 +432,7 @@ LuringState *luring_init(Error **errp) =20 rc =3D io_uring_queue_init(MAX_ENTRIES, ring, 0); if (rc < 0) { - error_setg_errno(errp, errno, "failed to init linux io_uring ring"= ); + error_setg_errno(errp, -rc, "failed to init linux io_uring ring"); g_free(s); return NULL; } --=20 2.43.0