From nobody Tue Nov 26 15:43:08 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1706534758; cv=none; d=zohomail.com; s=zohoarc; b=NpUe3NOcR+ph2VC+eJysNu0HM/9cqYDp4l7FFK/gcc97qHJKbXXeeX74zK27GputlGSw/V+59NOTpIrJos7CJ7dfV+w3dmIDi18MJFsK68EsWJpTWLTgzFw/0+C88j3XflxFGM8dVWyEAIA18eZmP9JOrOYHA74ynEI/gVBb2Rw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1706534758; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=vqcWzWPVvk67G425Dven4TaY5cdIzJsDLAkkOQm29aM=; b=ZjQeiLh3XGSaR410zVJ9Cjo28OnYSP65L8/8VaoYUAa4CUYPo/98gJK+Ibd8w4DrxreYCIyQfdcOc/NhY/oTO6egqGrUrVyZVeJtudMzyHjHX8WS+y8a8MiGhUHF+JvHiqGw3J9qRGyv/UUJfL6ayaa0tp0Tu1oownVbtlgoYJc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1706534758768610.2798008455262; Mon, 29 Jan 2024 05:25:58 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rURd4-0008Nd-4S; Mon, 29 Jan 2024 08:24:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rURd2-0008MW-6s for qemu-devel@nongnu.org; Mon, 29 Jan 2024 08:24:48 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rURcz-0004dL-Gz for qemu-devel@nongnu.org; Mon, 29 Jan 2024 08:24:47 -0500 Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-L365JoEfNBm6-C2lAaOWfA-1; Mon, 29 Jan 2024 08:24:13 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 27C7238562C0; Mon, 29 Jan 2024 13:24:13 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.39.194.130]) by smtp.corp.redhat.com (Postfix) with ESMTP id A612B488; Mon, 29 Jan 2024 13:24:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706534656; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vqcWzWPVvk67G425Dven4TaY5cdIzJsDLAkkOQm29aM=; b=KLeew1WBui8yIvMqNFfDqbd5fwUEKZx4WtNflQiS+S07sWrr8xwtJ7J7rAu4PqEAuxJ85I HeXdHFaYprizKXQouukBImpguI6rHVWTdY9jeMsktnSRF0OygrQ2PCiWUTFPfP2+W6Mhlp qRTX12hZGTNKki2RVbRyhQ43GtDSCVY= X-MC-Unique: L365JoEfNBm6-C2lAaOWfA-1 From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= To: qemu-devel@nongnu.org, mst@redhat.com Cc: si-wei.liu@oracle.com, leiyang@redhat.com, yajunw@nvidia.com, Ani Sinha , Jason Wang , dtatulea@nvidia.com, mcoqueli@redhat.com Subject: [PATCH 1/2] net: parameterize the removing client from nc list Date: Mon, 29 Jan 2024 14:24:06 +0100 Message-Id: <20240129132407.1474202-2-eperezma@redhat.com> In-Reply-To: <20240129132407.1474202-1-eperezma@redhat.com> References: <20240129132407.1474202-1-eperezma@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=eperezma@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.29, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1706534759183100001 This change is used in later commits so we can avoid the removal of the netclient if it is delayed. No functional change intended. Signed-off-by: Eugenio P=C3=A9rez Acked-by: Jason Wang Reported-by: Lei Yang Reviewed-by: Si-Wei Liu --- net/net.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/net/net.c b/net/net.c index 0520bc1681..11e19d3bed 100644 --- a/net/net.c +++ b/net/net.c @@ -375,9 +375,12 @@ NetClientState *qemu_get_peer(NetClientState *nc, int = queue_index) return ncs->peer; } =20 -static void qemu_cleanup_net_client(NetClientState *nc) +static void qemu_cleanup_net_client(NetClientState *nc, + bool remove_from_net_clients) { - QTAILQ_REMOVE(&net_clients, nc, next); + if (remove_from_net_clients) { + QTAILQ_REMOVE(&net_clients, nc, next); + } =20 if (nc->info->cleanup) { nc->info->cleanup(nc); @@ -436,14 +439,14 @@ void qemu_del_net_client(NetClientState *nc) } =20 for (i =3D 0; i < queues; i++) { - qemu_cleanup_net_client(ncs[i]); + qemu_cleanup_net_client(ncs[i], true); } =20 return; } =20 for (i =3D 0; i < queues; i++) { - qemu_cleanup_net_client(ncs[i]); + qemu_cleanup_net_client(ncs[i], true); qemu_free_net_client(ncs[i]); } } @@ -468,7 +471,7 @@ void qemu_del_nic(NICState *nic) for (i =3D queues - 1; i >=3D 0; i--) { NetClientState *nc =3D qemu_get_subqueue(nic, i); =20 - qemu_cleanup_net_client(nc); + qemu_cleanup_net_client(nc, true); qemu_free_net_client(nc); } =20 --=20 2.39.3 From nobody Tue Nov 26 15:43:08 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1706534764; cv=none; d=zohomail.com; s=zohoarc; b=JmMH/U8wW8g6xcTIKVlr/hke3VUJ699nefMOjNqspKdT1OusafUX9edtVXn9NsO5FlwPmPYjA54O1ogo0nhGHP0qWl8uyRC5cVT3nAeoBQol5fCoed4vGto6ZssqVNyIjAHDw92Db8Q+GZl/JeoNKW80q4WUNcL/X9t7WGX4d3A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1706534764; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lEY/03v+aSw42tIRGuHD6+WMpVoHm4K6M49mhh/iPpw=; b=IU9vRO8U/Ix4gsbta+ymoZkS33dO95PqLpdmnsagwj9uALRlHJ0KWyfe/WFhzwtLILfp1vUg2rTrlML1eoRIQ3yvnPEzx0v4U1bcj2RFDMlwHbSuJzGvcxaU4nsc+E8Rw21M/X09RWOf5fd/O3gz+FSJNSsDfxStMXIgpfbXzWk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1706534764676485.20704911398184; Mon, 29 Jan 2024 05:26:04 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rURdA-0008OC-D9; Mon, 29 Jan 2024 08:24:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rURd3-0008NP-CP for qemu-devel@nongnu.org; Mon, 29 Jan 2024 08:24:49 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rURcz-0004dP-Ig for qemu-devel@nongnu.org; Mon, 29 Jan 2024 08:24:49 -0500 Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-FBVqc_YOMgW6oLj1xT54Hw-1; Mon, 29 Jan 2024 08:24:15 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DA7763CBDF60; Mon, 29 Jan 2024 13:24:14 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.39.194.130]) by smtp.corp.redhat.com (Postfix) with ESMTP id 65AC1488; Mon, 29 Jan 2024 13:24:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706534656; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lEY/03v+aSw42tIRGuHD6+WMpVoHm4K6M49mhh/iPpw=; b=FPviiG/vBuZqetAseT++sDo8Qm4CTBmCTPjhJX0yLH4EuBS4cLuX+LOGb+ernLZbOO7GAl u8iDbMnl18vG3GHzwz2S2euC1vX/GWu56QFB2qlXtFq6OdhCCW92Y0B1y1sy4FYrB47ux2 8kyNeyKeObBQbMQoBLM8XVhkDnaZ350= X-MC-Unique: FBVqc_YOMgW6oLj1xT54Hw-1 From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= To: qemu-devel@nongnu.org, mst@redhat.com Cc: si-wei.liu@oracle.com, leiyang@redhat.com, yajunw@nvidia.com, Ani Sinha , Jason Wang , dtatulea@nvidia.com, mcoqueli@redhat.com Subject: [PATCH 2/2] net: move backend cleanup to NIC cleanup Date: Mon, 29 Jan 2024 14:24:07 +0100 Message-Id: <20240129132407.1474202-3-eperezma@redhat.com> In-Reply-To: <20240129132407.1474202-1-eperezma@redhat.com> References: <20240129132407.1474202-1-eperezma@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=eperezma@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.29, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1706534765144100001 Commit a0d7215e33 ("vhost-vdpa: do not cleanup the vdpa/vhost-net structures if peer nic is present") effectively delayed the backend cleanup, allowing the frontend or the guest to access it resources as long as the frontend is still visible to the guest. However it does not clean up the resources until the qemu process is over. This causes an effective leak if the device is deleted with device_del, as there is no way to close the vdpa device. This makes impossible to re-add that device to this or other QEMU instances until the first instance of QEMU is finished. Move the cleanup from qemu_cleanup to the NIC deletion. Fixes: a0d7215e33 ("vhost-vdpa: do not cleanup the vdpa/vhost-net structure= s if peer nic is present") Acked-by: Jason Wang Reported-by: Lei Yang Signed-off-by: Eugenio P=C3=A9rez Reviewed-by: Si-Wei Liu --- Carring the Acked-by Jason as it was given when I proposed this one year ago to qemu-security@nongnu.org off list, trying to solve CVE-2023-3301. --- net/net.c | 19 +++++++++++++------ net/vhost-vdpa.c | 8 -------- 2 files changed, 13 insertions(+), 14 deletions(-) diff --git a/net/net.c b/net/net.c index 11e19d3bed..fb6e130c62 100644 --- a/net/net.c +++ b/net/net.c @@ -422,7 +422,13 @@ void qemu_del_net_client(NetClientState *nc) object_unparent(OBJECT(nf)); } =20 - /* If there is a peer NIC, delete and cleanup client, but do not free.= */ + /* + * If there is a peer NIC, transfer ownership to it. Delete the client + * from net_client list but do not cleanup nor free. This way NIC can + * still access to members of the backend. + * + * The cleanup and free will be done when the NIC is free. + */ if (nc->peer && nc->peer->info->type =3D=3D NET_CLIENT_DRIVER_NIC) { NICState *nic =3D qemu_get_nic(nc->peer); if (nic->peer_deleted) { @@ -432,16 +438,13 @@ void qemu_del_net_client(NetClientState *nc) =20 for (i =3D 0; i < queues; i++) { ncs[i]->peer->link_down =3D true; + QTAILQ_REMOVE(&net_clients, ncs[i], next); } =20 if (nc->peer->info->link_status_changed) { nc->peer->info->link_status_changed(nc->peer); } =20 - for (i =3D 0; i < queues; i++) { - qemu_cleanup_net_client(ncs[i], true); - } - return; } =20 @@ -459,8 +462,12 @@ void qemu_del_nic(NICState *nic) =20 for (i =3D 0; i < queues; i++) { NetClientState *nc =3D qemu_get_subqueue(nic, i); - /* If this is a peer NIC and peer has already been deleted, free i= t now. */ + /* + * If this is a peer NIC and peer has already been deleted, clean = it up + * and free it now. + */ if (nic->peer_deleted) { + qemu_cleanup_net_client(nc->peer, false); qemu_free_net_client(nc->peer); } else if (nc->peer) { /* if there are RX packets pending, complete them */ diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index 3726ee5d67..64825136a3 100644 --- a/net/vhost-vdpa.c +++ b/net/vhost-vdpa.c @@ -221,14 +221,6 @@ static void vhost_vdpa_cleanup(NetClientState *nc) { VhostVDPAState *s =3D DO_UPCAST(VhostVDPAState, nc, nc); =20 - /* - * If a peer NIC is attached, do not cleanup anything. - * Cleanup will happen as a part of qemu_cleanup() -> net_cleanup() - * when the guest is shutting down. - */ - if (nc->peer && nc->peer->info->type =3D=3D NET_CLIENT_DRIVER_NIC) { - return; - } munmap(s->cvq_cmd_out_buffer, vhost_vdpa_net_cvq_cmd_page_len()); munmap(s->status, vhost_vdpa_net_cvq_cmd_page_len()); if (s->vhost_net) { --=20 2.39.3