From nobody Tue Nov 26 16:31:33 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1706250576; cv=none; d=zohomail.com; s=zohoarc; b=gQJSXkSgvpKEBIlM1vCN8khTnGTD70j98lm3CQTgw/MBi1NAIqRwJ7tuKhwDgkf0EBEQlYJ0TzTs2unGJLOHBg/zhIRm70RRF2TlPQDLtWAk+WaCjWvxt2gaIREldYjDuFfWRg1y7UsdFdUZ7r/DXC4hJ70WHqWje1ecXrwgqB8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1706250576; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=md68lIGdSEtX/fdjEE9hpy5ztw1WO1te9qlqHlHS1Qo=; b=Fy4vOtywhSSpG7vT4GJ5k+IM2Nhy3QGjvNlcUC1LbDp12udF1Ce5srOik+eD3qKhGUcz16+nuUWcONopGWisnE0YWMyOXjSd4iXEHOh54Z78UAagoL8Y+TKi5NxrZlnDpFEdErzRThXwl1MEucVK+yfqT/UCDdfO5SB3mvpEwEA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1706250576703682.3954829193361; Thu, 25 Jan 2024 22:29:36 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rTFh6-0005H2-Mf; Fri, 26 Jan 2024 01:28:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTFgx-0005Bo-D6 for qemu-devel@nongnu.org; Fri, 26 Jan 2024 01:27:56 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTFgt-0001lI-Fl for qemu-devel@nongnu.org; Fri, 26 Jan 2024 01:27:53 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-353-QrMdDcFgMeCCSZO3kBZ_iA-1; Fri, 26 Jan 2024 01:27:46 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EC6BC85A588; Fri, 26 Jan 2024 06:27:45 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.123]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CA12640C1430; Fri, 26 Jan 2024 06:27:45 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id B6D4C21E66F1; Fri, 26 Jan 2024 07:27:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706250470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=md68lIGdSEtX/fdjEE9hpy5ztw1WO1te9qlqHlHS1Qo=; b=GDBlId7CjZzg4SR/HLv9oTlbSImVPIMBMZ5GDDAqieEnWSeV9fQxfgD4Kw8FjqD8RwZjJQ FYkv3pXpPTmlMhwiDp/zew1+Mt4grqMBq9M+J+HMnojlleokyaakDuRiLsv9bJAJDm0Drf f7C+MvjRUJfHit439j8TqbrUpkVafX0= X-MC-Unique: QrMdDcFgMeCCSZO3kBZ_iA-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Eric Blake Subject: [PULL 1/8] docs/devel/qapi-code-gen: Don't reserve types ending with 'Kind' Date: Fri, 26 Jan 2024 07:27:37 +0100 Message-ID: <20240126062744.265588-2-armbru@redhat.com> In-Reply-To: <20240126062744.265588-1-armbru@redhat.com> References: <20240126062744.265588-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.5, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1706250578311100009 Content-Type: text/plain; charset="utf-8" We reserved type names ending with 'Kind' because a simple union 'SomeSimpleUnion' generated both a struct type SomeSimpleUnion and an enum type SomeSimpleUnionKind. Gone since commit 4e99f4b12c0 (qapi: Drop simple unions). The commit neglected to update the documentation not to reserve type names ending with 'Kind'. Do that now. Signed-off-by: Markus Armbruster Message-ID: <20231221145727.835905-1-armbru@redhat.com> Reviewed-by: Eric Blake --- docs/devel/qapi-code-gen.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/devel/qapi-code-gen.rst b/docs/devel/qapi-code-gen.rst index ea8228518c..0c6f4201bc 100644 --- a/docs/devel/qapi-code-gen.rst +++ b/docs/devel/qapi-code-gen.rst @@ -737,9 +737,8 @@ Types, commands, and events share a common namespace. = Therefore, generally speaking, type definitions should always use CamelCase for user-defined type names, while built-in types are lowercase. =20 -Type names ending with ``Kind`` or ``List`` are reserved for the -generator, which uses them for implicit union enums and array types, -respectively. +Type names ending with ``List`` are reserved for the generator, which +uses them for array types. =20 Command names, member names within a type, and feature names should be all lower case with words separated by a hyphen. However, some --=20 2.43.0