From nobody Thu Nov 14 07:06:17 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1705587070; cv=none; d=zohomail.com; s=zohoarc; b=NGbNlQEdx3i4LXcs2HcvrL/OjaFmn4BEaOD5NyITMDnJMA4BwueSB+rBaBV7mgZmhLM/zwFjkz1AfT60t54K108iHKbY9oTek/7ytBWWH3a2a7lxI71ATUEzEWmD802YNdIiFUxvLOrnmETwyRg0AwHcZVSMFJDZVlj3s1yYl6k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1705587070; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=cfcfiBdpXmXsTWV/H5LO5HZvuIqA57o3t6QktI+ixng=; b=W3KZfyQZxYgZVFyUZiSOrA9Y7CaHV43OH4yolgm2xy+JwwhugxKOBzZZXdYy8Y881Bu/zMh6e3u1ozuJJbYkW7a//5s69s3he3zDwR1OWQiEwQQQSlWNOLHWwi8b02ewkuL08OIMJS7CXTseXJbmRq4/zTNsNJFQ2KFFnYWspNk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1705587070549564.7517811112015; Thu, 18 Jan 2024 06:11:10 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQT6A-00057d-Vk; Thu, 18 Jan 2024 09:10:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQT68-00056G-Jf; Thu, 18 Jan 2024 09:10:24 -0500 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rQT64-0000tW-21; Thu, 18 Jan 2024 09:10:24 -0500 Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-6da202aa138so8964700b3a.2; Thu, 18 Jan 2024 06:10:19 -0800 (PST) Received: from wheely.local0.net (124-171-76-150.tpgi.com.au. [124.171.76.150]) by smtp.gmail.com with ESMTPSA id l18-20020a62be12000000b006db3149eacasm3323336pff.104.2024.01.18.06.10.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 06:10:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705587018; x=1706191818; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cfcfiBdpXmXsTWV/H5LO5HZvuIqA57o3t6QktI+ixng=; b=E22CQ0UGcdY3xUblsKmnHQkzj9K9KbTx5t9We65gvrddx9FoY4S2Jv/0LxL/RyirI8 gS5UnpTbsUin72h3YvLoRC15REOka8XvWPlQqYGcDPqFn6v/YDfmVb6uaasm28jgNMDJ HvrL0E/13Y3NkpmF6bXI9o6n8Fj4ap3pJwK0YeevnEFWAU1H+h64vIJnHhV8fsF1Qnme 73kE244+oMdQkLJaKWbsZVCM285PaB6HPlRR11yXkvxhvNvs41wUr79EpbNXXuibETD1 DuJgXYp207YaQ6iRajU12yQl2Mv+jsoniDWdkvTTvD2rRJ71f9/mdrO3ciNc5vtfbcy3 n6nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705587018; x=1706191818; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cfcfiBdpXmXsTWV/H5LO5HZvuIqA57o3t6QktI+ixng=; b=Y2pbR+hz8I0MRrniuTwC2fTJmhIOYFUn9X2Je3CWOp9vVaaif6IoNa0W5KOWQ3BuTr +W/y4jpIRjNKOhA5y4pBtw4rkNLwRg639vEHyr2Hygy4YBKbE+dtgZyodp9BmOhx3Wkf qHSt3fnaBUyP+j6JVHZ/LhR2vRAufoglZPO5KM6xdl3d/MI7/pG53EAS1grp2UdxjDqJ /I2/tzHJSXAZkGiTmlK/CBvpkaOg+QCsZKLQt15PBByG7JiPt4Lm+xs5Om7Mf5e+I6vC pRBfsqxwf0FB845WDFq9aABfkothJP11rp7qD4u/NzanImsA8peNHeu0FV++tZE+5KIX Af+A== X-Gm-Message-State: AOJu0YxWCK34O5UTaITaPsK/rGI+rtt1aiiUJZpC93Dq8CQpR8xQW55E MPL/+F4EypDajEQz0wrJ8QpBssslQc2uy0w7UxvKSoaMFXpaOZwvkc/yBH5F X-Google-Smtp-Source: AGHT+IH4gQVvdAw2Ay24azHrr+8z6IVRLRjld5q+7vhBEF2xyCCdv+ipPUlv+Zdxl37pfD0wrg9ajA== X-Received: by 2002:a05:6a00:3a06:b0:6da:dbd9:1742 with SMTP id fj6-20020a056a003a0600b006dadbd91742mr938192pfb.57.1705587017765; Thu, 18 Jan 2024 06:10:17 -0800 (PST) From: Nicholas Piggin To: qemu-ppc@nongnu.org Cc: Nicholas Piggin , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Barrat?= , Daniel Henrique Barboza , David Gibson , Harsh Prateek Bora , qemu-devel@nongnu.org Subject: [PATCH 3/8] ppc/spapr: Remove copy-paste from pa-features under TCG Date: Fri, 19 Jan 2024 00:09:37 +1000 Message-ID: <20240118140942.164319-4-npiggin@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20240118140942.164319-1-npiggin@gmail.com> References: <20240118140942.164319-1-npiggin@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::434; envelope-from=npiggin@gmail.com; helo=mail-pf1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1705587072792100008 Content-Type: text/plain; charset="utf-8" TCG does not support copy/paste instructions. Remove it from ibm,pa-features when running TCG. Similarly to SAO, there is a migration issue here, but this doesn't really make things worse, a cap would be required to fix it. Signed-off-by: Nicholas Piggin --- hw/ppc/spapr.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 1c79d5670d..ce969be770 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -299,6 +299,18 @@ static void spapr_dt_pa_features(SpaprMachineState *sp= apr, pa_features[4 + 2] &=3D ~0x80; } =20 + if (tcg_enabled()) { + /* + * TCG does not implement copy/paste instructions. This causes a + * migration issue similarly to SAO, but there is no avoiding that + * since there is no KVM cap or way to disable the instructions in + * hardware. It's also quite an obscure instruction and is not rea= lly + * used in KVM guests since KVM does not support accelerator pass- + * through anyway. + */ + pa_features[38 + 2] &=3D ~0x80; + } + if (ppc_hash64_has(cpu, PPC_HASH64_CI_LARGEPAGE)) { /* * Note: we keep CI large pages off by default because a 64K capab= le --=20 2.42.0