From nobody Sat Sep 21 03:01:18 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1705587187; cv=none; d=zohomail.com; s=zohoarc; b=PpsLvQ5PTilmvETPJ6dB18lbB+VrxIUIe1uiyBusWHpss0u0IibGXjTL/hwaau9BsCmDFoi3/xMzvp0ou648/f0GP6DkBaFAUTc4YpVBOMvBlOL/V5JDc0b+Boimb6PuzsdLSczbsp0jkDcmejYJPlB/7frg/Ar/XFu2y4+Br4c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1705587187; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=nhpTemOWW0eKHDpq5+DOtRyqlGrRk4XHyHUl6XdyOQg=; b=Tgs8eehO8YHiMpyMaWX+DimHk5nNXJlnnKW89SXcuU5LC4qCfJPySd9IGyN1ftNKr0hCBasE79QJS1tLk0tV2OHX6GRRcXamVdQFPMzeABLp/9LYesYsg+l6qngAHU0dR/eIyRL/UeKsX9B7jRe7OnJ4YP0BltJfL7xaBlBda/w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 170558718753123.93385442406418; Thu, 18 Jan 2024 06:13:07 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQT64-0004zr-7D; Thu, 18 Jan 2024 09:10:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQT60-0004w4-Ho; Thu, 18 Jan 2024 09:10:16 -0500 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rQT5x-0000sM-DC; Thu, 18 Jan 2024 09:10:16 -0500 Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-6daf9d5f111so10063497b3a.0; Thu, 18 Jan 2024 06:10:10 -0800 (PST) Received: from wheely.local0.net (124-171-76-150.tpgi.com.au. [124.171.76.150]) by smtp.gmail.com with ESMTPSA id l18-20020a62be12000000b006db3149eacasm3323336pff.104.2024.01.18.06.10.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 06:10:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705587009; x=1706191809; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nhpTemOWW0eKHDpq5+DOtRyqlGrRk4XHyHUl6XdyOQg=; b=QuBI/6bMHEQK5zDytw3GG0YM98WmxM8JrOmZ5efVWXrPSSiMewRZy4JkITqRlWTKfz gGzR4g72s/e3YTtmk5Gu5SPkIQWkFo6YK2/8I/irAo2F0Ey5sTxpmJPIiDdh+FsHarsE IUvBoroc43dHpMELXiOiGDiokRjeSrAREDGsVko6+UO5GBx/4D9PmcvWkyJ5G4kf2PJg TCWmFx2u7Xn3VigIPLC+Pyt3aZ/jaMag8qyRgCbm7ZWSKBX1MlPOPAv/I9LLUIukOrAu tjQSNoH0V2lIakBovplJMxuOMQoHKsd6KSi7hPY7xZNgxDwUB8y4D/389+Bdbqt321CG HehA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705587009; x=1706191809; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nhpTemOWW0eKHDpq5+DOtRyqlGrRk4XHyHUl6XdyOQg=; b=UXaaz/AwKXZENmgfV7KPumWXP3mkZokhiLwRHWKxfOguzPXa2g8gVGV13gxdRaQwaY 5Ad4VRG2fjx8b3PwOI0/doOviZqa0Ulxi04Fw416eFKHNaQrgvlSVlPPhwG4MTbcyKu/ YE8ZlZ0GD99M3iWrniyebpb417xF2fjI6PTZTZSfiZfe3BCGsjCn3oBegpYTC2x2Z7m7 i4+9jW/HF4r4oPDywq3Fu6F+N3RBG2VjX4AiCaZy2w96SZphS7P5r02Zou2YtxQMiqzs vx4pJu6fRSkWouL3mjE+G8TA1GS+VGXTzrLxxAggXGhfzGZn+GsiqF8hUCrLEzaP9MKm l90A== X-Gm-Message-State: AOJu0Yy6loH/ugvoa/BXuDRmaG4eZwtG9sKxOLTx9c/B/qBfDbHLCGcc FBUJaA9lpaA7c0K/PB9DDmySdh/uwdRR76cty/2bW1S81BkiNwy3A39W60s3 X-Google-Smtp-Source: AGHT+IGqkm8TEsTCatBIJ00Pm71wtHkVQVuS4duKAcUbqmzGpJ0hOE/Ep/h8seQlGRv5MJk/0KMNOA== X-Received: by 2002:a05:6a21:999b:b0:19a:fd2b:5a75 with SMTP id ve27-20020a056a21999b00b0019afd2b5a75mr942555pzb.3.1705587009490; Thu, 18 Jan 2024 06:10:09 -0800 (PST) From: Nicholas Piggin To: qemu-ppc@nongnu.org Cc: Nicholas Piggin , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Barrat?= , Daniel Henrique Barboza , David Gibson , Harsh Prateek Bora , qemu-devel@nongnu.org Subject: [PATCH 1/8] target/ppc: POWER10 does not have transactional memory Date: Fri, 19 Jan 2024 00:09:35 +1000 Message-ID: <20240118140942.164319-2-npiggin@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20240118140942.164319-1-npiggin@gmail.com> References: <20240118140942.164319-1-npiggin@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::429; envelope-from=npiggin@gmail.com; helo=mail-pf1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1705587187885100001 Content-Type: text/plain; charset="utf-8" POWER10 hardware implements a degenerate transactional memory facility in POWER8/9 PCR compatibility modes to permit migration from older CPUs, but POWER10 / ISA v3.1 mode does not support it so the CPU model should not support it. Signed-off-by: Nicholas Piggin --- target/ppc/cpu_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c index 9df606d523..5c1d0adca8 100644 --- a/target/ppc/cpu_init.c +++ b/target/ppc/cpu_init.c @@ -6576,7 +6576,7 @@ POWERPC_FAMILY(POWER10)(ObjectClass *oc, void *data) PPC2_FP_TST_ISA206 | PPC2_BCTAR_ISA207 | PPC2_LSQ_ISA207 | PPC2_ALTIVEC_207 | PPC2_ISA205 | PPC2_ISA207S | PPC2_FP_CVT_S64 | - PPC2_TM | PPC2_ISA300 | PPC2_PRCNTL | PPC2_ISA310 | + PPC2_ISA300 | PPC2_PRCNTL | PPC2_ISA310 | PPC2_MEM_LWSYNC | PPC2_BCDA_ISA206; pcc->msr_mask =3D (1ull << MSR_SF) | (1ull << MSR_HV) | @@ -6620,7 +6620,7 @@ POWERPC_FAMILY(POWER10)(ObjectClass *oc, void *data) pcc->flags =3D POWERPC_FLAG_VRE | POWERPC_FLAG_SE | POWERPC_FLAG_BE | POWERPC_FLAG_PMM | POWERPC_FLAG_BUS_CLK | POWERPC_FLAG_CFAR | - POWERPC_FLAG_VSX | POWERPC_FLAG_TM | POWERPC_FLAG_SCV; + POWERPC_FLAG_VSX | POWERPC_FLAG_SCV; pcc->l1_dcache_size =3D 0x8000; pcc->l1_icache_size =3D 0x8000; } --=20 2.42.0 From nobody Sat Sep 21 03:01:18 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1705587146; cv=none; d=zohomail.com; s=zohoarc; b=hLraT7PcflSYq2FNxRP8R07U4ktEdcaVdTA5q9XXd1ojnj6jhliTLFui9C0Bu4uIivAieSlxPYaUe7CTn1M4pZmH74QzIqv6dPZGuxMEs7Z7UV2SHHffQup/y/4Miao6QnqXfiBQvx+kCaf77KOCykzs+iT/4LY3aaKOWM8274E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1705587146; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=eMGW3NgZceQQATl9VA8EF7mRTSS5hHP8Vew+qm1IcAQ=; b=F0l8L5UhrCGQXhDIyFdzfx8/4Voq04m/fgFgiDms5gL3ZZaG/AsYXk/X6F/CVrNxlK/DH5kIwtkXRh+woi7X9ZXIAUQYaqUq/nPyCQUPeQF6b8ElmjRlKOPrly3bR7mNksj6rgQKA9g3Gx9k7THWf6STzOowyEAf8W1VHm8aTdY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1705587146864397.8056806897472; Thu, 18 Jan 2024 06:12:26 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQT64-00053Z-RL; Thu, 18 Jan 2024 09:10:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQT62-0004wu-1V; Thu, 18 Jan 2024 09:10:18 -0500 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rQT60-0000t5-6j; Thu, 18 Jan 2024 09:10:17 -0500 Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-6d9bba6d773so10413787b3a.1; Thu, 18 Jan 2024 06:10:15 -0800 (PST) Received: from wheely.local0.net (124-171-76-150.tpgi.com.au. [124.171.76.150]) by smtp.gmail.com with ESMTPSA id l18-20020a62be12000000b006db3149eacasm3323336pff.104.2024.01.18.06.10.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 06:10:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705587014; x=1706191814; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eMGW3NgZceQQATl9VA8EF7mRTSS5hHP8Vew+qm1IcAQ=; b=T0nOEj3rrZs9pjjrOKViIP8AS2ORBlHdebawKtr0CpZ7IbJ2kQyPDQXzAv5CX+P8Zg +pMd+lerIEF+3DtN22Vdr+mljc3TWdU/ZdoNtydxYK4bRlgmn8YBLk7cq0V65czf4JzZ s3KL59ZS6iJRut2Are36Iq4wEoJoX4gTkkGvjIV2JSt07e49HgwLAbRHmeMg0CcodqPB hGcpMEw4h+5K80WKgtvg7F6YrP78QgqqVMVGnZfmjek2iwCnXiEs692sjOS/RkS7F1QW 0wnhJIyclWKEOZlr2Lg0WdseSv79YYwzR76mz4B0yiReOVO6K10mxY/RI32cogCimYKm Pm5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705587014; x=1706191814; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eMGW3NgZceQQATl9VA8EF7mRTSS5hHP8Vew+qm1IcAQ=; b=T6UToQ6mcypilP6VD234DIQZLL8wo6fRopUlcS+vbgNGsfBkL3813vmdZXByP0sblh 9WcmSgJZoCm4N468AG350Ok2sPcwD1F1KKufcifWlss30YfpekF3Uov/NbuIixYVuHNT Rl4bTT+Ixr/feyZgPiX9cAsgAYvd5xnct4a/K3fXJjsbJchpkId8WsNVbdkHjaeYBtGI pcb6SNRlVWXz1NO5UNfqjYCryjrtuOUGE0HswyDqUB13kMyk9sI7NvWhVX55nYgqKqby SdXutHkreRocyvAnVwCS3yJKsJ8xGjvJqoW2ZPb0BSnmDT0VWXrBwPNJ/NB1Vh6rb/b3 4dnQ== X-Gm-Message-State: AOJu0YyQuHZvbaXX4R8MpTEa8Wcc+xfl9wRRH8sNatck3B92ALyzYMnk L+sjKTWd5JYS1wg90j55D2CeTfIWh6jKVYDtZ8fVi2O2GpqBMq5/vOi8Sro6 X-Google-Smtp-Source: AGHT+IG/BiiCIb2a0kZiDBwwbGju6ONBdx+cpVOcxg3aUNV/M3kyrF9NT0LN6y9kvznr5FJ0urXZ8Q== X-Received: by 2002:a05:6a00:4648:b0:6d9:af31:293b with SMTP id kp8-20020a056a00464800b006d9af31293bmr750153pfb.61.1705587013748; Thu, 18 Jan 2024 06:10:13 -0800 (PST) From: Nicholas Piggin To: qemu-ppc@nongnu.org Cc: Nicholas Piggin , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Barrat?= , Daniel Henrique Barboza , David Gibson , Harsh Prateek Bora , qemu-devel@nongnu.org Subject: [PATCH 2/8] ppc/spapr|pnv: Remove SAO from pa-features when running MTTCG Date: Fri, 19 Jan 2024 00:09:36 +1000 Message-ID: <20240118140942.164319-3-npiggin@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20240118140942.164319-1-npiggin@gmail.com> References: <20240118140942.164319-1-npiggin@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42f; envelope-from=npiggin@gmail.com; helo=mail-pf1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1705587147753100005 Content-Type: text/plain; charset="utf-8" SAO is a page table attribute that strengthens the memory ordering of accesses. QEMU with MTTCG does not implement this, so clear it in ibm,pa-features. There is a complication with spapr migration that is addressed with comments, it is not a new problem here. Signed-off-by: Nicholas Piggin --- hw/ppc/pnv.c | 5 +++++ hw/ppc/spapr.c | 15 +++++++++++++++ 2 files changed, 20 insertions(+) diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index b949398689..4969fbdb05 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -158,6 +158,11 @@ static void pnv_dt_core(PnvChip *chip, PnvCore *pc, vo= id *fdt) char *nodename; int cpus_offset =3D get_cpus_node(fdt); =20 + if (qemu_tcg_mttcg_enabled()) { + /* SSO (SAO) ordering is not supported under MTTCG. */ + pa_features[4 + 2] &=3D ~0x80; + } + nodename =3D g_strdup_printf("%s@%x", dc->fw_name, pc->pir); offset =3D fdt_add_subnode(fdt, cpus_offset, nodename); _FDT(offset); diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 021b1a00e1..1c79d5670d 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -284,6 +284,21 @@ static void spapr_dt_pa_features(SpaprMachineState *sp= apr, return; } =20 + if (qemu_tcg_mttcg_enabled()) { + /* + * SSO (SAO) ordering is not supported under MTTCG, so disable it. + * There is no cap for this, so there is a migration bug here. + * However don't disable it entirely, to allow it to be used under + * KVM. This is a minor concern because: + * - SAO is an obscure an rarely (if ever) used feature. + * - SAO is removed from POWER10 / v3.1, so there is already a + * migration problem today. + * - Linux does not test this pa-features bit today anyway, so it's + * academic. + */ + pa_features[4 + 2] &=3D ~0x80; + } + if (ppc_hash64_has(cpu, PPC_HASH64_CI_LARGEPAGE)) { /* * Note: we keep CI large pages off by default because a 64K capab= le --=20 2.42.0 From nobody Sat Sep 21 03:01:18 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1705587070; cv=none; d=zohomail.com; s=zohoarc; b=NGbNlQEdx3i4LXcs2HcvrL/OjaFmn4BEaOD5NyITMDnJMA4BwueSB+rBaBV7mgZmhLM/zwFjkz1AfT60t54K108iHKbY9oTek/7ytBWWH3a2a7lxI71ATUEzEWmD802YNdIiFUxvLOrnmETwyRg0AwHcZVSMFJDZVlj3s1yYl6k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1705587070; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=cfcfiBdpXmXsTWV/H5LO5HZvuIqA57o3t6QktI+ixng=; b=W3KZfyQZxYgZVFyUZiSOrA9Y7CaHV43OH4yolgm2xy+JwwhugxKOBzZZXdYy8Y881Bu/zMh6e3u1ozuJJbYkW7a//5s69s3he3zDwR1OWQiEwQQQSlWNOLHWwi8b02ewkuL08OIMJS7CXTseXJbmRq4/zTNsNJFQ2KFFnYWspNk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1705587070549564.7517811112015; Thu, 18 Jan 2024 06:11:10 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQT6A-00057d-Vk; Thu, 18 Jan 2024 09:10:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQT68-00056G-Jf; Thu, 18 Jan 2024 09:10:24 -0500 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rQT64-0000tW-21; Thu, 18 Jan 2024 09:10:24 -0500 Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-6da202aa138so8964700b3a.2; Thu, 18 Jan 2024 06:10:19 -0800 (PST) Received: from wheely.local0.net (124-171-76-150.tpgi.com.au. [124.171.76.150]) by smtp.gmail.com with ESMTPSA id l18-20020a62be12000000b006db3149eacasm3323336pff.104.2024.01.18.06.10.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 06:10:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705587018; x=1706191818; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cfcfiBdpXmXsTWV/H5LO5HZvuIqA57o3t6QktI+ixng=; b=E22CQ0UGcdY3xUblsKmnHQkzj9K9KbTx5t9We65gvrddx9FoY4S2Jv/0LxL/RyirI8 gS5UnpTbsUin72h3YvLoRC15REOka8XvWPlQqYGcDPqFn6v/YDfmVb6uaasm28jgNMDJ HvrL0E/13Y3NkpmF6bXI9o6n8Fj4ap3pJwK0YeevnEFWAU1H+h64vIJnHhV8fsF1Qnme 73kE244+oMdQkLJaKWbsZVCM285PaB6HPlRR11yXkvxhvNvs41wUr79EpbNXXuibETD1 DuJgXYp207YaQ6iRajU12yQl2Mv+jsoniDWdkvTTvD2rRJ71f9/mdrO3ciNc5vtfbcy3 n6nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705587018; x=1706191818; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cfcfiBdpXmXsTWV/H5LO5HZvuIqA57o3t6QktI+ixng=; b=Y2pbR+hz8I0MRrniuTwC2fTJmhIOYFUn9X2Je3CWOp9vVaaif6IoNa0W5KOWQ3BuTr +W/y4jpIRjNKOhA5y4pBtw4rkNLwRg639vEHyr2Hygy4YBKbE+dtgZyodp9BmOhx3Wkf qHSt3fnaBUyP+j6JVHZ/LhR2vRAufoglZPO5KM6xdl3d/MI7/pG53EAS1grp2UdxjDqJ /I2/tzHJSXAZkGiTmlK/CBvpkaOg+QCsZKLQt15PBByG7JiPt4Lm+xs5Om7Mf5e+I6vC pRBfsqxwf0FB845WDFq9aABfkothJP11rp7qD4u/NzanImsA8peNHeu0FV++tZE+5KIX Af+A== X-Gm-Message-State: AOJu0YxWCK34O5UTaITaPsK/rGI+rtt1aiiUJZpC93Dq8CQpR8xQW55E MPL/+F4EypDajEQz0wrJ8QpBssslQc2uy0w7UxvKSoaMFXpaOZwvkc/yBH5F X-Google-Smtp-Source: AGHT+IH4gQVvdAw2Ay24azHrr+8z6IVRLRjld5q+7vhBEF2xyCCdv+ipPUlv+Zdxl37pfD0wrg9ajA== X-Received: by 2002:a05:6a00:3a06:b0:6da:dbd9:1742 with SMTP id fj6-20020a056a003a0600b006dadbd91742mr938192pfb.57.1705587017765; Thu, 18 Jan 2024 06:10:17 -0800 (PST) From: Nicholas Piggin To: qemu-ppc@nongnu.org Cc: Nicholas Piggin , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Barrat?= , Daniel Henrique Barboza , David Gibson , Harsh Prateek Bora , qemu-devel@nongnu.org Subject: [PATCH 3/8] ppc/spapr: Remove copy-paste from pa-features under TCG Date: Fri, 19 Jan 2024 00:09:37 +1000 Message-ID: <20240118140942.164319-4-npiggin@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20240118140942.164319-1-npiggin@gmail.com> References: <20240118140942.164319-1-npiggin@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::434; envelope-from=npiggin@gmail.com; helo=mail-pf1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1705587072792100008 Content-Type: text/plain; charset="utf-8" TCG does not support copy/paste instructions. Remove it from ibm,pa-features when running TCG. Similarly to SAO, there is a migration issue here, but this doesn't really make things worse, a cap would be required to fix it. Signed-off-by: Nicholas Piggin --- hw/ppc/spapr.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 1c79d5670d..ce969be770 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -299,6 +299,18 @@ static void spapr_dt_pa_features(SpaprMachineState *sp= apr, pa_features[4 + 2] &=3D ~0x80; } =20 + if (tcg_enabled()) { + /* + * TCG does not implement copy/paste instructions. This causes a + * migration issue similarly to SAO, but there is no avoiding that + * since there is no KVM cap or way to disable the instructions in + * hardware. It's also quite an obscure instruction and is not rea= lly + * used in KVM guests since KVM does not support accelerator pass- + * through anyway. + */ + pa_features[38 + 2] &=3D ~0x80; + } + if (ppc_hash64_has(cpu, PPC_HASH64_CI_LARGEPAGE)) { /* * Note: we keep CI large pages off by default because a 64K capab= le --=20 2.42.0 From nobody Sat Sep 21 03:01:18 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1705587159; cv=none; d=zohomail.com; s=zohoarc; b=EnvKNS3ITlDa1snlBOpPQrUlxtXyI36pp4z7H7vvljj1B43QFHzjj+GljOWtIyUao1bxSgVa0QumiELQnkQKiAOsjVkctxu73rWKu0HWbPtexxv1vBcmGpP23NriTmBVpDo8ai5Hm7iU0F/93fJ6zt00SLKcHPB+txmGNHYEkmc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1705587159; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Vzpd9gv/kIdWlDpyR0UgDjKHHsa/fTE6O8y5VckY0X4=; b=QnIV1RvTKbXWkAg+yYzz0RRINw9+AurZXX3prUp2YduOQ3wETVaHwx0OihkugtDICVYZQjyXg7z8xjfab4qAZvxIK9/o7XlueMNXrLVsuU73nil279fTq61uogyGo+vCusCE63uPyQKGvz4KsT8RuMxnDoaZX78XkTOJhs5O+5k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1705587159666801.6523764966024; Thu, 18 Jan 2024 06:12:39 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQT6D-00058h-Bv; Thu, 18 Jan 2024 09:10:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQT6B-00057j-DA; Thu, 18 Jan 2024 09:10:27 -0500 Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rQT69-0000u8-54; Thu, 18 Jan 2024 09:10:27 -0500 Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-6da4a923b1bso6770747b3a.2; Thu, 18 Jan 2024 06:10:24 -0800 (PST) Received: from wheely.local0.net (124-171-76-150.tpgi.com.au. [124.171.76.150]) by smtp.gmail.com with ESMTPSA id l18-20020a62be12000000b006db3149eacasm3323336pff.104.2024.01.18.06.10.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 06:10:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705587023; x=1706191823; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Vzpd9gv/kIdWlDpyR0UgDjKHHsa/fTE6O8y5VckY0X4=; b=H0gWoTYwhMaSnn1C/kUEO2nScUsMuaCeEpBAUiuf+3zzaqdbnedLq80bBBWSgV3PS8 0IpFyzseLgxXDNArfEZuKRlmHxR8IZWLENOoVHRt+RfYBC5gXKng4hPCaJ0GeqyoqvD3 plQ2R88xvqK654g37MHjNp8w4EEEFK4cyE2SefsDZEXC+JlW3Mp4lEQSt4TMJ2AAeytd 8Td1CT+eIZ/txHHEQjBFXyqX/2mYXDEevH2qBnIMznyntsrxzP6fX8a6lpf1fs23tpqZ OGIlVw6ith3U5CbAe5CmUGkTpMPptChAu/+UPlrqKAvaf1rLhbBlUCvVyZ99HCbag7ha fgNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705587023; x=1706191823; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Vzpd9gv/kIdWlDpyR0UgDjKHHsa/fTE6O8y5VckY0X4=; b=GpQJhxOuBIP9ARRYBenRjWhl4SWZKd2Wv9cb8Oj/+eDo6nrlnGOaFhjIx57cHReCe1 Du3jj5jSZe1jSf5B+MrgViKf9juD1to+1/3sATJsXDqchjrP4b5FPOJkdY48XyMCSX4S moSKMhKspDb7MeNl/aX+RziKqbHehDQFLX2SnTH/EzlYJmkmj91vQX+pWP4KFzYJjx8L 3RX+oIbwt+6IaF0U+5hO+UqM/+HBIntwunEF13NbUqW5l2dls5MAzRhvCaEUOpN8elNl Mx566Xi2sRs9FyDdNgeLMJEisM6zZDv52dNF/ojHQNbPV89AJLgH1FX+aL3IWcSzMD0x KRNg== X-Gm-Message-State: AOJu0YxuJCi5dm1t+WwQ+EhyfUPfAMTYbq785OthCXuJ165aj6kEv9Mp Hi2GKTnPUQ0b+nGlpCpL43owtpgIocxIXnDpH9SfbXfHrSsM772IUA7YZsCv X-Google-Smtp-Source: AGHT+IHV00uMGJoAmoYa50eJouruBXTCymZDG15r2WAImchsC1uGTM2CJA/0D3A/NqEtXn1G24iO0g== X-Received: by 2002:a05:6a00:194a:b0:6d9:b293:115c with SMTP id s10-20020a056a00194a00b006d9b293115cmr968738pfk.11.1705587021849; Thu, 18 Jan 2024 06:10:21 -0800 (PST) From: Nicholas Piggin To: qemu-ppc@nongnu.org Cc: Nicholas Piggin , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Barrat?= , Daniel Henrique Barboza , David Gibson , Harsh Prateek Bora , qemu-devel@nongnu.org Subject: [PATCH 4/8] ppc/spapr: Adjust ibm,pa-features for POWER9 Date: Fri, 19 Jan 2024 00:09:38 +1000 Message-ID: <20240118140942.164319-5-npiggin@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20240118140942.164319-1-npiggin@gmail.com> References: <20240118140942.164319-1-npiggin@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::430; envelope-from=npiggin@gmail.com; helo=mail-pf1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1705587162041100003 Content-Type: text/plain; charset="utf-8" "MMR" and "SPR SO" are not implemented in POWER9, so clear those bits. HTM is not set by default, and only later if the cap is set, so remove the comment that suggests otherwise. Signed-off-by: Nicholas Piggin --- hw/ppc/spapr.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index ce969be770..1e1946de59 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -248,14 +248,14 @@ static void spapr_dt_pa_features(SpaprMachineState *s= papr, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, /* 6 - 11 */ /* 16: Vector */ 0x00, 0x00, 0x00, 0x00, 0x80, 0x00, /* 12 - 17 */ - /* 18: Vec. Scalar, 20: Vec. XOR, 22: HTM */ + /* 18: Vec. Scalar, 20: Vec. XOR */ 0x80, 0x00, 0x80, 0x00, 0x00, 0x00, /* 18 - 23 */ /* 24: Ext. Dec, 26: 64 bit ftrs, 28: PM ftrs */ 0x80, 0x00, 0x80, 0x00, 0x80, 0x00, /* 24 - 29 */ - /* 30: MMR, 32: LE atomic, 34: EBB + ext EBB */ - 0x80, 0x00, 0x80, 0x00, 0xC0, 0x00, /* 30 - 35 */ - /* 36: SPR SO, 38: Copy/Paste, 40: Radix MMU */ - 0x80, 0x00, 0x80, 0x00, 0x80, 0x00, /* 36 - 41 */ + /* 32: LE atomic, 34: EBB + ext EBB */ + 0x00, 0x00, 0x80, 0x00, 0xC0, 0x00, /* 30 - 35 */ + /* 38: Copy/Paste, 40: Radix MMU */ + 0x00, 0x00, 0x80, 0x00, 0x80, 0x00, /* 36 - 41 */ /* 42: PM, 44: PC RA, 46: SC vec'd */ 0x80, 0x00, 0x80, 0x00, 0x80, 0x00, /* 42 - 47 */ /* 48: SIMD, 50: QP BFP, 52: String */ --=20 2.42.0 From nobody Sat Sep 21 03:01:18 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1705587070; cv=none; d=zohomail.com; s=zohoarc; b=B7n7Dgzhnc5X2NF4chZneCmzYMAP2n4GBn6ncblndArfszTGzuiTW8RFhEpKHt9LifmcEeb6ScWP5ADTtaQ+ZZuXl5VYgX4wD8mw6yoariqXl5/5WYGnoaH0zJXzDAqMzcdIS8I8PVi3iFUI/88E/+SnRvwPq8kvzhdRVQzxUJY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1705587070; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=cSs51jCTaxuPt7JZH7N+SR57yUi0hzkGNoCB45S0rmY=; b=dq4rC1FeJrat4SB+XZ++mW3+8RDTiup8aXzfqSI829AmweRJ0mUmsiGXZrFbd30lCsb7GarrwAUQvenQlD2q2JuRRrbvFdKlcvdFoV/aBxucJiBaZUHOX51nUenCg6SVfBKq2hoM1Yc+GpstkhIyme0mpasG66cXnuh51w5eLP0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1705587070717883.0349768825475; Thu, 18 Jan 2024 06:11:10 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQT6F-00059L-3o; Thu, 18 Jan 2024 09:10:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQT6D-00058x-Hg; Thu, 18 Jan 2024 09:10:29 -0500 Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rQT6B-0000uU-Nd; Thu, 18 Jan 2024 09:10:29 -0500 Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-6dac225bf42so6606938b3a.0; Thu, 18 Jan 2024 06:10:27 -0800 (PST) Received: from wheely.local0.net (124-171-76-150.tpgi.com.au. [124.171.76.150]) by smtp.gmail.com with ESMTPSA id l18-20020a62be12000000b006db3149eacasm3323336pff.104.2024.01.18.06.10.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 06:10:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705587026; x=1706191826; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cSs51jCTaxuPt7JZH7N+SR57yUi0hzkGNoCB45S0rmY=; b=QieSQB+PwJ7pvMzwK+A8mJaMS3vbANHaFexgn3F3jvBKV1QOYmwpL6Mbc4sZs3b2Nh EjqioPRrEBT/fKsvC1a6Ti8Epj21Ld5+BIpmqWrLclYrsl6WFwXgW2RmoNIiMyncoOP+ LxOI5xZlZ/s8qLmh4ILlsdl2yQ+B/tiXm5tnsJ6PElnKbjUyu0m36FYZM9NLl1RLGhXn Klh+xysedsV5VvVwMdZTDK7cKDAu+azXV6AWEGyQHd3u5dOvzXQNbZrr/I9Uun4QT2Uh lgFt0ASqzDyWqEPM50Bu7m7/Q5WzympXenoLew/w9aHkcSrgAFA9+GHLg2mMCwq3qUVj BIhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705587026; x=1706191826; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cSs51jCTaxuPt7JZH7N+SR57yUi0hzkGNoCB45S0rmY=; b=usP4XCAbMQphtOmUx4XNxGvsz2CqBXZpjpp/WQ5lPLwg4Bg2yLSO7CjGcIBv94Y6so YJqLskZG/yFNor7T2lQvtJSQUnOwUtko0ABhW33blfIaaF+oyGgnCbg/624GIqL0lkBk ag/xTTmZgQudOsJoiV6v3ppdNcGkzzO7aWMsSv0x9+DXvzA6Bd3HDA6EsgVHli+RjE+s vsA7ZkSc+q2mT8Z6rCRA17rW3hNZ0U2q0j7yMpRhUe/bHmxozWsWWNayhFafPTytx9Oz fKOok8OlxGdpH18d5t01bX8FKX1CRhF13EjfMyi3YDL3JMK7LlClC+wZ3vJ7a4/ILNCZ 5NUA== X-Gm-Message-State: AOJu0YxO6AjK/uEMPsJgx5QWk0J2aSxpVIsFJK/4WVQu+x2LH6sZ3mVC /lw3fIqRfzaqSHr+bgeo9Nvv2fMDhkglm+Zk2ipf+Au4UnX/YaU3NC60OlLe X-Google-Smtp-Source: AGHT+IGi0P1WdUd210usWT5ODKorGBOrtFAjNLtcicN14e33ImXjg/Pjy0lD1KUUrQXV19TK4NFuOA== X-Received: by 2002:a05:6a00:2d01:b0:6d9:b8e3:8f28 with SMTP id fa1-20020a056a002d0100b006d9b8e38f28mr1058381pfb.44.1705587026030; Thu, 18 Jan 2024 06:10:26 -0800 (PST) From: Nicholas Piggin To: qemu-ppc@nongnu.org Cc: Nicholas Piggin , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Barrat?= , Daniel Henrique Barboza , David Gibson , Harsh Prateek Bora , qemu-devel@nongnu.org Subject: [PATCH 5/8] ppc/spapr: Add pa-features for POWER10 machines Date: Fri, 19 Jan 2024 00:09:39 +1000 Message-ID: <20240118140942.164319-6-npiggin@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20240118140942.164319-1-npiggin@gmail.com> References: <20240118140942.164319-1-npiggin@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::430; envelope-from=npiggin@gmail.com; helo=mail-pf1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1705587072781100007 Content-Type: text/plain; charset="utf-8" Signed-off-by: Nicholas Piggin --- hw/ppc/spapr.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 1e1946de59..2f58d8f292 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -265,6 +265,36 @@ static void spapr_dt_pa_features(SpaprMachineState *sp= apr, /* 60: NM atomic, 62: RNG */ 0x80, 0x00, 0x80, 0x00, 0x00, 0x00, /* 60 - 65 */ }; + /* 3.1 removes SAO, HTM support */ + uint8_t pa_features_31[] =3D { 74, 0, + /* 0: MMU|FPU|SLB|RUN|DABR|NX, 1: fri[nzpm]|DABRX|SPRG3|SLB0|PP110= */ + /* 2: VPM|DS205|PPR|DS202|DS206, 3: LSD|URG, 5: LE|CFAR|EB|LSQ */ + 0xf6, 0x1f, 0xc7, 0xc0, 0x00, 0xf0, /* 0 - 5 */ + /* 6: DS207 */ + 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, /* 6 - 11 */ + /* 16: Vector */ + 0x00, 0x00, 0x00, 0x00, 0x80, 0x00, /* 12 - 17 */ + /* 18: Vec. Scalar, 20: Vec. XOR */ + 0x80, 0x00, 0x80, 0x00, 0x00, 0x00, /* 18 - 23 */ + /* 24: Ext. Dec, 26: 64 bit ftrs, 28: PM ftrs */ + 0x80, 0x00, 0x80, 0x00, 0x80, 0x00, /* 24 - 29 */ + /* 32: LE atomic, 34: EBB + ext EBB */ + 0x00, 0x00, 0x80, 0x00, 0xC0, 0x00, /* 30 - 35 */ + /* 38: Copy/Paste, 40: Radix MMU */ + 0x00, 0x00, 0x80, 0x00, 0x80, 0x00, /* 36 - 41 */ + /* 42: PM, 44: PC RA, 46: SC vec'd */ + 0x80, 0x00, 0x80, 0x00, 0x80, 0x00, /* 42 - 47 */ + /* 48: SIMD, 50: QP BFP, 52: String */ + 0x80, 0x00, 0x80, 0x00, 0x80, 0x00, /* 48 - 53 */ + /* 54: DecFP, 56: DecI, 58: SHA */ + 0x80, 0x00, 0x80, 0x00, 0x80, 0x00, /* 54 - 59 */ + /* 60: NM atomic, 62: RNG */ + 0x80, 0x00, 0x80, 0x00, 0x00, 0x00, /* 60 - 65 */ + /* 68: DEXCR[SBHE|IBRTPDUS|SRAPD|NPHIE|PHIE] */ + 0x00, 0x00, 0xce, 0x00, 0x00, 0x00, /* 66 - 71 */ + /* 72: Hash Check */ + 0x80, 0x00, /* 73 */ + }; uint8_t *pa_features =3D NULL; size_t pa_size; =20 @@ -280,6 +310,10 @@ static void spapr_dt_pa_features(SpaprMachineState *sp= apr, pa_features =3D pa_features_300; pa_size =3D sizeof(pa_features_300); } + if (ppc_check_compat(cpu, CPU_POWERPC_LOGICAL_3_10, 0, cpu->compat_pvr= )) { + pa_features =3D pa_features_31; + pa_size =3D sizeof(pa_features_31); + } if (!pa_features) { return; } --=20 2.42.0 From nobody Sat Sep 21 03:01:18 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1705587192; cv=none; d=zohomail.com; s=zohoarc; b=JHvDEnUnmRRyrkkLxCQigNUlFxnVttD4vrPwfsenHtqmhEC/b17YPlUNE4DdGkxpNx4q3prno74ME2Hg//tpJxwuGEv+sCoZ93Qk2fgcg/T3ZC6a7BoMuwWyLa1jq8nXRY1VlAeFtm+aJyNJY4UgsZ+SfulqYEA5ABTietBR+/4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1705587192; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=mKSBPWv52bR/VdmVRdHQJRMeuRKYTrFY5qPGuWj2bn4=; b=nrdNXbIgdsjhSrVpz3sCdH1zHmUQMG8FwEsSHy0WTLvPOrGbJvlxV5vcFzFE10JUfaMqYoCJZBulOhNRSgg3ip8Ww0G+1iZwGT6uBRVfcF2f7DJVCddz/oIF12bCDoFCTthZ7JOQBgzwqT97MoG+5tecfhxPOux3zgwRzHjrqu4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1705587192300572.6622067667968; Thu, 18 Jan 2024 06:13:12 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQT6N-0005E0-1t; Thu, 18 Jan 2024 09:10:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQT6J-0005CQ-4d; Thu, 18 Jan 2024 09:10:35 -0500 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rQT6H-0000v0-5t; Thu, 18 Jan 2024 09:10:34 -0500 Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-6d9b267007fso7385769b3a.3; Thu, 18 Jan 2024 06:10:32 -0800 (PST) Received: from wheely.local0.net (124-171-76-150.tpgi.com.au. [124.171.76.150]) by smtp.gmail.com with ESMTPSA id l18-20020a62be12000000b006db3149eacasm3323336pff.104.2024.01.18.06.10.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 06:10:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705587031; x=1706191831; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mKSBPWv52bR/VdmVRdHQJRMeuRKYTrFY5qPGuWj2bn4=; b=CF8Gyv67ozuHF3kiDzCfURFjzjTBC1f2DHssioWVN5gau7prpVEbSL9OtcPa/meyjz CNNjWesoEGbS8zI22S/PLfR32Se5pP7CZio34+lThbJj4j1CmeskYfOuKIeqcBMmJgRP LohtW5p9L8/TfaN6JHi49oqFAMoa8Wy8FEiwG+uv38zl4bevKGsWzfjz15CIM8iswbZ1 OqO+rNor6g5QUqu07h/2ssbmB5goku3bCtdpUlwM/5BHBPy0QxENHfKaCv+HI6RDl63B 9OZydn9CsCTj5wm4PcwAle/lbeziuDmLtgr25nPy2qX/ftVbSjjEs18nOhkyqxU4jT4o /5Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705587031; x=1706191831; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mKSBPWv52bR/VdmVRdHQJRMeuRKYTrFY5qPGuWj2bn4=; b=GqWKODF/KMe39wxR/Kyv/f89Rm7vTfLLiIb4T8p1EXzvOuBOp3ozvWGXJEQCqfqRr3 kfpEaeP2cp4vHURxY2G4pXhXNdenXtzev3d8HcKwQdkPRwcZllWCJtPXjh6gf6LqBWWM Vs35yDcUPpejqFwkEeS/OkSVdh2pRPB4/AXFQLjjhyRFYH9KNKG02WHZGXln1Y8SRDey sA1t2iuPuDiVq8TMqRt9JkShojqvo3+rIL9PqkXFv67Dwt+HUARa6mLON8dY50/eH2ig MElZ9em2uCNSUzJPhu7AxlwxhxKH4f1et6CsuvkdZGinNFXlF5JP0K0BeVd/F+97xuQq wqMg== X-Gm-Message-State: AOJu0YwBf7na6Ir8qjtPuv5lqoWMBQYJa356G1FxpymJUgHuUruPamN1 9Pmmd+hC9SahW7H2aDDRNLcZTi9kanEmNVo/ibEXHzCMzAWqtvtIufuisFFu X-Google-Smtp-Source: AGHT+IFeeKXVhjiYjPozGMCPzVXXPDFGD0bGQOfQb+KqBN11Y8M5QHAkWB/XuUoktybuNmhZ63Obbg== X-Received: by 2002:a05:6a00:291a:b0:6d9:ecbb:8bd8 with SMTP id cg26-20020a056a00291a00b006d9ecbb8bd8mr884036pfb.32.1705587031003; Thu, 18 Jan 2024 06:10:31 -0800 (PST) From: Nicholas Piggin To: qemu-ppc@nongnu.org Cc: Nicholas Piggin , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Barrat?= , Daniel Henrique Barboza , David Gibson , Harsh Prateek Bora , qemu-devel@nongnu.org Subject: [PATCH 6/8] ppc/pnv: Permit ibm,pa-features set per machine variant Date: Fri, 19 Jan 2024 00:09:40 +1000 Message-ID: <20240118140942.164319-7-npiggin@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20240118140942.164319-1-npiggin@gmail.com> References: <20240118140942.164319-1-npiggin@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::435; envelope-from=npiggin@gmail.com; helo=mail-pf1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1705587193885100003 Content-Type: text/plain; charset="utf-8" This allows different pa-features for powernv8/9/10. Signed-off-by: Nicholas Piggin --- hw/ppc/pnv.c | 41 +++++++++++++++++++++++++++++------------ 1 file changed, 29 insertions(+), 12 deletions(-) diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index 4969fbdb05..0a144402d7 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -133,7 +133,7 @@ static int get_cpus_node(void *fdt) * device tree, used in XSCOM to address cores and in interrupt * servers. */ -static void pnv_dt_core(PnvChip *chip, PnvCore *pc, void *fdt) +static int pnv_dt_core(PnvChip *chip, PnvCore *pc, void *fdt) { PowerPCCPU *cpu =3D pc->threads[0]; CPUState *cs =3D CPU(cpu); @@ -149,11 +149,6 @@ static void pnv_dt_core(PnvChip *chip, PnvCore *pc, vo= id *fdt) uint32_t cpufreq =3D 1000000000; uint32_t page_sizes_prop[64]; size_t page_sizes_prop_size; - const uint8_t pa_features[] =3D { 24, 0, - 0xf6, 0x3f, 0xc7, 0xc0, 0x80, 0xf0, - 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, - 0x00, 0x00, 0x00, 0x00, 0x80, 0x00, - 0x80, 0x00, 0x80, 0x00, 0x80, 0x00 }; int offset; char *nodename; int cpus_offset =3D get_cpus_node(fdt); @@ -241,15 +236,14 @@ static void pnv_dt_core(PnvChip *chip, PnvCore *pc, v= oid *fdt) page_sizes_prop, page_sizes_prop_size))); } =20 - _FDT((fdt_setprop(fdt, offset, "ibm,pa-features", - pa_features, sizeof(pa_features)))); - /* Build interrupt servers properties */ for (i =3D 0; i < smt_threads; i++) { servers_prop[i] =3D cpu_to_be32(pc->pir + i); } _FDT((fdt_setprop(fdt, offset, "ibm,ppc-interrupt-server#s", servers_prop, sizeof(*servers_prop) * smt_threads))= ); + + return offset; } =20 static void pnv_dt_icp(PnvChip *chip, void *fdt, uint32_t pir, @@ -304,6 +298,17 @@ PnvChip *pnv_chip_add_phb(PnvChip *chip, PnvPHB *phb) return chip; } =20 +/* + * Same as spapr pa_features_207 except pnv always enables CI largepages b= it. + * HTM is always enabled because TCG does implement HTM, it's just a + * degenerate implementation. + */ +static const uint8_t pa_features_207[] =3D { 24, 0, + 0xf6, 0x3f, 0xc7, 0xc0, 0x80, 0xf0, + 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x80, 0x00, + 0x80, 0x00, 0x80, 0x00, 0x80, 0x00 }; + static void pnv_chip_power8_dt_populate(PnvChip *chip, void *fdt) { static const char compat[] =3D "ibm,power8-xscom\0ibm,xscom"; @@ -316,8 +321,12 @@ static void pnv_chip_power8_dt_populate(PnvChip *chip,= void *fdt) =20 for (i =3D 0; i < chip->nr_cores; i++) { PnvCore *pnv_core =3D chip->cores[i]; + int offset; + + offset =3D pnv_dt_core(chip, pnv_core, fdt); =20 - pnv_dt_core(chip, pnv_core, fdt); + _FDT((fdt_setprop(fdt, offset, "ibm,pa-features", + pa_features_207, sizeof(pa_features_207)))); =20 /* Interrupt Control Presenters (ICP). One per core. */ pnv_dt_icp(chip, fdt, pnv_core->pir, CPU_CORE(pnv_core)->nr_thread= s); @@ -340,8 +349,12 @@ static void pnv_chip_power9_dt_populate(PnvChip *chip,= void *fdt) =20 for (i =3D 0; i < chip->nr_cores; i++) { PnvCore *pnv_core =3D chip->cores[i]; + int offset; =20 - pnv_dt_core(chip, pnv_core, fdt); + offset =3D pnv_dt_core(chip, pnv_core, fdt); + + _FDT((fdt_setprop(fdt, offset, "ibm,pa-features", + pa_features_207, sizeof(pa_features_207)))); } =20 if (chip->ram_size) { @@ -363,8 +376,12 @@ static void pnv_chip_power10_dt_populate(PnvChip *chip= , void *fdt) =20 for (i =3D 0; i < chip->nr_cores; i++) { PnvCore *pnv_core =3D chip->cores[i]; + int offset; + + offset =3D pnv_dt_core(chip, pnv_core, fdt); =20 - pnv_dt_core(chip, pnv_core, fdt); + _FDT((fdt_setprop(fdt, offset, "ibm,pa-features", + pa_features_207, sizeof(pa_features_207)))); } =20 if (chip->ram_size) { --=20 2.42.0 From nobody Sat Sep 21 03:01:18 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1705587126; cv=none; d=zohomail.com; s=zohoarc; b=I0RqDpb+HlupBa4Dr1xPM9+E5eWJO+cRatJeJuDBmhZHvCGmeM8HQpqjSJ9RZqDqvE5G7pbTouegR4ihG8hFuIaBhjFIv7YhZMCVYiyPX6qbMSabexZWZF7wdyokhRhFnn/qjaPhUDqDviFgJTfAT/Cxjb5klG0uqbTF46ngzdU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1705587126; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=JxSsIMWIjG+FA8eKVyzES24tcAp+iTv4zsAB6Y5sWTQ=; b=SaHZfYQLbx82kL4WwdPy6pp5mWQgRh5U4cRC8hjqDY8Xi0+nx4vX0iBDbq7qxrAvuDOYSe/+/qapWZpqyWjo13L3ZpTiFveaB9R9zUIevf5A9Od4QPv8O0jW9f0o2itsZbai4uD8SANYFu8mdOGyRuG1MCTZv46Dm3BEZNTigk4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1705587126818529.4897093565041; Thu, 18 Jan 2024 06:12:06 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQT6U-0005Fz-Hx; Thu, 18 Jan 2024 09:10:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQT6O-0005Es-QG; Thu, 18 Jan 2024 09:10:41 -0500 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rQT6M-0000vf-TV; Thu, 18 Jan 2024 09:10:40 -0500 Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-6d9b13fe9e9so9396928b3a.2; Thu, 18 Jan 2024 06:10:36 -0800 (PST) Received: from wheely.local0.net (124-171-76-150.tpgi.com.au. [124.171.76.150]) by smtp.gmail.com with ESMTPSA id l18-20020a62be12000000b006db3149eacasm3323336pff.104.2024.01.18.06.10.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 06:10:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705587035; x=1706191835; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JxSsIMWIjG+FA8eKVyzES24tcAp+iTv4zsAB6Y5sWTQ=; b=gQUMiNQalUQnXFhGr0mJgcqkeZ0FjKD9DRKuaOTgwR3QP7DKk0kYrhM2BQljQbKh09 flp1AsDVWfuvXEnLFWjqhigV3EPhM0aJA1BgvvBeQkRSOKwmWscjGLL1eNqGWSofyXq0 Dm4TqzFVilGRLgWeJKdNFJZwCR9JsbMNQUajoOpMzvC4vqwYHHHG3S1HO3AS2Vjqs0/a sQSzb+Rf6lWhWLsABatgMEZI4Es8DoHanXeWH8jEENkT9/E7SSKllDayLDKe1J1jJYO2 CwhZtB8ZFKao8QMNY77EM4oDaELpPjqsqg5yBqvuXKQFW6Ub4+MhvWY4zYVdimzScrME rHDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705587035; x=1706191835; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JxSsIMWIjG+FA8eKVyzES24tcAp+iTv4zsAB6Y5sWTQ=; b=eMUlFy0vBhguWVoOEsyo/r1P8Q2sGD/Jcr6GZuXfWGfEaCRBQMO/etlEofwx8e1yKQ pZKneLLda7wpgCbT9rwo2LMB7tqgdEB7BT9nHBC7R9kMh6hi9us3d0pJL9DWO1jv7J5k INNUrTHRTfN9Dxn78+AoCbgP+1HocZ6zZzJwMDJC2cOulbqPSBbHmP4LiFtbCyPNz7Hn HmEK2e6IJ7E+i+izyErsAM9pHp+xJCuO+Xqa9SjKWLb+uA0IAokTogpEo7n/SzJkLkx9 e81Krt0tlUFkGjR4yAUu7tLIj1QyZE9cZcMryJj4O8UUJpTcJ2PRlWGqrSz+x7ZySCjM 15sA== X-Gm-Message-State: AOJu0YxQf9Nq0Wx57zUCze+l7RzhD7KGrUUpC9OOkbapAAUuX76xD96Z aA2+XfUbhjIDb5vJgQmcrT8M026cj0DfA4NxgHu/TZZnNciwjUEbAZeh+a94 X-Google-Smtp-Source: AGHT+IFzuouUvx8Kax5/sT2grNCGR4NRWW/ZQkp9dB2VDTGrowTpIezsM623FZpur3s27I+v+iQOHA== X-Received: by 2002:a05:6a20:8e16:b0:199:9013:1980 with SMTP id y22-20020a056a208e1600b0019990131980mr1054257pzj.58.1705587035362; Thu, 18 Jan 2024 06:10:35 -0800 (PST) From: Nicholas Piggin To: qemu-ppc@nongnu.org Cc: Nicholas Piggin , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Barrat?= , Daniel Henrique Barboza , David Gibson , Harsh Prateek Bora , qemu-devel@nongnu.org Subject: [PATCH 7/8] ppc/pnv: Set POWER9, POWER10 ibm,pa-features bits Date: Fri, 19 Jan 2024 00:09:41 +1000 Message-ID: <20240118140942.164319-8-npiggin@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20240118140942.164319-1-npiggin@gmail.com> References: <20240118140942.164319-1-npiggin@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::431; envelope-from=npiggin@gmail.com; helo=mail-pf1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1705587127331100001 Content-Type: text/plain; charset="utf-8" Copy the pa-features arrays from spapr, adjusting slightly as described in comments. Signed-off-by: Nicholas Piggin --- hw/ppc/pnv.c | 68 ++++++++++++++++++++++++++++++++++++++++++++++++-- hw/ppc/spapr.c | 1 + 2 files changed, 67 insertions(+), 2 deletions(-) diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index 0a144402d7..9db8fcd19e 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -337,6 +337,36 @@ static void pnv_chip_power8_dt_populate(PnvChip *chip,= void *fdt) } } =20 +/* + * Same as spapr pa_features_300 except pnv always enables CI largepages b= it, + * always disables copy/paste. + */ +static const uint8_t pa_features_300[] =3D { 66, 0, + /* 0: MMU|FPU|SLB|RUN|DABR|NX, 1: CILRG|fri[nzpm]|DABRX|SPRG3|SLB0|PP1= 10 */ + /* 2: VPM|DS205|PPR|DS202|DS206, 3: LSD|URG, 5: LE|CFAR|EB|LSQ */ + 0xf6, 0x3f, 0xc7, 0xc0, 0x00, 0xf0, /* 0 - 5 */ + /* 6: DS207 */ + 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, /* 6 - 11 */ + /* 16: Vector */ + 0x00, 0x00, 0x00, 0x00, 0x80, 0x00, /* 12 - 17 */ + /* 18: Vec. Scalar, 20: Vec. XOR, 22: HTM */ + 0x80, 0x00, 0x80, 0x00, 0x80, 0x00, /* 18 - 23 */ + /* 24: Ext. Dec, 26: 64 bit ftrs, 28: PM ftrs */ + 0x80, 0x00, 0x80, 0x00, 0x80, 0x00, /* 24 - 29 */ + /* 32: LE atomic, 34: EBB + ext EBB */ + 0x00, 0x00, 0x80, 0x00, 0xC0, 0x00, /* 30 - 35 */ + /* 40: Radix MMU */ + 0x00, 0x00, 0x00, 0x00, 0x80, 0x00, /* 36 - 41 */ + /* 42: PM, 44: PC RA, 46: SC vec'd */ + 0x80, 0x00, 0x80, 0x00, 0x80, 0x00, /* 42 - 47 */ + /* 48: SIMD, 50: QP BFP, 52: String */ + 0x80, 0x00, 0x80, 0x00, 0x80, 0x00, /* 48 - 53 */ + /* 54: DecFP, 56: DecI, 58: SHA */ + 0x80, 0x00, 0x80, 0x00, 0x80, 0x00, /* 54 - 59 */ + /* 60: NM atomic, 62: RNG */ + 0x80, 0x00, 0x80, 0x00, 0x00, 0x00, /* 60 - 65 */ +}; + static void pnv_chip_power9_dt_populate(PnvChip *chip, void *fdt) { static const char compat[] =3D "ibm,power9-xscom\0ibm,xscom"; @@ -354,7 +384,7 @@ static void pnv_chip_power9_dt_populate(PnvChip *chip, = void *fdt) offset =3D pnv_dt_core(chip, pnv_core, fdt); =20 _FDT((fdt_setprop(fdt, offset, "ibm,pa-features", - pa_features_207, sizeof(pa_features_207)))); + pa_features_300, sizeof(pa_features_300)))); } =20 if (chip->ram_size) { @@ -364,6 +394,40 @@ static void pnv_chip_power9_dt_populate(PnvChip *chip,= void *fdt) pnv_dt_lpc(chip, fdt, 0, PNV9_LPCM_BASE(chip), PNV9_LPCM_SIZE); } =20 +/* + * Same as spapr pa_features_31 except pnv always enables CI largepages bi= t, + * always disables copy/paste. + */ +static const uint8_t pa_features_31[] =3D { 74, 0, + /* 0: MMU|FPU|SLB|RUN|DABR|NX, 1: CILRG|fri[nzpm]|DABRX|SPRG3|SLB0|PP1= 10 */ + /* 2: VPM|DS205|PPR|DS202|DS206, 3: LSD|URG, 5: LE|CFAR|EB|LSQ */ + 0xf6, 0x3f, 0xc7, 0xc0, 0x00, 0xf0, /* 0 - 5 */ + /* 6: DS207 */ + 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, /* 6 - 11 */ + /* 16: Vector */ + 0x00, 0x00, 0x00, 0x00, 0x80, 0x00, /* 12 - 17 */ + /* 18: Vec. Scalar, 20: Vec. XOR */ + 0x80, 0x00, 0x80, 0x00, 0x00, 0x00, /* 18 - 23 */ + /* 24: Ext. Dec, 26: 64 bit ftrs, 28: PM ftrs */ + 0x80, 0x00, 0x80, 0x00, 0x80, 0x00, /* 24 - 29 */ + /* 32: LE atomic, 34: EBB + ext EBB */ + 0x00, 0x00, 0x80, 0x00, 0xC0, 0x00, /* 30 - 35 */ + /* 40: Radix MMU */ + 0x00, 0x00, 0x00, 0x00, 0x80, 0x00, /* 36 - 41 */ + /* 42: PM, 44: PC RA, 46: SC vec'd */ + 0x80, 0x00, 0x80, 0x00, 0x80, 0x00, /* 42 - 47 */ + /* 48: SIMD, 50: QP BFP, 52: String */ + 0x80, 0x00, 0x80, 0x00, 0x80, 0x00, /* 48 - 53 */ + /* 54: DecFP, 56: DecI, 58: SHA */ + 0x80, 0x00, 0x80, 0x00, 0x80, 0x00, /* 54 - 59 */ + /* 60: NM atomic, 62: RNG */ + 0x80, 0x00, 0x80, 0x00, 0x00, 0x00, /* 60 - 65 */ + /* 68: DEXCR[SBHE|IBRTPDUS|SRAPD|NPHIE|PHIE] */ + 0x00, 0x00, 0xce, 0x00, 0x00, 0x00, /* 66 - 71 */ + /* 72: Hash Check */ + 0x80, 0x00, /* 73 */ +}; + static void pnv_chip_power10_dt_populate(PnvChip *chip, void *fdt) { static const char compat[] =3D "ibm,power10-xscom\0ibm,xscom"; @@ -381,7 +445,7 @@ static void pnv_chip_power10_dt_populate(PnvChip *chip,= void *fdt) offset =3D pnv_dt_core(chip, pnv_core, fdt); =20 _FDT((fdt_setprop(fdt, offset, "ibm,pa-features", - pa_features_207, sizeof(pa_features_207)))); + pa_features_31, sizeof(pa_features_31)))); } =20 if (chip->ram_size) { diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 2f58d8f292..40fdbd5d12 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -233,6 +233,7 @@ static void spapr_dt_pa_features(SpaprMachineState *spa= pr, PowerPCCPU *cpu, void *fdt, int offset) { + /* These should be kept in sync with pnv */ uint8_t pa_features_206[] =3D { 6, 0, 0xf6, 0x1f, 0xc7, 0x00, 0x80, 0xc0 }; uint8_t pa_features_207[] =3D { 24, 0, --=20 2.42.0 From nobody Sat Sep 21 03:01:18 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1705587144; cv=none; d=zohomail.com; s=zohoarc; b=drwXWkDtrljNlk79plRQzUqlsz+0dH58vRPgU7mImTbBeZ4NKGenBcLz3TQAmmKjOJplX4nVLD3z1edO9GkV7deC51ZnQFZRzYsMKMuLx1Pb1qaBwm/ghN4ddhqAJ5EjzIWTS1Pp0Xq6FbcJjPiJSNC7gY6lHnTI/EAtMURppk0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1705587144; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=sWk2dgjHndp7FsuzpUD/csXND4J+Krq5hKfllN40/I8=; b=DqZwMaMVA7YSKDPVmGdL4zRrO2jCZp0y+wVXLIB6gLmtAuD03go+WtwX8gm0u0S672t8mHuhfd0a6zRMiUhzRmxTO4vOOgfuK/MPyqkPk0kaTuH/zaq7JVamOcNxeKvH6lyr2osQzcwF1RiqKZ1F5WCa/6clOb6YOAhhORfmLic= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1705587144191862.3856362549491; Thu, 18 Jan 2024 06:12:24 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQT6Y-0005HJ-6i; Thu, 18 Jan 2024 09:10:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQT6R-0005FR-7R; Thu, 18 Jan 2024 09:10:46 -0500 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rQT6P-0000w3-Aa; Thu, 18 Jan 2024 09:10:42 -0500 Received: by mail-pg1-x535.google.com with SMTP id 41be03b00d2f7-5cf22a89a54so4397145a12.3; Thu, 18 Jan 2024 06:10:40 -0800 (PST) Received: from wheely.local0.net (124-171-76-150.tpgi.com.au. [124.171.76.150]) by smtp.gmail.com with ESMTPSA id l18-20020a62be12000000b006db3149eacasm3323336pff.104.2024.01.18.06.10.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 06:10:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705587039; x=1706191839; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sWk2dgjHndp7FsuzpUD/csXND4J+Krq5hKfllN40/I8=; b=hilZ8qIKjhMnPMqIjEmbxV6gw7h/tI+cpRVRtoM6T1Kq1sJydZpGrDvivSUlblxfIC ebxGe22CsqrfUEDQ84Mh6JMYD/Lj5Dm+ly6iMht68LtlzkqgvF0Or7+PypvYp/NFsrON bdynWJXpMr7KOpI3yYaiPZxolS1xmHW5kU0NZWMSHRq36++WUAN2V5nuDfzTOxHWe4ms bRVbeIEun8L/j7OWU6ASXvKpDp1qhTbN8SwBcXmvC824tLEXtNnSErHYjl7yRzUDf5g8 JOmI3SWg7aGcK/UMkKYvHKw7rT6XSRCstkwSwIkM0asAgq4PhasmH//zYKyw3tjFb1O8 8LGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705587039; x=1706191839; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sWk2dgjHndp7FsuzpUD/csXND4J+Krq5hKfllN40/I8=; b=Tee4NLcurUxHtTFGW2DTSLx9M/127bpGg+i8mj0dJPDaI5/MB5FMPC/minJVeE0rd2 zcvhgiMY2FR9QJHL0r3xz8vZrGxTs+58sTt59vlkLwvTxH6N0YV5VfaAFBdQrh5Vt86d Vcd97aCc+GLobI+YzD3zi+sKZW+nKS4h7w7DHqa+X5DrbRHoFib+OfiYWsGKu0GWeIq2 ja5QvXoFL9pBY4ibs9ggJvNFzPzq6rkVvtNu6XR20jL2bUcPpDx9GRSpPkKK3jst3i1v z7pP1AAC0qiR21MjzOB/ZeOgoAQxmNf9n4bgY+5yekMZu/Py/fTm7gz38NCS+rDDszKK 8ZwA== X-Gm-Message-State: AOJu0YztmetZ60bg8gAZ5cix4+H2lt+w2QbtFb2TZtNFQbgGt1aNxL8P jHAvD85culdFZ/EBF9jFDXrcSbcTYpk+UWlnT/BtJGPrYlMZUyDPm3Xyp3bY X-Google-Smtp-Source: AGHT+IG40l8R7daxsLo3FkNMw+NwptleL5xyIP8Hgdm7NW3vkxhFoyYUsooYspb2SfuiNRwfwADV+A== X-Received: by 2002:a05:6a21:8cc5:b0:19a:9db4:851b with SMTP id ta5-20020a056a218cc500b0019a9db4851bmr777598pzb.61.1705587039578; Thu, 18 Jan 2024 06:10:39 -0800 (PST) From: Nicholas Piggin To: qemu-ppc@nongnu.org Cc: Nicholas Piggin , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Barrat?= , Daniel Henrique Barboza , David Gibson , Harsh Prateek Bora , qemu-devel@nongnu.org Subject: [PATCH 8/8] ppc/pnv: Update skiboot to v7.1 Date: Fri, 19 Jan 2024 00:09:42 +1000 Message-ID: <20240118140942.164319-9-npiggin@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20240118140942.164319-1-npiggin@gmail.com> References: <20240118140942.164319-1-npiggin@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::535; envelope-from=npiggin@gmail.com; helo=mail-pg1-x535.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1705587145850100003 Content-Type: text/plain; charset="utf-8" This includes a number of improvements and fixes. Importantly there is a change for QEMU platforms to permit the ChipTOD to be initialised if it is present in the device tree. This will facilitate ChipTOD enablement in pnv. Signed-off-by: Nicholas Piggin Reviewed-by: C=C3=A9dric Le Goater --- [blob omitted, patch is just for comments] pc-bios/skiboot.lid | Bin 2527240 -> 2527328 bytes roms/skiboot | 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/roms/skiboot b/roms/skiboot index 24a7eb3596..dbd5de6624 160000 --- a/roms/skiboot +++ b/roms/skiboot @@ -1 +1 @@ -Subproject commit 24a7eb35966d93455520bc2debdd7954314b638b +Subproject commit dbd5de6624d7466bb67d1eb4e57bc3a8e2ad9e87 --=20 2.42.0