From nobody Tue Nov 26 20:36:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1705483045; cv=none; d=zohomail.com; s=zohoarc; b=UdTn+geGH9Zsjair75hWcRr6eSTZZhiP1Kobc7hqPZAuMfaOQGoP2UBiSE0v9z/tXfAgap315O+ARH9vJiLr+VrMAFGMwjmQnCJWeUaCebFVDRBH0JFz8lmyeNH2pMChXNpao7XmOHwaNT0S830X41ucln4nHovB0WDGWNgEDvk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1705483045; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=pFdoHAJ+lkGOTCUL+ieZy9Kht+Sp7cO/n/p8tGSPvWM=; b=OKgpFKWUMkA/W2gUpK6IZ4FiNQbXKbwbsI2P5XccYnpTW9JZDtAk8mdpWj4De9wzpjPtP4TY8w0Lvh7LXkphzTl/ldACcg+P24TKsQcLSGsNJwnWGDVyMpx7d2cegGwtoElNfyXskvJrUPqwCr34mdqppeeYEQj/o/S2m3rQVy8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1705483045731550.6566520250672; Wed, 17 Jan 2024 01:17:25 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQ225-0008SU-A9; Wed, 17 Jan 2024 04:16:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQ223-0008SI-55 for qemu-devel@nongnu.org; Wed, 17 Jan 2024 04:16:23 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQ221-0006az-OM for qemu-devel@nongnu.org; Wed, 17 Jan 2024 04:16:22 -0500 Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-659-lHz3sYrWNfmgrUBKKdIVrg-1; Wed, 17 Jan 2024 04:16:19 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E419F280FEC8 for ; Wed, 17 Jan 2024 09:16:18 +0000 (UTC) Received: from x1n.redhat.com (unknown [10.72.116.92]) by smtp.corp.redhat.com (Postfix) with ESMTP id 52AE92166B32; Wed, 17 Jan 2024 09:16:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705482980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pFdoHAJ+lkGOTCUL+ieZy9Kht+Sp7cO/n/p8tGSPvWM=; b=YtDCL0ODgrehggU1KAlm7jFts5r+Y8LB+8FVYjeF3+rAp24dX3XTOELfc19bXKin5pNfA4 mDFdinxnmWC3L+x+gNtsy+bAzBRBaVWxuBqSHdy+V0JSfUz7cyhJa8TPjrCiV5Y32YtJG5 5opy1CRfV62nGPZv9VOA9I+6J3ewrPU= X-MC-Unique: lHz3sYrWNfmgrUBKKdIVrg-1 From: peterx@redhat.com To: qemu-devel@nongnu.org Cc: Eric Auger , "Michael S . Tsirkin" , Jason Wang , Alex Williamson , Igor Mammedov , peterx@redhat.com Subject: [PATCH 3/4] intel_iommu: Tear down address spaces before IOMMU reset Date: Wed, 17 Jan 2024 17:15:58 +0800 Message-ID: <20240117091559.144730-4-peterx@redhat.com> In-Reply-To: <20240117091559.144730-1-peterx@redhat.com> References: <20240117091559.144730-1-peterx@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -38 X-Spam_score: -3.9 X-Spam_bar: --- X-Spam_report: (-3.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.806, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1705483047172100011 Content-Type: text/plain; charset="utf-8" From: Peter Xu No bug report for this, but logically tearing down of existing address space should happen before reset of IOMMU state / registers, because the current address spaces may still rely on those information. Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 1a07faddb4..8b467cbbd2 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -4090,8 +4090,8 @@ static void vtd_reset(DeviceState *dev) { IntelIOMMUState *s =3D INTEL_IOMMU_DEVICE(dev); =20 - vtd_init(s); vtd_address_space_refresh_all(s); + vtd_init(s); } =20 static AddressSpace *vtd_host_dma_iommu(PCIBus *bus, void *opaque, int dev= fn) --=20 2.43.0