From nobody Tue Nov 26 22:30:50 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1705333779; cv=none; d=zohomail.com; s=zohoarc; b=MomBO9erOcHkoXg7j5u8IzY/vQNCqpbhhBMPGSIzeAGAC5hWiGXdcRw4kTw3TCCRVVliMUAKW1K9dslHxHAo5QUMpKBn4dta8LghuMnoque62gBhqwT2Ds60p8CU8H62+pscovsjtFA26GKcFt1EC42kVOqDaOX2hRd4YthZjRE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1705333779; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tp8RLIRVaWVkYt4UxaAhQqaCgr9WAKqef890MJV0AxE=; b=nk2d9m+PSy/houumXfkIaUpPH98/rSHaQsjfYpSjAcqbb0pAadkPRgnfLxKK+H8EPai9LlHAO0VAgMZYAwDPDdWKFInXFBLCWN95W69DeGNlUtsOlhVsftPtVv8LmQo0wr/+C7ZZTk6XuVbhuvxFOMLLaR6cZ5chpcI2U7OBNRA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1705333779830384.17413429900785; Mon, 15 Jan 2024 07:49:39 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rPPCe-00037v-Ck; Mon, 15 Jan 2024 10:48:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rPPCc-00037S-Ns for qemu-devel@nongnu.org; Mon, 15 Jan 2024 10:48:42 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rPPCb-0007b4-9Z for qemu-devel@nongnu.org; Mon, 15 Jan 2024 10:48:42 -0500 Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-685-yGn4CCMRMf6ifzQcqwfswg-1; Mon, 15 Jan 2024 10:48:38 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AD4E9280A9B1 for ; Mon, 15 Jan 2024 15:48:38 +0000 (UTC) Received: from localhost (unknown [10.39.208.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id EE0C51C060B2; Mon, 15 Jan 2024 15:48:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705333720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tp8RLIRVaWVkYt4UxaAhQqaCgr9WAKqef890MJV0AxE=; b=BBYU1s2pcDfs5QuCv67+mBxC6kBEWw9qwkdu2K+CmTvShE66ACVPu2ZjspKrwu7IlBuLVk B0e5Tb4RsRZxRntFyGJUAUX3WlLRr05qPeod4/E1ZktnDc+/jb0P52xV3asJyGIxvJHvZ5 rzfqgrrLm8QhS6ta39j5+13kTOpYNII= X-MC-Unique: yGn4CCMRMf6ifzQcqwfswg-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: peterx@redhat.com, Gerd Hoffmann , "Michael S. Tsirkin" , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH 1/2] virtio-gpu: remove needless condition Date: Mon, 15 Jan 2024 19:48:29 +0400 Message-ID: <20240115154830.498304-2-marcandre.lureau@redhat.com> In-Reply-To: <20240115154830.498304-1-marcandre.lureau@redhat.com> References: <20240115154830.498304-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.531, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1705333781110100001 From: Marc-Andr=C3=A9 Lureau qemu_create_displaysurface_pixman() never returns NULL. Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/display/virtio-gpu.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index f8a675eb30..a62ffb1627 100644 --- a/hw/display/virtio-gpu.c +++ b/hw/display/virtio-gpu.c @@ -679,10 +679,6 @@ static void virtio_gpu_do_set_scanout(VirtIOGPU *g, =20 /* realloc the surface ptr */ scanout->ds =3D qemu_create_displaysurface_pixman(rect); - if (!scanout->ds) { - *error =3D VIRTIO_GPU_RESP_ERR_UNSPEC; - return; - } #ifdef WIN32 qemu_displaysurface_win32_set_handle(scanout->ds, res->handle, fb-= >offset); #endif --=20 2.43.0