From nobody Tue Nov 26 20:14:09 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1705310074; cv=none; d=zohomail.com; s=zohoarc; b=OwYWoXMGOn+JITYPtwm2OG58U3A9YLkD+yFwHBLx82tvJwdk9FhVHXEiLE1Yn02HiTbiRSma58teBUDZBxuRYtLWxhEU8U9ojXpPKGz9HU4EAvXtjraz5HVQ3kKO+FL2e/V/zeGNMAUaEEM2vBo8CCu8xiz25antkOGvTKCx+34= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1705310074; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=kegjZOM6GFHwLSK0hh0LmnucTms168jTuGAiauTdxok=; b=fbQfREkKVW7uHITJNmvDi1BsruTgFAgVlU71pJ84vQEvAsGAcIaUceR9g5rFNdPwqM7jRfChXUpTaxU03/XzOMHr91GzRxW6wXzxsxe5/n7dkozZkniQEDJyK/4zp0sSeEMhK4afMc4lbvmvzZKmcYlIOVXtJKi8q2YwOZhlGiM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1705310074013447.369683981722; Mon, 15 Jan 2024 01:14:34 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rPJ2N-000317-M0; Mon, 15 Jan 2024 04:13:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rPJ2H-0002lJ-Q5 for qemu-devel@nongnu.org; Mon, 15 Jan 2024 04:13:39 -0500 Received: from mgamail.intel.com ([198.175.65.10]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rPJ2D-0003fi-5F for qemu-devel@nongnu.org; Mon, 15 Jan 2024 04:13:34 -0500 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jan 2024 01:13:30 -0800 Received: from lxy-clx-4s.sh.intel.com ([10.239.48.52]) by fmsmga002.fm.intel.com with ESMTP; 15 Jan 2024 01:13:27 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1705310014; x=1736846014; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=DvipdMKTg2/aLfv+rUwe5Yj3aRSIk9f8Ei/eEqpcd0o=; b=KpJRstA3bmpz3KKX2xfjthjZKnG7fQ09cqjxKFHdCsBYFKNSZjT/LOV0 kzcXcSzrJ5YTtXKH3+6e3GeCkePILpxD2rz4NMctd/qChlUiq6S+ntsNd 07IoO1kGYN4RPimPUEArfQOFV1ZzVDo23LzI+ULyJBwfvn3nDdx+qdgGd sRzxtybn92pswj2DHnVmpFpq6EcfxA2wxWD1DYH2+3On5fqf+cE+Q15XN sWcS8/869vMb+FXKki7JDBhVrtV0q2kc0bJDCAKlW7ZlJilUbidS4giSz KBusXNEsrmrYyPEgSHA51mVqAMS+5qMf+z8TbBgqEPjCWHKGUXVKzc1UA Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10953"; a="12928490" X-IronPort-AV: E=Sophos;i="6.04,196,1695711600"; d="scan'208";a="12928490" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10953"; a="902720576" X-IronPort-AV: E=Sophos;i="6.04,196,1695711600"; d="scan'208";a="902720576" From: Xiaoyao Li To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Yang Weijiang Subject: [PATCH 1/2] i386/cpu: Clear FEAT_XSAVE_XSS_LO/HI leafs when CPUID_EXT_XSAVE is not available Date: Mon, 15 Jan 2024 04:13:24 -0500 Message-Id: <20240115091325.1904229-2-xiaoyao.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240115091325.1904229-1-xiaoyao.li@intel.com> References: <20240115091325.1904229-1-xiaoyao.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=198.175.65.10; envelope-from=xiaoyao.li@intel.com; helo=mgamail.intel.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.758, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HK_RANDOM_ENVFROM=0.998, HK_RANDOM_FROM=0.998, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1705310075725100007 Content-Type: text/plain; charset="utf-8" Leaf FEAT_XSAVE_XSS_LO and FEAT_XSAVE_XSS_HI also need to be cleared when CPUID_EXT_XSAVE is not set. Fixes: 301e90675c3f ("target/i386: Enable support for XSAVES based features= ") Signed-off-by: Xiaoyao Li Reviewed-by: Yang Weijiang --- target/i386/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 2524881ce245..b445e2957c4f 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -6926,6 +6926,8 @@ static void x86_cpu_enable_xsave_components(X86CPU *c= pu) if (!(env->features[FEAT_1_ECX] & CPUID_EXT_XSAVE)) { env->features[FEAT_XSAVE_XCR0_LO] =3D 0; env->features[FEAT_XSAVE_XCR0_HI] =3D 0; + env->features[FEAT_XSAVE_XSS_LO] =3D 0; + env->features[FEAT_XSAVE_XSS_HI] =3D 0; return; } =20 --=20 2.34.1