From nobody Sat Sep 21 05:19:49 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=quicinc.com ARC-Seal: i=1; a=rsa-sha256; t=1705275977; cv=none; d=zohomail.com; s=zohoarc; b=MYIQxKJN3HCsdvMKEHw/pnSyyI7y3hwOebsGp6ucwUDkNLFEBdpILiF9IWOCD9XAJTPiZmz1Gjg22c1oSOozuVswkT4jKggYyRsh1HhOEF2nDo89NHMKy/++4Y6gP5I3Xi7HXqM4z4ApU81Ps18By77Anx9HxvNg3VBepVaHFy8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1705275977; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=g+BLs7JcrxxPDqLBfXVtiL5D26+lGpsjpTwKgc8Oo9s=; b=QlonU5eLvgNavn/E/Yh9fwgIim1OavqkO3y83QuYzSCeWUDgNWMO+5uIbEHCyto8+UtvSooIn9mCpQK3ReA6zlLq7z9AgA4Uc76gwNEdZQEN6xFS5pMT0S+mZnJYjvCR7G5l+qGaAOMqabl+paNSMs/IcZbErrTy1Or1HbXtd2A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1705275977274223.79195515171443; Sun, 14 Jan 2024 15:46:17 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rPAAF-0003X8-RL; Sun, 14 Jan 2024 18:45:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rPAAE-0003Ws-Bi for qemu-devel@nongnu.org; Sun, 14 Jan 2024 18:45:14 -0500 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rPAAC-0006ng-8q for qemu-devel@nongnu.org; Sun, 14 Jan 2024 18:45:14 -0500 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40ENUVUw023944; Sun, 14 Jan 2024 23:45:07 GMT Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3vkmjc2872-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 14 Jan 2024 23:45:07 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 40ENj6Ef019174 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 14 Jan 2024 23:45:06 GMT Received: from hu-bcain-lv.qualcomm.com (10.49.16.6) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Sun, 14 Jan 2024 15:45:05 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= from:to:cc:subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=qcppdkim1; bh=g+BLs7JcrxxPDqLBfXVt iL5D26+lGpsjpTwKgc8Oo9s=; b=ZxeigbQww9soFvhjfzFPFbsVmx+dXIl9zPEE Zyr7v78SuzxYyi224P3CYcHAUt0QNccSomRUYffzeXsvh5c+Dc69UeW4/IXehg8T UjiwrPT/TQd/FXEdsnWJ290blC6PpIAzUK5D/shtamtjDivSDi/Dgv3UCF9jbz1v Zx8asAHHUaozPWZwgzrO1yAwlMQzPArk3mnzP7K76SblpGivQ5nROosdv5xPXoGQ TdC5qbogP3023MJAGJ132k7wV4ohXz8tUA/5+XqwTa3XOBbA4rYzx6sgu3/mnK0d NllWKtpnOdnR9L+iE7h8nNjlVpFWoxKMjhC+6Fj8cmBXjOUd+g== From: Brian Cain To: CC: , , , , , , Subject: [PATCH] Reduce scope of def_regnum, remove dead assignment Date: Sun, 14 Jan 2024 15:44:53 -0800 Message-ID: <20240114234453.4114587-1-bcain@quicinc.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01b.na.qualcomm.com (10.47.209.197) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: bJJEcwDofUmrmzJ1toGUnTpEW5GDNxf7 X-Proofpoint-ORIG-GUID: bJJEcwDofUmrmzJ1toGUnTpEW5GDNxf7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-09_02,2023-12-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 bulkscore=0 suspectscore=0 phishscore=0 spamscore=0 clxscore=1015 mlxscore=0 priorityscore=1501 mlxlogscore=457 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2311290000 definitions=main-2401140186 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=bcain@quicinc.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @quicinc.com) X-ZM-MESSAGEID: 1705275978018100001 This is intended to address a coverity finding: CID 1527408. Signed-off-by: Brian Cain Reviewed-by: Matheus Tavares Bernardino --- target/hexagon/mmvec/decode_ext_mmvec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/hexagon/mmvec/decode_ext_mmvec.c b/target/hexagon/mmvec= /decode_ext_mmvec.c index 174eb3b78b..202d84c7c0 100644 --- a/target/hexagon/mmvec/decode_ext_mmvec.c +++ b/target/hexagon/mmvec/decode_ext_mmvec.c @@ -33,7 +33,6 @@ check_new_value(Packet *pkt) const char *dststr =3D NULL; uint16_t def_opcode; char letter; - int def_regnum; =20 for (i =3D 1; i < pkt->num_insns; i++) { uint16_t use_opcode =3D pkt->insn[i].opcode; @@ -78,7 +77,6 @@ check_new_value(Packet *pkt) } } if ((dststr =3D=3D NULL) && GET_ATTRIB(def_opcode, A_CVI_GATH= ER)) { - def_regnum =3D 0; pkt->insn[i].regno[use_regidx] =3D def_oreg; pkt->insn[i].new_value_producer_slot =3D pkt->insn[def_idx= ].slot; } else { @@ -86,7 +84,7 @@ check_new_value(Packet *pkt) /* still not there, we have a bad packet */ g_assert_not_reached(); } - def_regnum =3D pkt->insn[def_idx].regno[dststr - reginfo]; + int def_regnum =3D pkt->insn[def_idx].regno[dststr - regin= fo]; /* Now patch up the consumer with the register number */ pkt->insn[i].regno[use_regidx] =3D def_regnum ^ def_oreg; /* special case for (Vx,Vy) */ --=20 2.25.1