From nobody Thu Nov 14 06:53:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 170506488579078.0619173631984; Fri, 12 Jan 2024 05:08:05 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rOHD0-0004Sw-5z; Fri, 12 Jan 2024 08:04:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOHCY-0004Js-HF for qemu-devel@nongnu.org; Fri, 12 Jan 2024 08:04:02 -0500 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOHCW-0002uv-5b for qemu-devel@nongnu.org; Fri, 12 Jan 2024 08:03:58 -0500 Received: from [2a02:8012:c93d:0:260e:bf57:a4e9:8142] (helo=cheesecake.fritz.box) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rOH7C-0008jM-Rg; Fri, 12 Jan 2024 12:58:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To:Cc: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=IRWmVN7u1WyIsFFHEiosyYaiKIebFBg95VXoAT5KMFM=; b=eoTsX7NUEdHxcm7OBvkkbJEq6A zTv4bIne4UIGKusBnnEEzHOMbDQMxjMdiZHTgjjeLajQ1OcuqsJx0Nf1QtktHJ1dONEyUqPNjFF9I 8wBdMLWJuiuxfS59/7MLg22WXkveW60e/T3qRFXCxgSV5Mn/I6prbyILF+qCW2QRoT285j0JipOLf kIHb3JWzavyb5b3acUo9fz+bimNt0+EeW0lxfU5pbh2KzNB7iQHhTjGzLcg92uGrt0wuOHM3NC9WG Ib80aZb8mVFDz9pLmUpmwKiHfUo8dL+8lt70Si30oPZrbHlcuGjnB+Jppq1MqlEvEE1XNeIrs0w0V p3FhGXdTQthXARAifcbe/iQfZitLwXAvlXMXYOFXwTyPOWE1G/WqviQQxWG3uIA1Uz4WAF9EjZnZN HMCQdCIzpfPqdnHNnR44Xdf3/grVqATlcbM8+h9fGM5LeQFa6VQl7smP8tTYSgjlNrytYSVVEQve9 a6X2s2Z/1P681cvPkZKOnhDQXy2TdtJGwgDeAZotoOqXRtLdUpqkxn4PS4K6OaDSBhiaFgpzI1Jfl ky30B9IpfscexogpH1l7HMsErKYEemuDQRZrWiOMlHWwUG2UxOeji4jVzHom78peNRvspAREbRhp/ A8LSyUJuvqPQMo0Ng4YksOdzRG6ThlBx6+0gPAwNA=; From: Mark Cave-Ayland To: pbonzini@redhat.com, fam@euphon.net, hpoussin@reactos.org, laurent@vivier.eu, thuth@redhat.com, qemu-devel@nongnu.org Date: Fri, 12 Jan 2024 12:54:14 +0000 Message-Id: <20240112125420.514425-83-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240112125420.514425-1-mark.cave-ayland@ilande.co.uk> References: <20240112125420.514425-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a02:8012:c93d:0:260e:bf57:a4e9:8142 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [PATCH 82/88] esp.c: consolidate DMA and PDMA logic in STATUS and MESSAGE IN phases X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1705064886484100001 Content-Type: text/plain; charset="utf-8" This allows the removal of duplicate logic shared between the two implement= ations. Note that we restrict esp_raise_drq() to PDMA to help reduce the log verbos= ity for normal DMA. Signed-off-by: Mark Cave-Ayland --- hw/scsi/esp.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c index 8ef6d203e0..879e311bc4 100644 --- a/hw/scsi/esp.c +++ b/hw/scsi/esp.c @@ -593,12 +593,11 @@ static void esp_do_dma(ESPState *s) =20 if (s->dma_memory_write) { s->dma_memory_write(s->dma_opaque, buf, len); - esp_set_tc(s, esp_get_tc(s) - len); } else { fifo8_push_all(&s->fifo, buf, len); - esp_set_tc(s, esp_get_tc(s) - len); } =20 + esp_set_tc(s, esp_get_tc(s) - len); esp_set_phase(s, STAT_MI); =20 if (esp_get_tc(s) > 0) { @@ -629,12 +628,12 @@ static void esp_do_dma(ESPState *s) =20 if (s->dma_memory_write) { s->dma_memory_write(s->dma_opaque, buf, len); - esp_set_tc(s, esp_get_tc(s) - len); } else { fifo8_push_all(&s->fifo, buf, len); - esp_set_tc(s, esp_get_tc(s) - len); } =20 + esp_set_tc(s, esp_get_tc(s) - len); + /* Raise end of command interrupt */ s->rregs[ESP_RINTR] |=3D INTR_FC; esp_raise_irq(s); --=20 2.39.2