From nobody Sat Sep 21 07:33:40 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1705065589453728.0694295720273; Fri, 12 Jan 2024 05:19:49 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rOHBP-0006FP-OJ; Fri, 12 Jan 2024 08:02:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOHBG-0004uP-3L for qemu-devel@nongnu.org; Fri, 12 Jan 2024 08:02:38 -0500 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOHBD-00024w-UJ for qemu-devel@nongnu.org; Fri, 12 Jan 2024 08:02:37 -0500 Received: from [2a02:8012:c93d:0:260e:bf57:a4e9:8142] (helo=cheesecake.fritz.box) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rOH6v-0008jM-L1; Fri, 12 Jan 2024 12:58:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To:Cc: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=hTiBIvU/chvkJ/J+N/HUIfIavZdoB7wH/zpxm8f4Qg4=; b=ILoyHtdnUx2n6icda/tuzDmpZE wBv0z32BK5HqlD1IqDktRNW17d6N7sryFOGTPQLzRNTndBzzmPTjkhVnpvmoy0EBFnrlcaP4nsWXi 53jMknWjV9o/aOGh8BSuXEjRSjQQRcH8E1qVfP5Nctdvga8onvC3XFJhjqdltfSNUJn6337mQ8cme Bl6yyYgri2jsre4aJ/90bi4Hpy6kmrTc4py4Nh+/tJwcn+UE2I3OL1RGc3KXqIyKBKThUXa0/ye2a Kqvygh2rYfyHMErnMAk1XK3AvAp1wcdxXyaK4gW7XKzUKuuHPinN1e0wiR9BgHSmtdR89XV5tSjKy sX4a0KAV5Gc4vp2SC6jczgMFOpCFI9yM1EbLfHQD7Q7g7eTjFnhEnK1qMti+NRPDtyGQlcjjz1GcN tyx2GH3dGsDcMosHktWA75keEemCXKLu3TBH4H4fUxhJfKyRVVhlBCvL2hdL9DdeYZ3AKotbwdGnO T8tvqqrqbXZLMiafrg2/9LDw7BR5B8xHBdhUjvtiImlsyzwNGfsDZ1+NnS6xvY9TMJnwz2onjGwmy PID0aHiCfvuPfJthzmwOP4gOkKrxk7KtjH4KVUztL7qsXl4/QpBrKhArOEFS7gixvufQzqsR1ta7V SEg0QkYHr2Pcg44ItOVt/ZtxJAfKPu70fjdRc5Sho=; From: Mark Cave-Ayland To: pbonzini@redhat.com, fam@euphon.net, hpoussin@reactos.org, laurent@vivier.eu, thuth@redhat.com, qemu-devel@nongnu.org Date: Fri, 12 Jan 2024 12:54:10 +0000 Message-Id: <20240112125420.514425-79-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240112125420.514425-1-mark.cave-ayland@ilande.co.uk> References: <20240112125420.514425-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a02:8012:c93d:0:260e:bf57:a4e9:8142 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [PATCH 78/88] esp.c: consolidate DMA and PDMA logic in DATA OUT phase X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1705065589839100005 Content-Type: text/plain; charset="utf-8" This allows the removal of duplicate logic shared between the two implement= ations. Note that we restrict esp_raise_drq() to PDMA to help reduce the log verbos= ity for normal DMA. Signed-off-by: Mark Cave-Ayland --- hw/scsi/esp.c | 35 ++++++++++++----------------------- 1 file changed, 12 insertions(+), 23 deletions(-) diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c index d63039af89..394774c379 100644 --- a/hw/scsi/esp.c +++ b/hw/scsi/esp.c @@ -521,40 +521,29 @@ static void esp_do_dma(ESPState *s) if (len > s->async_len) { len =3D s->async_len; } + if (s->dma_memory_read) { s->dma_memory_read(s->dma_opaque, s->async_buf, len); - esp_set_tc(s, esp_get_tc(s) - len); - s->async_buf +=3D len; - s->async_len -=3D len; - s->ti_size +=3D len; - - if (s->async_len =3D=3D 0 && fifo8_num_used(&s->fifo) < 2) { - /* Defer until the scsi layer has completed */ - scsi_req_continue(s->current_req); - return; - } - - esp_dma_ti_check(s); } else { /* Copy FIFO data to device */ len =3D MIN(s->async_len, ESP_FIFO_SZ); len =3D MIN(len, fifo8_num_used(&s->fifo)); - n =3D esp_fifo_pop_buf(&s->fifo, s->async_buf, len); - s->async_buf +=3D n; - s->async_len -=3D n; - s->ti_size +=3D n; - + len =3D esp_fifo_pop_buf(&s->fifo, s->async_buf, len); esp_raise_drq(s); + } =20 - if (s->async_len =3D=3D 0 && fifo8_num_used(&s->fifo) < 2) { - /* Defer until the scsi layer has completed */ - scsi_req_continue(s->current_req); - return; - } + s->async_buf +=3D len; + s->async_len -=3D len; + s->ti_size +=3D len; =20 - esp_dma_ti_check(s); + if (s->async_len =3D=3D 0 && fifo8_num_used(&s->fifo) < 2) { + /* Defer until the scsi layer has completed */ + scsi_req_continue(s->current_req); + return; } + + esp_dma_ti_check(s); break; =20 case STAT_DI: --=20 2.39.2