From nobody Thu Nov 14 07:04:31 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1705053763; cv=none; d=zohomail.com; s=zohoarc; b=IGwbNU9/Zt2D4HYdbQJ8lnY9OxoFEYAULK+9my7kPrGcBy31UWpoGKSV4t5j/QQCfxPZiPAB9XO19VQtBmegMlXvGBhS25JajM8973QL44Da5gAxwHIxrTBwLKR/DUtsi5y0WTBhzssHzqhtMH6UcZVKXfZNSwgfS58v2LHaEeg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1705053763; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=t9q/1fP6B5/Fr/WdjYFW30bFD0l49qIgksjeahzvbOg=; b=WPXWh/qBlB4FyfRqlZr+PZhVKl6AgkdD3gbfy0rlp2tFPT44uwoyHjHtlKZUt8sotMJLEFgjVjBEBEPT+ELJIkdgCcK8yPE/ZzoOuZGG3dGQsglajFmjhuKz/oCKXhZi6cR5rnNxi/gfgj55juHspJ1Zc3eQytto1Nl+1tMizKI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1705053763483109.7173701112896; Fri, 12 Jan 2024 02:02:43 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rOEM4-0004EF-T5; Fri, 12 Jan 2024 05:01:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOELj-00048H-OS for qemu-devel@nongnu.org; Fri, 12 Jan 2024 05:01:17 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOELh-0005gf-Aj for qemu-devel@nongnu.org; Fri, 12 Jan 2024 05:01:14 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-537-P3uL-XnLOgq6ord1A2R58A-1; Fri, 12 Jan 2024 05:01:10 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0CBC485A588; Fri, 12 Jan 2024 10:01:10 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.194.216]) by smtp.corp.redhat.com (Postfix) with ESMTP id 39DCBC08ED4; Fri, 12 Jan 2024 10:01:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705053672; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t9q/1fP6B5/Fr/WdjYFW30bFD0l49qIgksjeahzvbOg=; b=A65NK20UHr7H55vlfeLH8rZcJAbslVQE0EJ14j1hPG/wNs722qTbXsgdNZIfvWtNi3qb4g IMhv9JF1S0VArIpwuihAVHuHuc9jeGVJ1cHmMZrtQEPNn0XbL9veFagHVRvQ5HsN5Wbz0O QC2leOZZVLU4xMG1jafOnqKIw/BWwnM= X-MC-Unique: P3uL-XnLOgq6ord1A2R58A-1 From: Thomas Huth To: qemu-devel@nongnu.org, Paolo Bonzini Cc: Markus Armbruster , qemu-trivial@nongnu.org, =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Claudio Imbrenda Subject: [PATCH 4/5] qemu-options: Remove the deprecated -chroot option Date: Fri, 12 Jan 2024 11:00:58 +0100 Message-ID: <20240112100059.965041-5-thuth@redhat.com> In-Reply-To: <20240112100059.965041-1-thuth@redhat.com> References: <20240112100059.965041-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -45 X-Spam_score: -4.6 X-Spam_bar: ---- X-Spam_report: (-4.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.467, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1705053765147100005 Content-Type: text/plain; charset="utf-8" It's been marked as deprecated since QEMU 8.1, so it should be fine to remove this now. Signed-off-by: Thomas Huth Reviewed-by: Markus Armbruster --- docs/about/deprecated.rst | 5 ----- docs/about/removed-features.rst | 5 +++++ system/vl.c | 5 ----- qemu-options.hx | 12 ------------ 4 files changed, 5 insertions(+), 22 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 80eacd40ba..b50cfe596b 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -63,11 +63,6 @@ as short-form boolean values, and passed to plugins as `= `arg_name=3Don``. However, short-form booleans are deprecated and full explicit ``arg_name= =3Don`` form is preferred. =20 -``-chroot`` (since 8.1) -''''''''''''''''''''''' - -Use ``-run-with chroot=3Ddir`` instead. - ``-singlestep`` (since 8.1) ''''''''''''''''''''''''''' =20 diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.= rst index 43f64a26ba..a8546f4787 100644 --- a/docs/about/removed-features.rst +++ b/docs/about/removed-features.rst @@ -477,6 +477,11 @@ Use ``-machine acpi=3Doff`` instead. =20 Use ``-run-with async-teardown=3Don`` instead. =20 +``-chroot`` (removed in 9.0) +'''''''''''''''''''''''''''' + +Use ``-run-with chroot=3Ddir`` instead. + =20 QEMU Machine Protocol (QMP) commands ------------------------------------ diff --git a/system/vl.c b/system/vl.c index 924356f864..c125fb9079 100644 --- a/system/vl.c +++ b/system/vl.c @@ -3592,11 +3592,6 @@ void qemu_init(int argc, char **argv) exit(1); } break; - case QEMU_OPTION_chroot: - warn_report("option is deprecated," - " use '-run-with chroot=3D...' instead"); - os_set_chroot(optarg); - break; case QEMU_OPTION_daemonize: os_set_daemonize(true); break; diff --git a/qemu-options.hx b/qemu-options.hx index 10c952ba3f..9be6beb5a0 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -4790,18 +4790,6 @@ SRST ``-nodefaults`` option will disable all those default devices. ERST =20 -#ifndef _WIN32 -DEF("chroot", HAS_ARG, QEMU_OPTION_chroot, \ - "-chroot dir chroot to dir just before starting the VM (deprecated= )\n", - QEMU_ARCH_ALL) -#endif -SRST -``-chroot dir`` - Deprecated, use '-run-with chroot=3D...' instead. - Immediately before starting guest execution, chroot to the specified - directory. Especially useful in combination with -runas. -ERST - #ifndef _WIN32 DEF("runas", HAS_ARG, QEMU_OPTION_runas, \ "-runas user change to user id user just before starting the VM\n"= \ --=20 2.43.0