From nobody Sat Sep 21 05:38:50 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1705036722; cv=none; d=zohomail.com; s=zohoarc; b=oCZV8CGC1fBGvM13XodsQ4bXJ1Q7EQqj5oGZNWqAtGLZcUDmkS5BtHRc3nhANgEWCxq+hNNFfUA7eIQnI4Yt5un7F9Zi6Brax79j5vOI7TRgFDujGDCAW5v4xhkKpZl34Uo7/29EnwmQOXMb0bIscnMkFvbGP8oYaPzo9Y0Dth0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1705036722; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=yhEpTAOIOGxwApEuyOerzPJ+/tZaLW87qz6BfwQ4wJ0=; b=Har1/DGSuWnamldlZyd3I2ZcEnbgw6KiKaMKE/dm19OwI8SGQqDAERZw4p5UkybcR4w5Qn+atDCmWTEAk2ZzE8volNrHMIH8NvbUbC00ogvCmgB5xP6HTW7eaXv3n70V8V8nRY8ogoLvssHCAB8MG7K7DsdDJ9fLsiiHOubbwTs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1705036722312677.9992577846411; Thu, 11 Jan 2024 21:18:42 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rO9ve-0004Qh-SY; Fri, 12 Jan 2024 00:18:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rO9va-0004QF-Ip for qemu-devel@nongnu.org; Fri, 12 Jan 2024 00:17:58 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rO9vY-0003Eb-G5 for qemu-devel@nongnu.org; Fri, 12 Jan 2024 00:17:57 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-518-xjrp215uNAeX2zj9vAuhiw-1; Fri, 12 Jan 2024 00:17:51 -0500 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0F7C5830E5C; Fri, 12 Jan 2024 05:17:51 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.192.58]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9C79C492BC6; Fri, 12 Jan 2024 05:17:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705036675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=yhEpTAOIOGxwApEuyOerzPJ+/tZaLW87qz6BfwQ4wJ0=; b=JJOrGyZZqq4rojAgCCACapq35ZJjbi7FxWE07PMvDUixeWGPupa3aqgP1xVUIRLWJGExBl nMlptl0fSD1KlbbKW6pHBNKrLE19p7fZGdECd+FlzgVUl79M9VcgRia9BfF5lzag5SUD77 6r3wzvuY4FbmnzYf6wgLgrBFu3UgVkk= X-MC-Unique: xjrp215uNAeX2zj9vAuhiw-1 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Paolo Bonzini , qemu-trivial@nongnu.org, Thomas Huth Subject: [PATCH] util/uri: Remove is_hex() function Date: Fri, 12 Jan 2024 06:17:40 +0100 Message-ID: <20240112051740.926658-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -45 X-Spam_score: -4.6 X-Spam_bar: ---- X-Spam_report: (-4.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.467, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1705036722579100003 Content-Type: text/plain; charset="utf-8" We can simply use the g_ascii_isxdigit() from the glib instead. Signed-off-by: Thomas Huth --- util/uri.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/util/uri.c b/util/uri.c index dcb3305236..7411c5ba14 100644 --- a/util/uri.c +++ b/util/uri.c @@ -1561,15 +1561,6 @@ done_cd: return 0; } =20 -static int is_hex(char c) -{ - if (((c >=3D '0') && (c <=3D '9')) || ((c >=3D 'a') && (c <=3D 'f')) || - ((c >=3D 'A') && (c <=3D 'F'))) { - return 1; - } - return 0; -} - /** * uri_string_unescape: * @str: the string to unescape @@ -1607,7 +1598,7 @@ char *uri_string_unescape(const char *str, int len, c= har *target) in =3D str; out =3D ret; while (len > 0) { - if ((len > 2) && (*in =3D=3D '%') && (is_hex(in[1])) && (is_hex(in= [2]))) { + if (len > 2 && *in =3D=3D '%' && g_ascii_isxdigit(in[1]) && g_asci= i_isxdigit(in[2])) { in++; if ((*in >=3D '0') && (*in <=3D '9')) { *out =3D (*in - '0'); --=20 2.43.0