From nobody Tue Nov 26 22:12:48 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1704633905; cv=none; d=zohomail.com; s=zohoarc; b=Uv9E6DJTOePXSo5/KtStfDwImzhLf4MwzTNZlMR1rc9p7+XLVvj6e9tvjFId0W7kYXO2X8FZh4A3+Y78ZMUhmtAmKfgn5iQjfivGgGQ362pN9zdjurOgEZexBHuBUFfzVd6B+yrG1d4vl0a6f8KTudl3nmImaM7P6GxEge3tDnc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1704633905; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=bgLWp3MJMYxxBp/+fK07fyD+Yhjndfd4cpHzKOSrMaE=; b=HzFG8uMycwfQyowrUBUOtYl2+MI5ESXuytY0P6jLyWjpJ3CrYNnXkmtuLhFVlCKhPvLQAGdVzD3tLpSCcUR/FzqvsAFHdcPt/otzr9jv6wzcsMrOUJPi4R+r5p73rrOGwumjxWi8pEhRrr4q3VmrB9GC24qp9FwrjBAJKUJA+oI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1704633905327716.7512956218831; Sun, 7 Jan 2024 05:25:05 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rMT7e-0006S3-1V; Sun, 07 Jan 2024 08:23:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMT7I-0006L0-2C for qemu-devel@nongnu.org; Sun, 07 Jan 2024 08:23:05 -0500 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMT7F-0003Lt-Nu for qemu-devel@nongnu.org; Sun, 07 Jan 2024 08:23:03 -0500 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 3E006CE098A; Sun, 7 Jan 2024 13:22:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EDE43C433C7; Sun, 7 Jan 2024 13:22:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704633777; bh=aBgCGCkIpFK/yMSnSEqSZ/aCgv/Nk3BedkbPafVsmYI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g+PKJaIlgJ7WMNtFaki2Dbt72B9LnYCXkAAOLTphAMMqQu2CBClJWtdlLVoO3EZfl UiFYM40Ux6NCh+awCnvKO90Cj6NKJRgqcNAHiiQdRAi2bdLXJ6HoPHDnRjxPf/mO/x jeB8Hs6iU7Gbs9LGUlqna7XFdkjoIUbGVLJgaFosFmFQgCfJmC0freAikDYpNGDMuR vN4mkAjXpVlaQNr5f6grSBUnbZsT2olGZSX9sPC5/4gvRhsvTPFjANBDG7atmNY6oC mNW+KyblPrkLEtdrr6/t028YUMkZAX4ObWfqzCXEcgnoYqYaZ4Sr88xtXWnLeVYteI IFa3WlmuoQZUg== From: deller@kernel.org To: qemu-devel@nongnu.org Cc: Richard Henderson , Michael Tokarev , Bruno Haible , "Nelson H . F . Beebe" , Helge Deller Subject: [PATCH v2 8/9] target/hppa: Avoid accessing %gr0 when raising exception Date: Sun, 7 Jan 2024 14:22:36 +0100 Message-ID: <20240107132237.50553-9-deller@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240107132237.50553-1-deller@kernel.org> References: <20240107132237.50553-1-deller@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2604:1380:40e1:4800::1; envelope-from=deller@kernel.org; helo=sin.source.kernel.org X-Spam_score_int: -64 X-Spam_score: -6.5 X-Spam_bar: ------ X-Spam_report: (-6.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.098, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @kernel.org) X-ZM-MESSAGEID: 1704633906918100001 Content-Type: text/plain; charset="utf-8" From: Helge Deller The value of unwind_breg may reference register %r0, but we need to avoid accessing gr0 directly and use the value 0 instead. At runtime I've seen unwind_breg being zero with the Linux kernel when rfi is used to jump to smp_callin(). Signed-off-by: Helge Deller Reviewed-by: Richard Henderson --- target/hppa/mem_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hppa/mem_helper.c b/target/hppa/mem_helper.c index 011b192406..42bd0063c0 100644 --- a/target/hppa/mem_helper.c +++ b/target/hppa/mem_helper.c @@ -335,7 +335,7 @@ raise_exception_with_ior(CPUHPPAState *env, int excp, u= intptr_t retaddr, =20 cpu_restore_state(cs, retaddr); =20 - b =3D env->gr[env->unwind_breg]; + b =3D env->unwind_breg ? env->gr[env->unwind_breg] : 0; b >>=3D (env->psw & PSW_W ? 62 : 30); env->cr[CR_IOR] |=3D b << 62; =20 --=20 2.43.0