From nobody Tue Nov 26 22:31:32 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1704393462; cv=none; d=zohomail.com; s=zohoarc; b=JnR070Up1YbgEwPingEfp7bVmc+ihW9B4UOjT1b3CGZeW6XMQbAj6IpHHkildVwlg0MhJExjLd0uUo6/+Cmo/gAB3b+a2e17eDLrU6hd6cOshQNHHI8/LtKDGv3rMvdCT/xoyVxf05uJ9NMXPPy0baItlwDX33IWiEaFrerZwHE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1704393462; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=bgLWp3MJMYxxBp/+fK07fyD+Yhjndfd4cpHzKOSrMaE=; b=j7ltlMXlrv78/L72YKXvwgfvBwxov5EHcDBZMhIthTQeOfHydeQeqAYsRXmGPwrvvlAeSoiOoaIk7YWhsi78lOGouyjOfD44xwe/312ywLIdEuuI7M+w7hhIX6D80bdv880TTDEM03sBENg5TEeJ3YJM0uE1trjtiFJ5sly3M7s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1704393462406156.7297514806496; Thu, 4 Jan 2024 10:37:42 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rLSaM-0001Se-DH; Thu, 04 Jan 2024 13:36:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLSaK-0001SR-TW for qemu-devel@nongnu.org; Thu, 04 Jan 2024 13:36:52 -0500 Received: from sin.source.kernel.org ([145.40.73.55]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLSaJ-0005H1-B8 for qemu-devel@nongnu.org; Thu, 04 Jan 2024 13:36:52 -0500 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 67DDCCE1A93; Thu, 4 Jan 2024 18:36:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D646C433C7; Thu, 4 Jan 2024 18:36:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704393407; bh=aBgCGCkIpFK/yMSnSEqSZ/aCgv/Nk3BedkbPafVsmYI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ugx8B6xw3kBY0o4Wopo2c+78GT6m29BXBa/KGFvIQI0Lkz1Tuxwc9koHaNtXqXB7P H/FRmDX+gsHGbFKWRz4ScEiCZZ+mQbDc8GVGLO59Xr4xcuHzOt4K5bPSOtjhOihvpa DO4TrnOZXfOvxec0DlBBydJ6Q50On9HnpqIGhuqzY0Wgt0II7uw0xmmKQk4RY0Bbmr PF8DDj9hP4z2PxN/W2v0Y6qXYX5hScP192moA4Neznw06A61UoYnC12KkntdWP++XU YeQ657v9XEoRkdOpDjSwo0g1iKeFIO75YClg2S2p+2q0h4SoW5DnBwBVvZ/Se3zk8b Wm5ANW2RWxuCw== From: deller@kernel.org To: qemu-devel@nongnu.org Cc: Michael Tokarev , Bruno Haible , Richard Henderson , "Nelson H . F . Beebe" , Helge Deller Subject: [PATCH 8/9] target/hppa: Avoid accessing %gr0 when raising exception Date: Thu, 4 Jan 2024 19:36:27 +0100 Message-ID: <20240104183628.101366-9-deller@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240104183628.101366-1-deller@kernel.org> References: <20240104183628.101366-1-deller@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=145.40.73.55; envelope-from=deller@kernel.org; helo=sin.source.kernel.org X-Spam_score_int: -70 X-Spam_score: -7.1 X-Spam_bar: ------- X-Spam_report: (-7.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.691, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @kernel.org) X-ZM-MESSAGEID: 1704393464592100001 Content-Type: text/plain; charset="utf-8" From: Helge Deller The value of unwind_breg may reference register %r0, but we need to avoid accessing gr0 directly and use the value 0 instead. At runtime I've seen unwind_breg being zero with the Linux kernel when rfi is used to jump to smp_callin(). Signed-off-by: Helge Deller --- target/hppa/mem_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hppa/mem_helper.c b/target/hppa/mem_helper.c index 011b192406..42bd0063c0 100644 --- a/target/hppa/mem_helper.c +++ b/target/hppa/mem_helper.c @@ -335,7 +335,7 @@ raise_exception_with_ior(CPUHPPAState *env, int excp, u= intptr_t retaddr, =20 cpu_restore_state(cs, retaddr); =20 - b =3D env->gr[env->unwind_breg]; + b =3D env->unwind_breg ? env->gr[env->unwind_breg] : 0; b >>=3D (env->psw & PSW_W ? 62 : 30); env->cr[CR_IOR] |=3D b << 62; =20 --=20 2.43.0