From nobody Tue Nov 26 22:24:59 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1703237971; cv=none; d=zohomail.com; s=zohoarc; b=FG3RPHOxvYKrOrCR/7M2ZmgZDWmZDwlDt+Aiv3oMNmTYBmpd2ICSigylj+p0yMSpKBdwf1AfB40BLgKJod9N4oMZZRibY22tv33XwxzB+R9XCJ/g3qLT5fq1ZhlMvQBF+xDkk7GFvTJH7U0Kh8+/3SfJl6OjJj04P8SltoKdVuY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1703237971; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/NPXkc+ZqVZCNO6BnvmDKBzJhiCBAoVEp/+ZmXA8Bys=; b=MgwLQGOjeey7O0eC/b24tQLlquoldDNVl3m2a5eMxwZ8/UeGYpKtvpmRnP4ZnFySVEiGUGcvPi8SimhbBPwVIXZO/2eJ96KCZTCX2MRRusiZIPD4nC2DdRLKAIlE/zqSIMAMrgYTQEUXrE/n9VuVy0wuocfZjxDqJszaD2IR5Xo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1703237971532889.8655333278558; Fri, 22 Dec 2023 01:39:31 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rGbzZ-0000Be-U5; Fri, 22 Dec 2023 04:38:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rGbzQ-0000B5-Fy for qemu-devel@nongnu.org; Fri, 22 Dec 2023 04:38:44 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rGbzE-00078E-A1 for qemu-devel@nongnu.org; Fri, 22 Dec 2023 04:38:44 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-685-sLwDubhoPkCgY0cSv5h_Pw-1; Fri, 22 Dec 2023 04:38:29 -0500 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B984087B2A0; Fri, 22 Dec 2023 09:38:28 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.129]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 97DC7492BC6; Fri, 22 Dec 2023 09:38:28 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 7B85B21E6925; Fri, 22 Dec 2023 10:38:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703237910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/NPXkc+ZqVZCNO6BnvmDKBzJhiCBAoVEp/+ZmXA8Bys=; b=eq5avBbes5dysPuuDnjtWGNERs+3Fza5I8dGRC7C+tFOKaxdB1IWMiOTxwaaJPZo+VfUNx W4IStPM5GEdD01BaKO+PfHPZGJco6+AnvFy2zL4ojyf3IfCh8jcfUIKESEUjBVJLjp1UAp 10K2IPOHOY0G2AJdqzhvAV/KxDGzEek= X-MC-Unique: sLwDubhoPkCgY0cSv5h_Pw-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: Stephen Brennan , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH v2 1/1] dump: Fix HMP dump-guest-memory -z without -R Date: Fri, 22 Dec 2023 10:38:27 +0100 Message-ID: <20231222093827.951039-2-armbru@redhat.com> In-Reply-To: <20231222093827.951039-1-armbru@redhat.com> References: <20231222093827.951039-1-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.061, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1703237971816100001 -z without -R has no effect: the dump format remains @elf. Fix the logic error so it becomes @kdump-zlib. Fixes: e6549197f7ed (dump: Add command interface for kdump-raw formats) Fixes: CID 1523841 Signed-off-by: Markus Armbruster Reviewed-by: Stephen Brennan Reviewed-by: Marc-Andr=C3=A9 Lureau --- dump/dump-hmp-cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dump/dump-hmp-cmds.c b/dump/dump-hmp-cmds.c index b428ec33df..d9340427c3 100644 --- a/dump/dump-hmp-cmds.c +++ b/dump/dump-hmp-cmds.c @@ -41,7 +41,7 @@ void hmp_dump_guest_memory(Monitor *mon, const QDict *qdi= ct) dump_format =3D DUMP_GUEST_MEMORY_FORMAT_WIN_DMP; } =20 - if (zlib && raw) { + if (zlib) { if (raw) { dump_format =3D DUMP_GUEST_MEMORY_FORMAT_KDUMP_RAW_ZLIB; } else { --=20 2.43.0