From nobody Wed Nov 27 00:49:05 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1703179259; cv=none; d=zohomail.com; s=zohoarc; b=f6U4ebY9gkRUrCEGmPKxul79err3ifM1smszlSCUapvr8IEgjkau8sdaXijlwpJEDqC8IQqkEk4zG6tpOuvAjdXldGbzCrWoNAjFyEaAJIDLJyJStHSHSUCZu0ZAOT25yD7Kkf4FqmiocwStY23YXJM82xaxM/Up9OY0rI/iKfU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1703179259; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=7KHsaL4UQVL7EB67oxOli3jIm09+5F03qAdq+7G5z8A=; b=c8DdHqJoLBFWk70YnPTlNmmIBNd72n5In5rd7/Gk+vcOvxG1sMBRSHnLqRIozzVwPkZb7rBj3+P3Il8lzxOeDrp95mxM5CTufvvIn07NM+Kzvi6+5sZKOttpvwAC4GaH0eXBU5EVgTFwZpRMCFYYjHL2CeItRqbIZYWo0Zwv+VY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1703179259302481.7683897344034; Thu, 21 Dec 2023 09:20:59 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rGMiW-0007WU-Sa; Thu, 21 Dec 2023 12:20:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rGMiT-0007W3-3e for qemu-devel@nongnu.org; Thu, 21 Dec 2023 12:20:13 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rGMiQ-0004Sh-CZ for qemu-devel@nongnu.org; Thu, 21 Dec 2023 12:20:12 -0500 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-397-qHULxM2mPBu4aY2SN65ZFA-1; Thu, 21 Dec 2023 12:20:08 -0500 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-40d39a425bbso7559455e9.3 for ; Thu, 21 Dec 2023 09:20:07 -0800 (PST) Received: from [192.168.10.118] ([2001:b07:6468:f312:4783:a68:c1ee:15c5]) by smtp.gmail.com with ESMTPSA id b6-20020adfee86000000b00336344c3c3fsm2448885wro.90.2023.12.21.09.20.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 09:20:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703179209; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7KHsaL4UQVL7EB67oxOli3jIm09+5F03qAdq+7G5z8A=; b=gpLLUEzN0/QBqmeyC5URdXay15y6m26kFt4PLmPyR5q+6fMx0QKa19QYsI+RlIoKpDsyse iOhqdiCkXRWitZ2LNnN7/U28Lc4bOGo83P/zt/JW6BboD6dnxWz2LApX0DYGU0xL0UOSVK azVDg1qWBqr5ZcNqeQMRNcYrPqHDqeY= X-MC-Unique: qHULxM2mPBu4aY2SN65ZFA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703179206; x=1703784006; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7KHsaL4UQVL7EB67oxOli3jIm09+5F03qAdq+7G5z8A=; b=uQQyNy8KswTaFshf5Y84+NkLRzRwhbKw6zv5gnWadt56hsxPtbZHPnOsxNVHQ6u/1V btTNjrvuj/qQZ5/P+O6PolIf4Dv9KxtAdJD3GNYETl9qp99c3koZlXoS8IJ+muG7ZJ3P BHzPUdT21YJxLudd+Ad8nawy+Vfl9rxdsYdZtmkJZPwWu1cGhWAP0om87yzadkGy64Vy QE2WfepWyXsi9zuu5Hp6Fz6gVhDx9dw+Zm0WJ/m7OSC3QKQEiAJ6w7fSVg/tcI1vzk60 t7JohfI4P4EvBF2VIb+1FwuDb9h3JWCrD2v5uAYFm8eUyEXJPt6PQZI29XerRa8gM6ur I9QA== X-Gm-Message-State: AOJu0YxzDUkNozhaiHywtKjWWPIZLuEnY3afXMfupMlD2CvWF1VO+Q7l XKnGKywSg8SpgknenMzBEeZqUOjSwZU39Bo5I35xnK3Q/ulQ0tATKyfsThtBrha9SBPuN2IQHHs INUBYVLgVKuzyJ8xMUtG6e+U+LSekCGOnXxYo2n6YlyVcaW6S7DaRWOl8+x8RvXoWQeyRupjQB9 s0hWPSVoY= X-Received: by 2002:a7b:c3c6:0:b0:40d:3c5d:b2e3 with SMTP id t6-20020a7bc3c6000000b0040d3c5db2e3mr42271wmj.81.1703179206212; Thu, 21 Dec 2023 09:20:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IFgRCM8MSsEZYKAuSpXQ5DEHlq5cOxLBFTe/7kgCyBhh1v8yzD64apT6H/xmCeCJCrH5BS/Ew== X-Received: by 2002:a7b:c3c6:0:b0:40d:3c5d:b2e3 with SMTP id t6-20020a7bc3c6000000b0040d3c5db2e3mr42268wmj.81.1703179205801; Thu, 21 Dec 2023 09:20:05 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PATCH 03/21] meson: use version_compare() to compare version Date: Thu, 21 Dec 2023 18:19:40 +0100 Message-ID: <20231221171958.59350-4-pbonzini@redhat.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231221171958.59350-1-pbonzini@redhat.com> References: <20231221171958.59350-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.061, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1703179261671100003 Content-Type: text/plain; charset="utf-8" While a simple lexicographic comparison usually works, it is less robust than a more specific algorithm designed to compare versions. Signed-off-by: Paolo Bonzini --- qga/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/meson.build b/qga/meson.build index ff7a8496e48..a6af614891a 100644 --- a/qga/meson.build +++ b/qga/meson.build @@ -140,7 +140,7 @@ if targetos =3D=3D 'windows' qemu_ga_msi_vss =3D ['-D', 'InstallVss'] deps +=3D qga_vss endif - if glib.version() < '2.73.2' + if glib.version().version_compare('<2.73.2') libpcre =3D 'libpcre1' else libpcre =3D 'libpcre2' --=20 2.43.0