From nobody Wed Nov 19 19:59:57 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=rfc1149.net Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 170259672451379.88015504044893; Thu, 14 Dec 2023 15:32:04 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rDvAZ-0007NN-Q8; Thu, 14 Dec 2023 18:31:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rDvAW-0007Mo-ED for qemu-devel@nongnu.org; Thu, 14 Dec 2023 18:31:04 -0500 Received: from zoidberg.rfc1149.net ([195.154.227.159]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rDvAR-0005kL-Hw for qemu-devel@nongnu.org; Thu, 14 Dec 2023 18:31:04 -0500 Received: from buffy.. (buffy [192.168.147.6]) by zoidberg.rfc1149.net (Postfix) with ESMTP id 6728F80027; Fri, 15 Dec 2023 00:30:56 +0100 (CET) Authentication-Results: zoidberg.rfc1149.net; dmarc=fail (p=none dis=none) header.from=rfc1149.net Authentication-Results: zoidberg.rfc1149.net; spf=fail smtp.mailfrom=rfc1149.net From: Samuel Tardieu To: qemu-devel@nongnu.org Cc: Richard Henderson , Samuel Tardieu Subject: [PATCH 2/2] tcg: Jump after always false condition Date: Fri, 15 Dec 2023 00:30:55 +0100 Message-ID: <20231214233055.2505387-3-sam@rfc1149.net> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231214233055.2505387-1-sam@rfc1149.net> References: <20231214233055.2505387-1-sam@rfc1149.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.154.227.159; envelope-from=sam@rfc1149.net; helo=zoidberg.rfc1149.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1702596725654100001 Content-Type: text/plain; charset="utf-8" `buf_rw` is always `NULL` when jumping to the `fail` label. Move the label `down` after the `if (buf_rw) { ... }` statement. Signed-off-by: Samuel Tardieu --- tcg/region.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/region.c b/tcg/region.c index 6d657e8c33..691a726eae 100644 --- a/tcg/region.c +++ b/tcg/region.c @@ -596,10 +596,10 @@ static int alloc_code_gen_buffer_splitwx_memfd(size_t= size, Error **errp) =20 fail_rx: error_setg_errno(errp, errno, "failed to map shared memory for execute= "); - fail: if (buf_rw) { munmap(buf_rw, size); } + fail: if (fd >=3D 0) { close(fd); } --=20 2.42.0