From nobody Wed Nov 19 18:41:58 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=swemel.ru ARC-Seal: i=1; a=rsa-sha256; t=1702455525; cv=none; d=zohomail.com; s=zohoarc; b=Q/p/pra3vHwNSL01jieH+PSEC4IFqhrKGa/RApbRt2n9RCR9WNcWxA7dbGssUITrioCbicX0izEsttoIv1jq3ArO+Qi++jkngBLlFkpKnaCtWVWuynMjwzck2GAZBzAAC4taUkZcfN/yrk0oBoTl7YsvNp/5HGAy515uAvN0Xig= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702455525; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0zz4oKmZxD1+h18f+jPpxrATc/T6UK1uMXVCIRtb9Ag=; b=HvesuyyaoEvLvXh2LOUis6Ev1X5VVPA6VPBsWiA0DszgSD6L4f6Z9AIw6EaclLVKL/+THWlLW6X5j07h9jmpJStZi2ToGy7plj9GJJaPizAVbPvZPxgmx4xofwiJ5M5DYfHvRVflwG4q4+9DMYHgESlneasp9eydKmW4YWfDmeY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1702455525229207.9921654229977; Wed, 13 Dec 2023 00:18:45 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rDKRM-0007VR-Lx; Wed, 13 Dec 2023 03:18:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rDKRK-0007VA-3c for qemu-devel@nongnu.org; Wed, 13 Dec 2023 03:17:58 -0500 Received: from mx.swemel.ru ([95.143.211.150]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rDKRH-000129-Er for qemu-devel@nongnu.org; Wed, 13 Dec 2023 03:17:57 -0500 From: Dmitry Frolov DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=swemel.ru; s=mail; t=1702455471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=0zz4oKmZxD1+h18f+jPpxrATc/T6UK1uMXVCIRtb9Ag=; b=IFfwADUf7URB2rsAMOOwaVftEymfegf9TULH6HNVZ82Zy0VRNJsuXp5hDdJ5Tj9BBbNok0 ndnfQrC/gJoyTIyNpuocy+SnSaR/nAgJOyl+9K9w7fYeHfTEgNIykvOpAsAlCR244b+QPk CH2mN8+snemgPelj2ZpL5uBoo9eBjKo= To: mst@redhat.com Cc: sdl.qemu@linuxtesting.org, qemu-devel@nongnu.org, Dmitry Frolov Subject: [PATCH] hw/virtio: remove meaningless NULL-check Date: Wed, 13 Dec 2023 11:15:46 +0300 Message-Id: <20231213081544.1064630-1-frolov@swemel.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=95.143.211.150; envelope-from=frolov@swemel.ru; helo=mx.swemel.ru X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @swemel.ru) X-ZM-MESSAGEID: 1702455530712100002 Content-Type: text/plain; charset="utf-8" vdev is being dereferenced in the first line of the function. The following NULL-check makes no sense. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Dmitry Frolov --- hw/virtio/virtio-bus.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/virtio/virtio-bus.c b/hw/virtio/virtio-bus.c index 896feb37a1..0436f545b8 100644 --- a/hw/virtio/virtio-bus.c +++ b/hw/virtio/virtio-bus.c @@ -119,10 +119,8 @@ void virtio_bus_device_unplugged(VirtIODevice *vdev) =20 DPRINTF("%s: remove device.\n", qbus->name); =20 - if (vdev !=3D NULL) { - if (klass->device_unplugged !=3D NULL) { - klass->device_unplugged(qbus->parent); - } + if (klass->device_unplugged !=3D NULL) { + klass->device_unplugged(qbus->parent); } } =20 --=20 2.34.1