From nobody Wed Nov 19 18:52:52 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1702324722; cv=none; d=zohomail.com; s=zohoarc; b=bNqW+TnWhNFnLSvUWIJeeGT0XXJ2hRnSw2CDFXgwELkgejetMioTaeHT5gbk7hVHIdvjEJJl6LwrGMvP7i8oW9nMtfS1yCLF6DP0xxYCnyIBiq5neKgKLGpxPjM/43ucFAVU2pAOREHqtP+bW/MGawbJxZG+ZOw3Tp+AWDI4K9Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702324722; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lp7K3n/7c/f1iC1ve5tU7YX2KfBbu0xvJng0LTVTzpg=; b=m1nM1dcYnoQPexyOdmZQOuBnyNTz9FG1/I7t3w7wEqbv1TLmc7AsdXis7kxrLATkdnPV75IADmSdESJI+FmD6hAb2Vq16DdGmp09OOZqlLPVmCDLMRfuiBVNPYCAb2l9BOMUxps2eWWL9xTtCxkxQCra43pZDv3LMRoBvT17tdM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1702324722516667.2357472089235; Mon, 11 Dec 2023 11:58:42 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rCmPc-0003re-Kz; Mon, 11 Dec 2023 14:57:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCmPY-0003r7-JK for qemu-devel@nongnu.org; Mon, 11 Dec 2023 14:57:53 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCmPV-0005BF-MR for qemu-devel@nongnu.org; Mon, 11 Dec 2023 14:57:52 -0500 Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-479-aGxrM2baOrGOI0MbRrAZ-Q-1; Mon, 11 Dec 2023 14:57:37 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1D71A2999B2B; Mon, 11 Dec 2023 19:57:37 +0000 (UTC) Received: from localhost (unknown [10.39.193.189]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9F2F63C25; Mon, 11 Dec 2023 19:57:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702324660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=lp7K3n/7c/f1iC1ve5tU7YX2KfBbu0xvJng0LTVTzpg=; b=Zoveth1seu0pfdX7mH7iPfR0ns0RAiDnQbxN0NhvtWbMZzRd+40xY63/evfPU2RAJ0I+/a wFyCTc4o0xIU+MZYj5SW93RVSAbB2YHKH1Z2GVeAUmnbVPuOn7sN+QO2FcuWd7yGbPxSrB /nPnFnDHKEIBPubya+uGOqirF7fjOiA= X-MC-Unique: aGxrM2baOrGOI0MbRrAZ-Q-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org, armbru@redhat.com Cc: Michael Roth , Stefan Hajnoczi Subject: [RFC] string-output-visitor: show structs as "" Date: Mon, 11 Dec 2023 14:57:34 -0500 Message-ID: <20231211195734.425040-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1702324723734100001 Content-Type: text/plain; charset="utf-8" StringOutputVisitor crashes when it visits a struct because ->start_struct() is NULL. Show "" instead of crashing. This is necessary because the virtio-blk-pci iothread-vq-mapping parameter that I'd like to introduce soon is a list of IOThreadMapping structs. Cc: Markus Armbruster Signed-off-by: Stefan Hajnoczi --- Can we do better? I am unfamiliar with StringOutputVisitor, so I wasn't sure how to proceed. Is the format or at least the intended use of StringOutputVisitor's output defined somewhere? Does it need to be a single line or can the output be multiple lines? Or maybe I shouldn't introduce a qdev property with IOThreadMappingList as its type in https://lore.kernel.org/qemu-devel/ZUoPiFxIIwFq5wMg@redhat.com/? --- include/qapi/string-output-visitor.h | 6 +++--- qapi/string-output-visitor.c | 14 ++++++++++++++ 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/include/qapi/string-output-visitor.h b/include/qapi/string-out= put-visitor.h index 268dfe9986..762fe3f705 100644 --- a/include/qapi/string-output-visitor.h +++ b/include/qapi/string-output-visitor.h @@ -26,9 +26,9 @@ typedef struct StringOutputVisitor StringOutputVisitor; * If everything else succeeds, pass @result to visit_complete() to * collect the result of the visit. * - * The string output visitor does not implement support for visiting - * QAPI structs, alternates, null, or arbitrary QTypes. It also - * requires a non-null list argument to visit_start_list(). + * The string output visitor does not implement support for alternates, nu= ll, + * or arbitrary QTypes. It also requires a non-null list argument to + * visit_start_list(). */ Visitor *string_output_visitor_new(bool human, char **result); =20 diff --git a/qapi/string-output-visitor.c b/qapi/string-output-visitor.c index c0cb72dbe4..363dac00fe 100644 --- a/qapi/string-output-visitor.c +++ b/qapi/string-output-visitor.c @@ -292,6 +292,18 @@ static bool print_type_null(Visitor *v, const char *na= me, QNull **obj, return true; } =20 +static bool start_struct(Visitor *v, const char *name, void **obj, + size_t size, Error **errp) +{ + return true; +} + +static void end_struct(Visitor *v, void **obj) +{ + StringOutputVisitor *sov =3D to_sov(v); + string_output_set(sov, g_strdup("")); +} + static bool start_list(Visitor *v, const char *name, GenericList **list, size_t size, Error **errp) @@ -379,6 +391,8 @@ Visitor *string_output_visitor_new(bool human, char **r= esult) v->visitor.type_str =3D print_type_str; v->visitor.type_number =3D print_type_number; v->visitor.type_null =3D print_type_null; + v->visitor.start_struct =3D start_struct; + v->visitor.end_struct =3D end_struct; v->visitor.start_list =3D start_list; v->visitor.next_list =3D next_list; v->visitor.end_list =3D end_list; --=20 2.43.0