From nobody Wed Nov 27 00:27:51 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1702062735; cv=none; d=zohomail.com; s=zohoarc; b=hSoZOvD/zp9nJTkbnLtbepBrOpJ9dxdfo7++v8Y22XF0h5TuZ9CxbzkUI6+OjoyXGVXAaSjGQJO+hHXk9wy8xlQVytQQbiEaeeOK4aqUzQOHkD98Kan1kSgfSkCpgdiJATDiRymNfa2EOWUlEKtPY5Blhw5sncSJSO/D+PfHdro= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702062735; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=wdEEnBD47cr/C4n0H9WjVscK7jQsS6lAH6ka4UUOD5A=; b=e3Asb4hf7f+wb6AmTjIpPGhYdNz6K0l3rRc2N85cOrKIqOCRrff0Gfl5JiNaK+Y1alyQGeRW3m6KRryKtBup973fqvzhMfgRlT7Xfg8LlTK1IqpVH6Q8scqqNvV2NFGjMVmgidFmnALUGFfN+mp5KI60wcHBeRYW6SsNorZTBsM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1702062735363154.5742793765388; Fri, 8 Dec 2023 11:12:15 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rBgFz-0000oB-9F; Fri, 08 Dec 2023 14:11:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBgFy-0000o3-Ap for qemu-devel@nongnu.org; Fri, 08 Dec 2023 14:11:26 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBgFd-0003gA-Kj for qemu-devel@nongnu.org; Fri, 08 Dec 2023 14:11:26 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-118-t1mhqpHFPUmoqQ8JkaKWHA-1; Fri, 08 Dec 2023 14:09:25 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8A4AC8352A0; Fri, 8 Dec 2023 19:09:24 +0000 (UTC) Received: from p1.localdomain.com (ovpn-114-104.gru2.redhat.com [10.97.114.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 855D1112131D; Fri, 8 Dec 2023 19:09:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702062664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wdEEnBD47cr/C4n0H9WjVscK7jQsS6lAH6ka4UUOD5A=; b=aXrPuDSSW1Y6YEt96qKdk7YXbBE4bo62egpFNjPUYHyAF9DA3Dy9guUDz1jJekB8XpHVP/ VxoIKpEeH2FIbrAIXknmR1Pwxr6MhUC6EEr9JWA1PgLgelQN9LnQyVelOTTVsEUcl11mH5 sbtfZImJ/T0W6jumnvTcZb7/TsdJtmg= X-MC-Unique: t1mhqpHFPUmoqQ8JkaKWHA-1 From: Cleber Rosa To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Radoslaw Biernacki , Paul Durrant , Akihiko Odaki , Leif Lindholm , Peter Maydell , Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , kvm@vger.kernel.org, qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Beraldo Leal , Wainer dos Santos Moschetta , Sriram Yagnaraman , Marcin Juszkiewicz , Cleber Rosa , David Woodhouse Subject: [PATCH 01/10] tests/avocado: mips: fallback to HTTP given certificate expiration Date: Fri, 8 Dec 2023 14:09:02 -0500 Message-ID: <20231208190911.102879-2-crosa@redhat.com> In-Reply-To: <20231208190911.102879-1-crosa@redhat.com> References: <20231208190911.102879-1-crosa@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=crosa@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1702062736469100003 Content-Type: text/plain; charset="utf-8" The SSL certificate installed at mipsdistros.mips.com has expired: 0 s:CN =3D mipsdistros.mips.com i:C =3D US, O =3D Amazon, OU =3D Server CA 1B, CN =3D Amazon a:PKEY: rsaEncryption, 2048 (bit); sigalg: RSA-SHA256 v:NotBefore: Dec 23 00:00:00 2019 GMT; NotAfter: Jan 23 12:00:00 2021 GMT Because this project has no control over that certificate and host, this falls back to plain HTTP instead. The integrity of the downloaded files can be guaranteed by the existing hashes for those files (which are not modified here). Signed-off-by: Cleber Rosa Reviewed-by: Alex Benn=C3=A9e --- tests/avocado/boot_linux_console.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/avocado/boot_linux_console.py b/tests/avocado/boot_linux= _console.py index 3f0180e1f8..8066861c17 100644 --- a/tests/avocado/boot_linux_console.py +++ b/tests/avocado/boot_linux_console.py @@ -299,7 +299,7 @@ def test_mips_malta32el_nanomips_4k(self): :avocado: tags=3Dendian:little :avocado: tags=3Dcpu:I7200 """ - kernel_url =3D ('https://mipsdistros.mips.com/LinuxDistro/nanomips= /' + kernel_url =3D ('http://mipsdistros.mips.com/LinuxDistro/nanomips/' 'kernels/v4.15.18-432-gb2eb9a8b07a1-20180627102142/' 'generic_nano32r6el_page4k.xz') kernel_hash =3D '477456aafd2a0f1ddc9482727f20fe9575565dd6' @@ -312,7 +312,7 @@ def test_mips_malta32el_nanomips_16k_up(self): :avocado: tags=3Dendian:little :avocado: tags=3Dcpu:I7200 """ - kernel_url =3D ('https://mipsdistros.mips.com/LinuxDistro/nanomips= /' + kernel_url =3D ('http://mipsdistros.mips.com/LinuxDistro/nanomips/' 'kernels/v4.15.18-432-gb2eb9a8b07a1-20180627102142/' 'generic_nano32r6el_page16k_up.xz') kernel_hash =3D 'e882868f944c71c816e832e2303b7874d044a7bc' @@ -325,7 +325,7 @@ def test_mips_malta32el_nanomips_64k_dbg(self): :avocado: tags=3Dendian:little :avocado: tags=3Dcpu:I7200 """ - kernel_url =3D ('https://mipsdistros.mips.com/LinuxDistro/nanomips= /' + kernel_url =3D ('http://mipsdistros.mips.com/LinuxDistro/nanomips/' 'kernels/v4.15.18-432-gb2eb9a8b07a1-20180627102142/' 'generic_nano32r6el_page64k_dbg.xz') kernel_hash =3D '18d1c68f2e23429e266ca39ba5349ccd0aeb7180' --=20 2.43.0 From nobody Wed Nov 27 00:27:51 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1702062735; cv=none; d=zohomail.com; s=zohoarc; b=Q7cUA32FJmid6CrgwHNCz3kpHUCKaTAYrjLDNC03E4niGdUZky5VuDAbPpaD8wBgiks2RlIStMD+A7yel1ygFv9asS81BeZkkqzz8yAqSmNUlYvTXZOHJs9dpHGh5ht6ZoT2Merw3/Xeknq/hmB+dREvNIwlPqFtilRRRzyZdwA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702062735; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=HAQodLw6o39wfGU2+kKO3r3kXuqnKBwHuQCL8rcVZAo=; b=N/MRTJFQsNMvy9Kyzs5W9wRgUvoOlxvCWRT5/Z8MEe6rnftKOdsJIe03f+cOjl+gQRVUbR/i5yAzBHFsxTGFIu91og6huq40NjQVBApLVIG8vyKeZJ3XDT375mSLJsBiImxEKhgjcrCO56xhUhwAAdoN2A5EQ0xAo/dizG1h93o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1702062735757577.223104746171; Fri, 8 Dec 2023 11:12:15 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rBgFo-0000iF-4Q; Fri, 08 Dec 2023 14:11:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBgFg-0000dv-5w for qemu-devel@nongnu.org; Fri, 08 Dec 2023 14:11:11 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBgFb-0003eg-Kr for qemu-devel@nongnu.org; Fri, 08 Dec 2023 14:11:07 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-249-st6o27ktOfGRsVq4m6Pwjw-1; Fri, 08 Dec 2023 14:09:28 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D73CE85A58A; Fri, 8 Dec 2023 19:09:27 +0000 (UTC) Received: from p1.localdomain.com (ovpn-114-104.gru2.redhat.com [10.97.114.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D23BB112131D; Fri, 8 Dec 2023 19:09:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702062661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HAQodLw6o39wfGU2+kKO3r3kXuqnKBwHuQCL8rcVZAo=; b=iUxwog5siNwGQRWacgNres8rZ9H/GjXx+GBkQResiBWDMXIB1tPlmb+eoMiIYW4rFdzNfO A/aF/kbgmToHolksxc3su98T41sjzWdsscRhVZBvvmH9aJu3P8pYQo+Fs2CifFOkPote9F JdRZHGUmfBhTTUR5G7/R/T3nkrqE6DQ= X-MC-Unique: st6o27ktOfGRsVq4m6Pwjw-1 From: Cleber Rosa To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Radoslaw Biernacki , Paul Durrant , Akihiko Odaki , Leif Lindholm , Peter Maydell , Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , kvm@vger.kernel.org, qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Beraldo Leal , Wainer dos Santos Moschetta , Sriram Yagnaraman , Marcin Juszkiewicz , Cleber Rosa , David Woodhouse Subject: [PATCH 02/10] tests/avocado: mips: add hint for fetchasset plugin Date: Fri, 8 Dec 2023 14:09:03 -0500 Message-ID: <20231208190911.102879-3-crosa@redhat.com> In-Reply-To: <20231208190911.102879-1-crosa@redhat.com> References: <20231208190911.102879-1-crosa@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=crosa@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1702062736479100004 Content-Type: text/plain; charset="utf-8" Avocado's fetchasset plugin runs before the actual Avocado job (and any test). It analyses the test's code looking for occurrences of "self.fetch_asset()" in the either the actual test or setUp() method. It's not able to fully analyze all code, though. The way these tests are written, make the fetchasset plugin blind to the assets. This adds redundant code, true, but one that doesn't hurt the test and aids the fetchasset plugin to download or verify the existence of these assets in advance. Signed-off-by: Cleber Rosa --- tests/avocado/boot_linux_console.py | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/tests/avocado/boot_linux_console.py b/tests/avocado/boot_linux= _console.py index 8066861c17..f5c5d647a4 100644 --- a/tests/avocado/boot_linux_console.py +++ b/tests/avocado/boot_linux_console.py @@ -303,6 +303,11 @@ def test_mips_malta32el_nanomips_4k(self): 'kernels/v4.15.18-432-gb2eb9a8b07a1-20180627102142/' 'generic_nano32r6el_page4k.xz') kernel_hash =3D '477456aafd2a0f1ddc9482727f20fe9575565dd6' + + # The following line is a no-op that aids the avocado + # fetchasset plugin that runs before any portion of the test + self.fetch_asset(kernel_url, asset_hash=3Dkernel_hash) + self.do_test_mips_malta32el_nanomips(kernel_url, kernel_hash) =20 def test_mips_malta32el_nanomips_16k_up(self): @@ -316,6 +321,11 @@ def test_mips_malta32el_nanomips_16k_up(self): 'kernels/v4.15.18-432-gb2eb9a8b07a1-20180627102142/' 'generic_nano32r6el_page16k_up.xz') kernel_hash =3D 'e882868f944c71c816e832e2303b7874d044a7bc' + + # The following line is a no-op that aids the avocado + # fetchasset plugin that runs before any portion of the test + self.fetch_asset(kernel_url, asset_hash=3Dkernel_hash) + self.do_test_mips_malta32el_nanomips(kernel_url, kernel_hash) =20 def test_mips_malta32el_nanomips_64k_dbg(self): @@ -329,6 +339,11 @@ def test_mips_malta32el_nanomips_64k_dbg(self): 'kernels/v4.15.18-432-gb2eb9a8b07a1-20180627102142/' 'generic_nano32r6el_page64k_dbg.xz') kernel_hash =3D '18d1c68f2e23429e266ca39ba5349ccd0aeb7180' + + # The following line is a no-op that aids the avocado + # fetchasset plugin that runs before any portion of the test + self.fetch_asset(kernel_url, asset_hash=3Dkernel_hash) + self.do_test_mips_malta32el_nanomips(kernel_url, kernel_hash) =20 def test_aarch64_xlnx_versal_virt(self): --=20 2.43.0 From nobody Wed Nov 27 00:27:51 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1702062757; cv=none; d=zohomail.com; s=zohoarc; b=RzfVUYRqc8mkE6wGWjvKRdong9TZnbQgE2Cc5w77B1nhHLdJL6RXFwpX6F7ls4AvLFmyqwWfgt751FwrrY76f/6RO28taV8zIIzKys9vgdlF+s3UdCKfq733xI+qbQKJi5oMxka5h2p03C1jaNr1ZY/9VzB1dE09sIiuLrIeunY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702062757; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=RtZ362NiJGxvbeWbael3pXl8UQtexWlIoEdoihDgXIM=; b=arn5Lj9VTixeJntxWg5TEkI4iVqekqd0Wm9Tmr3DYWN9Mdbdsh99dWVytOjIzuHQY+meseQkE7sWvlr8keOgE6TAyMDSJBq+fFQED5xv/I7gojKTT001URHWRotR6deHGxDhX58RZvnHAtgkneMXgpuXK81rxCkUpZrXe4YIe7A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1702062757162785.395775269554; Fri, 8 Dec 2023 11:12:37 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rBgFt-0000m2-CY; Fri, 08 Dec 2023 14:11:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBgFk-0000fs-BJ for qemu-devel@nongnu.org; Fri, 08 Dec 2023 14:11:13 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBgFb-0003fM-Ki for qemu-devel@nongnu.org; Fri, 08 Dec 2023 14:11:10 -0500 Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-625-FVcO3bX4Nqmuzkc0Zr7RvQ-1; Fri, 08 Dec 2023 14:09:32 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 32A5A1C05195; Fri, 8 Dec 2023 19:09:31 +0000 (UTC) Received: from p1.localdomain.com (ovpn-114-104.gru2.redhat.com [10.97.114.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2DA75112131D; Fri, 8 Dec 2023 19:09:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702062662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RtZ362NiJGxvbeWbael3pXl8UQtexWlIoEdoihDgXIM=; b=fpu8rzCsXRiVTiNKQlMAL0B4z8HUAP3UwzVMBsVR0fg0iyZzSunRtJ2h4TMGbFXMZvHLre UkKnX2U9J354Je1wp6UtQ/5e0VNrbnUvT6Q8oZH2XKOyGdLdcAiIq6FqQZ4j0TAVP6eLRc GNIzcUtcHda5gRkcxeI96CQNq2ipnrQ= X-MC-Unique: FVcO3bX4Nqmuzkc0Zr7RvQ-1 From: Cleber Rosa To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Radoslaw Biernacki , Paul Durrant , Akihiko Odaki , Leif Lindholm , Peter Maydell , Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , kvm@vger.kernel.org, qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Beraldo Leal , Wainer dos Santos Moschetta , Sriram Yagnaraman , Marcin Juszkiewicz , Cleber Rosa , David Woodhouse Subject: [PATCH 03/10] tests/avocado/intel_iommu.py: increase timeout Date: Fri, 8 Dec 2023 14:09:04 -0500 Message-ID: <20231208190911.102879-4-crosa@redhat.com> In-Reply-To: <20231208190911.102879-1-crosa@redhat.com> References: <20231208190911.102879-1-crosa@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=crosa@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1702062758641100001 Content-Type: text/plain; charset="utf-8" Based on many runs, the average run time for these 4 tests is around 250 seconds, with 320 seconds being the ceiling. In any way, the default 120 seconds timeout is inappropriate in my experience. Let's increase the timeout so these tests get a chance to completion. Signed-off-by: Cleber Rosa --- tests/avocado/intel_iommu.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/avocado/intel_iommu.py b/tests/avocado/intel_iommu.py index f04ee1cf9d..24bfad0756 100644 --- a/tests/avocado/intel_iommu.py +++ b/tests/avocado/intel_iommu.py @@ -25,6 +25,8 @@ class IntelIOMMU(LinuxTest): :avocado: tags=3Dflaky """ =20 + timeout =3D 360 + IOMMU_ADDON =3D ',iommu_platform=3Don,disable-modern=3Doff,disable-leg= acy=3Don' kernel_path =3D None initrd_path =3D None --=20 2.43.0 From nobody Wed Nov 27 00:27:51 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1702062735; cv=none; d=zohomail.com; s=zohoarc; b=JcjZ+xK64emquQ+Yq3sxWU/NsAXP3MadDWBuwXiCwdtep+qPIblk/3OoMh1G1y1RoTJNUlE97GyxxT9ZoaIj4LOMdGUbBfighMRKDpxpr7ICPkbayyePG3gX85V3MlPvHDSwQbjQ0GGLpkMKkk68UIbDnPicjiiUMrX1sk1TAq0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702062735; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=pfo6t1Tv1s9qe/N7cakX7vdc0jIAiwRYsYLYOF8ZcxM=; b=kTWZYSaXS8Wb8jyn7bY5djzLB7Tzf/UipxCSKfHyKKW9900PEtPzX0Hh17z32l917ERxsppsWyK75pjPb734Ve0tRzyCA/GdRVHO6m75rTp4KBdYgRHlTKD3aSc0iZuAbAEaTvfRwOeaIEPQIWn8WR3iIWM7fnv/L4qsdgTlLs8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1702062735777430.7951352242934; Fri, 8 Dec 2023 11:12:15 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rBgFR-0000cg-Tv; Fri, 08 Dec 2023 14:10:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBgFO-0000cO-GG for qemu-devel@nongnu.org; Fri, 08 Dec 2023 14:10:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBgFK-0003as-MR for qemu-devel@nongnu.org; Fri, 08 Dec 2023 14:10:50 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-150-quU-GsylOAWcEGm1VCZntw-1; Fri, 08 Dec 2023 14:09:35 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7F265185A780; Fri, 8 Dec 2023 19:09:34 +0000 (UTC) Received: from p1.localdomain.com (ovpn-114-104.gru2.redhat.com [10.97.114.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7A767112131D; Fri, 8 Dec 2023 19:09:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702062645; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pfo6t1Tv1s9qe/N7cakX7vdc0jIAiwRYsYLYOF8ZcxM=; b=O0/c9nVSkhPy89qebixr/1/Btvi5KVlpu/RciQWHO1KAaQk3cAGlALosspcjbh5CYBzMbT J8kHack4Gx34+1YOddrtKl/OwHtVbnno6A4wXqA5Zv2cF8WMfN/y+PBX3UR+9hPNe+oMAz 15meAhr8GJwiB87o3nFQevLlHKp5Ymg= X-MC-Unique: quU-GsylOAWcEGm1VCZntw-1 From: Cleber Rosa To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Radoslaw Biernacki , Paul Durrant , Akihiko Odaki , Leif Lindholm , Peter Maydell , Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , kvm@vger.kernel.org, qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Beraldo Leal , Wainer dos Santos Moschetta , Sriram Yagnaraman , Marcin Juszkiewicz , Cleber Rosa , David Woodhouse Subject: [PATCH 04/10] tests/avocado: machine aarch64: standardize location and RO/RW access Date: Fri, 8 Dec 2023 14:09:05 -0500 Message-ID: <20231208190911.102879-5-crosa@redhat.com> In-Reply-To: <20231208190911.102879-1-crosa@redhat.com> References: <20231208190911.102879-1-crosa@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=crosa@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1702062736488100005 Content-Type: text/plain; charset="utf-8" The tests under machine_aarch64_virt.py do not need read-write access to the ISOs. The ones under machine_aarch64_sbsaref.py, on the other hand, will need read-write access, so let's give each test an unique file. And while at it, let's use a single code style and hash for the ISO url. Signed-off-by: Cleber Rosa --- tests/avocado/machine_aarch64_sbsaref.py | 9 +++++++-- tests/avocado/machine_aarch64_virt.py | 14 +++++++------- 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/tests/avocado/machine_aarch64_sbsaref.py b/tests/avocado/machi= ne_aarch64_sbsaref.py index 528c7d2934..6ae84d77ac 100644 --- a/tests/avocado/machine_aarch64_sbsaref.py +++ b/tests/avocado/machine_aarch64_sbsaref.py @@ -7,6 +7,7 @@ # SPDX-License-Identifier: GPL-2.0-or-later =20 import os +import shutil =20 from avocado import skipUnless from avocado.utils import archive @@ -123,13 +124,15 @@ def boot_alpine_linux(self, cpu): =20 iso_hash =3D "5a36304ecf039292082d92b48152a9ec21009d3a62f459de623e= 19c4bd9dc027" iso_path =3D self.fetch_asset(iso_url, algorithm=3D"sha256", asset= _hash=3Diso_hash) + iso_path_rw =3D os.path.join(self.workdir, os.path.basename(iso_pa= th)) + shutil.copy(iso_path, iso_path_rw) =20 self.vm.set_console() self.vm.add_args( "-cpu", cpu, "-drive", - f"file=3D{iso_path},format=3Draw", + f"file=3D{iso_path_rw},format=3Draw", "-device", "virtio-rng-pci,rng=3Drng0", "-object", @@ -170,13 +173,15 @@ def boot_openbsd73(self, cpu): =20 img_hash =3D "7fc2c75401d6f01fbfa25f4953f72ad7d7c18650056d30755c44= b9c129b707e5" img_path =3D self.fetch_asset(img_url, algorithm=3D"sha256", asset= _hash=3Dimg_hash) + img_path_rw =3D os.path.join(self.workdir, os.path.basename(img_pa= th)) + shutil.copy(img_path, img_path_rw) =20 self.vm.set_console() self.vm.add_args( "-cpu", cpu, "-drive", - f"file=3D{img_path},format=3Draw", + f"file=3D{img_path_rw},format=3Draw", "-device", "virtio-rng-pci,rng=3Drng0", "-object", diff --git a/tests/avocado/machine_aarch64_virt.py b/tests/avocado/machine_= aarch64_virt.py index a90dc6ff4b..093d68f837 100644 --- a/tests/avocado/machine_aarch64_virt.py +++ b/tests/avocado/machine_aarch64_virt.py @@ -37,13 +37,13 @@ def test_alpine_virt_tcg_gic_max(self): :avocado: tags=3Dmachine:virt :avocado: tags=3Daccel:tcg """ - iso_url =3D ('https://dl-cdn.alpinelinux.org/' - 'alpine/v3.17/releases/aarch64/' - 'alpine-standard-3.17.2-aarch64.iso') + iso_url =3D ( + "https://dl-cdn.alpinelinux.org/" + "alpine/v3.17/releases/aarch64/alpine-standard-3.17.2-aarch64.= iso" + ) =20 - # Alpine use sha256 so I recalculated this myself - iso_sha1 =3D '76284fcd7b41fe899b0c2375ceb8470803eea839' - iso_path =3D self.fetch_asset(iso_url, asset_hash=3Diso_sha1) + iso_hash =3D "5a36304ecf039292082d92b48152a9ec21009d3a62f459de623e= 19c4bd9dc027" + iso_path =3D self.fetch_asset(iso_url, algorithm=3D"sha256", asset= _hash=3Diso_hash) =20 self.vm.set_console() kernel_command_line =3D (self.KERNEL_COMMON_COMMAND_LINE + @@ -60,7 +60,7 @@ def test_alpine_virt_tcg_gic_max(self): self.vm.add_args("-smp", "2", "-m", "1024") self.vm.add_args('-bios', os.path.join(BUILD_DIR, 'pc-bios', 'edk2-aarch64-code.fd')) - self.vm.add_args("-drive", f"file=3D{iso_path},format=3Draw") + self.vm.add_args("-drive", f"file=3D{iso_path},readonly=3Don,forma= t=3Draw") self.vm.add_args('-device', 'virtio-rng-pci,rng=3Drng0') self.vm.add_args('-object', 'rng-random,id=3Drng0,filename=3D/dev/= urandom') =20 --=20 2.43.0 From nobody Wed Nov 27 00:27:51 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1702062812; cv=none; d=zohomail.com; s=zohoarc; b=YbWwWviFnLfL/C/K5KNjbrGGrFRKWvLDLLdV4HeSzW4hYn6AyBxsTFQglmkQAcUT4i2CFvIAdfFt42PJS/fZpI+MnvxUlS1xROMuEInQU+QWG6jKHw0JNCrujC56FaG84ZRhBM0W04snUwsIYNWVjAD8wjK/iZG/g2R52Idz3sg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702062812; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=dQfV6LviLmnLOWvIHHdxc9m6pS5dYwlHHOW0whSlNbs=; b=Kmq8GwzOhU8wumcpQOnfWV4obwoTSqCnqSEiFd5L+inahKYKrAmQyh7x9bmHhqSnJ6q88OAaOETNv7t2IyDvcbwePCJBwbANZDRA41sfpB+frlVBvrHaaXgFEgtl+0g3QIQHVQy25hz9MC84EOzuNk8RRcFEy9ocBQ/nIc6JECo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1702062812941647.9115045618695; Fri, 8 Dec 2023 11:13:32 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rBgFq-0000jy-MU; Fri, 08 Dec 2023 14:11:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBgFm-0000h4-Bp for qemu-devel@nongnu.org; Fri, 08 Dec 2023 14:11:14 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBgFb-0003el-Kw for qemu-devel@nongnu.org; Fri, 08 Dec 2023 14:11:12 -0500 Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-74-k844ebb0OB23C_5-AhuuGw-1; Fri, 08 Dec 2023 14:09:38 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CF95E2823F61; Fri, 8 Dec 2023 19:09:37 +0000 (UTC) Received: from p1.localdomain.com (ovpn-114-104.gru2.redhat.com [10.97.114.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C9176112131D; Fri, 8 Dec 2023 19:09:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702062661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dQfV6LviLmnLOWvIHHdxc9m6pS5dYwlHHOW0whSlNbs=; b=WkE6VUCuTnRhjXBKOVll+WgLM5GLI+oe311YgqtdgZO4LWl4NaEYk06jUE60L0HoF4zSuT wzVLtQlRy/u6ohSc7GxqtZ+R1P4lv/XpDYUj9KRx0rX7/9c2Qbzp39yqYNCRvczFkQP5MI ioBZOfugcmY1pHKVMNDCY+XpwlK3mtk= X-MC-Unique: k844ebb0OB23C_5-AhuuGw-1 From: Cleber Rosa To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Radoslaw Biernacki , Paul Durrant , Akihiko Odaki , Leif Lindholm , Peter Maydell , Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , kvm@vger.kernel.org, qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Beraldo Leal , Wainer dos Santos Moschetta , Sriram Yagnaraman , Marcin Juszkiewicz , Cleber Rosa , David Woodhouse Subject: [PATCH 05/10] tests/avocado: use more distinct names for assets Date: Fri, 8 Dec 2023 14:09:06 -0500 Message-ID: <20231208190911.102879-6-crosa@redhat.com> In-Reply-To: <20231208190911.102879-1-crosa@redhat.com> References: <20231208190911.102879-1-crosa@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=crosa@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1702062813685100001 Content-Type: text/plain; charset="utf-8" Avocado's asset system will deposit files in a cache organized either by their original location (the URI) or by their names. Because the cache (and the "by_name" sub directory) is common across tests, it's a good idea to make these names as distinct as possible. This avoid name clashes, which makes future Avocado runs to attempt to redownload the assets with the same name, but from the different locations they actually are from. This causes cache misses, extra downloads, and possibly canceled tests. Signed-off-by: Cleber Rosa --- tests/avocado/kvm_xen_guest.py | 3 ++- tests/avocado/netdev-ethtool.py | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/avocado/kvm_xen_guest.py b/tests/avocado/kvm_xen_guest.py index 5391283113..ec4052a1fe 100644 --- a/tests/avocado/kvm_xen_guest.py +++ b/tests/avocado/kvm_xen_guest.py @@ -40,7 +40,8 @@ def get_asset(self, name, sha1): url =3D base_url + name # use explicit name rather than failing to neatly parse the # URL into a unique one - return self.fetch_asset(name=3Dname, locations=3D(url), asset_hash= =3Dsha1) + return self.fetch_asset(name=3Df"qemu-kvm-xen-guest-{name}", + locations=3D(url), asset_hash=3Dsha1) =20 def common_vm_setup(self): # We also catch lack of KVM_XEN support if we fail to launch diff --git a/tests/avocado/netdev-ethtool.py b/tests/avocado/netdev-ethtool= .py index 5f33288f81..462cf8de7d 100644 --- a/tests/avocado/netdev-ethtool.py +++ b/tests/avocado/netdev-ethtool.py @@ -27,7 +27,8 @@ def get_asset(self, name, sha1): url =3D base_url + name # use explicit name rather than failing to neatly parse the # URL into a unique one - return self.fetch_asset(name=3Dname, locations=3D(url), asset_hash= =3Dsha1) + return self.fetch_asset(name=3Df"qemu-netdev-ethtool-{name}", + locations=3D(url), asset_hash=3Dsha1) =20 def common_test_code(self, netdev, extra_args=3DNone): =20 --=20 2.43.0 From nobody Wed Nov 27 00:27:51 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1702062802; cv=none; d=zohomail.com; s=zohoarc; b=QE/Wmn7Ymab24f/3zINUXf7RkisB5GOkuFJV6ZH5drBKO1zGAQCdpIiHKZ/XhqVEhV09K7MhO8If8iWMZg0v+mEksiWw/nRu09Qu/LRwAKNOn92XHC/n70cQUJRTcb9hOaq1Il94TwtsE+wMOddmOQT3ve2H6gd1vMt/Ab8XW3g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702062802; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=TtGy8l+fgmdQS+kFDaMnC380yWtdx1MWMjnafi+N5hE=; b=TrmnXBY/6RPANjE+aa5zxIHHDwp2jbP03Eriv08TTz9e8Ih5yILc6yBxDk2Caz7pJzMD1h4hkAbbkDrNkIXYnAxjxETzNb1NN45UznKGQ/VOURe6QOqIYsb1YEVC2vn/eZdahYS9PdJU/FagTPIN0gs/12783BZBfFuSh8g787U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1702062802352999.1712733282916; Fri, 8 Dec 2023 11:13:22 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rBgFp-0000is-Es; Fri, 08 Dec 2023 14:11:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBgFf-0000ds-Oe for qemu-devel@nongnu.org; Fri, 08 Dec 2023 14:11:09 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBgFb-0003ev-Cy for qemu-devel@nongnu.org; Fri, 08 Dec 2023 14:11:06 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-671-NG8nsRIfMeOT9mJg1nEguw-1; Fri, 08 Dec 2023 14:09:41 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 271FE185A784; Fri, 8 Dec 2023 19:09:41 +0000 (UTC) Received: from p1.localdomain.com (ovpn-114-104.gru2.redhat.com [10.97.114.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 22DAB112131D; Fri, 8 Dec 2023 19:09:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702062661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TtGy8l+fgmdQS+kFDaMnC380yWtdx1MWMjnafi+N5hE=; b=BKm2ux7n6YGOAWXpsmliPlRHUdsAcosh28pfVPdZgxRTO87f+5bZBffJ+1+7QJWYz51SzV sIur7w+kqgNW3zNWDSlyPXyAyzbHEqqUz4YR/zUsI6mj+DluBL24FvpMfJB4sJpKUDqtRm jNTFQP0vSkRAHDgXD8+0VTQ2rmdVg1I= X-MC-Unique: NG8nsRIfMeOT9mJg1nEguw-1 From: Cleber Rosa To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Radoslaw Biernacki , Paul Durrant , Akihiko Odaki , Leif Lindholm , Peter Maydell , Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , kvm@vger.kernel.org, qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Beraldo Leal , Wainer dos Santos Moschetta , Sriram Yagnaraman , Marcin Juszkiewicz , Cleber Rosa , David Woodhouse Subject: [PATCH 06/10] tests/avocado/kvm_xen_guest.py: cope with asset RW requirements Date: Fri, 8 Dec 2023 14:09:07 -0500 Message-ID: <20231208190911.102879-7-crosa@redhat.com> In-Reply-To: <20231208190911.102879-1-crosa@redhat.com> References: <20231208190911.102879-1-crosa@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=crosa@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1702062803645100001 Content-Type: text/plain; charset="utf-8" Some of these tests actually require the root filesystem image, obtained through Avocado's asset feature and kept in a common cache location, to be writable. This makes a distinction between the tests that actually have this requirement and those who don't. The goal is to be as safe as possible, avoiding causing cache misses (because the assets get modified and thus need to be dowloaded again) while avoid copying the root filesystem backing file whenever possible. This also allow these tests to be run in parallel with newer Avocado versions. Signed-off-by: Cleber Rosa --- tests/avocado/kvm_xen_guest.py | 27 ++++++++++++++++++--------- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/tests/avocado/kvm_xen_guest.py b/tests/avocado/kvm_xen_guest.py index ec4052a1fe..d73fa888ef 100644 --- a/tests/avocado/kvm_xen_guest.py +++ b/tests/avocado/kvm_xen_guest.py @@ -10,6 +10,7 @@ # SPDX-License-Identifier: GPL-2.0-or-later =20 import os +import shutil =20 from qemu.machine import machine =20 @@ -43,7 +44,7 @@ def get_asset(self, name, sha1): return self.fetch_asset(name=3Df"qemu-kvm-xen-guest-{name}", locations=3D(url), asset_hash=3Dsha1) =20 - def common_vm_setup(self): + def common_vm_setup(self, readwrite=3DFalse): # We also catch lack of KVM_XEN support if we fail to launch self.require_accelerator("kvm") =20 @@ -56,11 +57,19 @@ def common_vm_setup(self): "367962983d0d32109998a70b45dcee4= 672d0b045") self.rootfs =3D self.get_asset("rootfs.ext4", "f1478401ea4b3fa2ea196396be44315bab2b= b5e4") + if readwrite: + dest =3D os.path.join(self.workdir, os.path.basename(self.root= fs)) + shutil.copy(self.rootfs, dest) + self.rootfs =3D dest =20 - def run_and_check(self): + def run_and_check(self, readwrite=3DFalse): + if readwrite: + drive =3D f"file=3D{self.rootfs},if=3Dnone,format=3Draw,id=3Dd= rv0" + else: + drive =3D f"file=3D{self.rootfs},if=3Dnone,readonly=3Don,forma= t=3Draw,id=3Ddrv0" self.vm.add_args('-kernel', self.kernel_path, '-append', self.kernel_params, - '-drive', f"file=3D{self.rootfs},if=3Dnone,forma= t=3Draw,id=3Ddrv0", + '-drive', drive, '-device', 'xen-disk,drive=3Ddrv0,vdev=3Dxvda', '-device', 'virtio-net-pci,netdev=3Dunet', '-netdev', 'user,id=3Dunet,hostfwd=3D:127.0.0.1:0= -:22') @@ -90,11 +99,11 @@ def test_kvm_xen_guest(self): :avocado: tags=3Dkvm_xen_guest """ =20 - self.common_vm_setup() + self.common_vm_setup(True) =20 self.kernel_params =3D (self.KERNEL_DEFAULT + ' xen_emul_unplug=3Dide-disks') - self.run_and_check() + self.run_and_check(True) self.ssh_command('grep xen-pirq.*msi /proc/interrupts') =20 def test_kvm_xen_guest_nomsi(self): @@ -102,11 +111,11 @@ def test_kvm_xen_guest_nomsi(self): :avocado: tags=3Dkvm_xen_guest_nomsi """ =20 - self.common_vm_setup() + self.common_vm_setup(True) =20 self.kernel_params =3D (self.KERNEL_DEFAULT + ' xen_emul_unplug=3Dide-disks pci=3Dnomsi') - self.run_and_check() + self.run_and_check(True) self.ssh_command('grep xen-pirq.* /proc/interrupts') =20 def test_kvm_xen_guest_noapic_nomsi(self): @@ -114,11 +123,11 @@ def test_kvm_xen_guest_noapic_nomsi(self): :avocado: tags=3Dkvm_xen_guest_noapic_nomsi """ =20 - self.common_vm_setup() + self.common_vm_setup(True) =20 self.kernel_params =3D (self.KERNEL_DEFAULT + ' xen_emul_unplug=3Dide-disks noapic pci=3Dn= omsi') - self.run_and_check() + self.run_and_check(True) self.ssh_command('grep xen-pirq /proc/interrupts') =20 def test_kvm_xen_guest_vapic(self): --=20 2.43.0 From nobody Wed Nov 27 00:27:51 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1702062752; cv=none; d=zohomail.com; s=zohoarc; b=FaCQZw3yRZIFAK51wXfVz+NErU+yYVcNAT1PariYA34ffcQ3ig8+TkjNci2s+875M33HjJhNpMqc9awFyAlJ8uBTkjYP9NAD1p2r1KeeAdsOlfKVUV/GCCIpeXvjAjIUCWGzl8SrD5O5xoICoc144MosbtvPQ2YUkUVaEFRjirg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702062752; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=AmGLkTWwFQFYqZRcdZPvYJBBBCt8tOcHxSrPZZ9IGpU=; b=BsCotdjgJCIKoLM95dLkZ3Z1eZqrWKQAT8yeI2sSkBTDI3ozDRWEWgrCNmsbah6NYcXrFiZ3Q+spMsDxIB7+98KfT1MI1yE9xn+3HQkIaiKaJsbW0QZWQMk6ncVl3vBYWsUB+oPwml9RRoVeAtSusmTsY3JYzTTKIXgd8HT4/fE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1702062752875492.2452369234129; Fri, 8 Dec 2023 11:12:32 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rBgFp-0000iz-SE; Fri, 08 Dec 2023 14:11:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBgFf-0000dq-MO for qemu-devel@nongnu.org; Fri, 08 Dec 2023 14:11:09 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBgFb-0003er-Jz for qemu-devel@nongnu.org; Fri, 08 Dec 2023 14:11:06 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-402-BBdazSDrOnOS10C4y7b7oQ-1; Fri, 08 Dec 2023 14:09:45 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 76559102F220; Fri, 8 Dec 2023 19:09:44 +0000 (UTC) Received: from p1.localdomain.com (ovpn-114-104.gru2.redhat.com [10.97.114.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7169B111E404; Fri, 8 Dec 2023 19:09:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702062661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AmGLkTWwFQFYqZRcdZPvYJBBBCt8tOcHxSrPZZ9IGpU=; b=TjyhqmGMVdTPMqPTAtmMtES23NvrLN0Av3yJb9U9E3VmrOW3o/7i+Zav1YXETBLNCACzOR am146yiWhFmxK7JoGn/vfa04rYhIr7L4GRwrzp6IrYNScNS6WF0pnL6uECvpHFfvqwRt01 GtXiFPbgGT87IJrY7t78xzgsL0o+g7E= X-MC-Unique: BBdazSDrOnOS10C4y7b7oQ-1 From: Cleber Rosa To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Radoslaw Biernacki , Paul Durrant , Akihiko Odaki , Leif Lindholm , Peter Maydell , Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , kvm@vger.kernel.org, qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Beraldo Leal , Wainer dos Santos Moschetta , Sriram Yagnaraman , Marcin Juszkiewicz , Cleber Rosa , David Woodhouse Subject: [PATCH 07/10] testa/avocado: test_arm_emcraft_sf2: handle RW requirements for asset Date: Fri, 8 Dec 2023 14:09:08 -0500 Message-ID: <20231208190911.102879-8-crosa@redhat.com> In-Reply-To: <20231208190911.102879-1-crosa@redhat.com> References: <20231208190911.102879-1-crosa@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=crosa@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1702062754650100001 Content-Type: text/plain; charset="utf-8" The asset used in the mentioned test gets truncated before it's used in the test. This means that the file gets modified, and thus the asset's expected hash doesn't match anymore. This causes cache misses and re-downloads every time the test is re-run. Let's make a copy of the asset so that the one in the cache is preserved and the cache sees a hit on re-runs. Signed-off-by: Cleber Rosa --- tests/avocado/boot_linux_console.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/avocado/boot_linux_console.py b/tests/avocado/boot_linux= _console.py index f5c5d647a4..e2e928e703 100644 --- a/tests/avocado/boot_linux_console.py +++ b/tests/avocado/boot_linux_console.py @@ -414,14 +414,16 @@ def test_arm_emcraft_sf2(self): 'fe371d32e50ca682391e1e70ab98c2942aeffb01/spi.bin') spi_hash =3D '65523a1835949b6f4553be96dec1b6a38fb05501' spi_path =3D self.fetch_asset(spi_url, asset_hash=3Dspi_hash) + spi_path_rw =3D os.path.join(self.workdir, os.path.basename(spi_pa= th)) + shutil.copy(spi_path, spi_path_rw) =20 - file_truncate(spi_path, 16 << 20) # Spansion S25FL128SDPBHICO is 1= 6 MiB + file_truncate(spi_path_rw, 16 << 20) # Spansion S25FL128SDPBHICO i= s 16 MiB =20 self.vm.set_console() kernel_command_line =3D self.KERNEL_COMMON_COMMAND_LINE self.vm.add_args('-kernel', uboot_path, '-append', kernel_command_line, - '-drive', 'file=3D' + spi_path + ',if=3Dmtd,forma= t=3Draw', + '-drive', 'file=3D' + spi_path_rw + ',if=3Dmtd,fo= rmat=3Draw', '-no-reboot') self.vm.launch() self.wait_for_console_pattern('Enter \'help\' for a list') --=20 2.43.0 From nobody Wed Nov 27 00:27:51 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1702062735; cv=none; d=zohomail.com; s=zohoarc; b=COKoEjzZvKnJhlWujo3EY2sRHBlzk1PE2Tc4cN6dPVNlLfFDf5+2ZS1oyaeUNhpoeARB9vYaggsiHgzkoTOHvUO0mePLTUTp2UmpW4sRi9i9tDwoueTx9Yszq+qqn4/JTCh6zMl34hsaBT6C4APG3Wx7jox21+pVpj9Ycii/Gs4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702062735; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=6KemJUkWyU9r+J/jwN6os/ZXFpgsYC5/aEWfNA4odDs=; b=Cf7H+MYfI2Z9qgBHUcyky+/NGU6tCniDpTVz+FEBG5XXxxX3xlSjnqDocgj8uKvshbbHZRjIA1MX/p1Y8pr40bGK9HAPLjBKnZ6YZgy8/AaHMBuJNllk9Kr8HkdDJUpDotXz31YQQXTiK+2AnfKSIuhc7ti1dNk0mIjlA9quRhw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1702062735340260.7641256249684; Fri, 8 Dec 2023 11:12:15 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rBgFs-0000lF-KZ; Fri, 08 Dec 2023 14:11:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBgFm-0000h3-BI for qemu-devel@nongnu.org; Fri, 08 Dec 2023 14:11:15 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBgFW-0003dd-2R for qemu-devel@nongnu.org; Fri, 08 Dec 2023 14:11:12 -0500 Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-620-blH1v5GyMemL3aM-9qkpaw-1; Fri, 08 Dec 2023 14:09:48 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C15A11C05AD8; Fri, 8 Dec 2023 19:09:47 +0000 (UTC) Received: from p1.localdomain.com (ovpn-114-104.gru2.redhat.com [10.97.114.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BD471111E406; Fri, 8 Dec 2023 19:09:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702062657; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6KemJUkWyU9r+J/jwN6os/ZXFpgsYC5/aEWfNA4odDs=; b=XuayzAIVS5fRfIJp81gQ39a8WIO0kwecqZ9uiWFsDiFEF8Ck1skmQ5h0yKInqz7M8S0Vnu 7RZx2aQvFlFk3v0NvzM/fb28fAdakC+mP0dDaCY5KpCERbkx9rPY/Eh82s2E4amIyzhP9T sh4LvIpxNtDbLxbYIRQUOEHYUeG0FcU= X-MC-Unique: blH1v5GyMemL3aM-9qkpaw-1 From: Cleber Rosa To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Radoslaw Biernacki , Paul Durrant , Akihiko Odaki , Leif Lindholm , Peter Maydell , Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , kvm@vger.kernel.org, qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Beraldo Leal , Wainer dos Santos Moschetta , Sriram Yagnaraman , Marcin Juszkiewicz , Cleber Rosa , David Woodhouse Subject: [PATCH 08/10] tests/avocado/boot_xen.py: merge base classes Date: Fri, 8 Dec 2023 14:09:09 -0500 Message-ID: <20231208190911.102879-9-crosa@redhat.com> In-Reply-To: <20231208190911.102879-1-crosa@redhat.com> References: <20231208190911.102879-1-crosa@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=crosa@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1702062736462100001 Content-Type: text/plain; charset="utf-8" While it's a good practice to have reusable base classes, in this specific case there's no other user of the BootXenBase class. By unifying the class used in this test, we can improve readability and have the opportunity to add some future improvements in a clearer fashion. Signed-off-by: Cleber Rosa --- tests/avocado/boot_xen.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tests/avocado/boot_xen.py b/tests/avocado/boot_xen.py index fc2faeedb5..f80cbcb8fb 100644 --- a/tests/avocado/boot_xen.py +++ b/tests/avocado/boot_xen.py @@ -17,7 +17,7 @@ from boot_linux_console import LinuxKernelTest =20 =20 -class BootXenBase(LinuxKernelTest): +class BootXen(LinuxKernelTest): """ Boots a Xen hypervisor with a Linux DomU kernel. """ @@ -59,9 +59,6 @@ def launch_xen(self, xen_path): console_pattern =3D 'VFS: Cannot open root device' wait_for_console_pattern(self, console_pattern, "Panic on CPU 0:") =20 - -class BootXen(BootXenBase): - def test_arm64_xen_411_and_dom0(self): """ :avocado: tags=3Darch:aarch64 --=20 2.43.0 From nobody Wed Nov 27 00:27:51 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1702062808; cv=none; d=zohomail.com; s=zohoarc; b=EH6TnRTR7j9VNnCVM1kZ/wdXyAXQyPRFp1eKbJLCFwMHvjp0WjBZt6dBe5AFfMUuY5HbguNaJgRMtJ6FObz49/S7wspJueG/4yN/mVtsKX/4CRuuMXY+2ivUSam1u+TBvuZ/XSk7w6SQEtnPVFJWOLd4dj0vR0Q+NyPTszvysU8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702062808; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=aONzR2W5AGaoRzocN4fiH9lBklHZJB74jzBc5TX6OPU=; b=kzbAsv8S0EioJrClWu6qFP86E4h5D+KoU+00bJz/yzxejP2RwQQiU2Kmn/D/4aJ2gqlNI3ANxFk/A3CIJ9KNhDSYHNddueaYGiGhnkEd5c9HDxTFitJ9hHQvfiZNz2+AAN4eNpZgrJ3A7whwIve3//W/w+0C+5jE7kT6mG1iUUU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1702062808371893.7552762401173; Fri, 8 Dec 2023 11:13:28 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rBgFq-0000jE-0h; Fri, 08 Dec 2023 14:11:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBgFh-0000fe-40 for qemu-devel@nongnu.org; Fri, 08 Dec 2023 14:11:11 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBgFb-0003fI-Ja for qemu-devel@nongnu.org; Fri, 08 Dec 2023 14:11:08 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-255-JwBPCelKNQqVsZnDr9QaLA-1; Fri, 08 Dec 2023 14:09:52 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 18824185A781; Fri, 8 Dec 2023 19:09:51 +0000 (UTC) Received: from p1.localdomain.com (ovpn-114-104.gru2.redhat.com [10.97.114.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 14AD0112131D; Fri, 8 Dec 2023 19:09:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702062661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aONzR2W5AGaoRzocN4fiH9lBklHZJB74jzBc5TX6OPU=; b=R+vuot0O/Bx4mwdfk06b9RwvIAwseAAfqW3YgA61xxn424EiilrPSyci59Bxknft7hIHPL +d+nZiz/FUwHFG3Yv+f4CZnX4VGcG58SN2Bf05l9Vn0p/bUn1gwRkAMceBuLPyhfpG5B2r Hxv3CIMdOfJVi+D9pdm6FzqeMwm+PvM= X-MC-Unique: JwBPCelKNQqVsZnDr9QaLA-1 From: Cleber Rosa To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Radoslaw Biernacki , Paul Durrant , Akihiko Odaki , Leif Lindholm , Peter Maydell , Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , kvm@vger.kernel.org, qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Beraldo Leal , Wainer dos Santos Moschetta , Sriram Yagnaraman , Marcin Juszkiewicz , Cleber Rosa , David Woodhouse Subject: [PATCH 09/10] tests/avocado/boot_xen.py: unify tags Date: Fri, 8 Dec 2023 14:09:10 -0500 Message-ID: <20231208190911.102879-10-crosa@redhat.com> In-Reply-To: <20231208190911.102879-1-crosa@redhat.com> References: <20231208190911.102879-1-crosa@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=crosa@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1702062809522100001 Content-Type: text/plain; charset="utf-8" Because all tests share the same tags, it's possible to have all of them at the class level. Signed-off-by: Cleber Rosa Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tests/avocado/boot_xen.py | 26 +++++--------------------- 1 file changed, 5 insertions(+), 21 deletions(-) diff --git a/tests/avocado/boot_xen.py b/tests/avocado/boot_xen.py index f80cbcb8fb..f4b63c1ef2 100644 --- a/tests/avocado/boot_xen.py +++ b/tests/avocado/boot_xen.py @@ -20,6 +20,11 @@ class BootXen(LinuxKernelTest): """ Boots a Xen hypervisor with a Linux DomU kernel. + + :avocado: tags=3Darch:aarch64 + :avocado: tags=3Daccel:tcg + :avocado: tags=3Dcpu:cortex-a57 + :avocado: tags=3Dmachine:virt """ =20 timeout =3D 90 @@ -60,13 +65,6 @@ def launch_xen(self, xen_path): wait_for_console_pattern(self, console_pattern, "Panic on CPU 0:") =20 def test_arm64_xen_411_and_dom0(self): - """ - :avocado: tags=3Darch:aarch64 - :avocado: tags=3Daccel:tcg - :avocado: tags=3Dcpu:cortex-a57 - :avocado: tags=3Dmachine:virt - """ - # archive of file from https://deb.debian.org/debian/pool/main/x/x= en/ xen_url =3D ('https://fileserver.linaro.org/s/JSsewXGZ6mqxPr5/' 'download?path=3D%2F&files=3D' @@ -78,13 +76,6 @@ def test_arm64_xen_411_and_dom0(self): self.launch_xen(xen_path) =20 def test_arm64_xen_414_and_dom0(self): - """ - :avocado: tags=3Darch:aarch64 - :avocado: tags=3Daccel:tcg - :avocado: tags=3Dcpu:cortex-a57 - :avocado: tags=3Dmachine:virt - """ - # archive of file from https://deb.debian.org/debian/pool/main/x/x= en/ xen_url =3D ('https://fileserver.linaro.org/s/JSsewXGZ6mqxPr5/' 'download?path=3D%2F&files=3D' @@ -96,13 +87,6 @@ def test_arm64_xen_414_and_dom0(self): self.launch_xen(xen_path) =20 def test_arm64_xen_415_and_dom0(self): - """ - :avocado: tags=3Darch:aarch64 - :avocado: tags=3Daccel:tcg - :avocado: tags=3Dcpu:cortex-a57 - :avocado: tags=3Dmachine:virt - """ - xen_url =3D ('https://fileserver.linaro.org/' 's/JSsewXGZ6mqxPr5/download' '?path=3D%2F&files=3Dxen-upstream-4.15-unstable.deb') --=20 2.43.0 From nobody Wed Nov 27 00:27:51 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1702062735; cv=none; d=zohomail.com; s=zohoarc; b=hD6lRlNJhFsiwZpX92Rq8rrwbIBR3gWiFjOvE5a6M1zVLVXLaQq/Sm0EW6z9wAi273SoxYEh9CVQE2X5Rfa/Zcm/sC2NGwN6m1tVRhaYsXpfzLF4H5x0Gp8TO2XK6YiN5xYAzAoWe0l3qDJwx7cneoKdsOVvCD5xt2mmihHdHo0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702062735; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2/ZJBxQx+a/oBJOsQBV1mcDu69d7gKxirFUm2tSNNUI=; b=b7pNK4TyHa1cBCITfj3FogLqTi8UcJUoWUsTj6BKnHq4stHSmsOM2zyqTQK6Harz/IX5abS3mfMeGiYG7NFqFuotrXDDxMxD16/HJU6DLs5LBvgE2hMYyaxw+cYb6Mb3wJjv6EoeVJuTf0MJhcY/RRPYGGAM0yUyhXfn5WsHQSg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1702062735308213.59010028821672; Fri, 8 Dec 2023 11:12:15 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rBgFr-0000ky-Jp; Fri, 08 Dec 2023 14:11:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBgFn-0000hp-76 for qemu-devel@nongnu.org; Fri, 08 Dec 2023 14:11:15 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBgFd-0003ft-7F for qemu-devel@nongnu.org; Fri, 08 Dec 2023 14:11:12 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-302--3UFl49BNJGS3COW1tbAWg-1; Fri, 08 Dec 2023 14:09:55 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 68F6F85A589; Fri, 8 Dec 2023 19:09:54 +0000 (UTC) Received: from p1.localdomain.com (ovpn-114-104.gru2.redhat.com [10.97.114.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 63036112131D; Fri, 8 Dec 2023 19:09:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702062663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2/ZJBxQx+a/oBJOsQBV1mcDu69d7gKxirFUm2tSNNUI=; b=K6VPyrVvJAppkqaRqCgRCkpTsQb4hEfVIPKZJtA7NZPHDaIIw7GcjmUx6TLg3cqsHU4IXX AnaSCJB4o8kW995/8qSLf0P6O941bCvJkf4wJ18nD217Vdt1IoU9yz23v31yzIdhSgP9h+ 5y5LBAnhfTMzQxdUUwa+PBZys1Svmos= X-MC-Unique: -3UFl49BNJGS3COW1tbAWg-1 From: Cleber Rosa To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Radoslaw Biernacki , Paul Durrant , Akihiko Odaki , Leif Lindholm , Peter Maydell , Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , kvm@vger.kernel.org, qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Beraldo Leal , Wainer dos Santos Moschetta , Sriram Yagnaraman , Marcin Juszkiewicz , Cleber Rosa , David Woodhouse Subject: [PATCH 10/10] tests/avocado/boot_xen.py: use class attribute Date: Fri, 8 Dec 2023 14:09:11 -0500 Message-ID: <20231208190911.102879-11-crosa@redhat.com> In-Reply-To: <20231208190911.102879-1-crosa@redhat.com> References: <20231208190911.102879-1-crosa@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=crosa@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1702062736464100002 Content-Type: text/plain; charset="utf-8" Rather than defining a single use variable, let's just use the class attribute directly. Signed-off-by: Cleber Rosa Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tests/avocado/boot_xen.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/avocado/boot_xen.py b/tests/avocado/boot_xen.py index f4b63c1ef2..f29bc58b9e 100644 --- a/tests/avocado/boot_xen.py +++ b/tests/avocado/boot_xen.py @@ -50,11 +50,10 @@ def launch_xen(self, xen_path): =20 self.vm.set_console() =20 - xen_command_line =3D self.XEN_COMMON_COMMAND_LINE self.vm.add_args('-machine', 'virtualization=3Don', '-m', '768', '-kernel', xen_path, - '-append', xen_command_line, + '-append', self.XEN_COMMON_COMMAND_LINE, '-device', 'guest-loader,addr=3D0x47000000,kernel=3D%s,boota= rgs=3Dconsole=3Dhvc0' % (kernel_path)) --=20 2.43.0