From nobody Wed Nov 27 04:45:58 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1701708279; cv=none; d=zohomail.com; s=zohoarc; b=Tz92yMF/hilCKSA/rFE0jNe3a0Ok1APD8QhwaBngaCe4h1zwpEu/uP+ogFMauFjkioFsLT8WE+oSuVvpWFChD9Dun0l3FMRNJF2NVRlAKpviddFEZePOQSW9/qMHuWffRFsgmVvz8xaTSUKYGyRA29JoZIxMRnkWGwEwiCA7Af0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1701708279; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=etFa0T/3g4Vz8zVD5Uqj12qgEaaNIPMHbzLF/3mOxAg=; b=d2UqXI3CX9L7Zrnw1GW/UlkGTQsUAh2Bk4cvq7wZ+RYCsrFQ/C6rFlyuPtWspDNufbL5JUyQ/McRWS6TpQvACXM3iFYhX150Mzl2FSQVaxJUG+W5Mjb3ltR1j6zI+OkXoV3Kpyu241O711fZUB7P/fJZvbcbukBNh6RODX55czg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1701708279773134.62202949640596; Mon, 4 Dec 2023 08:44:39 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rAC2r-0005gw-5x; Mon, 04 Dec 2023 11:43:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rAC2m-0005g8-Gr for qemu-devel@nongnu.org; Mon, 04 Dec 2023 11:43:40 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rAC2l-0003f0-0c for qemu-devel@nongnu.org; Mon, 04 Dec 2023 11:43:40 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-317-uCOf092HMb6_efvT289IDw-1; Mon, 04 Dec 2023 11:43:33 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F3FE481C97E; Mon, 4 Dec 2023 16:43:32 +0000 (UTC) Received: from localhost (unknown [10.39.192.247]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7A6711C060BD; Mon, 4 Dec 2023 16:43:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701708216; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=etFa0T/3g4Vz8zVD5Uqj12qgEaaNIPMHbzLF/3mOxAg=; b=J0ioj019B2fcSRLG/Vr6XxUTDbWRU1WpmDrPiVDS5wwG6oYI9aoNZPIMWyaujXTJUiKUkq lscgDck6rE28jwMPLW7jWNbnXNODsy8q45OnhyK+nd2bMM4NCjPYnASZJF4N3FssbXhnQU PJxGmyQYq1jthXI2/S+NLXEh2z7gObU= X-MC-Unique: uCOf092HMb6_efvT289IDw-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Peter Xu , "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , David Hildenbrand , Paolo Bonzini , Fam Zheng , Stefan Hajnoczi , Eric Blake , Kevin Wolf Subject: [PATCH v2 2/4] virtio-scsi: don't lock AioContext around virtio_queue_aio_attach_host_notifier() Date: Mon, 4 Dec 2023 11:42:57 -0500 Message-ID: <20231204164259.1515217-3-stefanha@redhat.com> In-Reply-To: <20231204164259.1515217-1-stefanha@redhat.com> References: <20231204164259.1515217-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1701708280087100001 Content-Type: text/plain; charset="utf-8" virtio_queue_aio_attach_host_notifier() does not require the AioContext lock. Stop taking the lock and add an explicit smp_wmb() because we were relying on the implicit barrier in the AioContext lock before. Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake Reviewed-by: Kevin Wolf --- hw/scsi/virtio-scsi-dataplane.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/scsi/virtio-scsi-dataplane.c b/hw/scsi/virtio-scsi-dataplan= e.c index 1e684beebe..135e23fe54 100644 --- a/hw/scsi/virtio-scsi-dataplane.c +++ b/hw/scsi/virtio-scsi-dataplane.c @@ -149,23 +149,17 @@ int virtio_scsi_dataplane_start(VirtIODevice *vdev) =20 memory_region_transaction_commit(); =20 - /* - * These fields are visible to the IOThread so we rely on implicit bar= riers - * in aio_context_acquire() on the write side and aio_notify_accept() = on - * the read side. - */ s->dataplane_starting =3D false; s->dataplane_started =3D true; + smp_wmb(); /* paired with aio_notify_accept() */ =20 if (s->bus.drain_count =3D=3D 0) { - aio_context_acquire(s->ctx); virtio_queue_aio_attach_host_notifier(vs->ctrl_vq, s->ctx); virtio_queue_aio_attach_host_notifier_no_poll(vs->event_vq, s->ctx= ); =20 for (i =3D 0; i < vs->conf.num_queues; i++) { virtio_queue_aio_attach_host_notifier(vs->cmd_vqs[i], s->ctx); } - aio_context_release(s->ctx); } return 0; =20 --=20 2.43.0