From nobody Wed Nov 27 06:48:40 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1700637958; cv=none; d=zohomail.com; s=zohoarc; b=YmQ5pMd3lmtYyZ/j+ufmjVKh9g6BsytYo1Gqh9vBdjGFH17L9u9LV21YctnmR2GuFcMlZCKhSC8RTczgjYWMPWWYwcb6E44LgMAst2xJRDsAhb3FKRRaHLFpZYecUeem4148tNY9xp/OrlHEv/9A/isn6g5JzoVngS3/FZd91rI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1700637958; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=G6TnX9Kxvfwwi76JemoBX3SqpT8cHEynqAZXqVh+SQc=; b=FRS5Iw/EGfS5Rg8uTyBAFKDHke7xwZB2EyW2Y8gss7krblHE6c+xradCd5AaMj1G+SYXdm8TOg/Od/Aw1IxHuIymEfxo2SRFMM9hUTIynbxra+7Fo8e39cB7udF+Ll+FhRh7XMgHUymvbxdWJXoAdScQes/EdGaZsDneexJrBlY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1700637958552428.9097251699717; Tue, 21 Nov 2023 23:25:58 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r5hbh-0002qc-EK; Wed, 22 Nov 2023 02:25:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r5hbe-0002pi-Hy for qemu-devel@nongnu.org; Wed, 22 Nov 2023 02:25:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r5hbc-0000pR-NZ for qemu-devel@nongnu.org; Wed, 22 Nov 2023 02:25:06 -0500 Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-237-R57YFIk9NxKxUkJQyWMP_A-1; Wed, 22 Nov 2023 02:24:57 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A26A51C0514C; Wed, 22 Nov 2023 07:24:57 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.148]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7F9471121306; Wed, 22 Nov 2023 07:24:57 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 655D221E6A21; Wed, 22 Nov 2023 08:24:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700637901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G6TnX9Kxvfwwi76JemoBX3SqpT8cHEynqAZXqVh+SQc=; b=amXkiQxXM5b4isIhwhHq76tnlS6RKcT6QXUYA6oop8Kus2ia0uEcl+oKcgfJrejYy+0UBo C2GCYnRGd89iRw239TbFxhPEfmmuOiWhdzW+qMGZkmuDX4C8n5ewEkPu3i0/P/jeUxrhmo xFmq4FeIN/NGeiy51NwWeg4SFqjpf7Y= X-MC-Unique: R57YFIk9NxKxUkJQyWMP_A-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: michael.roth@amd.com Subject: [PATCH 1/3] tests/unit/test-qmp-event: Drop superfluous mutex Date: Wed, 22 Nov 2023 08:24:54 +0100 Message-ID: <20231122072456.2518816-2-armbru@redhat.com> In-Reply-To: <20231122072456.2518816-1-armbru@redhat.com> References: <20231122072456.2518816-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1700637959510100001 Content-Type: text/plain; charset="utf-8" Mutex @test_event_lock is held from fixture setup to teardown, protecting global variable @test_event_data. But tests always run one after the other, so this is superfluous. It also confuses Coverity. Drop the mutex. Fixes: CID 1527425 Signed-off-by: Markus Armbruster Reviewed-by: Thomas Huth --- tests/unit/test-qmp-event.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/tests/unit/test-qmp-event.c b/tests/unit/test-qmp-event.c index 3626d2372f..c2c44687d5 100644 --- a/tests/unit/test-qmp-event.c +++ b/tests/unit/test-qmp-event.c @@ -30,7 +30,6 @@ typedef struct TestEventData { } TestEventData; =20 TestEventData *test_event_data; -static GMutex test_event_lock; =20 void test_qapi_event_emit(test_QAPIEvent event, QDict *d) { @@ -59,9 +58,6 @@ void test_qapi_event_emit(test_QAPIEvent event, QDict *d) static void event_prepare(TestEventData *data, const void *unused) { - /* Global variable test_event_data was used to pass the expectation, so - test cases can't be executed at same time. */ - g_mutex_lock(&test_event_lock); test_event_data =3D data; } =20 @@ -69,7 +65,6 @@ static void event_teardown(TestEventData *data, const void *unused) { test_event_data =3D NULL; - g_mutex_unlock(&test_event_lock); } =20 static void event_test_add(const char *testpath, --=20 2.41.0