From nobody Wed Nov 27 07:38:29 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1700493080; cv=none; d=zohomail.com; s=zohoarc; b=Sut/jbgqExYFz3ZllYrg8/VLzVnbCngY3tNmk4BG9PWUWoUnithZ2hqaw3y/RotGrFyKzxoiptmvK6RMHG760QblNAb64kj/OC0jOKXISN5Bsb9jmDCfMtcEco2+RBk09CyySsm26MXR45UenlfsX4yRPSXq6ycHfjC6KxsQ3mM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1700493080; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=MdYIuvPCwbs1/SkyidzDPaAAsnYLQJ1SQQvqDWTDjY4=; b=lq+SlOy7Z8QGrMaGeIvhH08bf34SqRrmEF03yunFAhFxPN+r+Vm7Hf1B17kzp1fGcyGLt39bIn31KsqXf4zHRZcHyqi5XVoaX/w7NGvq7tA6KrYAu3ieUS5pU6l01SUi1afjtXgFvhJN/WxbtT2nHSiku/pz2g8eakEvoyvptIw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 170049308045611.75021989987306; Mon, 20 Nov 2023 07:11:20 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r55tf-0006LZ-LN; Mon, 20 Nov 2023 10:09:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r55tR-0005tj-Ho for qemu-devel@nongnu.org; Mon, 20 Nov 2023 10:09:00 -0500 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r55tG-0001Hr-8n for qemu-devel@nongnu.org; Mon, 20 Nov 2023 10:08:54 -0500 Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-50943ccbbaeso6230384e87.2 for ; Mon, 20 Nov 2023 07:08:43 -0800 (PST) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id e29-20020adfa45d000000b0033169451a84sm11501414wra.29.2023.11.20.07.08.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 07:08:38 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id CD30865777; Mon, 20 Nov 2023 15:08:34 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700492922; x=1701097722; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MdYIuvPCwbs1/SkyidzDPaAAsnYLQJ1SQQvqDWTDjY4=; b=m6JTyB23Uz+26G2fTIGU0iRylMm+0RbjDkZiSu4MHuUs4PEPVq6/AF1fo/17ljRStr /+feY3oSx9RMbbT1U7eYjWKZp15GSilihxT+tSdlTo4UmiCQRdnGYpPR7fZGSW38z17n ldEoR3IAZ+rsTjFUkSikOJKGDvNyaAA2ZkeY9otPRMjbWk/xBtxbDKCmZ0LdXLk67UlL 5sf+5wVJfrqkkL+15p/2CLA9pfgBYtoLmmva/mkkjigI+EgyAYTkIFpZPSfTsS2Cw4Hh dImMv+qDYL+lSKVBlMN5EITeqnVzHp7tCVqZdqGcT70LF9fqw/W1BM/j2flIbMmD7YSo aUyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700492922; x=1701097722; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MdYIuvPCwbs1/SkyidzDPaAAsnYLQJ1SQQvqDWTDjY4=; b=M2XZTvNk2pfO0AllhUfNEG47fGfb0Z2qyE9FXPDQGq/L2UvYu3rHLnTkH+YH4isQlt 9G4uDpKKN3I/Rm/5HCRe7tCJi3dEu10NMikAT4puYxboUdBXcMJ/EpYE03434wd+Nuvu cRWfcb7Bzu8DANjqY/WgPozaTtrmZc/K7wLnq2tDXUYMGcdehQ6PszB3/b5ztQIKQwGy 1VRoQTNfWKBoOXHHFJEtmmzTSG0UxuVrx2MRU1xtAisZM0s4b+4trnS3Pdc03Mt+UdG0 mj8JO8mLHAAT8AxgRZVdonWtcBkpt03DstU6ycRoxVlfhW7tlGuL2MDX7UntCwK5Mh1a jB0g== X-Gm-Message-State: AOJu0YzTnXwUeBijo6Bi3AA/ePOsn72uuzRg4KKwE/U82x4KYRO9HzSt sZqmjPpy+l6/bMjruan7yEkqig== X-Google-Smtp-Source: AGHT+IHGOkrx0KapVhaxqiUy8V1IlL2HM4IzeBDQH/UBvJi7eaZoPYIvqDtpZNvM6TAVX1cDEkEiYQ== X-Received: by 2002:ac2:4469:0:b0:509:e5a4:2b03 with SMTP id y9-20020ac24469000000b00509e5a42b03mr5760174lfl.13.1700492922721; Mon, 20 Nov 2023 07:08:42 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Mahmoud Mandour , Peter Maydell , David Hildenbrand , =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-s390x@nongnu.org, Beraldo Leal , qemu-arm@nongnu.org, devel@lists.libvirt.org, qemu-ppc@nongnu.org, Daniel Henrique Barboza , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alexandre Iooss , Marek Vasut , Thomas Huth , Chris Wulff , Ilya Leoshkevich , Richard Henderson , Nicholas Piggin Subject: [PATCH v2 09/14] hw/core: skip loading debug on all failures Date: Mon, 20 Nov 2023 15:08:28 +0000 Message-Id: <20231120150833.2552739-10-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231120150833.2552739-1-alex.bennee@linaro.org> References: <20231120150833.2552739-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::136; envelope-from=alex.bennee@linaro.org; helo=mail-lf1-x136.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1700493081628100001 ELF_LOAD_FAILED is one of many negative return codes we can have. Lets treat any positive size_t as a success for loading. Message-Id: <20231115205542.3092038-8-alex.bennee@linaro.org> Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Alex Benn=C3=A9e --- hw/core/loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/core/loader.c b/hw/core/loader.c index 3c79283777..e7a9b3775b 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -505,7 +505,7 @@ ssize_t load_elf_ram_sym(const char *filename, clear_lsb, data_swab, as, load_rom, sym_cb); } =20 - if (ret !=3D ELF_LOAD_FAILED) { + if (ret > 0) { debuginfo_report_elf(filename, fd, 0); } =20 --=20 2.39.2