From nobody Wed Nov 27 06:27:02 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1700214888; cv=none; d=zohomail.com; s=zohoarc; b=lR1wvPawu0H9qyBCH4mDzOyJXZc4I/ZkEAofu+rmAvz9aF5wibJ3RvwNrS6WASxtH2cRWLzBdNm2v7bz9sWqo0vZ++/SWl2ll7mmfFxXwospdU94LC0zGcKnPfou5hf1POSjTpCBnjmrbVE2HLcUZO0RMonldcDtM3hF4JXhZck= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1700214888; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=CHPoP9r353pL/nxEH9yEuVzWmT10zTbW5debocMeFww=; b=cuhJnwHE+giHx3J+XozFnh3tIc20dOINIrCloJyYEyZRhlJFzkM17O4Ytvz7ds4d/4aIn97nK7GReEQj6gFF/Uiavh0sWGN9vTfzcyZmhDMOMAAwBBvyaOGE4I4yu3lzMkcKIXRd2QHn5piio7v9YlZ4kvQMdaMhSiKuSxqukvY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1700214888321483.9581519809858; Fri, 17 Nov 2023 01:54:48 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r3vXj-0007rm-Co; Fri, 17 Nov 2023 04:53:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3vXh-0007oy-Eq for qemu-devel@nongnu.org; Fri, 17 Nov 2023 04:53:41 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3vXf-0006fQ-LR for qemu-devel@nongnu.org; Fri, 17 Nov 2023 04:53:41 -0500 Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-146-BkvK3e6RPvGkcoBADsP2VA-1; Fri, 17 Nov 2023 04:53:37 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EEBA81C05AB0 for ; Fri, 17 Nov 2023 09:53:36 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.91]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CDB1040C6EB9 for ; Fri, 17 Nov 2023 09:53:36 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id E6E0121E6922; Fri, 17 Nov 2023 10:53:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700214819; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CHPoP9r353pL/nxEH9yEuVzWmT10zTbW5debocMeFww=; b=STCi4iTRzY4HvmHJetT8EDecyhVy4xiXb97S2P9/3RakNhTpJBeHZmqBo63SUrmzIp05oj tgLhegeACAluKZ+Xvs4XrsgbXW8PEg1GIjrgb1Jr3WrHj0zJgRMmPcfq7vTG+mQ1FVtXhV qKqG+0ovxP8udBDrajHG9gEDA2TMe2E= X-MC-Unique: BkvK3e6RPvGkcoBADsP2VA-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, David Hildenbrand , "Michael S . Tsirkin" , Mario Casquero Subject: [PULL 6/7] balloon: Fix a misleading error message Date: Fri, 17 Nov 2023 10:53:33 +0100 Message-ID: <20231117095334.1819613-7-armbru@redhat.com> In-Reply-To: <20231117095334.1819613-1-armbru@redhat.com> References: <20231117095334.1819613-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.117, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1700214889922100006 Content-Type: text/plain; charset="utf-8" The error message {"execute": "balloon", "arguments":{"value": -1}} {"error": {"class": "GenericError", "desc": "Parameter 'target' expects= a size"}} points to 'target' instead of 'value'. Fix: {"error": {"class": "GenericError", "desc": "Parameter 'value' expects = a size"}} Root cause: qmp_balloon()'s parameter is named @target. Rename it to @value to match the QAPI schema. Signed-off-by: Markus Armbruster Message-ID: <20231031111059.3407803-7-armbru@redhat.com> Reviewed-by: David Hildenbrand Reviewed-by: Michael S. Tsirkin Tested-by: Mario Casquero --- system/balloon.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/system/balloon.c b/system/balloon.c index e0e8969a4b..fda7af832e 100644 --- a/system/balloon.c +++ b/system/balloon.c @@ -90,17 +90,17 @@ BalloonInfo *qmp_query_balloon(Error **errp) return info; } =20 -void qmp_balloon(int64_t target, Error **errp) +void qmp_balloon(int64_t value, Error **errp) { if (!have_balloon(errp)) { return; } =20 - if (target <=3D 0) { - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "target", "a size"); + if (value <=3D 0) { + error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "value", "a size"); return; } =20 - trace_balloon_event(balloon_opaque, target); - balloon_event_fn(balloon_opaque, target); + trace_balloon_event(balloon_opaque, value); + balloon_event_fn(balloon_opaque, value); } --=20 2.41.0