From nobody Wed Nov 27 07:32:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1700214831; cv=none; d=zohomail.com; s=zohoarc; b=fN163wfsDTOD2b2+aAaNyCRMr0h4sLYerklpXOKMlQqw6vUduTODDLadEbOsrX91t+DDBm9CDfRwifpX132lCHaLnifJY2DPBt31AYL26K5xnHyjDhzFKVaFDdUaGRRvxOufUNmjMoCkp/iOkYez17icxMU610ZD8ZV7oY1siOw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1700214831; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=jw/isfbp3xt/B11NQG83ja0Vh09xM5FOXvP5SNGXNnM=; b=AXCOC2Q2ywoF2R8U3VvcQTFxuXDoEs3D4SDjBS/htchItpCGPiAUZLprVv556c5/1ff6Oblk+sWtEXOe9mvAXh6CFYsqowSpobvKwnkPN7da08CyooixSszmMDPv8t4ZAJjFSpWxtRIVTYKHx2doFxjpZgxtRUTH2mf8v4F7oqc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17002148311531019.4423272466466; Fri, 17 Nov 2023 01:53:51 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r3vXk-0007sd-9s; Fri, 17 Nov 2023 04:53:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3vXj-0007pH-0Z for qemu-devel@nongnu.org; Fri, 17 Nov 2023 04:53:43 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3vXh-0006fT-74 for qemu-devel@nongnu.org; Fri, 17 Nov 2023 04:53:42 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-98-rl3qgInoOO6Dp_d5EXxt7Q-1; Fri, 17 Nov 2023 04:53:37 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ED98D85A59D for ; Fri, 17 Nov 2023 09:53:36 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.91]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CCD681121306 for ; Fri, 17 Nov 2023 09:53:36 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id E3E6621E6921; Fri, 17 Nov 2023 10:53:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700214819; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jw/isfbp3xt/B11NQG83ja0Vh09xM5FOXvP5SNGXNnM=; b=TnawN/KZxO0na2gRij57q2QsZvtkX8hm5jcVU+V+tZUxf015rFQ4tz6aY9VtjPVh5jz42r iE5PX8BwjdwKgFMIE56PgF4vUDZ8BFGF+H7mQBecM3Uu+lYAjm5kJbOilI43LKEF96g1dy JPp3zeLkrrNapEwphpDkaLvP+lA5KMc= X-MC-Unique: rl3qgInoOO6Dp_d5EXxt7Q-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: stefanha@redhat.com Subject: [PULL 5/7] net: Fix a misleading error message Date: Fri, 17 Nov 2023 10:53:32 +0100 Message-ID: <20231117095334.1819613-6-armbru@redhat.com> In-Reply-To: <20231117095334.1819613-1-armbru@redhat.com> References: <20231117095334.1819613-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.117, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1700214831767100001 Content-Type: text/plain; charset="utf-8" The error message $ qemu-system-x86_64 -netdev user,id=3Dnet0,ipv6-net=3Dfec0::0/ qemu-system-x86_64: -netdev user,id=3Dnet0,ipv6-net=3Dfec0::0/: Paramet= er 'ipv6-prefixlen' expects a number points to ipv6-prefixlen instead of ipv6-net. Fix: qemu-system-x86_64: -netdev user,id=3Dnet0,ipv6-net=3Dfec0::0/: paramet= er 'ipv6-net' expects a number after '/' Signed-off-by: Markus Armbruster Message-ID: <20231031111059.3407803-6-armbru@redhat.com> --- net/net.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/net.c b/net/net.c index c0c0cbe99e..8e67a20abc 100644 --- a/net/net.c +++ b/net/net.c @@ -1227,7 +1227,7 @@ static int net_client_init(QemuOpts *opts, bool is_ne= tdev, Error **errp) int ret =3D -1; Visitor *v =3D opts_visitor_new(opts); =20 - /* Parse convenience option format ip6-net=3Dfec0::0[/64] */ + /* Parse convenience option format ipv6-net=3Dfec0::0[/64] */ const char *ip6_net =3D qemu_opt_get(opts, "ipv6-net"); =20 if (ip6_net) { @@ -1247,8 +1247,8 @@ static int net_client_init(QemuOpts *opts, bool is_ne= tdev, Error **errp) if (substrings[1] && qemu_strtoul(substrings[1], NULL, 10, &prefix_len)) { - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, - "ipv6-prefixlen", "a number"); + error_setg(errp, + "parameter 'ipv6-net' expects a number after '/'"); goto out; } =20 --=20 2.41.0