From nobody Wed Nov 27 09:48:29 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1700043766; cv=none; d=zohomail.com; s=zohoarc; b=L287IXooYM8TfuChpuKlajtz3JkfxollpohX4rJele5BhLXapiRFKor12ftVPfJWchv5oa5uj3zHWaTWxtXczubWrze2WzjUQP5ol5VLdocV2pXnUfY7+5t+fYQgAsas2emOZ9ZjCFwlNL1BmVLzRSqazfVn/WYa+5iUbNa2/6E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1700043766; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=X+vdUCP8QcQyY6rCf/ZhNb44cHngi8TlCy6eUaEtkYc=; b=Jw7/LmMk96riPTTbdWLOH2XRfVyhJURQ6cqr7CVVHlgPS+cl+g7SMx+mE72Ctmw/jw9Ry6sGjaCPP8ZHuIdug0xl7X04MvzJIQA5xwJRuRO5lMJxwP+EmafviB6FMjESsv9NE4YzA3zbQEH5a13I0h+TtJ0/NJ5VfaswBDsFmvQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1700043766551895.7014400000669; Wed, 15 Nov 2023 02:22:46 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r3D2T-0003KL-Ku; Wed, 15 Nov 2023 05:22:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3D2Q-0003JW-2X for qemu-devel@nongnu.org; Wed, 15 Nov 2023 05:22:26 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3D2N-0005p9-VT for qemu-devel@nongnu.org; Wed, 15 Nov 2023 05:22:25 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-604-REtEfAUNPYqRMmL80zYbfw-1; Wed, 15 Nov 2023 05:22:18 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 90CB2811E7B for ; Wed, 15 Nov 2023 10:22:18 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.45.226.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id D5A6F40C6EB9; Wed, 15 Nov 2023 10:22:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700043740; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X+vdUCP8QcQyY6rCf/ZhNb44cHngi8TlCy6eUaEtkYc=; b=Y/P908gyyPwxDAeTo2JzLVSoUQRgheAxdbDViTkcKwN/dY5YrJHgHLjSgA6DGVK3jj7rBt YosthATICNP9FCBMXulttBSE9B8UGSFk0E+mqP4q6Jdak8fv6gAPNqwSru0HnQVv6SID7U 9b6ShTrWj7lTC5lFoiZ7mpMNKeVJZ9U= X-MC-Unique: REtEfAUNPYqRMmL80zYbfw-1 From: Vitaly Kuznetsov To: qemu-devel@nongnu.org, Paolo Bonzini Cc: Marcelo Tosatti Subject: [PATCH RESEND v2 2/2] i386: Exclude 'hv-syndbg' from 'hv-passthrough' Date: Wed, 15 Nov 2023 11:22:15 +0100 Message-ID: <20231115102215.372012-3-vkuznets@redhat.com> In-Reply-To: <20231115102215.372012-1-vkuznets@redhat.com> References: <20231115102215.372012-1-vkuznets@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=vkuznets@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1700043767091100001 Content-Type: text/plain; charset="utf-8" Windows with Hyper-V role enabled doesn't boot with 'hv-passthrough' when no debugger is configured, this significantly limits the usefulness of the feature as there's no support for subtracting Hyper-V features from CPU flags at this moment (e.g. "-cpu host,hv-passthrough,-hv-syndbg" does not work). While this is also theoretically fixable, 'hv-syndbg' is likely very special and unneeded in the default set. Genuine Hyper-V doesn't seem to enable it either. Introduce 'skip_passthrough' flag to 'kvm_hyperv_properties' and use it as one-off to skip 'hv-syndbg' when enabling features in 'hv-passthrough' mode. Note, "-cpu host,hv-passthrough,hv-syndbg" can still be used if needed. As both 'hv-passthrough' and 'hv-syndbg' are debug features, the change should not have any effect on production environments. Signed-off-by: Vitaly Kuznetsov --- docs/system/i386/hyperv.rst | 13 +++++++++---- target/i386/kvm/kvm.c | 7 +++++-- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/docs/system/i386/hyperv.rst b/docs/system/i386/hyperv.rst index 2505dc4c86e0..009947e39141 100644 --- a/docs/system/i386/hyperv.rst +++ b/docs/system/i386/hyperv.rst @@ -262,14 +262,19 @@ Supplementary features ``hv-passthrough`` In some cases (e.g. during development) it may make sense to use QEMU in 'pass-through' mode and give Windows guests all enlightenments currently - supported by KVM. This pass-through mode is enabled by "hv-passthrough" = CPU - flag. + supported by KVM. =20 Note: ``hv-passthrough`` flag only enables enlightenments which are know= n to QEMU (have corresponding 'hv-' flag) and copies ``hv-spinlocks`` and ``hv-ven= dor-id`` values from KVM to QEMU. ``hv-passthrough`` overrides all other 'hv-' se= ttings on - the command line. Also, enabling this flag effectively prevents migratio= n as the - list of enabled enlightenments may differ between target and destination= hosts. + the command line. + + Note: ``hv-passthrough`` does not enable ``hv-syndbg`` which can prevent= certain + Windows guests from booting when used without proper configuration. If n= eeded, + ``hv-syndbg`` can be enabled additionally. + + Note: ``hv-passthrough`` effectively prevents migration as the list of e= nabled + enlightenments may differ between target and destination hosts. =20 ``hv-enforce-cpuid`` By default, KVM allows the guest to use all currently supported Hyper-V diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index 2fcb1f6673d8..0c745562b667 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -823,6 +823,7 @@ static struct { uint32_t bits; } flags[2]; uint64_t dependencies; + bool skip_passthrough; } kvm_hyperv_properties[] =3D { [HYPERV_FEAT_RELAXED] =3D { .desc =3D "relaxed timing (hv-relaxed)", @@ -951,7 +952,8 @@ static struct { {.func =3D HV_CPUID_FEATURES, .reg =3D R_EDX, .bits =3D HV_FEATURE_DEBUG_MSRS_AVAILABLE} }, - .dependencies =3D BIT(HYPERV_FEAT_SYNIC) | BIT(HYPERV_FEAT_RELAXED) + .dependencies =3D BIT(HYPERV_FEAT_SYNIC) | BIT(HYPERV_FEAT_RELAXED= ), + .skip_passthrough =3D true, }, [HYPERV_FEAT_MSR_BITMAP] =3D { .desc =3D "enlightened MSR-Bitmap (hv-emsr-bitmap)", @@ -1360,7 +1362,8 @@ bool kvm_hyperv_expand_features(X86CPU *cpu, Error **= errp) * hv_build_cpuid_leaf() uses this info to build guest CPUIDs. */ for (feat =3D 0; feat < ARRAY_SIZE(kvm_hyperv_properties); feat++)= { - if (hyperv_feature_supported(cs, feat)) { + if (hyperv_feature_supported(cs, feat) && + !kvm_hyperv_properties[feat].skip_passthrough) { cpu->hyperv_features |=3D BIT(feat); } } --=20 2.41.0