From nobody Wed Nov 27 08:36:46 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1699962263; cv=none; d=zohomail.com; s=zohoarc; b=RKRPDnsLur53JksaVVIM1BoOoBbHcNRc8GF61YLAPdXTT7+UGIuH9cXdUxvvIC7IMT5gUVLvY3s3tj/0VeCGuOkFPexugY7Y0x469Eqts5IMbxNHPpZ718NykKPqf6YNjI8EQjYxsNNEY1b62KTrdo6ZvhHE75sXXO8r/esbw8c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1699962263; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=wnU4m+nnvKKrpGXKmgU9CiQ2rWBumI9JSEF8gwG1iXE=; b=kbo4A6bqAaplCErH68x6ISGFqfFefmjUej10taV/LKs4ZHrwtBhBDPwtv/0Z+nVHCBt3GL8p4VOxxwaX5dWhRuaz+d1uQ14CbttVfWnpEfEgUrx3Bb27tHt6qzsWFPwnKq0JdwjAgeLAW9EKZyU/LRrYoc+ufsGAOjQlJyDiH6A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1699962263339341.0022112323369; Tue, 14 Nov 2023 03:44:23 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r2rpR-0004LX-DM; Tue, 14 Nov 2023 06:43:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2rpP-0004Kj-5Y for qemu-devel@nongnu.org; Tue, 14 Nov 2023 06:43:35 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2rpN-0005kY-Mg for qemu-devel@nongnu.org; Tue, 14 Nov 2023 06:43:34 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-369-3TNRcmosN-mygkUTGETlAA-1; Tue, 14 Nov 2023 06:43:28 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0D24B101A52D; Tue, 14 Nov 2023 11:43:27 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.192.119]) by smtp.corp.redhat.com (Postfix) with ESMTP id 37A152026D4C; Tue, 14 Nov 2023 11:43:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699962211; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wnU4m+nnvKKrpGXKmgU9CiQ2rWBumI9JSEF8gwG1iXE=; b=Tqt1Z1kpmSlQ4OVaOxzSuenEh3XcqXx9sdNfGLLVEeYOKEuI1l4XyRHa9JDznzJLTUaSXb gGVAtqjF256kCvdU9NKceeo8u4DTmT1qC2V70nlLXq0afNgWIKumDrjtqJkxid+bOriUJU YwqKzduozWzDZCg3wsIMyf5vmon5D7M= X-MC-Unique: 3TNRcmosN-mygkUTGETlAA-1 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Stefan Hajnoczi , Janosch Frank , Claudio Imbrenda , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PULL 3/3] target/s390x/arch_dump: Add arch cleanup function for PV dumps Date: Tue, 14 Nov 2023 12:43:18 +0100 Message-ID: <20231114114318.158226-4-thuth@redhat.com> In-Reply-To: <20231114114318.158226-1-thuth@redhat.com> References: <20231114114318.158226-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1699962264805100002 From: Janosch Frank PV dumps block vcpu runs until dump end is reached. If there's an error between PV dump init and PV dump end the vm will never be able to run again. One example of such an error is insufficient disk space for the dump file. Let's add a cleanup function that tries to do a dump end. The dump completion data is discarded but there's no point in writing it to a file anyway if there's a possibility that other PV dump data is missing. Signed-off-by: Janosch Frank Reviewed-by: Thomas Huth Reviewed-by: Claudio Imbrenda Reviewed-by: Marc-Andr=C3=A9 Lureau Message-ID: <20231109120443.185979-4-frankja@linux.ibm.com> Signed-off-by: Thomas Huth --- target/s390x/arch_dump.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/target/s390x/arch_dump.c b/target/s390x/arch_dump.c index bdb0bfa0e7..7e8a1b4fc0 100644 --- a/target/s390x/arch_dump.c +++ b/target/s390x/arch_dump.c @@ -433,6 +433,22 @@ static int arch_sections_write(DumpState *s, uint8_t *= buff) return 0; } =20 +static void arch_cleanup(DumpState *s) +{ + g_autofree uint8_t *buff =3D NULL; + int rc; + + if (!pv_dump_initialized) { + return; + } + + buff =3D g_malloc(kvm_s390_pv_dmp_get_size_completion_data()); + rc =3D kvm_s390_dump_completion_data(buff); + if (!rc) { + pv_dump_initialized =3D false; + } +} + int cpu_get_dump_info(ArchDumpInfo *info, const struct GuestPhysBlockList *guest_phys_blocks) { @@ -448,6 +464,7 @@ int cpu_get_dump_info(ArchDumpInfo *info, info->arch_sections_add_fn =3D *arch_sections_add; info->arch_sections_write_hdr_fn =3D *arch_sections_write_hdr; info->arch_sections_write_fn =3D *arch_sections_write; + info->arch_cleanup_fn =3D *arch_cleanup; } return 0; } --=20 2.41.0