From nobody Wed Nov 27 09:52:31 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1699957681; cv=none; d=zohomail.com; s=zohoarc; b=czFQQXYUIkQIEEMHUAROsWIWL+fgA9n6TCmqHiWKpO0lN+3QnebKhHIDDgyH6gt1JaZqQjnsP0gJZqCsPdQW9R18zH6KrS1k62D9kCfFUh+UuA/3SB8kPLyt8cno4CrlhhRD1RB2iyXVlF9D0fy75SLyds1Bk721yqvZRskeRdc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1699957681; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=fqdG77ByAAMEw3REUPbJoKue2E9ZlS3ywRBL9l8YEOk=; b=TnZLeAQ69peiwI/cVRekmhGZleqKxJxzFd+EjziHJhNzY506NeRAiMPzNNoRrZcs10kIWwuXlk4c47cpZwMkldHTQN2bf/4aaZhjQEhpu9fYWdgRSNaUbTeU9pvped7jMlbAStKDzokuU2s8wdvjpoKL22Tmn8+l4ztjNE+6DIw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1699957681827337.5497803029548; Tue, 14 Nov 2023 02:28:01 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r2qcG-00034W-6q; Tue, 14 Nov 2023 05:25:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2qc2-0002sk-Mh for qemu-devel@nongnu.org; Tue, 14 Nov 2023 05:25:44 -0500 Received: from mgamail.intel.com ([134.134.136.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2qc1-0007dL-1N for qemu-devel@nongnu.org; Tue, 14 Nov 2023 05:25:42 -0500 Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2023 02:25:39 -0800 Received: from duan-server-s2600bt.bj.intel.com ([10.240.192.147]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2023 02:25:35 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699957541; x=1731493541; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=lOMSYfd6Vk4mCdm9aZuJtn+x/0g7nHBaDO8bSoUq0ok=; b=NWUOafLmPZwxsqkVpwxNAoilQkU+ms56+OS5E7agzJ10RdZkFvNzrd1C wKWOteV8aaDRfy+reJzJgfBgZ5ZmJVglqAgAE3rGd1jea2aWchyryg/NI pYM/nxHYy4K55BuflAvWcLOZuqjfbShN5Bx7LLAFnrul8be4hdMb3cKnl ZMj177aFyXm15+vhFwUwcNe30NSLiDnZeyDo/yatkiaKm5hrX6jWYGKko uIdkVIuSNG/KpGGSp5ckg3s6D4nxsyYTUDywW4iHhNhrAoZxkEBUADXGL P/avHyC9wrYcsikczXJV7stYoZQQniHzfaaUai2ZZk0l2Ir/zXrmNRL8M A==; X-IronPort-AV: E=McAfee;i="6600,9927,10893"; a="394543423" X-IronPort-AV: E=Sophos;i="6.03,301,1694761200"; d="scan'208";a="394543423" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10893"; a="888212819" X-IronPort-AV: E=Sophos;i="6.03,301,1694761200"; d="scan'208";a="888212819" From: Zhenzhong Duan To: qemu-devel@nongnu.org Cc: alex.williamson@redhat.com, clg@redhat.com, jgg@nvidia.com, nicolinc@nvidia.com, joao.m.martins@oracle.com, eric.auger@redhat.com, peterx@redhat.com, jasowang@redhat.com, kevin.tian@intel.com, yi.l.liu@intel.com, yi.y.sun@intel.com, chao.p.peng@intel.com, Zhenzhong Duan Subject: [PATCH v6 03/21] vfio/common: return early if space isn't empty Date: Tue, 14 Nov 2023 18:09:37 +0800 Message-Id: <20231114100955.1961974-4-zhenzhong.duan@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231114100955.1961974-1-zhenzhong.duan@intel.com> References: <20231114100955.1961974-1-zhenzhong.duan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=134.134.136.65; envelope-from=zhenzhong.duan@intel.com; helo=mgamail.intel.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1699957683738100003 Content-Type: text/plain; charset="utf-8" This is a trivial optimization. If there is active container in space, vfio_reset_handler will never be unregistered. So revert the check of space->containers and return early. Signed-off-by: Zhenzhong Duan Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Eric Auger --- hw/vfio/common.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 572ae7c934..934f4f5446 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -1462,10 +1462,13 @@ VFIOAddressSpace *vfio_get_address_space(AddressSpa= ce *as) =20 void vfio_put_address_space(VFIOAddressSpace *space) { - if (QLIST_EMPTY(&space->containers)) { - QLIST_REMOVE(space, list); - g_free(space); + if (!QLIST_EMPTY(&space->containers)) { + return; } + + QLIST_REMOVE(space, list); + g_free(space); + if (QLIST_EMPTY(&vfio_address_spaces)) { qemu_unregister_reset(vfio_reset_handler, NULL); } --=20 2.34.1