From nobody Wed Nov 27 06:27:09 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1699871728; cv=none; d=zohomail.com; s=zohoarc; b=i/I2VlsxAD7p4pTgS+rpiYikiqve6rJ87MyjlAX9FeCK//TOHpTDNjMZ7yAucTJ4X0dZaGwbVpcQNTiBTJsXOKJya1xOkHaEH7+aPBQ6gg7ff0Y+8/pm3YvA6yXXRL3dsKBFvAdUVnHUZQpiqAjXKvOyUhgXLmRGKyBYiNSE9Ng= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1699871728; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=vh/QcMRLH4PuQvUhmNxrq2svFkqRQw1ACSw03Qhhmf8=; b=Ua9LLHL7RAdrS4ILukV1S12o/52cB2iXykPcMErnNoENfL/uWUCDTeb549Lv+/oCHoFMzApNLsa4GnuN+o8xkEybbC45w4uqliTIeue6s6OuT043oGe/3wVNHrhaMeYYC11kZEobX8upM/TjrnsWN25R12MT+OZGRjFE0yFHkT0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1699871728105223.28270969511232; Mon, 13 Nov 2023 02:35:28 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r2UH9-0004vL-JL; Mon, 13 Nov 2023 05:34:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2UH7-0004uX-UT for qemu-devel@nongnu.org; Mon, 13 Nov 2023 05:34:37 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2UH6-0003oo-3j for qemu-devel@nongnu.org; Mon, 13 Nov 2023 05:34:37 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-vj6wXDEkPtGUW_3wh9e1AQ-1; Mon, 13 Nov 2023 05:34:33 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C06A2811E86; Mon, 13 Nov 2023 10:34:32 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.91]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8D35C40C6EBA; Mon, 13 Nov 2023 10:34:32 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 7D62021E6A26; Mon, 13 Nov 2023 11:34:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699871674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vh/QcMRLH4PuQvUhmNxrq2svFkqRQw1ACSw03Qhhmf8=; b=M2FxAGyA0eRUz49UdVTkVPbqoxWFy/e5l3Q+5RF2LmJ92jtGDlMsCA3bSTQs5G2T5LC89u 19lXEqlv2VP+qS+pIb5z25CbHYdqcj+RcxA4EOLhcnm4J4zF6cly5+uX6f+yi1asI9/d/B fs0NZul5RkzWzF3tkPAiRz2PItdYSxM= X-MC-Unique: vj6wXDEkPtGUW_3wh9e1AQ-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 1/3] qapi: Fix QAPISchemaEntity.__repr__() Date: Mon, 13 Nov 2023 11:34:29 +0100 Message-ID: <20231113103431.913394-2-armbru@redhat.com> In-Reply-To: <20231113103431.913394-1-armbru@redhat.com> References: <20231113103431.913394-1-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1699871730049100005 I messed it up on merge. It's a debugging aid, so no impact on build. Fixes: e307a8174bb8 (qapi: provide a friendly string representation of QAPI= classes) Signed-off-by: Markus Armbruster Message-ID: <20231024104841.1569250-1-armbru@redhat.com> Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- scripts/qapi/schema.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/qapi/schema.py b/scripts/qapi/schema.py index d739e558e9..6a836950a9 100644 --- a/scripts/qapi/schema.py +++ b/scripts/qapi/schema.py @@ -76,7 +76,8 @@ def __init__(self, name: str, info, doc, ifcond=3DNone, f= eatures=3DNone): def __repr__(self): if self.name is None: return "<%s at 0x%x>" % (type(self).__name__, id(self)) - return "<%s:%s at 0x%x>" % type(self).__name__, self.name, id(self) + return "<%s:%s at 0x%x>" % (type(self).__name__, self.name, + id(self)) =20 def c_name(self): return c_name(self.name) --=20 2.41.0 From nobody Wed Nov 27 06:27:09 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1699871729; cv=none; d=zohomail.com; s=zohoarc; b=BDzDQajJ3LWuzPRv30U9IPT4JnZF+wTQUT9gigdJUXPpdA+NDWpqU5ZykORZt5SBBkQU7fLwQQ+xuvdUgaV/Hr00nN9ekNyHV9klGcuaW/v1AsMFoCfHq19jd0JW4vihl+0HigWUt90XiYuspBvJ2kc0REQQuiJ/rwp4mu/DpNU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1699871729; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=D+kpVpCpHa96AM9uqfu+PCMuf1A9EuVf8AG3yVlTUWY=; b=gkoOOyHkbk8DqPEj2UzIdJDyDnuMzjYx4h7F8yv2pkKanwRPGJDNseJ/Bfrw1WuSgM176SOMsZkfGU4cPN1EEmNzVes3inisYUiJ2fuOx6XCccRFL5S4NFwXFHXGNaJbwkhpVDRGpkfe3NPBCrKyXPBF0YXbHu7QVsmXU20rsIA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1699871729475337.2814647829648; Mon, 13 Nov 2023 02:35:29 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r2UHB-0004wI-5m; Mon, 13 Nov 2023 05:34:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2UH9-0004ur-7A for qemu-devel@nongnu.org; Mon, 13 Nov 2023 05:34:39 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2UH7-0003qS-Dm for qemu-devel@nongnu.org; Mon, 13 Nov 2023 05:34:38 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-595-u1f52s_RNwCoMan2kVx0nA-1; Mon, 13 Nov 2023 05:34:33 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C12DE867900 for ; Mon, 13 Nov 2023 10:34:32 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.91]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9FDFA2026D4C for ; Mon, 13 Nov 2023 10:34:32 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 8082D21E6A28; Mon, 13 Nov 2023 11:34:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699871676; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D+kpVpCpHa96AM9uqfu+PCMuf1A9EuVf8AG3yVlTUWY=; b=bp9orFewlGK2aLMjkXR+EVulY94PBIqUroxDhiJGmOkRavthTsmJVZzvFfQRRPCXA5xBuE 2FUrQZcXZn9gKr+wJtsN08qSCRTlmqoDo/oGfLY7uzJqkTFfc9156x4OrI+SxA1TQBfNup hpP0qRuEzFW2nuvo7js47gxtVA8bfEY= X-MC-Unique: u1f52s_RNwCoMan2kVx0nA-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, John Snow Subject: [PULL 2/3] sphinx/qapidoc: Tidy up pylint warning raise-missing-from Date: Mon, 13 Nov 2023 11:34:30 +0100 Message-ID: <20231113103431.913394-3-armbru@redhat.com> In-Reply-To: <20231113103431.913394-1-armbru@redhat.com> References: <20231113103431.913394-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1699871730053100007 Content-Type: text/plain; charset="utf-8" Pylint advises: docs/sphinx/qapidoc.py:518:12: W0707: Consider explicitly re-raising us= ing 'raise ExtensionError(str(err)) from err' (raise-missing-from) >From its manual: Python's exception chaining shows the traceback of the current exception, but also of the original exception. When you raise a new exception after another exception was caught it's likely that the second exception is a friendly re-wrapping of the first exception. In such cases `raise from` provides a better link between the two tracebacks in the final error. Makes sense, so do it. Signed-off-by: Markus Armbruster Message-ID: <20231025092159.1782638-2-armbru@redhat.com> Reviewed-by: John Snow --- docs/sphinx/qapidoc.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/sphinx/qapidoc.py b/docs/sphinx/qapidoc.py index 8f3b9997a1..658c288f8f 100644 --- a/docs/sphinx/qapidoc.py +++ b/docs/sphinx/qapidoc.py @@ -515,7 +515,7 @@ def run(self): except QAPIError as err: # Launder QAPI parse errors into Sphinx extension errors # so they are displayed nicely to the user - raise ExtensionError(str(err)) + raise ExtensionError(str(err)) from err =20 def do_parse(self, rstlist, node): """Parse rST source lines and add them to the specified node --=20 2.41.0 From nobody Wed Nov 27 06:27:09 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1699871728; cv=none; d=zohomail.com; s=zohoarc; b=DnjcGlZt+knVGflORhnp34bfB4c4NdyMLklsamX/Vr5ArXBJR+7gmCG6pIPxOjLPD2g29SYdMVFPuIOHEqxvc8gf/s7LAaVugwoiIy6yrW2HoPY0tTc4aqj6ggvP8GNt/TwasoaJ+ccpdhUUXZ+D1jVYq+ut34mImi8WtG0gCV4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1699871728; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=BzIVVmYQq2OMii9QNUo3hBKaJrnKGO6kQDth9Ef27lI=; b=WAAk0icHFlukR5i4Q3z6BCzls97oCyS5WUqvK1NYaG6DGjU5/Yx/qf/IDXkEQB67xJjz9EiG8JC+VeCbnLhMpTYfbDwJ0fMn2MLzKiSvdr809YbWQudyEpVh5aPMYVbc/Mqb9MktThGCKhwQdjr37Wdz/oym04+SI7Zcu2lcxBA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1699871728074341.6161671134696; Mon, 13 Nov 2023 02:35:28 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r2UH9-0004ut-AY; Mon, 13 Nov 2023 05:34:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2UH8-0004ui-HJ for qemu-devel@nongnu.org; Mon, 13 Nov 2023 05:34:38 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2UH6-0003op-Vh for qemu-devel@nongnu.org; Mon, 13 Nov 2023 05:34:38 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-227-t_V3WrVWN7ytm1f88kuKuA-1; Mon, 13 Nov 2023 05:34:33 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C1673101A52D for ; Mon, 13 Nov 2023 10:34:32 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.91]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9FC3140C6EBB for ; Mon, 13 Nov 2023 10:34:32 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 836BD21E6A37; Mon, 13 Nov 2023 11:34:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699871674; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BzIVVmYQq2OMii9QNUo3hBKaJrnKGO6kQDth9Ef27lI=; b=aZ1EwHquySTKXYBd7i5EMWhgLEdVfuuY4HMkBmJAmS8LS4rKeFFIGubSd2TVdXL7gZmFeI zAmnrwjViRO7tLJ12yO7lXNxE6gNzvCTJlNnzquFpHyBiseGWqyC1rZdICsHiRTwIUYNN3 uCNk4GjrZjHOYoUAuvnBVR6isDYHuMo= X-MC-Unique: t_V3WrVWN7ytm1f88kuKuA-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, John Snow Subject: [PULL 3/3] tests/qapi-schema: Tidy up pylint warnings and advice Date: Mon, 13 Nov 2023 11:34:31 +0100 Message-ID: <20231113103431.913394-4-armbru@redhat.com> In-Reply-To: <20231113103431.913394-1-armbru@redhat.com> References: <20231113103431.913394-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1699871730053100006 Content-Type: text/plain; charset="utf-8" Pylint warns: tests/qapi-schema/test-qapi.py:139:13: W1514: Using open without explic= itly specifying an encoding (unspecified-encoding) tests/qapi-schema/test-qapi.py:143:13: W1514: Using open without explic= itly specifying an encoding (unspecified-encoding) Add encoding=3D'utf-8'. Pylint advises: tests/qapi-schema/test-qapi.py:143:13: R1732: Consider using 'with' for= resource-allocating operations (consider-using-with) Silence this by returning the value directly. Pylint advises: tests/qapi-schema/test-qapi.py:221:4: R1722: Consider using sys.exit() = (consider-using-sys-exit) tests/qapi-schema/test-qapi.py:226:4: R1722: Consider using sys.exit() = (consider-using-sys-exit) Sure, why not. Signed-off-by: Markus Armbruster Message-ID: <20231025092925.1785934-1-armbru@redhat.com> Reviewed-by: John Snow --- tests/qapi-schema/test-qapi.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tests/qapi-schema/test-qapi.py b/tests/qapi-schema/test-qapi.py index d58c31f539..14f7b62a44 100755 --- a/tests/qapi-schema/test-qapi.py +++ b/tests/qapi-schema/test-qapi.py @@ -136,12 +136,11 @@ def test_frontend(fname): def open_test_result(dir_name, file_name, update): mode =3D 'r+' if update else 'r' try: - fp =3D open(os.path.join(dir_name, file_name), mode) + return open(os.path.join(dir_name, file_name), mode, encoding=3D'u= tf-8') except FileNotFoundError: if not update: raise - fp =3D open(os.path.join(dir_name, file_name), 'w+') - return fp + return open(os.path.join(dir_name, file_name), 'w+', encoding=3D'utf-8= ') =20 =20 def test_and_diff(test_name, dir_name, update): @@ -218,9 +217,9 @@ def main(argv): test_name =3D os.path.splitext(base_name)[0] status |=3D test_and_diff(test_name, dir_name, args.update) =20 - exit(status) + sys.exit(status) =20 =20 if __name__ =3D=3D '__main__': main(sys.argv) - exit(0) + sys.exit(0) --=20 2.41.0