From nobody Thu Nov 20 01:55:39 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1699549195; cv=none; d=zohomail.com; s=zohoarc; b=he67SGAC9nfeqMuOyLca24uOC//qYaRw/ctapzA3tk0NPmdpqj5Pk7317Oh/I1DgZqfz38uoJCh0IuGXeWZPrhd23Ns1S5FC+OZkvQZUZpe13+Uz+ORKnuPX04/LFvP/GCyWXXdYuz8sWkPUReW/pZBZ9lceIuQ/QXCMlqcbI9c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1699549195; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/cRpZGCYCqI/ZVcb18vmR0JwPH5yY1dnRm0DCN6UO+w=; b=FMq8dLbABLnkEw6c5oV2LD++NMWPmbsipjtBes5+XEMZ61NPQNS/G8MkOfNU+i00a7aNVLGRjSsLJfl6w4nWUTvtRYzFezcZji+q9gX3f2Uq9gvjHkefCxBqSUBSNgmicpO4mEW6/QTf1vRp9B8fKd3Rtt0waA8gYIR5704GBCw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16995491956021003.5783749702756; Thu, 9 Nov 2023 08:59:55 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r18N2-0000Vb-CI; Thu, 09 Nov 2023 11:59:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r18N0-0000V0-Ic for qemu-devel@nongnu.org; Thu, 09 Nov 2023 11:59:06 -0500 Received: from smtp-out1.suse.de ([2001:67c:2178:6::1c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r18Mz-00043g-4H for qemu-devel@nongnu.org; Thu, 09 Nov 2023 11:59:06 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1B55421985; Thu, 9 Nov 2023 16:59:02 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 99942138E5; Thu, 9 Nov 2023 16:59:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id mMYjGdQPTWVXNwAAMHmgww (envelope-from ); Thu, 09 Nov 2023 16:59:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1699549142; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/cRpZGCYCqI/ZVcb18vmR0JwPH5yY1dnRm0DCN6UO+w=; b=a77sIdrD6O3LXJfI6Q9EsrnfTy5tjqE5pCLzo7fHTkBKVf7FzJeH1QZ+1KqzSOQoxWt4Ak lORA1Dd+EbEqYxiA/vlcKLSa/YGHBU5MhV9PtlNGbmh3A1/vL99/GLDwettZtt9y/2jO3i NGj4w7BCtSqag7zX3H0k8ZaOf6BmAME= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1699549142; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/cRpZGCYCqI/ZVcb18vmR0JwPH5yY1dnRm0DCN6UO+w=; b=8di/rt2eVkZs70EuA039Wp2T1rnJEkI4fRIRQYwY+qQEh5y6nkp1qOiNS9tI8B34teomYD 0YAmFTqSJvYutMBQ== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Juan Quintela , Peter Xu , Leonardo Bras , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH 1/2] migration: Report error in incoming migration Date: Thu, 9 Nov 2023 13:58:55 -0300 Message-Id: <20231109165856.15224-2-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20231109165856.15224-1-farosas@suse.de> References: <20231109165856.15224-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:67c:2178:6::1c; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1699549197253100005 Content-Type: text/plain; charset="utf-8" We're not currently reporting the errors set with migrate_set_error() when incoming migration fails. Signed-off-by: Fabiano Rosas --- migration/migration.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/migration/migration.c b/migration/migration.c index 28a34c9068..cca32c553c 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -698,6 +698,13 @@ process_incoming_migration_co(void *opaque) } =20 if (ret < 0) { + MigrationState *s =3D migrate_get_current(); + + if (migrate_has_error(s)) { + WITH_QEMU_LOCK_GUARD(&s->error_mutex) { + error_report_err(s->error); + } + } error_report("load of migration failed: %s", strerror(-ret)); goto fail; } --=20 2.35.3