From nobody Wed Nov 27 09:53:42 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1699460751; cv=none; d=zohomail.com; s=zohoarc; b=Q3/NWEFx4TJ7Ckko30/E+B0vCF9e38s+Z2I4jDZ9RCnjIoG4cVbQqase+TZ7qYXb7P1h9FxNrglgLjOQcuSJIXKpoGAzs24b9+kiRgpToE3ZWEwKVARi8pjoqyKZknmFZLQ/FMJehTFt0mpZCL6O05TDivMeqSjtEuGh9MWqVD0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1699460751; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Z+Kd8D4ZxwpH7Ta3ZCRieR1Dc6Cf83zEOrRIhJPJel0=; b=KYJDgJQ/VRwBvDmTgil/P0iHjnlDFgoso1gorT/b5tYx4R+IkWCcqPzvbxOX0wwSuvbYDTjWsFqsZG3U4EviSXmg7CAyKnuxpuOnNKfrrvTOtl5FXsZ57J4uqvghhycL0k17RPAamT9SrpgG+2KqwP0nVp6DK5Tue+lJ4qj1a50= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1699460751027825.8127530667737; Wed, 8 Nov 2023 08:25:51 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r0lMe-00043u-FA; Wed, 08 Nov 2023 11:25:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0lMb-000434-FS for qemu-devel@nongnu.org; Wed, 08 Nov 2023 11:25:09 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0lMZ-0004Cq-R3 for qemu-devel@nongnu.org; Wed, 08 Nov 2023 11:25:09 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-66-XRzlwM11OTSx-RW5HdxXXw-1; Wed, 08 Nov 2023 11:23:57 -0500 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0750A83DE2D; Wed, 8 Nov 2023 16:23:57 +0000 (UTC) Received: from s390x-kvm-006.lab.eng.rdu2.redhat.com (s390x-kvm-006.lab.eng.rdu2.redhat.com [10.0.160.6]) by smtp.corp.redhat.com (Postfix) with ESMTP id F28B9492BEF; Wed, 8 Nov 2023 16:23:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699460706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Z+Kd8D4ZxwpH7Ta3ZCRieR1Dc6Cf83zEOrRIhJPJel0=; b=blFG9MCyVvQKyozd4yUV4P4CX4Q4lGLMhkL5AP5xEkH6cgZeJ35k/ggPf/KKUVwY+JFwfv cKGeZeczxYYwtglENq7CdZMYIh/kIZVmGbKZtOOg81dZqMkboIJD2RKRXa3ldr/ghwDrh/ GifUWVDxWexCTfZTfFYwStniCFg1ac4= X-MC-Unique: XRzlwM11OTSx-RW5HdxXXw-1 From: Sebastian Mitterle To: peter.maydell@linaro.org Cc: thuth@redhat.com, qemu-s390x@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH] risu: Add test summary Date: Wed, 8 Nov 2023 11:23:56 -0500 Message-ID: <20231108162356.36670-1-smitterl@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=smitterl@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1699460752108100003 Content-Type: text/plain; charset="utf-8" Currently, a successful test run finishes silently with exit code 0. The last message on the console is "starting image" which can leave the user wondering if they executed the commands correctly. Now add a summary of the number of executed instructions in case of success. Don't add that message when printing the trace to stdout (`-t -`). Tested: a) master/apprentice mode b) trace mode to file c) trace mode to stdout Suggested-by: Thomas Huth Signed-off-by: Sebastian Mitterle --- risu.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/risu.c b/risu.c index 36fc82a..740663a 100644 --- a/risu.c +++ b/risu.c @@ -551,6 +551,7 @@ int main(int argc, char **argv) struct option *longopts; char *shortopts; stack_t ss; + int ret; =20 longopts =3D setup_options(&shortopts); =20 @@ -635,8 +636,15 @@ int main(int argc, char **argv) arch_init(); =20 if (ismaster) { - return master(); + ret =3D master(); } else { - return apprentice(); + ret =3D apprentice(); } + + if (ret =3D=3D EXIT_SUCCESS && (!trace || (trace && strcmp(trace_fn, = "-") !=3D 0))) { + fprintf(stderr, "No mismatches found. Executed %zd checkpoints.\n", + signal_count); + } + + return ret; } --=20 2.41.0