From nobody Wed Nov 27 09:53:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1699384178; cv=none; d=zohomail.com; s=zohoarc; b=fGIj18tH5fD0BheTKDHaH0Vnsr7u/PGlS/EmE7Vlu5JQpZe+ZwYn+DNTDW2G0kpjBIBGIKRb8iRPBWDS9T5GbT2kS5je3bQvDPwRRv83HLJdCW+SGpc+6qFhcYFU5o+UpkBMDT1cb0r7XsltomZe5SeCm2zSzPUZb8buum22a0M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1699384178; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=e/CluFChsbBL3IuPKXEGp9v93+bN93D23x2uQhxilqA=; b=hHKBrRa/I3Cy1HxUXzlcR63lEEVOUSrmPQab/swnBeuc9KGyYzmZeWsDm/3vl4YHzeoLk/3KTyw404m5/RbXFqovgUkwrHD1OjTE2w6PG6MZYS1XPkiSfvirvrQfPVgInZVLTJRpwFe8hw6BTKlwwrPgsmeHCgDAlDsQl6BYRu0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1699384178713945.707661120661; Tue, 7 Nov 2023 11:09:38 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r0RR6-0004WE-I4; Tue, 07 Nov 2023 14:08:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0RR4-0004Vq-4L for qemu-devel@nongnu.org; Tue, 07 Nov 2023 14:08:26 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0RR2-0005oh-IG for qemu-devel@nongnu.org; Tue, 07 Nov 2023 14:08:25 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-601-pTCbF33cP-6s5e-gBPWbiw-1; Tue, 07 Nov 2023 14:08:20 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F3626185A781 for ; Tue, 7 Nov 2023 19:08:19 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.42.28.62]) by smtp.corp.redhat.com (Postfix) with ESMTP id F0C6D25C0; Tue, 7 Nov 2023 19:08:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699384103; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e/CluFChsbBL3IuPKXEGp9v93+bN93D23x2uQhxilqA=; b=cvPyINxnIvSrKLQ7celc3HAQwX6sFMEbxkgXM26Mc3H/Vjw+PPDt54kX31gYb5eWjq4QWc vs/VV9HEjq1ATHfTmCL4gjIwOM6t5yrZ2bKkT61ZZxBPafoqX5KGJUrmvsz1O6k8mTSP7l tAtpOYUHmNVHl68lEcwYIv3F9dod0hs= X-MC-Unique: pTCbF33cP-6s5e-gBPWbiw-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: Cleber Rosa , John Snow , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Markus Armbruster Subject: [PULL 1/5] crypto/rsakey-builtin.c.inc: Clean up two error paths Date: Tue, 7 Nov 2023 19:08:13 +0000 Message-ID: <20231107190817.1607710-2-berrange@redhat.com> In-Reply-To: <20231107190817.1607710-1-berrange@redhat.com> References: <20231107190817.1607710-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1699384179569100001 From: Markus Armbruster When qcrypto_builtin_rsa_public_key_parse() is about to fail, but no error has been set, it makes one up. Actually, there's just one way to fail without setting an error. Set it there instead. Same for qcrypto_builtin_rsa_private_key_parse(). Signed-off-by: Markus Armbruster Signed-off-by: Daniel P. Berrang=C3=A9 --- crypto/rsakey-builtin.c.inc | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/crypto/rsakey-builtin.c.inc b/crypto/rsakey-builtin.c.inc index aeeacc8f9b..46cc7afe87 100644 --- a/crypto/rsakey-builtin.c.inc +++ b/crypto/rsakey-builtin.c.inc @@ -88,15 +88,13 @@ static QCryptoAkCipherRSAKey *qcrypto_builtin_rsa_publi= c_key_parse( goto error; } if (seq_length !=3D 0) { + error_setg(errp, "Invalid RSA public key"); goto error; } =20 return rsa; =20 error: - if (errp && !*errp) { - error_setg(errp, "Invalid RSA public key"); - } qcrypto_akcipher_rsakey_free(rsa); return NULL; } @@ -169,15 +167,13 @@ static QCryptoAkCipherRSAKey *qcrypto_builtin_rsa_pri= vate_key_parse( return rsa; } if (seq_length !=3D 0) { + error_setg(errp, "Invalid RSA private key"); goto error; } =20 return rsa; =20 error: - if (errp && !*errp) { - error_setg(errp, "Invalid RSA private key"); - } qcrypto_akcipher_rsakey_free(rsa); return NULL; } --=20 2.41.0 From nobody Wed Nov 27 09:53:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1699384190; cv=none; d=zohomail.com; s=zohoarc; b=SnlvNgohN0KfOpFeRHdQTTUWSzhvK8Q/9nK0IaswyXKdGQYvLOnHGvSxsFb83m+dmTMOlfIz7yJkvM8d7FA1hj+xLhJGhZvFXfCVz7z0llyoujpozpABnLsf9JODE7pXP1UmSAWhfJCNJGOCWEQXnCoNC+gLay5UkOkbpEUWeuU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1699384190; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=YdT4dmDIj9ig64nGbs9O98aOZUydxuY94/yjftJPdio=; b=VNf0WqmRdcIfj/pG7Sclxi3Fef77GbZwtGFlq+oOYtCxsSrTloUuT56mL7Acmx2HX0mXtKQcbAKztQ5Rf6Mwa9ARQWewEM3syQ7vbITH0EwniT3RzyKbxZlgJ1kHV4Y5clI3zZm6qLUO0WOjW4WbAryw3mU6uMPQiUwY8uO81Ow= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1699384190595330.62046620145; Tue, 7 Nov 2023 11:09:50 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r0RR8-0004Wl-MN; Tue, 07 Nov 2023 14:08:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0RR6-0004WC-8u for qemu-devel@nongnu.org; Tue, 07 Nov 2023 14:08:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0RR3-0005os-G1 for qemu-devel@nongnu.org; Tue, 07 Nov 2023 14:08:27 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-140-4NBPX5gTMb-ySm-ONQWtRw-1; Tue, 07 Nov 2023 14:08:21 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8311185A5B5; Tue, 7 Nov 2023 19:08:21 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.42.28.62]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2FFB725C0; Tue, 7 Nov 2023 19:08:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699384105; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YdT4dmDIj9ig64nGbs9O98aOZUydxuY94/yjftJPdio=; b=FQ+51snIuJvBqESE5tEO3mpb6bOkyxXQ5+Ov4wbUbynAqZNsgSqRlYuovA3Z1WIyc/ZPcI vMxwDBuFtadpxwh77X48r5v56chlEewpnUOId8fr0bUfZLDGrE3dAU9VXu0wR348brkota pIQZnEWYCFTtleAHC/gKg4WBl9fvkxA= X-MC-Unique: 4NBPX5gTMb-ySm-ONQWtRw-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: Cleber Rosa , John Snow , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Fabiano Rosas Subject: [PULL 2/5] io: Stop appending -listen to net listeners Date: Tue, 7 Nov 2023 19:08:14 +0000 Message-ID: <20231107190817.1607710-3-berrange@redhat.com> In-Reply-To: <20231107190817.1607710-1-berrange@redhat.com> References: <20231107190817.1607710-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1699384191576100001 From: Fabiano Rosas All callers of qio_net_listener_set_name() already add some sort of "listen" or "listener" suffix. For intance, we currently have "migration-socket-listener-listen" and "vnc-listen-listen" as ioc names. Signed-off-by: Fabiano Rosas Signed-off-by: Daniel P. Berrang=C3=A9 --- io/net-listener.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/io/net-listener.c b/io/net-listener.c index 1c984d69c6..47405965a6 100644 --- a/io/net-listener.c +++ b/io/net-listener.c @@ -109,9 +109,7 @@ void qio_net_listener_add(QIONetListener *listener, QIOChannelSocket *sioc) { if (listener->name) { - char *name =3D g_strdup_printf("%s-listen", listener->name); - qio_channel_set_name(QIO_CHANNEL(sioc), name); - g_free(name); + qio_channel_set_name(QIO_CHANNEL(sioc), listener->name); } =20 listener->sioc =3D g_renew(QIOChannelSocket *, listener->sioc, --=20 2.41.0 From nobody Wed Nov 27 09:53:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1699384165; cv=none; d=zohomail.com; s=zohoarc; b=GkzNT7n2pcMTkvVYfp7qyicIT0I/f642ZAtb77+nR9YavjScn5otbOFBuVrg+rJDfa2oCpiGUY95KkhWB2NCmwZwiEu3wG/o33EIg8VfzVgN6P+2s0iWYfrTd1tPTtqwQXgmnt6tq8xPxMMj0j4sa6ZZYPeYv+cZZELwriyW7Tc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1699384165; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=FSK7TY/1g7Gf5t/DbU+U3KaUgEFAOOa8D7RZh8hYb64=; b=ZHZbK+E7NGZKe5628gaIlByciAKB5nWnCVpxhmUaW3T4PGrasMOQwq4ZRvDpVsaJoJaSo9mmg/of92J5/9GEu2+sKbf/ISaj8oaZwczRs/KwXcLP3V09s+9K4C7VLN2FSr3frmIO76OSWONhYvYl0hwgVP9K/fSMhraC+1erCeE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1699384165762879.5317686821544; Tue, 7 Nov 2023 11:09:25 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r0RRC-0004Xj-78; Tue, 07 Nov 2023 14:08:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0RR6-0004WB-82 for qemu-devel@nongnu.org; Tue, 07 Nov 2023 14:08:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0RR3-0005op-9d for qemu-devel@nongnu.org; Tue, 07 Nov 2023 14:08:27 -0500 Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-180-D4eJ8KngN7SwItvE6i6AMw-1; Tue, 07 Nov 2023 14:08:23 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A23F0383DC6C for ; Tue, 7 Nov 2023 19:08:22 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.42.28.62]) by smtp.corp.redhat.com (Postfix) with ESMTP id B88EE25C0; Tue, 7 Nov 2023 19:08:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699384104; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FSK7TY/1g7Gf5t/DbU+U3KaUgEFAOOa8D7RZh8hYb64=; b=V8D5Pw8U7pFOPDAdzw3Ya11xFRm8HEpT3oHcpLn6SZtP7AkI19HPND9+hotsCeQsFDvbbp IN5rbokYvECrSiPQSuxaFePZ51aYNu6PP+vxL5Bp0+7kDLaNcWGHDLaaMFSC78Q0R+7Ftr O0Jqvgcjg3fk3q6EsbCdmTIUacA2p44= X-MC-Unique: D4eJ8KngN7SwItvE6i6AMw-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: Cleber Rosa , John Snow , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PULL 3/5] audio: don't abort on f32 audio format in wav backend Date: Tue, 7 Nov 2023 19:08:15 +0000 Message-ID: <20231107190817.1607710-4-berrange@redhat.com> In-Reply-To: <20231107190817.1607710-1-berrange@redhat.com> References: <20231107190817.1607710-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1699384167508100005 Print a debug message as is done for other unsupported audio formats to give the user the chance to understand their mistake. Reviewed-by: Marc-Andr=C3=A9 Lureau Signed-off-by: Daniel P. Berrang=C3=A9 --- audio/wavaudio.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/audio/wavaudio.c b/audio/wavaudio.c index ea20fed0cc..a8798a1c42 100644 --- a/audio/wavaudio.c +++ b/audio/wavaudio.c @@ -97,6 +97,10 @@ static int wav_init_out(HWVoiceOut *hw, struct audsettin= gs *as, dolog ("WAVE files can not handle 32bit formats\n"); return -1; =20 + case AUDIO_FORMAT_F32: + dolog("WAVE files can not handle float formats\n"); + return -1; + default: abort(); } --=20 2.41.0 From nobody Wed Nov 27 09:53:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1699384164; cv=none; d=zohomail.com; s=zohoarc; b=G7yrUDJSu4+KO/5FoGJ8mUsfgSHVxaVQlWcEJJGxnhyrEldNYy6074tqcyJ+kEZMME3xN6TccPgDCVoflPtuJCi1/E4vQhjYnGJLvo01WcitmVy3/bJDFoEVCrTQ6udXXQXDCPkUSjgLDs0cBMV6Z0V/1MEQqceMfvXq6G7MXXQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1699384164; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9dMegn/efK+rKyOZfPBfNFez1MVQPbCQTbtkkBWQhh0=; b=ePVghAEM1+z9gV6cPPuKuVyDCIxxspy4oV3A3RzA+aMemB4wrv7TQqQsiXBbmuxBpHQdS9bVOZ8M9LXQX8MPibArDSEltwjIbVE1xybZb6RTj1Suv3FN8yK2eLsBnTs0ld4F0Gc5WcO6ghxgl++eoBmhtvZduggyPZ6qTrMVooI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1699384164804338.13827606968107; Tue, 7 Nov 2023 11:09:24 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r0RRG-0004Yc-Jl; Tue, 07 Nov 2023 14:08:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0RR9-0004X2-Lv for qemu-devel@nongnu.org; Tue, 07 Nov 2023 14:08:33 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0RR6-0005p2-Ei for qemu-devel@nongnu.org; Tue, 07 Nov 2023 14:08:30 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-599-K7kBJYlNP0-mPOiz7aOMmg-1; Tue, 07 Nov 2023 14:08:24 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C0A13811E7B for ; Tue, 7 Nov 2023 19:08:23 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.42.28.62]) by smtp.corp.redhat.com (Postfix) with ESMTP id D449225C0; Tue, 7 Nov 2023 19:08:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699384105; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9dMegn/efK+rKyOZfPBfNFez1MVQPbCQTbtkkBWQhh0=; b=F21IjQVFVrQbjQ6ehl3hZmqJave3UaR+AARBk3dCCQl5yhO/NL1UKo1nYZ1lwOP8HNwpwu vAKcREWW5prJFwE1kPLLOwrCf4Nw431I0R/O/Cc7+GdaA/9Wv6a7J+zkdLDqcnpREXO737 zuXOXcwzRDQuSaQRtyOI4l1jkhz7zx8= X-MC-Unique: K7kBJYlNP0-mPOiz7aOMmg-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: Cleber Rosa , John Snow , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PULL 4/5] MAINTAINERS: update libvirt devel mailing list address Date: Tue, 7 Nov 2023 19:08:16 +0000 Message-ID: <20231107190817.1607710-5-berrange@redhat.com> In-Reply-To: <20231107190817.1607710-1-berrange@redhat.com> References: <20231107190817.1607710-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1699384165482100001 Effective immediately, the libvirt project has moved its list off libvir-list@redhat.com, to devel@lists.libvirt.org Signed-off-by: Daniel P. Berrang=C3=A9 --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index b86ea7f75a..751860e064 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4062,7 +4062,7 @@ F: gitdm.config F: contrib/gitdm/* =20 Incompatible changes -R: libvir-list@redhat.com +R: devel@lists.libvirt.org F: docs/about/deprecated.rst =20 Build System --=20 2.41.0 From nobody Wed Nov 27 09:53:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1699384152; cv=none; d=zohomail.com; s=zohoarc; b=Gvn+hBKwp0yZwtt26vGPaUefKZ0kF99q+deXLCGPHsHtfqGLg4XhdjVenPfOcHvsOOmsNwPFtSrw6fdyMgCjAua6+gi1vfGymjk2y8hH8DP05ohkpVaLLgPaj73sLcKkxVtII88AAG8tioGMFesPfV4dWJfecTxPOIWhcDj9fx8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1699384152; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=VXuO0i8SoHDIuFTm9Ssk29bISFNyk+++0qvyee3CbjI=; b=CiJQsZP3KvQFyGcPZ7IMwB8jJm7z4e6SGTzehgNh+KiqNC+/Qs/ckTFdwX6tjBAg/Tb78RXYpy2JvtBSZr6i2la4Y+Q1Yu1wFPLlCoBZD3SMaAbJ8tfksbJyzIJl3sWcxIwBOkSiHucmK8UP/FB7PsOVMUQkb1b3TuOUq6Ony+c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1699384152136413.1915977191561; Tue, 7 Nov 2023 11:09:12 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r0RRE-0004Xx-UY; Tue, 07 Nov 2023 14:08:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0RRA-0004XG-Uv for qemu-devel@nongnu.org; Tue, 07 Nov 2023 14:08:33 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0RR9-0005pa-EI for qemu-devel@nongnu.org; Tue, 07 Nov 2023 14:08:32 -0500 Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-528-0Z2u_pGmPnWXDKYStLCJDg-1; Tue, 07 Nov 2023 14:08:25 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 431732801424; Tue, 7 Nov 2023 19:08:25 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.42.28.62]) by smtp.corp.redhat.com (Postfix) with ESMTP id 02EEF25C0; Tue, 7 Nov 2023 19:08:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699384110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VXuO0i8SoHDIuFTm9Ssk29bISFNyk+++0qvyee3CbjI=; b=X7KL8+i6TdUQGPCKjyNJ8E4XX0U31fybnSg/wfMpfbA6a2RgurBR3XH0i+oJJTITx+3eGa 23sAflDgFNHHS3cK7tRWqricjgPy0a3JSqATan+wb+XUn4sXizfCS+d80EFSRUBlEhSIKY /I7SCPWpZ09N97oTJqqIB1j9f9vj0go= X-MC-Unique: 0Z2u_pGmPnWXDKYStLCJDg-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: Cleber Rosa , John Snow , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Zhao Liu , Vladimir Sementsov-Ogievskiy Subject: [PULL 5/5] scripts/cpu-x86-uarch-abi.py: Fix parameter error of cmd Date: Tue, 7 Nov 2023 19:08:17 +0000 Message-ID: <20231107190817.1607710-6-berrange@redhat.com> In-Reply-To: <20231107190817.1607710-1-berrange@redhat.com> References: <20231107190817.1607710-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1699384153814100001 From: Zhao Liu When run this script, there's the error: python3 scripts/cpu-x86-uarch-abi.py /tmp/qmp Traceback (most recent call last): File "/path-to-qemu/qemu/scripts/cpu-x86-uarch-abi.py", line 96, in cpu =3D shell.cmd("query-cpu-model-expansion", TypeError: QEMUMonitorProtocol.cmd() takes 2 positional arguments but 3 wer= e given Commit 7f521b023bc28 ("scripts/cpu-x86-uarch-abi.py: use .command() instead of .cmd()") converts the the original .cmd() to .command() (which was later renamed to "cmd" to replace the original one). But the new .cmd() only accepts typing.Mapping as the parameter instead of typing.Dict (see _qmp.execute()). Change the paremeters of "query-cpu-model-expansion" to typing.Mapping format to fix this error. Fixes: 7f521b023bc28 ("scripts/cpu-x86-uarch-abi.py: use .command() instead= of .cmd()") Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Zhao Liu Signed-off-by: Daniel P. Berrang=C3=A9 --- scripts/cpu-x86-uarch-abi.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/cpu-x86-uarch-abi.py b/scripts/cpu-x86-uarch-abi.py index f6baeeff24..052ddd7514 100644 --- a/scripts/cpu-x86-uarch-abi.py +++ b/scripts/cpu-x86-uarch-abi.py @@ -94,8 +94,8 @@ =20 for name in sorted(names): cpu =3D shell.cmd("query-cpu-model-expansion", - { "type": "static", - "model": { "name": name }}) + type=3D"static", + model=3D{ "name": name }) =20 got =3D {} for (feature, present) in cpu["model"]["props"].items(): --=20 2.41.0