From nobody Wed Nov 27 13:36:18 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1698673139; cv=none; d=zohomail.com; s=zohoarc; b=XlNBRsnZ1UAXPKL9gKBjwdIfUUZbasULeQu6qiksenOd7/hOXLqNBzICUMFFjzmquZvwxySYa/gprslc+USls99FOg+T4mI7/J7iskkQOwSOouHWCJuUCd09JAoAHSIaDkkIN6X6xJBDNlqYFOtYm6xvUfBQcyP0qPasBdxOBbs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1698673139; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=oq0lWctSVa3/3897g4nCYpHn0n5Zdm88YbJL1HmTP7I=; b=ZEG3ZwOIXi62Y+3/CuHNiEBtyZbjWhed1MhlVOZpXc7H8/SfJI/pqIc5MjncdkF7a2H/G63hMHihWR3g+krYjDxVGJ+JHDikehD8BzPt7eHq1ieyjRwhMeZZ5dNjJtIAaBEU/k52FLmcimxOWL7CG/5ieeCDK7IkuX6Xq8mRb4E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1698673139022964.8525201329434; Mon, 30 Oct 2023 06:38:59 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qxSSZ-0003cl-P0; Mon, 30 Oct 2023 09:37:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qxSSO-0003bc-Mc for qemu-devel@nongnu.org; Mon, 30 Oct 2023 09:37:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qxSSN-0005qu-0S for qemu-devel@nongnu.org; Mon, 30 Oct 2023 09:37:28 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-592-OjntsvlOMfWWMg9fbQp1VA-1; Mon, 30 Oct 2023 09:37:14 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 11CF7811E86 for ; Mon, 30 Oct 2023 13:37:14 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.193.56]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E50B41C060AE for ; Mon, 30 Oct 2023 13:37:13 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id C8C5E21E6A28; Mon, 30 Oct 2023 14:37:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698673046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oq0lWctSVa3/3897g4nCYpHn0n5Zdm88YbJL1HmTP7I=; b=SRDeOE2U0YlBbISd4hRbgBMtmK1kAKondbPaBHqcL31gp6VFhzohEuBtEzfqxwZZBuP1PN 6pyB725I4vesO1s72akPAoMG83lfAdQK0QhKwuIZvOt2pENSrhg+VijCcyYRr3XqfG5EDN gpC1SxprHNduQpUgvcRRxjihI1mI/Do= X-MC-Unique: OjntsvlOMfWWMg9fbQp1VA-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: marcandre.lureau@redhat.com Subject: [PATCH 2/5] dump: Fix g_array_unref(NULL) in dump-guest-memory Date: Mon, 30 Oct 2023 14:37:09 +0100 Message-ID: <20231030133712.2822276-3-armbru@redhat.com> In-Reply-To: <20231030133712.2822276-1-armbru@redhat.com> References: <20231030133712.2822276-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.483, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1698673139577100001 Content-Type: text/plain; charset="utf-8" When dump_init()'s check for non-zero @length fails, dump_cleanup() passes null s->string_table_buf to g_array_unref(), which spews "GLib: g_array_unref: assertion 'array' failed" to stderr. Guard the g_array_unref(). Signed-off-by: Markus Armbruster Reviewed-by: Marc-Andr=C3=A9 Lureau --- dump/dump.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dump/dump.c b/dump/dump.c index a1fad17f9c..d8ea364af2 100644 --- a/dump/dump.c +++ b/dump/dump.c @@ -100,7 +100,9 @@ static int dump_cleanup(DumpState *s) memory_mapping_list_free(&s->list); close(s->fd); g_free(s->guest_note); - g_array_unref(s->string_table_buf); + if (s->string_table_buf) { + g_array_unref(s->string_table_buf); + } s->guest_note =3D NULL; if (s->resume) { if (s->detached) { --=20 2.41.0