From nobody Tue Feb 10 17:08:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1697723270; cv=none; d=zohomail.com; s=zohoarc; b=ihZf2tUBOod5f5opIqqd4CuKeoQxFyRf6uLZa/QKvjUCqGxYRc7eg7S93jcgSql8MO0Q8nrzZ60FllesGAKmsZRWRI/3w6dDPVtk8Bsr8GL/uO5kNZ6oKxofq0D1KY4H8bwL1Q4Il1yZViDjR/5CpcgQlQSTmRmibKqDeQkebvw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697723270; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+U66J5UOuuRnjCHK5uxRDUH8C5ug7oRD74rF7OruWos=; b=hy+7+8DAC7Yty2dq+JjfU4dsSBdMlgf3aKgvzjv6bsY/CfNOxXchHlE+3qNpm1XbTdBHGVKi+10l5LtaX6tEsE8jj+fDByfjKlGZFGs3z2OImjwKg09GLC8PL0yUR/ZbSLGVpbylyql19PKdunI4MpYJPGtaKY4GtGubmpvmxeo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1697723270489703.0879602796069; Thu, 19 Oct 2023 06:47:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qtTMi-00019l-9k; Thu, 19 Oct 2023 09:47:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtTMg-00018N-5B for qemu-devel@nongnu.org; Thu, 19 Oct 2023 09:47:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtTMe-0002ZV-Jw for qemu-devel@nongnu.org; Thu, 19 Oct 2023 09:47:05 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-330-fBCAq6O8OIqjpia2XVV2og-1; Thu, 19 Oct 2023 09:46:59 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1FC3482DFB8; Thu, 19 Oct 2023 13:46:59 +0000 (UTC) Received: from laptop.redhat.com (unknown [10.39.195.144]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6AB6C492BFA; Thu, 19 Oct 2023 13:46:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697723224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+U66J5UOuuRnjCHK5uxRDUH8C5ug7oRD74rF7OruWos=; b=EgGwnMDlr8iN792Sz8Kq2fcy3f4WKkgg0P9c59rNWFsxi0Co787AkoW3EoedpOLJCIsiBX X7LRHfbgK4YsxBjf1fbjNpwRDs0tvQ1D9tmHYz1/AKnRnH6reo6R2phM53WH5aCAFxttqc 9QV5THgftgbX6aZrrI5G8ZMARdGOKc8= X-MC-Unique: fBCAq6O8OIqjpia2XVV2og-1 From: Eric Auger To: eric.auger.pro@gmail.com, eric.auger@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, alex.williamson@redhat.com, clg@redhat.com, jean-philippe@linaro.org, mst@redhat.com, pbonzini@redhat.com Cc: peter.maydell@linaro.org, peterx@redhat.com, david@redhat.com, philmd@linaro.org, zhenzhong.duan@intel.com, yi.l.liu@intel.com, yanghliu@redhat.com Subject: [PATCH v4 01/12] memory: Let ReservedRegion use Range Date: Thu, 19 Oct 2023 15:45:07 +0200 Message-ID: <20231019134651.842175-2-eric.auger@redhat.com> In-Reply-To: <20231019134651.842175-1-eric.auger@redhat.com> References: <20231019134651.842175-1-eric.auger@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=eric.auger@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1697723270864100001 A reserved region is a range tagged with a type. Let's directly use the Range type in the prospect to reuse some of the library helpers shipped with the Range type. Signed-off-by: Eric Auger Reviewed-by: David Hildenbrand Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Michael S. Tsirkin --- v2 -> v3: - added Cedric's R-b v1 -> v2: - Added Philippe and David's R-b --- include/exec/memory.h | 4 ++-- hw/core/qdev-properties-system.c | 9 ++++++--- hw/virtio/virtio-iommu.c | 6 +++--- 3 files changed, 11 insertions(+), 8 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index 653a32ea10..a089ab4555 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -24,6 +24,7 @@ #include "qemu/bswap.h" #include "qemu/queue.h" #include "qemu/int128.h" +#include "qemu/range.h" #include "qemu/notify.h" #include "qom/object.h" #include "qemu/rcu.h" @@ -79,8 +80,7 @@ extern unsigned int global_dirty_tracking; typedef struct MemoryRegionOps MemoryRegionOps; =20 struct ReservedRegion { - hwaddr low; - hwaddr high; + Range range; unsigned type; }; =20 diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-sys= tem.c index 688340610e..07ac2f8f20 100644 --- a/hw/core/qdev-properties-system.c +++ b/hw/core/qdev-properties-system.c @@ -691,7 +691,7 @@ static void get_reserved_region(Object *obj, Visitor *v= , const char *name, int rc; =20 rc =3D snprintf(buffer, sizeof(buffer), "0x%"PRIx64":0x%"PRIx64":%u", - rr->low, rr->high, rr->type); + range_lob(&rr->range), range_upb(&rr->range), rr->type); assert(rc < sizeof(buffer)); =20 visit_type_str(v, name, &p, errp); @@ -703,6 +703,7 @@ static void set_reserved_region(Object *obj, Visitor *v= , const char *name, Property *prop =3D opaque; ReservedRegion *rr =3D object_field_prop_ptr(obj, prop); const char *endptr; + uint64_t lob, upb; char *str; int ret; =20 @@ -710,7 +711,7 @@ static void set_reserved_region(Object *obj, Visitor *v= , const char *name, return; } =20 - ret =3D qemu_strtou64(str, &endptr, 16, &rr->low); + ret =3D qemu_strtou64(str, &endptr, 16, &lob); if (ret) { error_setg(errp, "start address of '%s'" " must be a hexadecimal integer", name); @@ -720,7 +721,7 @@ static void set_reserved_region(Object *obj, Visitor *v= , const char *name, goto separator_error; } =20 - ret =3D qemu_strtou64(endptr + 1, &endptr, 16, &rr->high); + ret =3D qemu_strtou64(endptr + 1, &endptr, 16, &upb); if (ret) { error_setg(errp, "end address of '%s'" " must be a hexadecimal integer", name); @@ -730,6 +731,8 @@ static void set_reserved_region(Object *obj, Visitor *v= , const char *name, goto separator_error; } =20 + range_set_bounds(&rr->range, lob, upb); + ret =3D qemu_strtoui(endptr + 1, &endptr, 10, &rr->type); if (ret) { error_setg(errp, "type of '%s'" diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c index be51635895..e5e46e1b55 100644 --- a/hw/virtio/virtio-iommu.c +++ b/hw/virtio/virtio-iommu.c @@ -645,8 +645,8 @@ static ssize_t virtio_iommu_fill_resv_mem_prop(VirtIOIO= MMU *s, uint32_t ep, prop.head.type =3D cpu_to_le16(VIRTIO_IOMMU_PROBE_T_RESV_MEM); prop.head.length =3D cpu_to_le16(length); prop.subtype =3D subtype; - prop.start =3D cpu_to_le64(s->reserved_regions[i].low); - prop.end =3D cpu_to_le64(s->reserved_regions[i].high); + prop.start =3D cpu_to_le64(range_lob(&s->reserved_regions[i].range= )); + prop.end =3D cpu_to_le64(range_upb(&s->reserved_regions[i].range)); =20 memcpy(buf, &prop, size); =20 @@ -897,7 +897,7 @@ static IOMMUTLBEntry virtio_iommu_translate(IOMMUMemory= Region *mr, hwaddr addr, for (i =3D 0; i < s->nb_reserved_regions; i++) { ReservedRegion *reg =3D &s->reserved_regions[i]; =20 - if (addr >=3D reg->low && addr <=3D reg->high) { + if (range_contains(®->range, addr)) { switch (reg->type) { case VIRTIO_IOMMU_RESV_MEM_T_MSI: entry.perm =3D flag; --=20 2.41.0