From nobody Thu Jan 1 20:15:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1697711278; cv=none; d=zohomail.com; s=zohoarc; b=HCq31jbn6Nx57O4swotLTcmZW+edBVE38xeWMqsFksLgbTaOLylg8wfNWBi6pK5oV642rhnbvblGLgqfKahAkpxTdsvwkOG5MfX9ViV6tFCd5SY73qe5nypK0OuPiAAyy6A0MupTXtM+GjcQVj78oWAv2415FV1bn+xEUzdfepw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697711278; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:Message-Id:Reply-To:To; bh=21Z173hVFszR8s4nfjM3OYWaOyCmfZYL9fagBQvy26Q=; b=loBhb6Ga1+1hM/Jhm75cp4paelFR4PIpzhqNTlNJuQuF1YDoAJ7FDBBiz0QcNjxHulaVcZY4/HXNI04QC3iUQZfdUW6ciHj2gew+AT/NEKmpdITi2K0HCiWtjhb3766/VrJEN8TPUhPlN5D0Fl/sM7J8QK3k0R+lFs73GLwhTFU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1697711278357223.5872166095503; Thu, 19 Oct 2023 03:27:58 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qtQFG-0001EZ-2K; Thu, 19 Oct 2023 06:27:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtQFE-0001EM-DL for qemu-devel@nongnu.org; Thu, 19 Oct 2023 06:27:12 -0400 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qtQFC-0006Jx-Ov for qemu-devel@nongnu.org; Thu, 19 Oct 2023 06:27:12 -0400 Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-6bee11456baso735528b3a.1 for ; Thu, 19 Oct 2023 03:27:10 -0700 (PDT) Received: from localhost ([2400:4050:a840:1e00:78d2:b862:10a7:d486]) by smtp.gmail.com with UTF8SMTPSA id o7-20020a17090ac08700b002775281b9easm1277155pjs.50.2023.10.19.03.27.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Oct 2023 03:27:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20230601.gappssmtp.com; s=20230601; t=1697711229; x=1698316029; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=21Z173hVFszR8s4nfjM3OYWaOyCmfZYL9fagBQvy26Q=; b=EUMzBJkJ2+WdxQ9wt3QCn/+BH0w7Or/XnUCYx0WCoEZ+NgcpaAGPy3Sf5XFk317kTI bV75E6NMOvWChF7cO54SPcKJgqBHRJClMkggwuFSooez+XG68o4f6+/AAzEdAsSnmOP8 Z+hIMtbM3pBzTVEgs1FNPREyys1ZLkrAXgOjzRbyw2K7TV6iiYFDctM1ozqwc7r/StGE MiuHvyygviSBC843UxZDXY/+lC+iE8EwK/QyM8oe5z6o1LnU7wzalY1YCebfJS58QZX8 8rykuebub/9qO8nHnhCl1GEZjNLSte6ZQu1r1ZcQj9SNRvz9xPSfTC/f5yKdqqz0PgAn 6hLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697711229; x=1698316029; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=21Z173hVFszR8s4nfjM3OYWaOyCmfZYL9fagBQvy26Q=; b=CIxrygN6Y8GP8L8kHDyZm+NP8f2ff+b9StiafmUqT+uxe6WhBA7CncGVKXcmWs1nRm N2g9m40HajFVO6xrCKKFt77SrlgCrSd+Qe+QYtPaZ5r+a5hj+1lpeiw8IZbewJ4MCmAo TcJt2rSTMIPRaDFFsbVDiBdlun/8c9cgm3YhLnZky1utcayWBoAtKooHa1pnhuMaaost yMDmhVVpvomLdFPlXjMZENJL/jjx4kRIYm0JjpbG/MIb8bMFpeV0Zkq+179yK3D6zfVu xUHCBkQNlLQYBvhEeFHHmqWf2/U4nkoMyy86nx98ZaQ/Brl49WvJLWWqcQY/ZETqcoQF Vw8Q== X-Gm-Message-State: AOJu0YyT476LkVAtI4HB81dl2VdvAJ+/WRWJccbe0e6BfKFT/uRc8nj5 V5v1Rz9+uOS0kPn4/62IybvDSiNmbaYionGNcndC+A== X-Google-Smtp-Source: AGHT+IGRjq7QMtObJdjsg+w2g8OvhlsayP2M6Tg0kTVJgGtAD+NHldZbJKtUxfb/Orph+py8ykWJ5w== X-Received: by 2002:a05:6a20:4295:b0:17a:fcda:4a6b with SMTP id o21-20020a056a20429500b0017afcda4a6bmr1681132pzj.13.1697711229018; Thu, 19 Oct 2023 03:27:09 -0700 (PDT) From: Akihiko Odaki To: Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Mikhail Tyutin , Aleksandr Anenkov , qemu-devel@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Akihiko Odaki , John Snow , Cleber Rosa Subject: [PATCH v14 01/18] gdbstub: Add num_regs member to GDBFeature Date: Thu, 19 Oct 2023 19:26:36 +0900 Message-ID: <20231019102657.129512-2-akihiko.odaki@daynix.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231019102657.129512-1-akihiko.odaki@daynix.com> References: <20231019102657.129512-1-akihiko.odaki@daynix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=2607:f8b0:4864:20::42c; envelope-from=akihiko.odaki@daynix.com; helo=mail-pf1-x42c.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @daynix-com.20230601.gappssmtp.com) X-ZM-MESSAGEID: 1697711280583100009 Currently the number of registers exposed to GDB is written as magic numbers in code. Derive the number of registers GDB actually see from XML files to replace the magic numbers in code later. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alex Benn=C3=A9e --- include/exec/gdbstub.h | 1 + scripts/feature_to_c.py | 46 +++++++++++++++++++++++++++++++++++++++-- 2 files changed, 45 insertions(+), 2 deletions(-) diff --git a/include/exec/gdbstub.h b/include/exec/gdbstub.h index 1a01c35f8e..a43aa34dad 100644 --- a/include/exec/gdbstub.h +++ b/include/exec/gdbstub.h @@ -13,6 +13,7 @@ typedef struct GDBFeature { const char *xmlname; const char *xml; + int num_regs; } GDBFeature; =20 =20 diff --git a/scripts/feature_to_c.py b/scripts/feature_to_c.py index bcbcb83beb..e04d6b2df7 100755 --- a/scripts/feature_to_c.py +++ b/scripts/feature_to_c.py @@ -1,7 +1,7 @@ #!/usr/bin/env python3 # SPDX-License-Identifier: GPL-2.0-or-later =20 -import os, sys +import os, sys, xml.etree.ElementTree =20 def writeliteral(indent, bytes): sys.stdout.write(' ' * indent) @@ -39,10 +39,52 @@ def writeliteral(indent, bytes): with open(input, 'rb') as file: read =3D file.read() =20 + parser =3D xml.etree.ElementTree.XMLPullParser(['start', 'end']) + parser.feed(read) + events =3D parser.read_events() + event, element =3D next(events) + if event !=3D 'start': + sys.stderr.write(f'unexpected event: {event}\n') + exit(1) + if element.tag !=3D 'feature': + sys.stderr.write(f'unexpected start tag: {element.tag}\n') + exit(1) + + regnum =3D 0 + regnums =3D [] + tags =3D ['feature'] + for event, element in events: + if event =3D=3D 'end': + if element.tag !=3D tags[len(tags) - 1]: + sys.stderr.write(f'unexpected end tag: {element.tag}\n') + exit(1) + + tags.pop() + if element.tag =3D=3D 'feature': + break + elif event =3D=3D 'start': + if len(tags) < 2 and element.tag =3D=3D 'reg': + if 'regnum' in element.attrib: + regnum =3D int(element.attrib['regnum']) + + regnums.append(regnum) + regnum +=3D 1 + + tags.append(element.tag) + else: + raise Exception(f'unexpected event: {event}\n') + + if len(tags): + sys.stderr.write('unterminated feature tag\n') + exit(1) + + base_reg =3D min(regnums) + num_regs =3D max(regnums) - base_reg + 1 if len(regnums) else 0 + sys.stdout.write(' {\n') writeliteral(8, bytes(os.path.basename(input), 'utf-8')) sys.stdout.write(',\n') writeliteral(8, read) - sys.stdout.write('\n },\n') + sys.stdout.write(f',\n {num_regs},\n }},\n') =20 sys.stdout.write(' { NULL }\n};\n') --=20 2.42.0