From nobody Wed Apr 16 04:14:22 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1697485249; cv=none; d=zohomail.com; s=zohoarc; b=CJf2To2LXTdnYbMEs9k0EMpFuO39AgGKsff6ueUFrInU1+zvWS71ucnF/ZWomyoOMuZ6cdKPzxi+2vqkrrP9rA7l6qfsy7C9K8cFOiIci9zlp1VR4OAZWNNeLOAlsX1LD6was3CC1LQnSYqIh1+IDMjNXhdu+3L6pbpc9q5dpyI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697485249; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=PivKdxk4mdurscq2RS5WTjojhH6Clx17UfNyr5URoOY=; b=moCr9cE21BIHpC7oJBQTvoo1p17H1/d7MT/Ph2/9j/S7hXTPfi6q9lmAxsZxfAqVXkefKqReffIwQLf2BNnPYEmCzTiS4lvUwJlDM7ZhKNCrXyewyp1gfgevuhV2W2czWaychaH02+b/RKlx/Vqs+JOi0fPoIDjkJrCHDWMi7C8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1697485249057624.9481025936904; Mon, 16 Oct 2023 12:40:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qsTSE-0000lR-8x; Mon, 16 Oct 2023 15:40:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qsTSC-0000hF-HI for qemu-devel@nongnu.org; Mon, 16 Oct 2023 15:40:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qsTSA-0001Ek-Vb for qemu-devel@nongnu.org; Mon, 16 Oct 2023 15:40:40 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-479-wnvOC--6NkKPFQANr6ybEA-1; Mon, 16 Oct 2023 15:40:36 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E348B801234; Mon, 16 Oct 2023 19:40:35 +0000 (UTC) Received: from localhost (unknown [10.39.195.59]) by smtp.corp.redhat.com (Postfix) with ESMTP id 61057C15BBC; Mon, 16 Oct 2023 19:40:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697485238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PivKdxk4mdurscq2RS5WTjojhH6Clx17UfNyr5URoOY=; b=Yu/5lpLsr4VDtCND3jb44sLEm5IFLJ/KweF7xHYMXiY8ngoxhi5hbZIB2vxtHUIBRNYt47 hZYeYkaxvq6TQflUaiKzGiEzJXWc4K84gFWNGRUb6B1WSzSUFEf4ALPrTet0vW5TX34cEn i+BK8U+EL4gU9pKheO7l6fpJ61KmSu8= X-MC-Unique: wnvOC--6NkKPFQANr6ybEA-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Kevin Wolf , "Michael S. Tsirkin" , qemu-block@nongnu.org, Stefan Hajnoczi , Hanna Reitz , hujian Subject: [PULL 1/1] virtio-blk: don't start dataplane during the stop of dataplane Date: Mon, 16 Oct 2023 15:40:28 -0400 Message-ID: <20231016194028.163610-2-stefanha@redhat.com> In-Reply-To: <20231016194028.163610-1-stefanha@redhat.com> References: <20231016194028.163610-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1697485250636100003 Content-Type: text/plain; charset="utf-8" From: hujian During the stop of dataplane for virtio-blk, virtio_bus_cleanup_host_notifi= er() is be called to clean up notifier at the end, if polled ioeventfd, virtio_blk_han= dle_output() is used to handle io request. But due to s->dataplane_disabled is false, it= will be returned directly, which drops io request. Backtrace: ->virtio_blk_data_plane_stop ->virtio_bus_cleanup_host_notifier ->virtio_queue_host_notifier_read ->virtio_queue_notify_vq ->vq->handle_output ->virtio_blk_handle_output ->if (s->dataplane && !s->dataplane_stoped) ->if (!s->dataplane_disabled) ->return * ->virtio_blk_handle_output_do The above problem can occur when using "virsh reset" cmdline to reset guest= , while guest does io. To fix this problem, don't try to start dataplane if s->stopping is true, a= nd io would be handled by virtio_blk_handle_vq(). Signed-off-by: hujian Message-id: 202310111414266586398@zte.com.cn Signed-off-by: Stefan Hajnoczi --- hw/block/virtio-blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index 39e7f23fab..c2d59389cb 100644 --- a/hw/block/virtio-blk.c +++ b/hw/block/virtio-blk.c @@ -1166,7 +1166,7 @@ static void virtio_blk_handle_output(VirtIODevice *vd= ev, VirtQueue *vq) { VirtIOBlock *s =3D (VirtIOBlock *)vdev; =20 - if (s->dataplane && !s->dataplane_started) { + if (s->dataplane && !s->dataplane_started && !s->stopping) { /* Some guests kick before setting VIRTIO_CONFIG_S_DRIVER_OK so st= art * dataplane here instead of waiting for .set_status(). */ --=20 2.41.0