From nobody Tue Feb 10 11:55:36 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1697123604; cv=pass; d=zohomail.com; s=zohoarc; b=SQMjO6ocEfo7mHP1RHcWMUEmi2IXC7w0wc3Ew0+ym1RWHs9iIv5NxOyU7hiiyM+TAMOHGXSz3Rnc7A6A7eF+w9zu/yEEg27sQWV0n+TtotuMYK9jmGJoAWEfrgtwOht3KaNLgoyX5l4lPCPs2SYFCbLqWN81SirC7pq6mfdMCxY= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697123604; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=hLHnoLs2k8XyCKqL59yZ5EFsIqg3skKlW79vxSzXN3Y=; b=ZmNWpBl3Jbz4q3+/D5NZVpoeejyTAA46CUmXe3fjEXWh/SyEKrHjp82U7mcom3E1xNZ79kjGR8XhUlzeIZ+ayhafXIdrFiGfzvsppDWfg7ubUrowwcf/jyQm24UESNhZ2NKiRnwkKbU50moxbvKx7/x3QU7FdLhRcRRxafU1sw8= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1697123604573651.5541214643301; Thu, 12 Oct 2023 08:13:24 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qqxLi-0006SA-Tn; Thu, 12 Oct 2023 11:11:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqxLg-0006P1-Vh for qemu-devel@nongnu.org; Thu, 12 Oct 2023 11:11:41 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqxLd-0003gv-Vx for qemu-devel@nongnu.org; Thu, 12 Oct 2023 11:11:40 -0400 Received: from pps.filterd (m0127844.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.17.1.22/8.17.1.22) with ESMTP id 39CAbVNW017937; Thu, 12 Oct 2023 08:11:37 -0700 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2041.outbound.protection.outlook.com [104.47.66.41]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 3tkhv0bhs2-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Oct 2023 08:11:36 -0700 (PDT) Received: from SJ2PR02MB9955.namprd02.prod.outlook.com (2603:10b6:a03:55f::16) by IA0PR02MB9510.namprd02.prod.outlook.com (2603:10b6:208:403::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.45; Thu, 12 Oct 2023 15:11:23 +0000 Received: from SJ2PR02MB9955.namprd02.prod.outlook.com ([fe80::f13d:ea:118b:b4ae]) by SJ2PR02MB9955.namprd02.prod.outlook.com ([fe80::f13d:ea:118b:b4ae%4]) with mapi id 15.20.6863.043; Thu, 12 Oct 2023 15:11:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :content-type:content-transfer-encoding:mime-version; s= proofpoint20171006; bh=hLHnoLs2k8XyCKqL59yZ5EFsIqg3skKlW79vxSzXN 3Y=; b=cjIrYapUUVio28Z0gVQFtd+gjhwpZPhiQO4ZnHP1qbHYHUdLejqW9bON/ Tqm9eP+q9cxO2kuEtY5GQKz69dXUB+hCxZow6TkJzI9RYZTFwr24UaXEN46DRXV1 wP2SO2s6WHS25oDIoKabrZrYLAlOkL1Han5D/DjbTaXzquDAafPHrbyxEhvMfray 82Q6JUZj1gvz+m0ykOKZlWrBlHrIMWo2y3HdfNYYd7bLDOAbqwHmGa362h3Q46HT OIm5I1c/Mz7MP4FEoSOfvmMZVDzZhxD+8Ij4/rx4qttw0/3LahLfapWTd6xk5wjz It2npb08mFUSpqcvbEKYg7KBCRvlw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ab+gNRqB1TV9OfeBoXRYftaqleUTEsVRKEBgTyJT4rZizGzEB1Fni0FnD8aUHwViy4gVzoA2FDF8tpvFipXZhsRwFgnBIDS/QD9w8zL26Dk14HT42q9nEv7TqsSpUBHa2TCY2Hj+RRyJ6uGCKBp2vA7hVUlNwCbgP0p9V942S6g7BjGz5FPW5fYpxP8lmqnsoJ1VXbnBDJ7dETSijgxhSdG5XqrvTTfSPrZ26Y/zghj+1Ylny6vsicIP1e8fDmbrqWHwz1+EXNiVoWm53m206aUPakJ8Vuv3eqBIJxixCo85GBqifdDRSEwjVcCXVYYp2nJms/ow9rE9RqRwQw5MlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hLHnoLs2k8XyCKqL59yZ5EFsIqg3skKlW79vxSzXN3Y=; b=UwTZHpyhxKcmAWxmWQux0blGdDcbv9fy3jejW2fjVEspk3QSS9wPx3FbahJkhCoCFIhf7yuzJc7KkShevWAsnhcLEu6e/8vDFMR8WgbKfqTrwrenP1Rf/I+oboQRTl5M6FTTuoNjT/ugLwI5wYOmyR/wfw9itzIh2ywkxxO2zTep92IrExkmgMu+6j4mcmFGZzjDIHxUT1kKHrrMTaF0qIITwljOEh7OfNhi19wmsvMtwm4ScCnKC+XY/nOyHnllmcUEL/KbUMK1pLEmPZvEU+Tsssl8KYh58FwCIYrXBWZkf5n9CSWn+lZoGJ5VrWm0h1m4Y6Ek8lMi/zTxmC+g0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hLHnoLs2k8XyCKqL59yZ5EFsIqg3skKlW79vxSzXN3Y=; b=GmRluPs2RSyTCigw1foWwJyoU5OZtJE0e+Uc21/by+18EIGGxuLjmCr58V3CtXTysFibuRyl8J8Ot9oeVJVU+tdLLuHENRyAWkSx0kpNnbxnaYcaL1XzuvXPfufaWCPNdsJKVOA3dDSn3+vQ/Cp2o3mGt9hXwPGhi+PJHm71kVQVIhFk/URFZbYrVc43UW0h0nSfxu3BtpG8HRKGthtS0tRq5alI6GiHrNAxJpfutSI4UmkpUsKAXIpe4EP3bmopJMx/LjMzfMGKeDgBfiDcbBt9tGCYmYsGMXo8AaUMz040knnH/NmesrC3nEtIUnFDRKZAHUxYp9DD4ZLTqpqU7w== From: Het Gala To: qemu-devel@nongnu.org Cc: prerna.saxena@nutanix.com, quintela@redhat.com, dgilbert@redhat.com, pbonzini@redhat.com, berrange@redhat.com, armbru@redhat.com, eblake@redhat.com, farosas@suse.de, manish.mishra@nutanix.com, aravind.retnakaran@nutanix.com, Het Gala Subject: [PATCH v13 07/10] migration: modify migration_channels_and_uri_compatible() for new QAPI syntax Date: Thu, 12 Oct 2023 15:10:49 +0000 Message-Id: <20231012151052.154106-8-het.gala@nutanix.com> X-Mailer: git-send-email 2.22.3 In-Reply-To: <20231012151052.154106-1-het.gala@nutanix.com> References: <20231012151052.154106-1-het.gala@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN2PR12CA0004.namprd12.prod.outlook.com (2603:10b6:208:a8::17) To SJ2PR02MB9955.namprd02.prod.outlook.com (2603:10b6:a03:55f::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR02MB9955:EE_|IA0PR02MB9510:EE_ X-MS-Office365-Filtering-Correlation-Id: 4d6d7cc5-52e1-47f8-b7b0-08dbcb357f46 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UgsZrFY0K+T1aAi5Pg4tN5AVSkgHAM8RA3BEmb/VyXDkkxjDM1bVCup/Y7nYRXOMKG7IUSScR32O7tq9W2hQ/XFEQHU22UHnrj4bhmXdg8Rr68zK0NYR5wirelcwDNlXI7auesJPgGQP1MPcASF/QXdGTNKDaklSMxp5Zod0yjBN4Hu85DSeILRxrwj6o5qiHZsi3AWgiuH8V3VCqzH336fliPFfUiftCr9ExIrDXGt8n7xzM97JASZklXTlqP7UnzoqTnOdEOPIB/nW2EfGQK0FIuvKkaFd9FwNyER5+uQ8j93Ymw0ONfgbwJwS9pGdwRUli3YZGEhn3p0dTx/2Fx5N+OMU+bRIAcZpvboay6k8x7ffYe2T+JvEA+E3dwzuRBmBuQnFXNZ0nsSGrdgS3UecZQZdGCC+jAJoptSuKjHQdxx5h6Q2ZcMZ0RguYaVAWpc+fmqasHhYJ9bOFLEfLmGli4zHOWw6Lb/fEgy+B1GXM/D37yvdQqbQX6hYRl5kkQA53Ry3LANGfiFq7dhP/D8I4suOuEPHostNl2LVGyJtfWKYbRLXhp8h2Pynvm6HH3jH1X+vf6gU2/umow2sG/NYgX67n5xijx8radifp+MikXwojk4lmA0TnyELDcFf X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR02MB9955.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(136003)(376002)(346002)(366004)(39860400002)(230922051799003)(1800799009)(64100799003)(451199024)(186009)(6512007)(38350700002)(38100700002)(26005)(2616005)(1076003)(107886003)(478600001)(6486002)(44832011)(5660300002)(8936002)(4326008)(8676002)(86362001)(2906002)(6916009)(316002)(66476007)(36756003)(41300700001)(66556008)(66946007)(6666004)(52116002)(6506007)(83380400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SHQ3TkhPMFBJanFnVUZTOG5VNXptaHhUU1BEMThoYThaWnY3LzJPOFZxaXFN?= =?utf-8?B?TGNNWjQ5b3FrSGo3eksrRHR5K2lDdVBoWGk5VlYxMGkwUkt5ZDlZWUFxcXc2?= =?utf-8?B?SFluWFFNM1RGVVcxTUlFUER6cExETFFCY3RzUkNVL0xobUcwQThibE15L3Q1?= =?utf-8?B?dS8zZzh1QnhHVVlVd3VvRXVvM3ppbWdqZS9hUW5iMlNvSWJVOVFDd1FDTmo4?= =?utf-8?B?SEYrdGZUUFlWV2MrL0huWTB5OFphTFd2WnYvME1HcXBsOWlidFNHZlhyUlBn?= =?utf-8?B?bk11cDkrNXpuMFExRXFTVlFqY2Q5N0svU3k2QmZiRWN6Q2Q4ZEo0dTh1aDhX?= =?utf-8?B?Z1ROUHgwdnVBQWlsNXhBUk5zMVhEZTdPQlRacFdGUVZlZFREdUR6dkUzdTFS?= =?utf-8?B?VHdscXM0RzNLdTF4NE10bktRelUwc29JZ09rRy9ybEo4dTJ6aVRhTi9sNDls?= =?utf-8?B?c2YwZHJWeTBjYThHbDJyemgwMVhmU2loY1hCbzE4Qk5paWVwY3JPSWNxbDRK?= =?utf-8?B?L0lxMlVsaWlPOGVxNVVHbzRlL3hPNHBIS09nb3h4WVg5VCtKTlIzVEFaSmtq?= =?utf-8?B?b0NwT2E2VFhkeVVtQXprcUQ2MlFobUpvRDA0N0FJQUxrTUNUR09FYWxqaXB2?= =?utf-8?B?TVRRYkg4RUtBdGpIanFVbS9VV0pkS29VeURaa3BjTG5VbGpSTkNLTzJaTElE?= =?utf-8?B?QXlZZ2RDNEcwSlBsMWhweWJuNG1JVzFFV2w1MG1IdWljeWtObStyVTh0N2tw?= =?utf-8?B?ZmFwU2xXTFAzRmxicXhReHZ5eVlpYjhGa0FSTUZTb3Q3d0gzQllSVkp1Nzlp?= =?utf-8?B?QmFhTGNyTk1jRkZyeUgydlZnbDF5NVgveTY5Rm83Ly9yRllod0Evdm5pTU9s?= =?utf-8?B?cFN2VVVyMzVmb3E4YWhQdFIxNUZoKzBMTitWRnlvR0hPWHZXbjVpU2FUSjFQ?= =?utf-8?B?LzV0ZTMzdHA1YkEreGtLYkYwdFh5T2hGcGtpNnJZQU55VDhJaHdOc0ZLTjhi?= =?utf-8?B?RTJxZ0JpNjBFYzVmTGIwbk91cUNMbXVXeVZFY0ZTcnFqcXM1aWNQYmR4ejNU?= =?utf-8?B?d2Uramhjc3o3YVRpbkZVb3dJRmlpOHpSdUlWbTlyamxMZmlpN3ZXSFh5ZFRk?= =?utf-8?B?VHRhOUNwZVZrYU04RW1TZVk1dGk4TXZnenhhNDNtTzdvZEh3RFk0blRjQVE5?= =?utf-8?B?Smk3NVlrbkMxckdHeUh6UjF6MG1iTm5YdWJKZklTUm9wNitmY21ZV0l3TEYv?= =?utf-8?B?VjRLMUhQamFLaTdXWUw3c2FIVk02VmlDTDRlTmsyZTkyTHdlVndPZU1MVEUw?= =?utf-8?B?bGtiME84dDNwejUwVE5HZU0wT3gyV1BlMHBNakp4cmgzVTI5N1lFNG43Zmpo?= =?utf-8?B?VVpMZkFHaEFUdDc2ZnM2SnVKZzlYN3pQODJOeXA3azVZMXR3TUR0Uks5UGZH?= =?utf-8?B?anNOM21wc1ppQld1TzlrT1lGM1pNeHYzNy9DZ1dsUUx2ZGlmSGRsaDExb2JU?= =?utf-8?B?bVpqN0h4bk9hdzRBQ3J2L0FtWFNnZXF1K0JWcGJIZWo2dnB3ZTZ1RDcrYWJm?= =?utf-8?B?M3ZSWmFpa0ZreEJPMG1LMHhBRVIrUDVWb0JqRFBtQ0ZmTEtpUytvUWJKdzNE?= =?utf-8?B?bjhhajdaTCtoNnZPR0xyWDV2YlRRUVFGNTI1RUxuekZRTVJLaDhmeFFBRzJ5?= =?utf-8?B?TDFndUI3cGlOMGNWdWJJS1JqT2paT1Jncmw2eXk4YjFSS0JtSXdTRlF6eDVM?= =?utf-8?B?clpUUnRvWFljRTh0eUFRVXJrSC9FeE5HQUFHcjFuaUVHWmxSSG80ME1vUHFF?= =?utf-8?B?eGpCWjVDRjQ2OTVsMnR3QlJhd0hzYWlRNWlBemljWEJpb0s0U2VIQ2MwSHFj?= =?utf-8?B?VGJGeUthNXI0Ui9lZG4rS3k4aGhLUzh0Y2RPbGhNY0Nxb0hyUjI5RUF1Y3Ba?= =?utf-8?B?SWRJajdyU3NGTVY4S3liam1ScHNORjl5YWNabGhvb0o1aTBwdzM3KzVSV1FL?= =?utf-8?B?RFVKS3F2elhSazFJeWJPQlgvYTZubTd0WUZLTjYzQnoxZkhObmREVUpDNVg1?= =?utf-8?B?am5KN1BMc1lIcVpDVHMwVlZTNngwRG9jdUpkVEZqM1B6Yi95WFZucmhiU0Nt?= =?utf-8?Q?c27nVcAiK8MnjUWbawkOiGD1/?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d6d7cc5-52e1-47f8-b7b0-08dbcb357f46 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR02MB9955.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2023 15:11:23.3775 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LQbi70FF9XGX7/4uLXe46JOIvv/UrWwFDXvG9thayGtnz2d3FdHtg8favtz4dnTH1fojJMe+o2skxLqHe3YJDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR02MB9510 X-Proofpoint-ORIG-GUID: _JwaYV6vNvJ7qcyLJBJMfp92NRZ-W5xS X-Proofpoint-GUID: _JwaYV6vNvJ7qcyLJBJMfp92NRZ-W5xS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-12_05,2023-10-12_01,2023-05-22_02 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=het.gala@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1697123606557100003 migration_channels_and_uri_compatible() check for transport mechanism suitable for multifd migration gets executed when the caller calls old uri syntax. It needs it to be run when using the modern MigrateChannel QAPI syntax too. After URI -> 'MigrateChannel' : migration_channels_and_uri_compatible() -> migration_channels_and_transport_compatible() passes object as argument and check for valid transport mechanism. Suggested-by: Aravind Retnakaran Signed-off-by: Het Gala Reviewed-by: Daniel P. Berrang=C3=A9 --- migration/migration.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index da50b83e5c..cf5a620c8e 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -107,17 +107,20 @@ static bool migration_needs_multiple_sockets(void) return migrate_multifd() || migrate_postcopy_preempt(); } =20 -static bool uri_supports_multi_channels(const char *uri) +static bool transport_supports_multi_channels(SocketAddress *saddr) { - return strstart(uri, "tcp:", NULL) || strstart(uri, "unix:", NULL) || - strstart(uri, "vsock:", NULL); + return saddr->type =3D=3D SOCKET_ADDRESS_TYPE_INET || + saddr->type =3D=3D SOCKET_ADDRESS_TYPE_UNIX || + saddr->type =3D=3D SOCKET_ADDRESS_TYPE_VSOCK; } =20 static bool -migration_channels_and_uri_compatible(const char *uri, Error **errp) +migration_channels_and_transport_compatible(MigrationAddress *addr, + Error **errp) { if (migration_needs_multiple_sockets() && - !uri_supports_multi_channels(uri)) { + (addr->transport =3D=3D MIGRATION_ADDRESS_TYPE_SOCKET) && + !transport_supports_multi_channels(&addr->u.socket)) { error_setg(errp, "Migration requires multi-channel URIs (e.g. tcp)= "); return false; } @@ -503,12 +506,12 @@ static void qemu_start_incoming_migration(const char = *uri, bool has_channels, return; } =20 - /* URI is not suitable for migration? */ - if (!migration_channels_and_uri_compatible(uri, errp)) { + if (uri && !migrate_uri_parse(uri, &channel, errp)) { return; } =20 - if (uri && !migrate_uri_parse(uri, &channel, errp)) { + /* transport mechanism not suitable for migration? */ + if (!migration_channels_and_transport_compatible(channel, errp)) { return; } =20 @@ -1788,12 +1791,12 @@ void qmp_migrate(const char *uri, bool has_channels, return; } =20 - /* URI is not suitable for migration? */ - if (!migration_channels_and_uri_compatible(uri, errp)) { + if (!migrate_uri_parse(uri, &channel, errp)) { return; } =20 - if (!migrate_uri_parse(uri, &channel, errp)) { + /* transport mechanism not suitable for migration? */ + if (!migration_channels_and_transport_compatible(channel, errp)) { return; } =20 --=20 2.22.3