From nobody Tue Feb 10 12:39:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1697122728; cv=none; d=zohomail.com; s=zohoarc; b=JjwrKnwxpSFbyRy+LNHKGGpIQBuI28J9X5sUZaHTo3h51Oivpaip1RDUnWZl//zd/pkLBfhsDQ/g5XJIu/g96a61iI/CrAkobMhat3gLURmzDDb4QwZfABMCBUal2Be7cR+1J4Tl4vGzHoDZsgo9uZKNtSNPdViVKTjI3ijjD3s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697122728; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=BOBvTN24AwDZymRAdlgF5sszPLVku+wG5poAs5x4ffs=; b=mQFsR2Rk115CWGOM2E85fSa2v6ncIu67JBSyqvzYugewY8fvW7mKDoo2Dp/zgNxKBN5Y/yhdlev90/xgim1BooBlGez3F/J4cEezF+hcUMBmPGz3OmAvo3LDwNynX6T2xL08GkSSOqP5ILbyVGpHCUd7JjxjLINOVm16pFzagCI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1697122728765667.5549150067051; Thu, 12 Oct 2023 07:58:48 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qqx83-0007wp-Jr; Thu, 12 Oct 2023 10:57:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqx81-0007wQ-Nx for qemu-devel@nongnu.org; Thu, 12 Oct 2023 10:57:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqx80-0000sK-D7 for qemu-devel@nongnu.org; Thu, 12 Oct 2023 10:57:33 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-6-GznckU62PSmlxVLzGM_36w-1; Thu, 12 Oct 2023 10:57:25 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 38578185A7B5; Thu, 12 Oct 2023 14:57:25 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.193.72]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 17BE1202701E; Thu, 12 Oct 2023 14:57:25 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id B713621E6A26; Thu, 12 Oct 2023 16:57:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697122651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BOBvTN24AwDZymRAdlgF5sszPLVku+wG5poAs5x4ffs=; b=gPLYwXmTntJ7L+gX5NPTVyB9DuH2T+Q9Go2IY+Y1sYisvuQjwHUpz7WgLb55SfC3rEhhQ5 ETZp6FNMkeElbfuphq9wAvTm6ovQY5XOsNQJverJR0/mFJecBDcyXEHbABJqPabjYv53r9 mFj2+AKehZJP/84wZUMb2j2lk4JyyII= X-MC-Unique: GznckU62PSmlxVLzGM_36w-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 5/5] target/i386: fix shadowed variable pasto Date: Thu, 12 Oct 2023 16:57:21 +0200 Message-ID: <20231012145721.77039-6-armbru@redhat.com> In-Reply-To: <20231012145721.77039-1-armbru@redhat.com> References: <20231012145721.77039-1-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1697122730188100008 From: Paolo Bonzini Commit a908985971a ("target/i386/seg_helper: introduce tss_set_busy", 2023-09-26) failed to use the tss_selector argument of the new function, which was therefore unused. This shows up as a #GP fault when booting old versions of 32-bit Linux. Fixes: a908985971a ("target/i386/seg_helper: introduce tss_set_busy", 2023-= 09-26) Signed-off-by: Paolo Bonzini Message-ID: <20231011135350.438492-1-pbonzini@redhat.com> Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Markus Armbruster --- target/i386/tcg/seg_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/tcg/seg_helper.c b/target/i386/tcg/seg_helper.c index 2b92aee207..eb29a1fd4e 100644 --- a/target/i386/tcg/seg_helper.c +++ b/target/i386/tcg/seg_helper.c @@ -229,7 +229,7 @@ static void tss_load_seg(CPUX86State *env, X86Seg seg_r= eg, int selector, static void tss_set_busy(CPUX86State *env, int tss_selector, bool value, uintptr_t retaddr) { - target_ulong ptr =3D env->gdt.base + (env->tr.selector & ~7); + target_ulong ptr =3D env->gdt.base + (tss_selector & ~7); uint32_t e2 =3D cpu_ldl_kernel_ra(env, ptr + 4, retaddr); =20 if (value) { --=20 2.41.0