From nobody Sun May 11 14:03:03 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass(p=none dis=none) header.from=yandex-team.ru
ARC-Seal: i=1; a=rsa-sha256; t=1696623751; cv=none;
d=zohomail.com; s=zohoarc;
b=Tb1idZF8/EdL2gCGCzwfq8F5EKr+kEpeQNQdsPaCiIyJxbJ/J1TPgL3dmVep/1v3OCvH+H4wD5thqpyTFFi3VXGAE0TG//60p130gSCZ4aWf4eXPYxglcCjDwY9hVkFDSN6DJKDb2bM3im/TEUgkLzpAfN6N+H6ijEOKs1WrJeA=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1696623751;
h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To;
bh=cYIUd1vWCV2rSNw0Vd96GaLbaPbVWwVkbM3mnNEKBBU=;
b=jsB9picwPnxDRjAzfRZ8IXYGYr1XCO7F3tI9ysO7NMsje9xJ1PEGaCT9x5kvrtdNwVhC8Gx9MEqPWt+6S3ZbjNZ5K/vOBZQApDG+2CG1ZcmEUTJnOFrEg0jSgEXDcXElEqWcbpupHm4P/C0BsG7q2tkk1IZ4px8DhyakasTHPbY=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass header.from=<vsementsov@yandex-team.ru> (p=none dis=none)
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
mx.zohomail.com
with SMTPS id 1696623751435875.4057322648878;
Fri, 6 Oct 2023 13:22:31 -0700 (PDT)
Received: from localhost ([::1] helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <qemu-devel-bounces@nongnu.org>)
id 1qorJs-0008G4-Uy; Fri, 06 Oct 2023 16:21:08 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <vsementsov@yandex-team.ru>)
id 1qorJq-0008Dv-Ap; Fri, 06 Oct 2023 16:21:06 -0400
Received: from forwardcorp1b.mail.yandex.net
([2a02:6b8:c02:900:1:45:d181:df01])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <vsementsov@yandex-team.ru>)
id 1qorJn-0005mT-In; Fri, 06 Oct 2023 16:21:06 -0400
Received: from mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net
(mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net
[IPv6:2a02:6b8:c12:3a8c:0:640:ec94:0])
by forwardcorp1b.mail.yandex.net (Yandex) with ESMTP id 296766182D;
Fri, 6 Oct 2023 23:21:01 +0300 (MSK)
Received: from vsementsov-lin.. (unknown [2a02:6b8:b081:b403::1:3c])
by mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net (smtpcorp/Yandex) with
ESMTPSA id kKgI6e5OrCg0-iM1X41DT; Fri, 06 Oct 2023 23:21:00 +0300
Precedence: bulk
X-Yandex-Fwd: 1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;
s=default; t=1696623660;
bh=cYIUd1vWCV2rSNw0Vd96GaLbaPbVWwVkbM3mnNEKBBU=;
h=Message-Id:Date:In-Reply-To:Cc:Subject:References:To:From;
b=FHU5Ei4SdLL94jbpG8PbmtMBis2QvywCviG6jmN2kNY1byf5lZ+L6jjdoVQK3Ib9V
+JUJ2XHdHxrav/iDES39cciETBo8R/YZGC5EitIFyHDUNfH/O1dm9okFDgA1CKsXzi
w+cWABr3rKv6Dq+3Er60+TUIWHQJomG39MMAeqkQ=
Authentication-Results: mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net;
dkim=pass header.i=@yandex-team.ru
From: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, eblake@redhat.com, dave@treblig.org,
armbru@redhat.com, eduardo@habkost.net, berrange@redhat.com,
pbonzini@redhat.com, hreitz@redhat.com, kwolf@redhat.com,
raphael.norwitz@nutanix.com, mst@redhat.com, yc-core@yandex-team.ru,
vsementsov@yandex-team.ru, den-plotnikov@yandex-team.ru,
daniil.tatianin@yandex.ru
Subject: [PATCH 4/4] qapi: introduce CONFIG_READ event
Date: Fri, 6 Oct 2023 23:20:45 +0300
Message-Id: <20231006202045.1161543-5-vsementsov@yandex-team.ru>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20231006202045.1161543-1-vsementsov@yandex-team.ru>
References: <20231006202045.1161543-1-vsementsov@yandex-team.ru>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
as permitted sender) client-ip=209.51.188.17;
envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
helo=lists.gnu.org;
Received-SPF: pass client-ip=2a02:6b8:c02:900:1:45:d181:df01;
envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1b.mail.yandex.net
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org
X-ZohoMail-DKIM: pass (identity @yandex-team.ru)
X-ZM-MESSAGEID: 1696623753286100011
Content-Type: text/plain; charset="utf-8"
Send a new event when guest reads virtio-pci config after
virtio_notify_config() call.
That's useful to check that guest fetched modified config, for example
after resizing disk backend.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
hw/virtio/virtio-pci.c | 9 +++++++++
include/monitor/qdev.h | 1 +
monitor/monitor.c | 1 +
qapi/qdev.json | 22 ++++++++++++++++++++++
softmmu/qdev-monitor.c | 5 +++++
5 files changed, 38 insertions(+)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index dd4620462b..f24f8ff03d 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virtio/virtio-pci.c
@@ -23,6 +23,7 @@
#include "hw/boards.h"
#include "hw/virtio/virtio.h"
#include "migration/qemu-file-types.h"
+#include "monitor/qdev.h"
#include "hw/pci/pci.h"
#include "hw/pci/pci_bus.h"
#include "hw/qdev-properties.h"
@@ -541,6 +542,10 @@ static uint64_t virtio_pci_config_read(void *opaque, h=
waddr addr,
}
addr -=3D config;
=20
+ if (vdev->generation > 0) {
+ qdev_config_read_event(DEVICE(proxy));
+ }
+
switch (size) {
case 1:
val =3D virtio_config_readb(vdev, addr);
@@ -1728,6 +1733,10 @@ static uint64_t virtio_pci_device_read(void *opaque,=
hwaddr addr,
return UINT64_MAX;
}
=20
+ if (vdev->generation > 0) {
+ qdev_config_read_event(DEVICE(proxy));
+ }
+
switch (size) {
case 1:
val =3D virtio_config_modern_readb(vdev, addr);
diff --git a/include/monitor/qdev.h b/include/monitor/qdev.h
index 949a3672cb..f0b0eab07e 100644
--- a/include/monitor/qdev.h
+++ b/include/monitor/qdev.h
@@ -39,6 +39,7 @@ DeviceState *qdev_device_add_from_qdict(const QDict *opts,
const char *qdev_set_id(DeviceState *dev, char *id, Error **errp);
=20
void qdev_hotplug_device_on_event(DeviceState *dev);
+void qdev_config_read_event(DeviceState *dev);
=20
DeviceAndPath *qdev_new_device_and_path(DeviceState *dev);
=20
diff --git a/monitor/monitor.c b/monitor/monitor.c
index 941f87815a..f8aa91b190 100644
--- a/monitor/monitor.c
+++ b/monitor/monitor.c
@@ -315,6 +315,7 @@ static MonitorQAPIEventConf monitor_qapi_event_conf[QAP=
I_EVENT__MAX] =3D {
[QAPI_EVENT_QUORUM_FAILURE] =3D { 1000 * SCALE_MS },
[QAPI_EVENT_VSERPORT_CHANGE] =3D { 1000 * SCALE_MS },
[QAPI_EVENT_MEMORY_DEVICE_SIZE_CHANGE] =3D { 1000 * SCALE_MS },
+ [QAPI_EVENT_X_CONFIG_READ] =3D { 300 * SCALE_MS },
};
=20
/*
diff --git a/qapi/qdev.json b/qapi/qdev.json
index 2468f8bddf..37a8785b81 100644
--- a/qapi/qdev.json
+++ b/qapi/qdev.json
@@ -329,3 +329,25 @@
# Since: 8.2
##
{ 'command': 'x-device-sync-config', 'data': {'id': 'str'} }
+
+##
+# @X_CONFIG_READ:
+#
+# Emitted whenever guest reads virtio device config after config change.
+#
+# @device: device name
+#
+# @path: device path
+#
+# Since: 5.0.1-24
+#
+# Example:
+#
+# <- { "event": "X_CONFIG_READ",
+# "data": { "device": "virtio-net-pci-0",
+# "path": "/machine/peripheral/virtio-net-pci-0" },
+# "timestamp": { "seconds": 1265044230, "microseconds": 450486 } }
+#
+##
+{ 'event': 'X_CONFIG_READ',
+ 'data': { '*device': 'str', 'path': 'str' } }
diff --git a/softmmu/qdev-monitor.c b/softmmu/qdev-monitor.c
index b485375049..d0f022e925 100644
--- a/softmmu/qdev-monitor.c
+++ b/softmmu/qdev-monitor.c
@@ -1252,3 +1252,8 @@ void qdev_hotplug_device_on_event(DeviceState *dev)
dev->device_on_event_sent =3D true;
qapi_event_send_x_device_on(dev->id, dev->canonical_path);
}
+
+void qdev_config_read_event(DeviceState *dev)
+{
+ qapi_event_send_x_config_read(dev->id, dev->canonical_path);
+}
--=20
2.34.1