From nobody Mon Feb 9 14:34:22 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1696607038; cv=none; d=zohomail.com; s=zohoarc; b=m2uaxNYP9pDOauIca03wvdgEzkxrZRIV9tSAf3kLDA/oCeE5VMeAm1s+ijlTm2KcvT/IwEWWOvKrgRneP5zNMa07F4s0VAyTOxW+emb1IQCkXWXbt0qSor5bx9EWbywBtSP2b5mtUsfhvIwqncy6XQYJh3PgHmOkEUZWFLQ3Uuo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1696607038; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gvkGZk/k24nZ1JAUhfPf/PBDaBGcGo+bo6/HMxHtkGk=; b=DsEn1R+lNysOmLAow8q8K9qCCPqC7Fg3AvOJy2yYYu+6TihQNA1KRkWOc/w12kAWlGW8l6ADA04+WM3ALZLbGrUPCGPD55bAknq6m+8pYT1QM/Eowo2hrZKy4qX488FQLMd3a4RYxgn/9KzAMpYOjLZlndyhNuj4KeDfk0sV+T4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1696607037996146.90514649596446; Fri, 6 Oct 2023 08:43:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qomxf-0006Y5-A1; Fri, 06 Oct 2023 11:41:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qomxc-0006UR-Fv; Fri, 06 Oct 2023 11:41:52 -0400 Received: from forwardcorp1c.mail.yandex.net ([2a02:6b8:c03:500:1:45:d181:df01]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qomxX-0003WH-P3; Fri, 06 Oct 2023 11:41:52 -0400 Received: from mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net [IPv6:2a02:6b8:c12:3a8c:0:640:ec94:0]) by forwardcorp1c.mail.yandex.net (Yandex) with ESMTP id 9E62B612D8; Fri, 6 Oct 2023 18:41:45 +0300 (MSK) Received: from vsementsov-lin.. (unknown [2a02:6b8:b081:a512::1:22]) by mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id VfbK2W5OrKo0-LcaQGfab; Fri, 06 Oct 2023 18:41:44 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1696606905; bh=gvkGZk/k24nZ1JAUhfPf/PBDaBGcGo+bo6/HMxHtkGk=; h=Message-Id:Date:In-Reply-To:Cc:Subject:References:To:From; b=qBefuczYQrUco14NFznul17B0LRXoZDzSRxfZpqDXqo6AATnSDtyrCvSbTzC39H9r 07hTanjt2OdFHevSum19R4LQugc9SjxDaJ1uUOLgbKhlv/k0XfCOsJ99liG35R8zSs 1N2Se9Xk7lokR84OJi4kWoKimz7zBqgzMErJjME4= Authentication-Results: mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, vsementsov@yandex-team.ru, jsnow@redhat.com, crosa@redhat.com, kwolf@redhat.com, hreitz@redhat.com, eblake@redhat.com Subject: [PATCH v7 03/15] scripts/cpu-x86-uarch-abi.py: use .command() instead of .cmd() Date: Fri, 6 Oct 2023 18:41:13 +0300 Message-Id: <20231006154125.1068348-4-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231006154125.1068348-1-vsementsov@yandex-team.ru> References: <20231006154125.1068348-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a02:6b8:c03:500:1:45:d181:df01; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1c.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1696607038694100003 Content-Type: text/plain; charset="utf-8" Here we don't expect a failure. In case of failure we'll crash on trying to access ['return']. Better is to use .command() that clearly raises on failure. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- scripts/cpu-x86-uarch-abi.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/scripts/cpu-x86-uarch-abi.py b/scripts/cpu-x86-uarch-abi.py index 82ff07582f..893afd1b35 100644 --- a/scripts/cpu-x86-uarch-abi.py +++ b/scripts/cpu-x86-uarch-abi.py @@ -69,7 +69,7 @@ shell =3D QEMUMonitorProtocol(sock) shell.connect() =20 -models =3D shell.cmd("query-cpu-definitions") +models =3D shell.command("query-cpu-definitions") =20 # These QMP props don't correspond to CPUID fatures # so ignore them @@ -85,7 +85,7 @@ =20 names =3D [] =20 -for model in models["return"]: +for model in models: if "alias-of" in model: continue names.append(model["name"]) @@ -93,12 +93,12 @@ models =3D {} =20 for name in sorted(names): - cpu =3D shell.cmd("query-cpu-model-expansion", - { "type": "static", - "model": { "name": name }}) + cpu =3D shell.command("query-cpu-model-expansion", + { "type": "static", + "model": { "name": name }}) =20 got =3D {} - for (feature, present) in cpu["return"]["model"]["props"].items(): + for (feature, present) in cpu["model"]["props"].items(): if present and feature not in skip: got[feature] =3D True =20 --=20 2.34.1