From nobody Tue Feb 10 20:50:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1696408788157793.149413142538; Wed, 4 Oct 2023 01:39:48 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qnxPc-00052u-BG; Wed, 04 Oct 2023 04:39:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnxPZ-0004yl-PS for qemu-devel@nongnu.org; Wed, 04 Oct 2023 04:39:18 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnxPX-0007jB-Qe for qemu-devel@nongnu.org; Wed, 04 Oct 2023 04:39:17 -0400 Received: from host86-159-123-68.range86-159.btcentralplus.com ([86.159.123.68] helo=localhost.localdomain) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qnxPH-0006za-Tb; Wed, 04 Oct 2023 09:39:03 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To:Cc: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3cK7mneHmXDNy7JJNlaYZg+pj4RJY5qtD7UyWcf/zd4=; b=00vLPv3lcAOH3ihG4/1rovrpWm DUZ3DVUhIJV5FXQaJ8L+HKbPj6RnyesoFdNzXmZ5x1TRj+PT3Tx1jiK3ty1GTDGrZ98XjaMS5iAq1 aVdpQwXg2QO5jmG42dmxBdQ4QfCJzAuzqW3jssmKcq8maLezMmYl56vHWrP5j17HctNnh9l6l2pHg iH9RAZKYGws/wq36mbRPHewIoSB71AvkQPXMYoSVCd1tmiF9+GMMV8812hztng1R2MQtps75Syb+i WHQnyu5wE5DcQfBGTSugbqO2Deb5l0n9ge66ZI4Z5CVF5+N6abJFp+qdYAAQkgmZliV1YLjZnaGG0 BmQSshr0piKh1VR/HQiWHs7fnxA/t7Zt6/+pfXGQ51gZUKiBfab8Z7nnAfslXCmx7PEXEz5bc2Zlg SMclVgSnSXtOycOU9WoZxEw9sWRCfUuz0mzK4axf1KzGijDC/lgyO7sAic8S6yG9qnFmGOLaqu3rL 03i2vr5ngIHePxWxD3Srr3oVsg62k4zC++F/avFJ6KPdVkZm7lpuMtSe6t48eIss53xX/dTL8kVXs gZjXk1HDRYLZDsk8hy9rF9xoyoawWRsE+JdQhWR8lA8oJoI8ysm+E9Eqwu8nBqQ6q1nePZ86wJcYc zhSKRxs49OaZdP3Ozo3qzTt+2z+GDxhnRtmzL5qUw=; From: Mark Cave-Ayland To: laurent@vivier.eu, qemu-devel@nongnu.org Date: Wed, 4 Oct 2023 09:38:01 +0100 Message-Id: <20231004083806.757242-16-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231004083806.757242-1-mark.cave-ayland@ilande.co.uk> References: <20231004083806.757242-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 86.159.123.68 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [PATCH v4 15/20] mac_via: workaround NetBSD ADB bus enumeration issue X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1696408789592100002 Content-Type: text/plain; charset="utf-8" NetBSD assumes it can send its first ADB command after sending the ADB_BUSR= ESET command in ADB_STATE_NEW without changing the state back to ADB_STATE_IDLE first as detailed in the ADB protocol. Add a workaround to detect this condition at the start of ADB enumeration and send the next command written to SR after a ADB_BUSRESET onto the bus regardless, even if we don't detect a state transition to ADB_STATE_NEW. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier --- hw/misc/mac_via.c | 34 ++++++++++++++++++++++++++++++++++ hw/misc/trace-events | 1 + 2 files changed, 35 insertions(+) diff --git a/hw/misc/mac_via.c b/hw/misc/mac_via.c index f2ccb12d64..9f9c2815d0 100644 --- a/hw/misc/mac_via.c +++ b/hw/misc/mac_via.c @@ -1001,6 +1001,8 @@ static void mos6522_q800_via1_write(void *opaque, hwa= ddr addr, uint64_t val, { MOS6522Q800VIA1State *v1s =3D MOS6522_Q800_VIA1(opaque); MOS6522State *ms =3D MOS6522(v1s); + int oldstate, state; + int oldsr =3D ms->sr; =20 addr =3D (addr >> 9) & 0xf; =20 @@ -1016,6 +1018,38 @@ static void mos6522_q800_via1_write(void *opaque, hw= addr addr, uint64_t val, =20 v1s->last_b =3D ms->b; break; + + case VIA_REG_SR: + { + /* + * NetBSD assumes it can send its first ADB command after send= ing + * the ADB_BUSRESET command in ADB_STATE_NEW without changing = the + * state back to ADB_STATE_IDLE first as detailed in the ADB + * protocol. + * + * Add a workaround to detect this condition at the start of A= DB + * enumeration and send the next command written to SR after a + * ADB_BUSRESET onto the bus regardless, even if we don't dete= ct a + * state transition to ADB_STATE_NEW. + * + * Note that in my tests the NetBSD state machine takes one ADB + * operation to recover which means the probe for an ADB devic= e at + * address 1 always fails. However since the first device is at + * address 2 then this will work fine, without having to come = up + * with a more complicated and invasive solution. + */ + oldstate =3D (v1s->last_b & VIA1B_vADB_StateMask) >> + VIA1B_vADB_StateShift; + state =3D (ms->b & VIA1B_vADB_StateMask) >> VIA1B_vADB_StateSh= ift; + + if (oldstate =3D=3D ADB_STATE_NEW && state =3D=3D ADB_STATE_NE= W && + (ms->acr & VIA1ACR_vShiftOut) && + oldsr =3D=3D 0 /* ADB_BUSRESET */) { + trace_via1_adb_netbsd_enum_hack(); + adb_via_send(v1s, state, ms->sr); + } + } + break; } } =20 diff --git a/hw/misc/trace-events b/hw/misc/trace-events index 5a998f5e4e..24ba7cc4d0 100644 --- a/hw/misc/trace-events +++ b/hw/misc/trace-events @@ -271,6 +271,7 @@ via1_rtc_cmd_pram_sect_write(int sector, int offset, in= t addr, int value) "secto via1_adb_send(const char *state, uint8_t data, const char *vadbint) "state= %s data=3D0x%02x vADBInt=3D%s" via1_adb_receive(const char *state, uint8_t data, const char *vadbint, int= status, int index, int size) "state %s data=3D0x%02x vADBInt=3D%s status= =3D0x%x index=3D%d size=3D%d" via1_adb_poll(uint8_t data, const char *vadbint, int status, int index, in= t size) "data=3D0x%02x vADBInt=3D%s status=3D0x%x index=3D%d size=3D%d" +via1_adb_netbsd_enum_hack(void) "using NetBSD enum hack" via1_auxmode(int mode) "setting auxmode to %d" via1_timer_hack_state(int state) "setting timer_hack_state to %d" =20 --=20 2.39.2