From nobody Wed Feb 11 07:02:13 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1695978083; cv=none; d=zohomail.com; s=zohoarc; b=dWKyfLShSZrJ0RdO0CpgO/0sAMwh4NzSuJR16P+LNp1uDN4I/EYtJrSbafHUy7iHCYADzvqg34xzPf48L5yxgH6gbfhforef0ER5YH7xoqfLj9+uPfNXff8RA4cZ+yhVvYAhcUoSsxqE2syS4KKh44zm+PGSjCj3VoVAqJf/xpE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1695978083; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vC9UdFtw5oUsGVhmJOxImvqvigFqmtXJZT8II3cT5zU=; b=bn6JGB5Wn5sNvMqxdfDpKgLE3UHC6lB0rQsAp+IvXwZ8jnKaYgy3eRHFVZ9W0G4PAj6cw68pTPE6iYvwoqxdrBddLO8sTLFnDLEf6knY+cSm51SwsqjctOZz9VQM4gyDHB/CGB9Qu1x3L57W+i7XVmXJkZLgTNmbFRxwQ/DmRik= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1695978083530772.3599920743517; Fri, 29 Sep 2023 02:01:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qm9Mb-0001mX-1X; Fri, 29 Sep 2023 05:00:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qm9MW-0001lu-Dj for qemu-devel@nongnu.org; Fri, 29 Sep 2023 05:00:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qm9MS-0008CP-F5 for qemu-devel@nongnu.org; Fri, 29 Sep 2023 05:00:40 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-583-AHSJQFTbM0a11empV89rgA-1; Fri, 29 Sep 2023 05:00:28 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 86E4D1019C92; Fri, 29 Sep 2023 09:00:28 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6465B400F3C; Fri, 29 Sep 2023 09:00:28 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id E86EC21E68A8; Fri, 29 Sep 2023 10:50:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695978034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vC9UdFtw5oUsGVhmJOxImvqvigFqmtXJZT8II3cT5zU=; b=Y9C7a3uErcKDDgDsZlv1vUZrjO8oXdl/RgeHyXtTMlQ06SQd5Q3nNDYjxH///nk/7TBoDo IpaanQwn3IBI3wZ69ZpRfHb7auzCotBkzkUP6TRIqv7rhog5wbeAm7xv0ytaJkNn/nzoPk XYGOwMD1djph2PGtg+gdoYKRKuVk6Nc= X-MC-Unique: AHSJQFTbM0a11empV89rgA-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, Alistair Francis , Alistair Francis , Daniel Henrique Barboza Subject: [PULL 51/56] hw/riscv: opentitan: Fixup local variables shadowing Date: Fri, 29 Sep 2023 10:50:48 +0200 Message-ID: <20230929085053.2789105-52-armbru@redhat.com> In-Reply-To: <20230929085053.2789105-1-armbru@redhat.com> References: <20230929085053.2789105-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1695978084345100001 Content-Type: text/plain; charset="utf-8" From: Alistair Francis Local variables shadowing other local variables or parameters make the code needlessly hard to understand. Bugs love to hide in such code. Evidence: "[PATCH v3 1/7] migration/rdma: Fix save_page method to fail on polling error". This patch removes the local variable shadowing. Tested by adding: --extra-cflags=3D'-Wshadow=3Dlocal -Wno-error=3Dshadow=3Dlocal -Wno-err= or=3Dshadow=3Dcompatible-local' To configure Signed-off-by: Alistair Francis Message-ID: <20230925043023.71448-2-alistair.francis@wdc.com> Reviewed-by: Daniel Henrique Barboza Signed-off-by: Markus Armbruster --- hw/riscv/opentitan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/riscv/opentitan.c b/hw/riscv/opentitan.c index 6a2fcc4ade..436503f1ba 100644 --- a/hw/riscv/opentitan.c +++ b/hw/riscv/opentitan.c @@ -227,7 +227,7 @@ static void lowrisc_ibex_soc_realize(DeviceState *dev_s= oc, Error **errp) IRQ_M_TIMER)); =20 /* SPI-Hosts */ - for (int i =3D 0; i < OPENTITAN_NUM_SPI_HOSTS; ++i) { + for (i =3D 0; i < OPENTITAN_NUM_SPI_HOSTS; ++i) { dev =3D DEVICE(&(s->spi_host[i])); if (!sysbus_realize(SYS_BUS_DEVICE(&s->spi_host[i]), errp)) { return; --=20 2.41.0