From nobody Tue Feb 10 00:59:17 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1695723325; cv=none; d=zohomail.com; s=zohoarc; b=LsZ2q8VRWr1/ESjYbsqvF2wB80GrLaY1HEp6p+tlMH6Cz1R6zv8OIn1+tlsYqok2HoeEkds6EEuPCWLy1rFf4m64Qao7vAuQxsSNsu4Oig1ScHPjEkpJ3VOXzc9muW+8YCeozUyooGuxhYHFloWzQQ1m7BF82ClpAzhML7ckxCk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1695723325; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=ssX8karBHUw+BmslLKs7x55paHeCjtLjJYLs95V1stE=; b=dLUGnMtYyOXNhiL3W8bYAIhoomzGEXk0wh7SALAG57ARjYku6gZWDn/+codptiP9dFp+XDtS1mFAdqJ4bDrvQ7rZmtVQYY7uVS+Rm/D/eedJQGj6qWFuHx6gaEqwz5aWLB3dPyMmU+l0CXD2U5fpCpXOnIVRgGuaotxSYQXZP7M= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1695723325458956.8988183173071; Tue, 26 Sep 2023 03:15:25 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ql55R-000055-38; Tue, 26 Sep 2023 06:14:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ql55I-0008NI-72; Tue, 26 Sep 2023 06:14:28 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ql55F-0005UM-AK; Tue, 26 Sep 2023 06:14:27 -0400 Received: from lhrpeml500001.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4RvwX24Jgfz6D8cB; Tue, 26 Sep 2023 18:12:02 +0800 (CST) Received: from A190218597.china.huawei.com (10.126.174.16) by lhrpeml500001.china.huawei.com (7.191.163.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 26 Sep 2023 11:14:04 +0100 To: , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH RFC V2 29/37] arm/virt: Update the guest(via GED) about CPU hot-(un)plug events Date: Tue, 26 Sep 2023 11:04:28 +0100 Message-ID: <20230926100436.28284-30-salil.mehta@huawei.com> X-Mailer: git-send-email 2.8.3 In-Reply-To: <20230926100436.28284-1-salil.mehta@huawei.com> References: <20230926100436.28284-1-salil.mehta@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.126.174.16] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To lhrpeml500001.china.huawei.com (7.191.163.213) X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=185.176.79.56; envelope-from=salil.mehta@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Salil Mehta From: Salil Mehta via Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1695723327168100003 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" During any vCPU hot-(un)plug, running guest VM needs to be intimated about = the new vCPU being added or request the deletion of the vCPU which is already p= art of the guest VM. This is done using the ACPI GED event which eventually gets demultiplexed to a CPU hotplug event and further to specific hot-(un)plug e= vent of a particular vCPU. This change adds the ACPI calls to the existing hot-(un)plug hooks to trigg= er ACPI GED events from QEMU to guest VM. Co-developed-by: Salil Mehta Signed-off-by: Salil Mehta Co-developed-by: Keqian Zhu Signed-off-by: Keqian Zhu Signed-off-by: Salil Mehta --- hw/arm/virt.c | 33 ++++++++++++++++++++++++++++++--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index b447e86fb6..6f5ee4a1c6 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -3157,6 +3157,7 @@ static void virt_cpu_plug(HotplugHandler *hotplug_dev= , DeviceState *dev, VirtMachineState *vms =3D VIRT_MACHINE(hotplug_dev); MachineState *ms =3D MACHINE(hotplug_dev); CPUState *cs =3D CPU(dev); + Error *local_err =3D NULL; CPUArchId *cpu_slot; =20 /* insert the cold/hot-plugged vcpu in the slot */ @@ -3169,12 +3170,20 @@ static void virt_cpu_plug(HotplugHandler *hotplug_d= ev, DeviceState *dev, * plugged, guest is also notified. */ if (vms->acpi_dev) { - /* TODO: update acpi hotplug state. Send cpu hotplug event to gues= t */ + HotplugHandlerClass *hhc; + /* update acpi hotplug state and send cpu hotplug event to guest */ + hhc =3D HOTPLUG_HANDLER_GET_CLASS(vms->acpi_dev); + hhc->plug(HOTPLUG_HANDLER(vms->acpi_dev), dev, &local_err); + if (local_err) { + goto fail; + } /* TODO: register cpu for reset & update F/W info for the next boo= t */ } =20 cs->disabled =3D false; return; +fail: + error_propagate(errp, local_err); } =20 static void virt_cpu_unplug_request(HotplugHandler *hotplug_dev, @@ -3182,8 +3191,10 @@ static void virt_cpu_unplug_request(HotplugHandler *= hotplug_dev, { MachineClass *mc =3D MACHINE_GET_CLASS(qdev_get_machine()); VirtMachineState *vms =3D VIRT_MACHINE(hotplug_dev); + HotplugHandlerClass *hhc; ARMCPU *cpu =3D ARM_CPU(dev); CPUState *cs =3D CPU(dev); + Error *local_err =3D NULL; =20 if (!vms->acpi_dev || !dev->realized) { error_setg(errp, "GED does not exists or device is not realized!"); @@ -3202,9 +3213,16 @@ static void virt_cpu_unplug_request(HotplugHandler *= hotplug_dev, return; } =20 - /* TODO: request cpu hotplug from guest */ + /* request cpu hotplug from guest */ + hhc =3D HOTPLUG_HANDLER_GET_CLASS(vms->acpi_dev); + hhc->unplug_request(HOTPLUG_HANDLER(vms->acpi_dev), dev, &local_err); + if (local_err) { + goto fail; + } =20 return; +fail: + error_propagate(errp, local_err); } =20 static void virt_cpu_unplug(HotplugHandler *hotplug_dev, DeviceState *dev, @@ -3212,7 +3230,9 @@ static void virt_cpu_unplug(HotplugHandler *hotplug_d= ev, DeviceState *dev, { VirtMachineState *vms =3D VIRT_MACHINE(hotplug_dev); MachineState *ms =3D MACHINE(hotplug_dev); + HotplugHandlerClass *hhc; CPUState *cs =3D CPU(dev); + Error *local_err =3D NULL; CPUArchId *cpu_slot; =20 if (!vms->acpi_dev || !dev->realized) { @@ -3222,7 +3242,12 @@ static void virt_cpu_unplug(HotplugHandler *hotplug_= dev, DeviceState *dev, =20 cpu_slot =3D virt_find_cpu_slot(ms, cs->cpu_index); =20 - /* TODO: update the acpi cpu hotplug state for cpu hot-unplug */ + /* update the acpi cpu hotplug state for cpu hot-unplug */ + hhc =3D HOTPLUG_HANDLER_GET_CLASS(vms->acpi_dev); + hhc->unplug(HOTPLUG_HANDLER(vms->acpi_dev), dev, &local_err); + if (local_err) { + goto fail; + } =20 unwire_gic_cpu_irqs(vms, cs); virt_update_gic(vms, cs); @@ -3236,6 +3261,8 @@ static void virt_cpu_unplug(HotplugHandler *hotplug_d= ev, DeviceState *dev, cs->disabled =3D true; =20 return; +fail: + error_propagate(errp, local_err); } =20 static void virt_machine_device_pre_plug_cb(HotplugHandler *hotplug_dev, --=20 2.34.1